64950 2011-07-21 08:28:14 -0700 Fix _win32_check_running_pid on natvie windows 2011-08-02 07:11:22 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC Windows 7 RESOLVED FIXED P2 Normal --- 48728 1 paroga paroga aroben webkit.review.bot oldest_to_newest 440425 0 paroga 2011-07-21 08:28:14 -0700 Fix _win32_check_running_pid on natvie windows 440427 1 101595 paroga 2011-07-21 08:34:21 -0700 Created attachment 101595 Patch 442861 2 101595 aroben 2011-07-27 05:09:56 -0700 Comment on attachment 101595 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=101595&action=review > Tools/Scripts/webkitpy/common/system/executive.py:254 > - ("szExeFile", ctypes.c_char * 260)] > + ("szExeFile", ctypes.c_char * 260), > + ("th32MemoryBase", ctypes.c_long), > + ("th32AccessKey", ctypes.c_long)] I don't see these new members mentioned here: <http://msdn.microsoft.com/en-us/library/ms684839(v=vs.85).aspx>. Looks like they only exist in the WinCE version of the struct. So I think we need to detect whether we're on WinCE or not. Otherwise won't this break non-CE builds? 442879 3 101595 paroga 2011-07-27 05:49:42 -0700 Comment on attachment 101595 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=101595&action=review >> Tools/Scripts/webkitpy/common/system/executive.py:254 >> + ("th32AccessKey", ctypes.c_long)] > > I don't see these new members mentioned here: <http://msdn.microsoft.com/en-us/library/ms684839(v=vs.85).aspx>. Looks like they only exist in the WinCE version of the struct. So I think we need to detect whether we're on WinCE or not. Otherwise won't this break non-CE builds? This is not related to WinCE! I try the get the native windows python test all pass on my windows box (german Windwos 7 Professional SP1 64bit). I tried different versions of this patch, but this is the only one which workded for me. :-/ Any idea why the function fails on my box without the two additional members? 442882 4 101595 aroben 2011-07-27 05:54:40 -0700 Comment on attachment 101595 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=101595&action=review >>> Tools/Scripts/webkitpy/common/system/executive.py:254 >>> + ("th32AccessKey", ctypes.c_long)] >> >> I don't see these new members mentioned here: <http://msdn.microsoft.com/en-us/library/ms684839(v=vs.85).aspx>. Looks like they only exist in the WinCE version of the struct. So I think we need to detect whether we're on WinCE or not. Otherwise won't this break non-CE builds? > > This is not related to WinCE! > I try the get the native windows python test all pass on my windows box (german Windwos 7 Professional SP1 64bit). > I tried different versions of this patch, but this is the only one which workded for me. :-/ > Any idea why the function fails on my box without the two additional members? Hm, I wonder if we need to be using ctypes.c_wchar instead of ctypes.c_char for the szExeFile parameter? I can't tell from the code whether we're calling Process32FirstW or Process32FirstA. 442884 5 101595 paroga 2011-07-27 06:04:42 -0700 Comment on attachment 101595 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=101595&action=review >>>> Tools/Scripts/webkitpy/common/system/executive.py:254 >>> >>> I don't see these new members mentioned here: <http://msdn.microsoft.com/en-us/library/ms684839(v=vs.85).aspx>. Looks like they only exist in the WinCE version of the struct. So I think we need to detect whether we're on WinCE or not. Otherwise won't this break non-CE builds? >> >> This is not related to WinCE! >> I try the get the native windows python test all pass on my windows box (german Windwos 7 Professional SP1 64bit). >> I tried different versions of this patch, but this is the only one which workded for me. :-/ >> Any idea why the function fails on my box without the two additional members? > > Hm, I wonder if we need to be using ctypes.c_wchar instead of ctypes.c_char for the szExeFile parameter? I can't tell from the code whether we're calling Process32FirstW or Process32FirstA. There is no Process32FirstA: Form http://msdn.microsoft.com/en-us/library/ms684834%28v=vs.85%29.aspx: Process32FirstW (Unicode) and Process32First (ANSI) So I think we call the ansi version here. A ctypes.sizeof PROCESSENTRY32 also returns the same size as in C code. Does this code work on your box with "natvie python"? 444427 6 102461 paroga 2011-07-31 12:04:53 -0700 Created attachment 102461 Patch Seams to be a problem of 64bit python, not windows :-) 445244 7 102461 webkit.review.bot 2011-08-02 07:11:17 -0700 Comment on attachment 102461 Patch Clearing flags on attachment: 102461 Committed r92188: <http://trac.webkit.org/changeset/92188> 445245 8 webkit.review.bot 2011-08-02 07:11:22 -0700 All reviewed patches have been landed. Closing bug. 101595 2011-07-21 08:34:21 -0700 2011-07-31 12:04:45 -0700 Patch bug-64950.patch text/plain 1612 paroga ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCA5MjE5 YWU3Li4zZDkwMmZhIDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTEtMDctMjEgIFBhdHJpY2sgR2Fuc3RlcmVyICA8 cGFyb2dhQHdlYmtpdC5vcmc+CisKKyAgICAgICAgRml4IF93aW4zMl9jaGVja19ydW5uaW5nX3Bp ZCBvbiBuYXR2aWUgd2luZG93cworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9NjQ5NTAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICBBZGQgdHdvIGFkZGl0aW9uYWwgbWVtYmVycyB0byB0aGUgUFJPQ0VTU0VOVFJZ MzIgc3RydWN0LiBUaGlzIGF2b2lkcyBhbgorICAgICAgICBwb3NzaWJsZSBFUlJPUl9CQURfTEVO R1RIIGZhaWx1cmUsIHdoZW4gY2FsbGluZyB0aGUgUHJvY2VzczMyRmlyc3QgZnVuY3Rpb24uCisg ICAgICAgIFRoaXMgY292ZXJlZCBieSB0aGUgZXhlY3V0aXZlIHVuaXR0ZXN0LgorCisgICAgICAg ICogU2NyaXB0cy93ZWJraXRweS9jb21tb24vc3lzdGVtL2V4ZWN1dGl2ZS5weToKKwogMjAxMS0w Ny0yMCAgUnlvc3VrZSBOaXdhICA8cm5pd2FAd2Via2l0Lm9yZz4KIAogICAgICAgICBCdWlsZGJv dCBtYXJrcyBhIG5yd3QgYm90IHJlZCB3aGVuIHRlc3RzIGFyZSBtaXNzaW5nIHJlc3VsdHMKZGlm ZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvY29tbW9uL3N5c3RlbS9leGVjdXRpdmUu cHkgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9zeXN0ZW0vZXhlY3V0aXZlLnB5Cmlu ZGV4IGQyNDU0ZTAuLmI4YTIzZGYgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkv Y29tbW9uL3N5c3RlbS9leGVjdXRpdmUucHkKKysrIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9j b21tb24vc3lzdGVtL2V4ZWN1dGl2ZS5weQpAQCAtMjQ5LDcgKzI0OSw5IEBAIGNsYXNzIEV4ZWN1 dGl2ZShvYmplY3QpOgogICAgICAgICAgICAgICAgICAgICAgICAgKCJ0aDMyUGFyZW50UHJvY2Vz c0lEIiwgY3R5cGVzLmNfdWxvbmcpLAogICAgICAgICAgICAgICAgICAgICAgICAgKCJwY1ByaUNs YXNzQmFzZSIsIGN0eXBlcy5jX3Vsb25nKSwKICAgICAgICAgICAgICAgICAgICAgICAgICgiZHdG bGFncyIsIGN0eXBlcy5jX3Vsb25nKSwKLSAgICAgICAgICAgICAgICAgICAgICAgICgic3pFeGVG aWxlIiwgY3R5cGVzLmNfY2hhciAqIDI2MCldCisgICAgICAgICAgICAgICAgICAgICAgICAoInN6 RXhlRmlsZSIsIGN0eXBlcy5jX2NoYXIgKiAyNjApLAorICAgICAgICAgICAgICAgICAgICAgICAg KCJ0aDMyTWVtb3J5QmFzZSIsIGN0eXBlcy5jX2xvbmcpLAorICAgICAgICAgICAgICAgICAgICAg ICAgKCJ0aDMyQWNjZXNzS2V5IiwgY3R5cGVzLmNfbG9uZyldCiAKICAgICAgICAgQ3JlYXRlVG9v bGhlbHAzMlNuYXBzaG90ID0gY3R5cGVzLndpbmRsbC5rZXJuZWwzMi5DcmVhdGVUb29saGVscDMy U25hcHNob3QKICAgICAgICAgUHJvY2VzczMyRmlyc3QgPSBjdHlwZXMud2luZGxsLmtlcm5lbDMy LlByb2Nlc3MzMkZpcnN0Cg== 102461 2011-07-31 12:04:53 -0700 2011-08-02 07:11:16 -0700 Patch bug-64950-20110731210526.patch text/plain 1782 paroga U3VidmVyc2lvbiBSZXZpc2lvbjogOTIwODMKZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBi L1Rvb2xzL0NoYW5nZUxvZwppbmRleCA1NzU1MmEzNmY3Zjc5MTYyNmNiMTAzOTM0MThlZDYwMTMx NTEwMTY2Li5mNzAzOGU5ZjFjZmFkYmEyZmNhNmNhMTIxNGYwNWY3MTJkMWE0MjczIDEwMDY0NAot LS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTgg QEAKKzIwMTEtMDctMzEgIFBhdHJpY2sgR2Fuc3RlcmVyICA8cGFyb2dhQHdlYmtpdC5vcmc+CisK KyAgICAgICAgRml4IF93aW4zMl9jaGVja19ydW5uaW5nX3BpZCBvbiA2NGJpdCB3aW5kb3dzIHB5 dGhvbgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjQ5 NTAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBVc2Ug dGhlIGNvcnJlY3QgdHlwZXMgZm9yIHRoZSBQUk9DRVNTRU5UUlkzMiBzdHJ1Y3QuCisgICAgICAg IHRoMzJEZWZhdWx0SGVhcElEIGlzIGRlY2xhcmVkIGFzIFVMT05HX1BUUiBhbmQgbm90IGFzIERX T1JELgorICAgICAgICBVc2luZyAzMmJpdCBmb3IgcG9pbnRlcnMgaW5zdGVhZCBvZiA2NGJpdCBy ZXN1bHRzIGluIGFuIEVSUk9SX0JBRF9MRU5HVEgKKyAgICAgICAgZmFpbHVyZSwgd2hlbiBjYWxs aW5nIHRoZSBQcm9jZXNzMzJGaXJzdCBmdW5jdGlvbi4KKyAgICAgICAgVGhpcyBpcyBjb3ZlcmVk IGJ5IHRoZSBleGVjdXRpdmUgdW5pdHRlc3QuCisKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5 L2NvbW1vbi9zeXN0ZW0vZXhlY3V0aXZlLnB5OgorCiAyMDExLTA3LTMxICBYYW4gTG9wZXogIDx4 bG9wZXpAaWdhbGlhLmNvbT4KIAogICAgICAgICBHcm91cCBkZXBlbmRlbmNpZXMgQ0ZMQUdTIHRv Z2V0aGVyLgpkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9jb21tb24vc3lzdGVt L2V4ZWN1dGl2ZS5weSBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvY29tbW9uL3N5c3RlbS9leGVj dXRpdmUucHkKaW5kZXggZDI0NTRlMGM0M2JmN2U4OGZiNmYxMjYyMjFkYjllOTM1M2I0Y2U4ZC4u ZmJiN2VmMDY3YjNkNTAzNWQ2ZTY1MmNlMjJmMjgzYTE1OTIwZTExYiAxMDA2NDQKLS0tIGEvVG9v bHMvU2NyaXB0cy93ZWJraXRweS9jb21tb24vc3lzdGVtL2V4ZWN1dGl2ZS5weQorKysgYi9Ub29s cy9TY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9zeXN0ZW0vZXhlY3V0aXZlLnB5CkBAIC0yNDMsNyAr MjQzLDcgQEAgY2xhc3MgRXhlY3V0aXZlKG9iamVjdCk6CiAgICAgICAgICAgICBfZmllbGRzXyA9 IFsoImR3U2l6ZSIsIGN0eXBlcy5jX3Vsb25nKSwKICAgICAgICAgICAgICAgICAgICAgICAgICgi Y250VXNhZ2UiLCBjdHlwZXMuY191bG9uZyksCiAgICAgICAgICAgICAgICAgICAgICAgICAoInRo MzJQcm9jZXNzSUQiLCBjdHlwZXMuY191bG9uZyksCi0gICAgICAgICAgICAgICAgICAgICAgICAo InRoMzJEZWZhdWx0SGVhcElEIiwgY3R5cGVzLmNfdWxvbmcpLAorICAgICAgICAgICAgICAgICAg ICAgICAgKCJ0aDMyRGVmYXVsdEhlYXBJRCIsIGN0eXBlcy5QT0lOVEVSKGN0eXBlcy5jX3Vsb25n KSksCiAgICAgICAgICAgICAgICAgICAgICAgICAoInRoMzJNb2R1bGVJRCIsIGN0eXBlcy5jX3Vs b25nKSwKICAgICAgICAgICAgICAgICAgICAgICAgICgiY250VGhyZWFkcyIsIGN0eXBlcy5jX3Vs b25nKSwKICAgICAgICAgICAgICAgICAgICAgICAgICgidGgzMlBhcmVudFByb2Nlc3NJRCIsIGN0 eXBlcy5jX3Vsb25nKSwK