64908 2011-07-20 17:19:56 -0700 Switch getTransformFromContainer and its uses to new layout types 2011-07-20 18:43:11 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 63567 1 leviw leviw eae eric jamesr simon.fraser webkit.review.bot oldest_to_newest 440131 0 leviw 2011-07-20 17:19:56 -0700 More scoped conversion to layout types. 440132 1 101531 leviw 2011-07-20 17:23:48 -0700 Created attachment 101531 Patch 440146 2 101531 leviw 2011-07-20 17:40:37 -0700 Comment on attachment 101531 Patch Thanks for the review, Simon! 440179 3 101531 webkit.review.bot 2011-07-20 18:43:06 -0700 Comment on attachment 101531 Patch Clearing flags on attachment: 101531 Committed r91436: <http://trac.webkit.org/changeset/91436> 440180 4 webkit.review.bot 2011-07-20 18:43:11 -0700 All reviewed patches have been landed. Closing bug. 101531 2011-07-20 17:23:48 -0700 2011-07-20 18:43:06 -0700 Patch bug-64908-20110720172347.patch text/plain 6185 leviw SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDkxNDI2KQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjggQEAKKzIwMTEtMDctMjAgIExldmkgV2Vp bnRyYXViICA8bGV2aXdAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFN3aXRjaCBnZXRUcmFuc2Zv cm1Gcm9tQ29udGFpbmVyIGFuZCBpdHMgdXNlcyB0byBuZXcgbGF5b3V0IHR5cGVzCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02NDkwOAorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFN3aXRjaGluZyBnZXRUcmFu c2Zvcm1Gcm9tQ29udGFpbmVyIGFuZCBpdHMgdXNlcyB0byB1c2UgdGhlIG5ldyBMYXlvdXQKKyAg ICAgICAgVHlwZXMgZnJvbSBzdHJpY3RseSBpbnRlZ2VyIG9uZXMuCisKKyAgICAgICAgTm8gbmV3 IHRlc3RzLCBubyBuZXcgZnVuY3Rpb25hbGl0eS4KKworICAgICAgICAqIHJlbmRlcmluZy9SZW5k ZXJCb3guY3BwOgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyQm94OjptYXBMb2NhbFRvQ29udGFp bmVyKToKKyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVySW5saW5lLmNwcDoKKyAgICAgICAgKFdl YkNvcmU6OlJlbmRlcklubGluZTo6bWFwTG9jYWxUb0NvbnRhaW5lcik6CisgICAgICAgICogcmVu ZGVyaW5nL1JlbmRlckxheWVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlckxheWVyOjpj cmVhdGVMb2NhbFRyYW5zZm9ybVN0YXRlKToKKyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVyT2Jq ZWN0LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlck9iamVjdDo6Z2V0VHJhbnNmb3JtRnJv bUNvbnRhaW5lcik6CisgICAgICAgICogcmVuZGVyaW5nL1JlbmRlck9iamVjdC5oOgorICAgICAg ICAqIHJlbmRlcmluZy9SZW5kZXJWaWV3LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlclZp ZXc6Om1hcExvY2FsVG9Db250YWluZXIpOgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyVmlldzo6 bWFwQWJzb2x1dGVUb0xvY2FsUG9pbnQpOgorCiAyMDExLTA3LTIwICBUb255IENoYW5nICA8dG9u eUBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgUmVtb3ZlIHN0cmF5IHJlZmVyZW5jZSB0byBTdHls ZUZsZXhpYmxlQm94RGF0YS5oIHRoYXQgd2FzIGFjY2lkZW50YWxseQpJbmRleDogU291cmNlL1dl YkNvcmUvcmVuZGVyaW5nL1JlbmRlckJveC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNv cmUvcmVuZGVyaW5nL1JlbmRlckJveC5jcHAJKHJldmlzaW9uIDkxNDExKQorKysgU291cmNlL1dl YkNvcmUvcmVuZGVyaW5nL1JlbmRlckJveC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTEyMDcsNyAr MTIwNyw3IEBAIHZvaWQgUmVuZGVyQm94OjptYXBMb2NhbFRvQ29udGFpbmVyKFJlbmQKICAgICBp ZiAoUmVuZGVyVmlldyogdiA9IHZpZXcoKSkgewogICAgICAgICBpZiAodi0+bGF5b3V0U3RhdGVF bmFibGVkKCkgJiYgIXJlcGFpbnRDb250YWluZXIpIHsKICAgICAgICAgICAgIExheW91dFN0YXRl KiBsYXlvdXRTdGF0ZSA9IHYtPmxheW91dFN0YXRlKCk7Ci0gICAgICAgICAgICBJbnRTaXplIG9m ZnNldCA9IGxheW91dFN0YXRlLT5tX3BhaW50T2Zmc2V0OworICAgICAgICAgICAgTGF5b3V0U2l6 ZSBvZmZzZXQgPSBsYXlvdXRTdGF0ZS0+bV9wYWludE9mZnNldDsKICAgICAgICAgICAgIG9mZnNl dC5leHBhbmQoeCgpLCB5KCkpOwogICAgICAgICAgICAgaWYgKHN0eWxlKCktPnBvc2l0aW9uKCkg PT0gUmVsYXRpdmVQb3NpdGlvbiAmJiBsYXllcigpKQogICAgICAgICAgICAgICAgIG9mZnNldCAr PSBsYXllcigpLT5yZWxhdGl2ZVBvc2l0aW9uT2Zmc2V0KCk7CkluZGV4OiBTb3VyY2UvV2ViQ29y ZS9yZW5kZXJpbmcvUmVuZGVySW5saW5lLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29y ZS9yZW5kZXJpbmcvUmVuZGVySW5saW5lLmNwcAkocmV2aXNpb24gOTE0MTEpCisrKyBTb3VyY2Uv V2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVySW5saW5lLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTEx Nyw3ICsxMTE3LDcgQEAgdm9pZCBSZW5kZXJJbmxpbmU6Om1hcExvY2FsVG9Db250YWluZXIoUgog ICAgIGlmIChSZW5kZXJWaWV3ICp2ID0gdmlldygpKSB7CiAgICAgICAgIGlmICh2LT5sYXlvdXRT dGF0ZUVuYWJsZWQoKSAmJiAhcmVwYWludENvbnRhaW5lcikgewogICAgICAgICAgICAgTGF5b3V0 U3RhdGUqIGxheW91dFN0YXRlID0gdi0+bGF5b3V0U3RhdGUoKTsKLSAgICAgICAgICAgIEludFNp emUgb2Zmc2V0ID0gbGF5b3V0U3RhdGUtPm1fcGFpbnRPZmZzZXQ7CisgICAgICAgICAgICBMYXlv dXRTaXplIG9mZnNldCA9IGxheW91dFN0YXRlLT5tX3BhaW50T2Zmc2V0OwogICAgICAgICAgICAg aWYgKHN0eWxlKCktPnBvc2l0aW9uKCkgPT0gUmVsYXRpdmVQb3NpdGlvbiAmJiBsYXllcigpKQog ICAgICAgICAgICAgICAgIG9mZnNldCArPSBsYXllcigpLT5yZWxhdGl2ZVBvc2l0aW9uT2Zmc2V0 KCk7CiAgICAgICAgICAgICB0cmFuc2Zvcm1TdGF0ZS5tb3ZlKG9mZnNldCk7CkluZGV4OiBTb3Vy Y2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTGF5ZXIuY3BwCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJj ZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJMYXllci5jcHAJKHJldmlzaW9uIDkxNDExKQorKysg U291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckxheWVyLmNwcAkod29ya2luZyBjb3B5KQpA QCAtMjkzMSw3ICsyOTMxLDcgQEAgUGFzc1JlZlB0cjxIaXRUZXN0aW5nVHJhbnNmb3JtU3RhdGU+ IFJlbgogICAgIFJlbmRlck9iamVjdCogY29udGFpbmVyUmVuZGVyZXIgPSBjb250YWluZXJMYXll ciA/IGNvbnRhaW5lckxheWVyLT5yZW5kZXJlcigpIDogMDsKICAgICBpZiAocmVuZGVyZXIoKS0+ c2hvdWxkVXNlVHJhbnNmb3JtRnJvbUNvbnRhaW5lcihjb250YWluZXJSZW5kZXJlcikpIHsKICAg ICAgICAgVHJhbnNmb3JtYXRpb25NYXRyaXggY29udGFpbmVyVHJhbnNmb3JtOwotICAgICAgICBy ZW5kZXJlcigpLT5nZXRUcmFuc2Zvcm1Gcm9tQ29udGFpbmVyKGNvbnRhaW5lclJlbmRlcmVyLCB0 b1NpemUob2Zmc2V0KSwgY29udGFpbmVyVHJhbnNmb3JtKTsKKyAgICAgICAgcmVuZGVyZXIoKS0+ Z2V0VHJhbnNmb3JtRnJvbUNvbnRhaW5lcihjb250YWluZXJSZW5kZXJlciwgdG9MYXlvdXRTaXpl KG9mZnNldCksIGNvbnRhaW5lclRyYW5zZm9ybSk7CiAgICAgICAgIHRyYW5zZm9ybVN0YXRlLT5h cHBseVRyYW5zZm9ybShjb250YWluZXJUcmFuc2Zvcm0sIEhpdFRlc3RpbmdUcmFuc2Zvcm1TdGF0 ZTo6QWNjdW11bGF0ZVRyYW5zZm9ybSk7CiAgICAgfSBlbHNlIHsKICAgICAgICAgdHJhbnNmb3Jt U3RhdGUtPnRyYW5zbGF0ZShvZmZzZXQueCgpLCBvZmZzZXQueSgpLCBIaXRUZXN0aW5nVHJhbnNm b3JtU3RhdGU6OkFjY3VtdWxhdGVUcmFuc2Zvcm0pOwpJbmRleDogU291cmNlL1dlYkNvcmUvcmVu ZGVyaW5nL1JlbmRlck9iamVjdC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvcmVu ZGVyaW5nL1JlbmRlck9iamVjdC5jcHAJKHJldmlzaW9uIDkxNDExKQorKysgU291cmNlL1dlYkNv cmUvcmVuZGVyaW5nL1JlbmRlck9iamVjdC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTE4ODcsNyAr MTg4Nyw3IEBAIGJvb2wgUmVuZGVyT2JqZWN0OjpzaG91bGRVc2VUcmFuc2Zvcm1Gcm8KICNlbmRp ZgogfQogCi12b2lkIFJlbmRlck9iamVjdDo6Z2V0VHJhbnNmb3JtRnJvbUNvbnRhaW5lcihjb25z dCBSZW5kZXJPYmplY3QqIGNvbnRhaW5lck9iamVjdCwgY29uc3QgSW50U2l6ZSYgb2Zmc2V0SW5D b250YWluZXIsIFRyYW5zZm9ybWF0aW9uTWF0cml4JiB0cmFuc2Zvcm0pIGNvbnN0Cit2b2lkIFJl bmRlck9iamVjdDo6Z2V0VHJhbnNmb3JtRnJvbUNvbnRhaW5lcihjb25zdCBSZW5kZXJPYmplY3Qq IGNvbnRhaW5lck9iamVjdCwgY29uc3QgTGF5b3V0U2l6ZSYgb2Zmc2V0SW5Db250YWluZXIsIFRy YW5zZm9ybWF0aW9uTWF0cml4JiB0cmFuc2Zvcm0pIGNvbnN0CiB7CiAgICAgdHJhbnNmb3JtLm1h a2VJZGVudGl0eSgpOwogICAgIHRyYW5zZm9ybS50cmFuc2xhdGUob2Zmc2V0SW5Db250YWluZXIu d2lkdGgoKSwgb2Zmc2V0SW5Db250YWluZXIuaGVpZ2h0KCkpOwpJbmRleDogU291cmNlL1dlYkNv cmUvcmVuZGVyaW5nL1JlbmRlck9iamVjdC5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3Jl L3JlbmRlcmluZy9SZW5kZXJPYmplY3QuaAkocmV2aXNpb24gOTE0MTEpCisrKyBTb3VyY2UvV2Vi Q29yZS9yZW5kZXJpbmcvUmVuZGVyT2JqZWN0LmgJKHdvcmtpbmcgY29weSkKQEAgLTc3NSw3ICs3 NzUsNyBAQCBwdWJsaWM6CiAgICAgdmlydHVhbCB2b2lkIG1hcEFic29sdXRlVG9Mb2NhbFBvaW50 KGJvb2wgZml4ZWQsIGJvb2wgdXNlVHJhbnNmb3JtcywgVHJhbnNmb3JtU3RhdGUmKSBjb25zdDsK IAogICAgIGJvb2wgc2hvdWxkVXNlVHJhbnNmb3JtRnJvbUNvbnRhaW5lcihjb25zdCBSZW5kZXJP YmplY3QqIGNvbnRhaW5lcikgY29uc3Q7Ci0gICAgdm9pZCBnZXRUcmFuc2Zvcm1Gcm9tQ29udGFp bmVyKGNvbnN0IFJlbmRlck9iamVjdCogY29udGFpbmVyLCBjb25zdCBJbnRTaXplJiBvZmZzZXRJ bkNvbnRhaW5lciwgVHJhbnNmb3JtYXRpb25NYXRyaXgmKSBjb25zdDsKKyAgICB2b2lkIGdldFRy YW5zZm9ybUZyb21Db250YWluZXIoY29uc3QgUmVuZGVyT2JqZWN0KiBjb250YWluZXIsIGNvbnN0 IExheW91dFNpemUmIG9mZnNldEluQ29udGFpbmVyLCBUcmFuc2Zvcm1hdGlvbk1hdHJpeCYpIGNv bnN0OwogICAgIAogICAgIHZpcnR1YWwgdm9pZCBhZGRGb2N1c1JpbmdSZWN0cyhWZWN0b3I8TGF5 b3V0UmVjdD4mLCBjb25zdCBMYXlvdXRQb2ludCYpIHsgfTsKIApJbmRleDogU291cmNlL1dlYkNv cmUvcmVuZGVyaW5nL1JlbmRlclZpZXcuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3Jl L3JlbmRlcmluZy9SZW5kZXJWaWV3LmNwcAkocmV2aXNpb24gOTE0MTEpCisrKyBTb3VyY2UvV2Vi Q29yZS9yZW5kZXJpbmcvUmVuZGVyVmlldy5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTE0NCw3ICsx NDQsNyBAQCB2b2lkIFJlbmRlclZpZXc6Om1hcExvY2FsVG9Db250YWluZXIoUmVuCiAKICAgICBp ZiAoIXJlcGFpbnRDb250YWluZXIgJiYgdXNlVHJhbnNmb3JtcyAmJiBzaG91bGRVc2VUcmFuc2Zv cm1Gcm9tQ29udGFpbmVyKDApKSB7CiAgICAgICAgIFRyYW5zZm9ybWF0aW9uTWF0cml4IHQ7Ci0g ICAgICAgIGdldFRyYW5zZm9ybUZyb21Db250YWluZXIoMCwgSW50U2l6ZSgpLCB0KTsKKyAgICAg ICAgZ2V0VHJhbnNmb3JtRnJvbUNvbnRhaW5lcigwLCBMYXlvdXRTaXplKCksIHQpOwogICAgICAg ICB0cmFuc2Zvcm1TdGF0ZS5hcHBseVRyYW5zZm9ybSh0KTsKICAgICB9CiAgICAgCkBAIC0xNTks NyArMTU5LDcgQEAgdm9pZCBSZW5kZXJWaWV3OjptYXBBYnNvbHV0ZVRvTG9jYWxQb2ludAogCiAg ICAgaWYgKHVzZVRyYW5zZm9ybXMgJiYgc2hvdWxkVXNlVHJhbnNmb3JtRnJvbUNvbnRhaW5lcigw KSkgewogICAgICAgICBUcmFuc2Zvcm1hdGlvbk1hdHJpeCB0OwotICAgICAgICBnZXRUcmFuc2Zv cm1Gcm9tQ29udGFpbmVyKDAsIEludFNpemUoKSwgdCk7CisgICAgICAgIGdldFRyYW5zZm9ybUZy b21Db250YWluZXIoMCwgTGF5b3V0U2l6ZSgpLCB0KTsKICAgICAgICAgdHJhbnNmb3JtU3RhdGUu YXBwbHlUcmFuc2Zvcm0odCk7CiAgICAgfQogfQo=