6487 2006-01-10 21:30:04 -0800 "Make Text Bigger/Smaller" affects SVGs when it probably shouldn't 2023-07-31 16:11:39 -0700 1 1 1 Unclassified WebKit SVG 420+ Mac OS X 10.4 RESOLVED DUPLICATE 59435 https://bugs.webkit.org/show_bug.cgi?id=76162 https://bugs.webkit.org/show_bug.cgi?id=259435 P4 Normal --- 1 eric rwlbuis ahmad.saleem792 bfulgham eoconnor ian kling sabouhallawa simon.fraser zimmermann oldest_to_newest 28221 0 eric 2006-01-10 21:30:04 -0800 "Make Text Bigger/Smaller" affects SVGs when it probably shouldn't I know that FireFox also has this "problem". I'm not sure what the right solution here is. Should we zoom the whole SVG? Should we disable text zoom, or should we leave it as is? 28237 1 sullivan 2006-01-11 06:28:25 -0800 We decided to make these menu items be equivalents for zoom in/out in PDF, though the concepts are of course not exactly the same. Doing the same thing for SVG seems sensible. 9952 2 14559 rwlbuis 2007-05-15 01:00:28 -0700 Created attachment 14559 First attempt How this option now works is not intuitive IMHO, either the whole svg should zoom in/out or this setting should be ignored, but just zooming svg text only clearly is wrong. This patch turns this behaviour off, thus no SVG text is affected by zoomFactor. Note that I think the patch still allows html text in foreignObject to zoom. Note that this setting feels similar to zooming and panning, I made a patch for that and will attach it to another bug report soon (will make a reference here). These subjects could be dependent. Cheers, Rob. 9953 3 hyatt 2007-05-15 01:04:28 -0700 We have a CSS property that can turn off text zoom. We use it in Safari RSS. It's called -webkit-text-size-adjust. Not sure if it would be helpful for you or not, but it is there and usable. 9960 4 14561 rwlbuis 2007-05-15 02:17:20 -0700 Created attachment 14561 Better approach I think Dave's approach is better as it doesnt require extra #if ENABLE(SVG). Cheers, Rob. 9961 5 hyatt 2007-05-15 02:22:19 -0700 Did you attach the wrong patch here? 9962 6 14562 rwlbuis 2007-05-15 02:27:56 -0700 Created attachment 14562 Now with the right patch... Doh! Cheers, Rob. 9963 7 14562 hyatt 2007-05-15 02:41:00 -0700 Comment on attachment 14562 Now with the right patch... r=me 9965 8 rwlbuis 2007-05-15 02:55:03 -0700 Landed in r21482. 850475 9 kling 2013-03-07 14:10:44 -0800 I'm removing -webkit-text-size-adjust in bug 56543, and this patch to svg.css is effectively reverted. However, I don't see any difference in SVG text behavior (with text-only zoom) before/after, so I'm not sure it was even needed anymore. @Rob, do we need to do anything with this? 850484 10 rwlbuis 2013-03-07 14:24:29 -0800 Hi Andreas, (In reply to comment #9) > I'm removing -webkit-text-size-adjust in bug 56543, and this patch to svg.css is effectively reverted. However, I don't see any difference in SVG text behavior (with text-only zoom) before/after, so I'm not sure it was even needed anymore. > > @Rob, do we need to do anything with this? If the behavior is the same after your patch, I am fine with the "revert". I guess a lot changed since 2007 :) 886365 11 14562 darin 2013-05-08 09:05:40 -0700 Comment on attachment 14562 Now with the right patch... Clearing the review flag so this does not show up as a “patch reviewed but not landed” any more. 1923822 12 ahmad.saleem792 2023-01-07 09:48:21 -0800 Comment 08 mention that this landed in 2007 and then got reverted in 2013 as per Comment 09 and the behavior was pre and post revert was same, do we need to track this anymore? Thanks! 1968942 13 ahmad.saleem792 2023-07-31 16:11:39 -0700 *** This bug has been marked as a duplicate of bug 59435 *** 14559 2007-05-15 01:00:28 -0700 2007-05-15 02:17:20 -0700 First attempt 6487.diff text/plain 2368 rwlbuis SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiAyMTQ3NikKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTYgQEAKKzIwMDctMDUtMTUgIFJvYiBCdWlzICA8YnVpc0BrZGUub3JnPgorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIGh0dHA6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTY0ODcKKyAgICAgICAgIk1ha2UgVGV4dCBCaWdn ZXIvU21hbGxlciIgYWZmZWN0cyBTVkdzIHdoZW4gaXQgcHJvYmFibHkgc2hvdWxkbid0CisKKyAg ICAgICAgSWdub3JlIHpvb21GYWN0b3IgZm9yIFNWRyB0ZXh0LgorCisgICAgICAgICogY3NzL2Nz c3N0eWxlc2VsZWN0b3IuY3BwOgorICAgICAgICAoV2ViQ29yZTo6Q1NTU3R5bGVTZWxlY3Rvcjo6 bG9hZERlZmF1bHRTdHlsZSk6CisgICAgICAgIChXZWJDb3JlOjpDU1NTdHlsZVNlbGVjdG9yOjpn ZXRDb21wdXRlZFNpemVGcm9tU3BlY2lmaWVkU2l6ZSk6CisKIDIwMDctMDUtMTQgIEp1c3RpbiBH YXJjaWEgIDxqdXN0aW4uZ2FyY2lhQGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBn Z2FyZW4KSW5kZXg6IFdlYkNvcmUvY3NzL2Nzc3N0eWxlc2VsZWN0b3IuY3BwCj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIFdlYkNvcmUvY3NzL2Nzc3N0eWxlc2VsZWN0b3IuY3BwCShyZXZpc2lvbiAyMTQ3NikKKysr IFdlYkNvcmUvY3NzL2Nzc3N0eWxlc2VsZWN0b3IuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0zMTI2 LDkgKzMxMjYsMTUgQEAgdm9pZCBDU1NTdHlsZVNlbGVjdG9yOjphcHBseVByb3BlcnR5KGludAog ICAgICAgICAgICAgZG91YmxlIG11bHRpcGxpZXIgPSAxLjA7CiAgICAgICAgICAgICAvLyBTY2Fs ZSBmb3IgdGhlIGZvbnQgem9vbSBmYWN0b3Igb25seSBmb3IgdHlwZXMgb3RoZXIgdGhhbiAiZW0i IGFuZCAiZXgiLCBzaW5jZSB0aG9zZSBhcmUKICAgICAgICAgICAgIC8vIGFscmVhZHkgYmFzZWQg b24gdGhlIGZvbnQgc2l6ZS4KKyNpZiBFTkFCTEUoU1ZHKQorICAgICAgICAgICAgaWYgKCFlbGVt ZW50LT5pc1NWR0VsZW1lbnQoKSkgeworI2VuZGlmCiAgICAgICAgICAgICBpZiAodHlwZSAhPSBD U1NQcmltaXRpdmVWYWx1ZTo6Q1NTX0VNUyAmJiB0eXBlICE9IENTU1ByaW1pdGl2ZVZhbHVlOjpD U1NfRVhTICYmIHZpZXcgJiYgdmlldy0+ZnJhbWUoKSkgewogICAgICAgICAgICAgICAgIG11bHRp cGxpZXIgPSB2aWV3LT5mcmFtZSgpLT56b29tRmFjdG9yKCkgLyAxMDAuMDsKICAgICAgICAgICAg IH0KKyNpZiBFTkFCTEUoU1ZHKQorICAgICAgICAgICAgfQorI2VuZGlmCiAgICAgICAgICAgICBs aW5lSGVpZ2h0ID0gTGVuZ3RoKHByaW1pdGl2ZVZhbHVlLT5jb21wdXRlTGVuZ3RoSW50Rm9yTGVu Z3RoKHN0eWxlLCBtdWx0aXBsaWVyKSwgRml4ZWQpOwogICAgICAgICB9IGVsc2UgaWYgKHR5cGUg PT0gQ1NTUHJpbWl0aXZlVmFsdWU6OkNTU19QRVJDRU5UQUdFKQogICAgICAgICAgICAgbGluZUhl aWdodCA9IExlbmd0aCgoc3R5bGUtPmZvbnRTaXplKCkgKiBpbnQocHJpbWl0aXZlVmFsdWUtPmdl dEZsb2F0VmFsdWUoKSkpIC8gMTAwLCBGaXhlZCk7CkBAIC00Njk0LDcgKzQ3MDAsMTUgQEAgZmxv YXQgQ1NTU3R5bGVTZWxlY3Rvcjo6Z2V0Q29tcHV0ZWRTaXplRgogICAgIGludCBtaW5TaXplID0g c2V0dGluZ3MtPm1pbmltdW1Gb250U2l6ZSgpOwogICAgIGludCBtaW5Mb2dpY2FsU2l6ZSA9IHNl dHRpbmdzLT5taW5pbXVtTG9naWNhbEZvbnRTaXplKCk7CiAKLSAgICBmbG9hdCB6b29tUGVyY2Vu dCA9IHZpZXcgPyB2aWV3LT5mcmFtZSgpLT56b29tRmFjdG9yKCkvMTAwLjBmIDogMS4wZjsKKyAg ICBmbG9hdCB6b29tUGVyY2VudCA9IDEuMDsKKyNpZiBFTkFCTEUoU1ZHKQorICAgIGlmIChlbGVt ZW50ICYmICFlbGVtZW50LT5pc1NWR0VsZW1lbnQoKSkgeworI2VuZGlmCisgICAgaWYgKHZpZXcp CisgICAgICAgIHpvb21QZXJjZW50ID0gdmlldy0+ZnJhbWUoKS0+em9vbUZhY3RvcigpIC8gMTAw LjBmOworI2lmIEVOQUJMRShTVkcpCisgICAgfQorI2VuZGlmCiAgICAgZmxvYXQgem9vbWVkU2l6 ZSA9IHNwZWNpZmllZFNpemUgKiB6b29tUGVyY2VudDsKIAogICAgIC8vIEFwcGx5IHRoZSBoYXJk IG1pbmltdW0gZmlyc3QuICBXZSBvbmx5IGFwcGx5IHRoZSBoYXJkIG1pbmltdW0gaWYgYWZ0ZXIg em9vbWluZyB3ZSdyZSBzdGlsbCB0b28gc21hbGwuCg== 14561 2007-05-15 02:17:20 -0700 2007-05-15 02:27:56 -0700 Better approach 6487-2.diff text/plain 2440 rwlbuis SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiAyMTQ4MCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTQgQEAKKzIwMDctMDUtMTUgIFJvYiBCdWlzICA8YnVpc0BrZGUub3JnPgorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIGh0dHA6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTY0ODcKKyAgICAgICAgIk1ha2UgVGV4dCBCaWdn ZXIvU21hbGxlciIgYWZmZWN0cyBTVkdzIHdoZW4gaXQgcHJvYmFibHkgc2hvdWxkbid0CisKKyAg ICAgICAgSWdub3JlIE1ha2UgVGV4dCBCaWdnZXIvU21hbGxlciBmb3IgU1ZHIHRleHQuCisKKyAg ICAgICAgKiBjc3Mvc3ZnLmNzczoKKwogMjAwNy0wNS0xNCAgQW5kZXJzIENhcmxzc29uICA8YW5k ZXJzY2FAYXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEdlb2ZmLgpAQCAtMzUsNiAr NDYsNyBAQAogICAgICAgICBiZXNpZGVzIHRoZSBpbml0aWFsIGVtcHR5IGRvYy4KICAgICAgICAg KiBsb2FkZXIvRnJhbWVMb2FkZXIuaDoKIAorPj4+Pj4+PiAucjIxNDgwCiAyMDA3LTA1LTE0ICBK dXN0aW4gR2FyY2lhICA8anVzdGluLmdhcmNpYUBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3 ZWQgYnkgZ2dhcmVuCkluZGV4OiBXZWJDb3JlL2Nzcy9jc3NzdHlsZXNlbGVjdG9yLmNwcAo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBXZWJDb3JlL2Nzcy9jc3NzdHlsZXNlbGVjdG9yLmNwcAkocmV2aXNpb24gMjE0 NzgpCisrKyBXZWJDb3JlL2Nzcy9jc3NzdHlsZXNlbGVjdG9yLmNwcAkod29ya2luZyBjb3B5KQpA QCAtMzEyNiw5ICszMTI2LDE1IEBAIHZvaWQgQ1NTU3R5bGVTZWxlY3Rvcjo6YXBwbHlQcm9wZXJ0 eShpbnQKICAgICAgICAgICAgIGRvdWJsZSBtdWx0aXBsaWVyID0gMS4wOwogICAgICAgICAgICAg Ly8gU2NhbGUgZm9yIHRoZSBmb250IHpvb20gZmFjdG9yIG9ubHkgZm9yIHR5cGVzIG90aGVyIHRo YW4gImVtIiBhbmQgImV4Iiwgc2luY2UgdGhvc2UgYXJlCiAgICAgICAgICAgICAvLyBhbHJlYWR5 IGJhc2VkIG9uIHRoZSBmb250IHNpemUuCisjaWYgRU5BQkxFKFNWRykKKy8vICAgICAgICAgICAg aWYgKCFlbGVtZW50LT5pc1NWR0VsZW1lbnQoKSkgeworI2VuZGlmCiAgICAgICAgICAgICBpZiAo dHlwZSAhPSBDU1NQcmltaXRpdmVWYWx1ZTo6Q1NTX0VNUyAmJiB0eXBlICE9IENTU1ByaW1pdGl2 ZVZhbHVlOjpDU1NfRVhTICYmIHZpZXcgJiYgdmlldy0+ZnJhbWUoKSkgewogICAgICAgICAgICAg ICAgIG11bHRpcGxpZXIgPSB2aWV3LT5mcmFtZSgpLT56b29tRmFjdG9yKCkgLyAxMDAuMDsKICAg ICAgICAgICAgIH0KKyNpZiBFTkFCTEUoU1ZHKQorLy8gICAgICAgICAgICB9CisjZW5kaWYKICAg ICAgICAgICAgIGxpbmVIZWlnaHQgPSBMZW5ndGgocHJpbWl0aXZlVmFsdWUtPmNvbXB1dGVMZW5n dGhJbnRGb3JMZW5ndGgoc3R5bGUsIG11bHRpcGxpZXIpLCBGaXhlZCk7CiAgICAgICAgIH0gZWxz ZSBpZiAodHlwZSA9PSBDU1NQcmltaXRpdmVWYWx1ZTo6Q1NTX1BFUkNFTlRBR0UpCiAgICAgICAg ICAgICBsaW5lSGVpZ2h0ID0gTGVuZ3RoKChzdHlsZS0+Zm9udFNpemUoKSAqIGludChwcmltaXRp dmVWYWx1ZS0+Z2V0RmxvYXRWYWx1ZSgpKSkgLyAxMDAsIEZpeGVkKTsKQEAgLTQ2OTQsNyArNDcw MCwxNSBAQCBmbG9hdCBDU1NTdHlsZVNlbGVjdG9yOjpnZXRDb21wdXRlZFNpemVGCiAgICAgaW50 IG1pblNpemUgPSBzZXR0aW5ncy0+bWluaW11bUZvbnRTaXplKCk7CiAgICAgaW50IG1pbkxvZ2lj YWxTaXplID0gc2V0dGluZ3MtPm1pbmltdW1Mb2dpY2FsRm9udFNpemUoKTsKIAotICAgIGZsb2F0 IHpvb21QZXJjZW50ID0gdmlldyA/IHZpZXctPmZyYW1lKCktPnpvb21GYWN0b3IoKS8xMDAuMGYg OiAxLjBmOworICAgIGZsb2F0IHpvb21QZXJjZW50ID0gMS4wOworI2lmIEVOQUJMRShTVkcpCisv LyAgICBpZiAoZWxlbWVudCAmJiAhZWxlbWVudC0+aXNTVkdFbGVtZW50KCkpIHsKKyNlbmRpZgor ICAgIGlmICh2aWV3KQorICAgICAgICB6b29tUGVyY2VudCA9IHZpZXctPmZyYW1lKCktPnpvb21G YWN0b3IoKSAvIDEwMC4wZjsKKyNpZiBFTkFCTEUoU1ZHKQorLy8gICAgfQorI2VuZGlmCiAgICAg ZmxvYXQgem9vbWVkU2l6ZSA9IHNwZWNpZmllZFNpemUgKiB6b29tUGVyY2VudDsKIAogICAgIC8v IEFwcGx5IHRoZSBoYXJkIG1pbmltdW0gZmlyc3QuICBXZSBvbmx5IGFwcGx5IHRoZSBoYXJkIG1p bmltdW0gaWYgYWZ0ZXIgem9vbWluZyB3ZSdyZSBzdGlsbCB0b28gc21hbGwuCg== 14562 2007-05-15 02:27:56 -0700 2013-05-08 09:05:39 -0700 Now with the right patch... 6487-2.diff text/plain 879 rwlbuis SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiAyMTQ4MCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTQgQEAKKzIwMDctMDUtMTUgIFJvYiBCdWlzICA8YnVpc0BrZGUub3JnPgorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIGh0dHA6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTY0ODcKKyAgICAgICAgIk1ha2UgVGV4dCBCaWdn ZXIvU21hbGxlciIgYWZmZWN0cyBTVkdzIHdoZW4gaXQgcHJvYmFibHkgc2hvdWxkbid0CisKKyAg ICAgICAgSWdub3JlIE1ha2UgVGV4dCBCaWdnZXIvU21hbGxlciBmb3IgU1ZHIHRleHQuCisKKyAg ICAgICAgKiBjc3Mvc3ZnLmNzczoKKwogMjAwNy0wNS0xNCAgQW5kZXJzIENhcmxzc29uICA8YW5k ZXJzY2FAYXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEdlb2ZmLgpJbmRleDogV2Vi Q29yZS9jc3Mvc3ZnLmNzcwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL2Nzcy9zdmcuY3NzCShyZXZp c2lvbiAyMTQ3OCkKKysrIFdlYkNvcmUvY3NzL3N2Zy5jc3MJKHdvcmtpbmcgY29weSkKQEAgLTUz LDMgKzUzLDcgQEAgdGV4dCwgZm9yZWlnbk9iamVjdCB7CiB0ZXh0LCB0c3BhbiB7CiAgICB3aGl0 ZS1zcGFjZTogbm93cmFwCiB9CisKK3RleHQsIHRzcGFuLCB0cmVmIHsKKyAgIC13ZWJraXQtdGV4 dC1zaXplLWFkanVzdDogbm9uZTsKK30K