64863 2011-07-20 05:08:57 -0700 Switch isPrimitiveValue() virtual function to inline one. 2012-01-08 15:27:53 -0800 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) All All RESOLVED DUPLICATE 71668 P2 Normal --- 64262 1 tczene davidbarr davidbarr dglazkov hyatt loki shanestephens webkit.review.bot oldest_to_newest 439750 0 tczene 2011-07-20 05:08:57 -0700 Removing the virtual functions - removing the calls - makes measurable performance progression on CSS. We measured the following performance progressions on some very popular websites, for example: msn.com: 33% yandex.ru: 3,3% The number of variables created during the test. m_isPrimitiveValue 261596 The max number of variables in the memory during the test. m_isPrimitiveValue 468 439751 1 101453 tczene 2011-07-20 05:11:35 -0700 Created attachment 101453 Switch isPrimitiveValue virtual function to inline 439755 2 101453 webkit.review.bot 2011-07-20 05:42:40 -0700 Comment on attachment 101453 Switch isPrimitiveValue virtual function to inline Attachment 101453 did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/9200235 New failing tests: css2.1/t1202-counter-16-f.html css2.1/t1202-counters-03-b.html css2.1/t1202-counter-12-b.html css2.1/t1202-counter-08-b.html css2.1/t1202-counter-02-b.html css2.1/t1202-counter-14-b.html css2.1/t1202-counter-00-b.html css2.1/t1202-counter-09-b.html css2.1/t1202-counter-15-b.html css2.1/t1202-counter-05-b.html css2.1/t1202-counter-07-b.html css2.1/t1202-counter-06-b.html css2.1/t1202-counter-01-b.html css2.1/t1202-counter-03-b.html css2.1/t1202-counters-02-b.html css2.1/t1202-counter-04-b.html css2.1/t1202-counters-01-b.html css2.1/t1202-counter-13-b.html css2.1/t1202-counter-11-b.html css2.1/t1202-counters-00-b.html 439969 3 hyatt 2011-07-20 13:25:44 -0700 See my comments in https://bugs.webkit.org/show_bug.cgi?id=64262. 465964 4 101453 eric 2011-09-12 17:00:07 -0700 Comment on attachment 101453 Switch isPrimitiveValue virtual function to inline How much of a memory regression is this? 482056 5 davidbarr 2011-10-11 17:09:45 -0700 I believe there are some wasted bits that could be put to good use for a perf enhancement without increasing the memory overhead. Please give a chance to upload an RFC patch and some repeatable numbers. 531837 6 davidbarr 2012-01-08 15:27:53 -0800 The action requested in this bug was taken in: http://trac.webkit.org/changeset/99468 *** This bug has been marked as a duplicate of bug 71668 *** 101453 2011-07-20 05:11:35 -0700 2011-09-12 17:00:07 -0700 Switch isPrimitiveValue virtual function to inline 0001-Switch-isPrimitiveValue-virtual-function-to-inline-o.patch text/plain 8736 tczene RnJvbSA2NDJlMDg0N2RkZDVmZDNjNmZjNTcyZmE2YzI3NWIzMDNkOWIzNTAwIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBUYW1hcyBDemVuZSA8Q3plbmUuVGFtYXNAc3R1ZC51LXN6ZWdl ZC5odT4KRGF0ZTogV2VkLCAyMCBKdWwgMjAxMSAxNDowOTo0MCArMDIwMApTdWJqZWN0OiBbUEFU Q0hdIFN3aXRjaCBpc1ByaW1pdGl2ZVZhbHVlKCkgdmlydHVhbCBmdW5jdGlvbiB0byBpbmxpbmUg b25lLgoKLS0tCiBTb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cgICAgICAgICAgICAgICAgIHwgICAx NiArKysrKysKIFNvdXJjZS9XZWJDb3JlL2Nzcy9DU1NQcmltaXRpdmVWYWx1ZS5jcHAgfCAgIDcw IC0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLQogU291cmNlL1dlYkNvcmUvY3NzL0NTU1ByaW1pdGl2 ZVZhbHVlLmggICB8ICAgODUgKysrKysrKysrKysrKysrKysrKysrKysrKysrLS0tCiBTb3VyY2Uv V2ViQ29yZS9jc3MvQ1NTVmFsdWUuaCAgICAgICAgICAgIHwgICAxMiArKysrLQogNCBmaWxlcyBj aGFuZ2VkLCAxMDQgaW5zZXJ0aW9ucygrKSwgNzkgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEv U291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCmluZGV4 IGZkNmE3NWQuLmM2MjRkMDIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwor KysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxOSBAQAorMjAxMS0wNy0y MCAgVGFtYXMgQ3plbmUgIDxDemVuZS5UYW1hc0BzdHVkLnUtc3plZ2VkLmh1PgorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFN3aXRjaCBpc1ByaW1pdGl2 ZVZhbHVlKCkgdmlydHVhbCBmdW5jdGlvbiB0byBpbmxpbmUgb25lLgorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjQ4NjMKKworICAgICAgICBSZW1vdmlu ZyB0aGUgdmlydHVhbCBmdW5jdGlvbnMgLSByZW1vdmluZyB0aGUgY2FsbHMgLSBtYWtlcyBtZWFz dXJhYmxlIHBlcmZvcm1hbmNlIHByb2dyZXNzaW9uIG9uIENTUy4KKworICAgICAgICAqIGNzcy9D U1NQcmltaXRpdmVWYWx1ZS5jcHA6TW92ZSBhbGwgY29uc3RydWN0b3JzIGludG8gdGhlIGhlYWRl ciBmaWxlLgorICAgICAgICAqIGNzcy9DU1NQcmltaXRpdmVWYWx1ZS5oOgorICAgICAgICAoV2Vi Q29yZTo6Q1NTUHJpbWl0aXZlVmFsdWU6OkNTU1ByaW1pdGl2ZVZhbHVlKTpBZGQgYWRkaXRpb25h bCB2YWx1ZSB0byB0aGUgdmFyaWFibGUsIHJlbW92ZSB2aXJ0dWFsIGZ1bmN0aW9uLgorICAgICAg ICAqIGNzcy9DU1NWYWx1ZS5oOgorICAgICAgICAoV2ViQ29yZTo6Q1NTVmFsdWU6OkNTU1ZhbHVl KTpJbml0aWFsaXplIHRoZSB2YXJpYWJsZS4KKyAgICAgICAgKFdlYkNvcmU6OkNTU1ZhbHVlOjpp c1ByaW1pdGl2ZVZhbHVlKTpTd2l0Y2ggdmlydHVhbCBmdW5jdGlvbiB0byBpbmxpbmUgZnVuY3Rp b24uCisKIDIwMTEtMDctMjAgIFNoZXJpZmYgQm90ICA8d2Via2l0LnJldmlldy5ib3RAZ21haWwu Y29tPgogCiAgICAgICAgIFVucmV2aWV3ZWQsIHJvbGxpbmcgb3V0IHI5MTI4NS4KZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJDb3JlL2Nzcy9DU1NQcmltaXRpdmVWYWx1ZS5jcHAgYi9Tb3VyY2UvV2Vi Q29yZS9jc3MvQ1NTUHJpbWl0aXZlVmFsdWUuY3BwCmluZGV4IGRlMzFjOTguLjFjZDE5NWMgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2Nzcy9DU1NQcmltaXRpdmVWYWx1ZS5jcHAKKysrIGIv U291cmNlL1dlYkNvcmUvY3NzL0NTU1ByaW1pdGl2ZVZhbHVlLmNwcApAQCAtMjUsMTQgKzI1LDEy IEBACiAjaW5jbHVkZSAiQ1NTUGFyc2VyLmgiCiAjaW5jbHVkZSAiQ1NTUHJvcGVydHlOYW1lcy5o IgogI2luY2x1ZGUgIkNTU1N0eWxlU2hlZXQuaCIKLSNpbmNsdWRlICJDU1NWYWx1ZUtleXdvcmRz LmgiCiAjaW5jbHVkZSAiQ1NTV3JhcFNoYXBlcy5oIgogI2luY2x1ZGUgIkNvbG9yLmgiCiAjaW5j bHVkZSAiQ291bnRlci5oIgogI2luY2x1ZGUgIkV4Y2VwdGlvbkNvZGUuaCIKICNpbmNsdWRlICJO b2RlLmgiCiAjaW5jbHVkZSAiUGFpci5oIgotI2luY2x1ZGUgIlJHQkNvbG9yLmgiCiAjaW5jbHVk ZSAiUmVjdC5oIgogI2luY2x1ZGUgIlJlbmRlclN0eWxlLmgiCiAjaW5jbHVkZSA8d3RmL0FTQ0lJ Q1R5cGUuaD4KQEAgLTExMyw3NCArMTExLDYgQEAgc3RhdGljIGNvbnN0IEF0b21pY1N0cmluZyYg dmFsdWVPclByb3BlcnR5TmFtZShpbnQgdmFsdWVPclByb3BlcnR5SUQpCiAgICAgcmV0dXJuIG51 bGxBdG9tOwogfQogCi1DU1NQcmltaXRpdmVWYWx1ZTo6Q1NTUHJpbWl0aXZlVmFsdWUoKQotICAg IDogbV90eXBlKDApCi0gICAgLCBtX2hhc0NhY2hlZENTU1RleHQoZmFsc2UpCi17Ci19Ci0KLUNT U1ByaW1pdGl2ZVZhbHVlOjpDU1NQcmltaXRpdmVWYWx1ZShpbnQgaWRlbnQpCi0gICAgOiBtX3R5 cGUoQ1NTX0lERU5UKQotICAgICwgbV9oYXNDYWNoZWRDU1NUZXh0KGZhbHNlKQotewotICAgIG1f dmFsdWUuaWRlbnQgPSBpZGVudDsKLX0KLQotQ1NTUHJpbWl0aXZlVmFsdWU6OkNTU1ByaW1pdGl2 ZVZhbHVlKGRvdWJsZSBudW0sIFVuaXRUeXBlcyB0eXBlKQotICAgIDogbV90eXBlKHR5cGUpCi0g ICAgLCBtX2hhc0NhY2hlZENTU1RleHQoZmFsc2UpCi17Ci0gICAgQVNTRVJUKGlzZmluaXRlKG51 bSkpOwotICAgIG1fdmFsdWUubnVtID0gbnVtOwotfQotCi1DU1NQcmltaXRpdmVWYWx1ZTo6Q1NT UHJpbWl0aXZlVmFsdWUoY29uc3QgU3RyaW5nJiBzdHIsIFVuaXRUeXBlcyB0eXBlKQotICAgIDog bV90eXBlKHR5cGUpCi0gICAgLCBtX2hhc0NhY2hlZENTU1RleHQoZmFsc2UpCi17Ci0gICAgaWYg KChtX3ZhbHVlLnN0cmluZyA9IHN0ci5pbXBsKCkpKQotICAgICAgICBtX3ZhbHVlLnN0cmluZy0+ cmVmKCk7Ci19Ci0KLUNTU1ByaW1pdGl2ZVZhbHVlOjpDU1NQcmltaXRpdmVWYWx1ZShSR0JBMzIg Y29sb3IpCi0gICAgOiBtX3R5cGUoQ1NTX1JHQkNPTE9SKQotICAgICwgbV9oYXNDYWNoZWRDU1NU ZXh0KGZhbHNlKQotewotICAgIG1fdmFsdWUucmdiY29sb3IgPSBjb2xvcjsKLX0KLQotQ1NTUHJp bWl0aXZlVmFsdWU6OkNTU1ByaW1pdGl2ZVZhbHVlKGNvbnN0IExlbmd0aCYgbGVuZ3RoKQotICAg IDogbV9oYXNDYWNoZWRDU1NUZXh0KGZhbHNlKQotewotICAgIHN3aXRjaCAobGVuZ3RoLnR5cGUo KSkgewotICAgICAgICBjYXNlIEF1dG86Ci0gICAgICAgICAgICBtX3R5cGUgPSBDU1NfSURFTlQ7 Ci0gICAgICAgICAgICBtX3ZhbHVlLmlkZW50ID0gQ1NTVmFsdWVBdXRvOwotICAgICAgICAgICAg YnJlYWs7Ci0gICAgICAgIGNhc2UgV2ViQ29yZTo6Rml4ZWQ6Ci0gICAgICAgICAgICBtX3R5cGUg PSBDU1NfUFg7Ci0gICAgICAgICAgICBBU1NFUlQoaXNmaW5pdGUobGVuZ3RoLnZhbHVlKCkpKTsK LSAgICAgICAgICAgIG1fdmFsdWUubnVtID0gbGVuZ3RoLnZhbHVlKCk7Ci0gICAgICAgICAgICBi cmVhazsKLSAgICAgICAgY2FzZSBJbnRyaW5zaWM6Ci0gICAgICAgICAgICBtX3R5cGUgPSBDU1Nf SURFTlQ7Ci0gICAgICAgICAgICBtX3ZhbHVlLmlkZW50ID0gQ1NTVmFsdWVJbnRyaW5zaWM7Ci0g ICAgICAgICAgICBicmVhazsKLSAgICAgICAgY2FzZSBNaW5JbnRyaW5zaWM6Ci0gICAgICAgICAg ICBtX3R5cGUgPSBDU1NfSURFTlQ7Ci0gICAgICAgICAgICBtX3ZhbHVlLmlkZW50ID0gQ1NTVmFs dWVNaW5JbnRyaW5zaWM7Ci0gICAgICAgICAgICBicmVhazsKLSAgICAgICAgY2FzZSBQZXJjZW50 OgotICAgICAgICAgICAgbV90eXBlID0gQ1NTX1BFUkNFTlRBR0U7Ci0gICAgICAgICAgICBBU1NF UlQoaXNmaW5pdGUobGVuZ3RoLnBlcmNlbnQoKSkpOwotICAgICAgICAgICAgbV92YWx1ZS5udW0g PSBsZW5ndGgucGVyY2VudCgpOwotICAgICAgICAgICAgYnJlYWs7Ci0gICAgICAgIGNhc2UgUmVs YXRpdmU6Ci0gICAgICAgICAgICBBU1NFUlRfTk9UX1JFQUNIRUQoKTsKLSAgICAgICAgICAgIGJy ZWFrOwotICAgIH0KLX0KLQogdm9pZCBDU1NQcmltaXRpdmVWYWx1ZTo6aW5pdChQYXNzUmVmUHRy PENvdW50ZXI+IGMpCiB7CiAgICAgbV90eXBlID0gQ1NTX0NPVU5URVI7CmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViQ29yZS9jc3MvQ1NTUHJpbWl0aXZlVmFsdWUuaCBiL1NvdXJjZS9XZWJDb3JlL2Nz cy9DU1NQcmltaXRpdmVWYWx1ZS5oCmluZGV4IGNiZmE4NGIuLjZkYWZiOWQgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJDb3JlL2Nzcy9DU1NQcmltaXRpdmVWYWx1ZS5oCisrKyBiL1NvdXJjZS9XZWJD b3JlL2Nzcy9DU1NQcmltaXRpdmVWYWx1ZS5oCkBAIC0yMyw3ICsyMywxMCBAQAogI2RlZmluZSBD U1NQcmltaXRpdmVWYWx1ZV9oCiAKICNpbmNsdWRlICJDU1NWYWx1ZS5oIgorI2luY2x1ZGUgIkNT U1ZhbHVlS2V5d29yZHMuaCIKICNpbmNsdWRlICJDb2xvci5oIgorI2luY2x1ZGUgIkxlbmd0aC5o IgorI2luY2x1ZGUgIlJHQkNvbG9yLmgiCiAjaW5jbHVkZSA8d3RmL0ZvcndhcmQuaD4KICNpbmNs dWRlIDx3dGYvTWF0aEV4dHJhcy5oPgogI2luY2x1ZGUgPHd0Zi9QYXNzUmVmUHRyLmg+CkBAIC0x OTgsMTQgKzIwMSw4MiBAQCBwdWJsaWM6CiAKIHByb3RlY3RlZDoKICAgICAvLyBGSVhNRTogaW50 IHZzLiB1bnNpZ25lZCBvdmVybG9hZGluZyBpcyB0b28gc3VidGxlIHRvIGRpc3Rpbmd1aXNoIHRo ZSBjb2xvciBhbmQgaWRlbnRpZmllciBjYXNlcy4KLSAgICBDU1NQcmltaXRpdmVWYWx1ZShpbnQg aWRlbnQpOwotICAgIENTU1ByaW1pdGl2ZVZhbHVlKGRvdWJsZSwgVW5pdFR5cGVzKTsKLSAgICBD U1NQcmltaXRpdmVWYWx1ZShjb25zdCBTdHJpbmcmLCBVbml0VHlwZXMpOworICAgIENTU1ByaW1p dGl2ZVZhbHVlKGludCBpZGVudCkKKyAgICAgICAgOiBtX3R5cGUoQ1NTX0lERU5UKQorICAgICAg ICAsIG1faGFzQ2FjaGVkQ1NTVGV4dChmYWxzZSkKKyAgICB7CisgICAgICAgIG1faXNQcmltaXRp dmVWYWx1ZSA9IHRydWU7CisgICAgICAgIG1fdmFsdWUuaWRlbnQgPSBpZGVudDsKKyAgICB9CisK KyAgICBDU1NQcmltaXRpdmVWYWx1ZShkb3VibGUgbnVtLCBVbml0VHlwZXMgdHlwZSkKKyAgICAg ICAgOiBtX3R5cGUodHlwZSkKKyAgICAgICAgLCBtX2hhc0NhY2hlZENTU1RleHQoZmFsc2UpCisg ICAgeworICAgICAgICBBU1NFUlQoaXNmaW5pdGUobnVtKSk7CisgICAgICAgIG1fdmFsdWUubnVt ID0gbnVtOworICAgICAgICBtX2lzUHJpbWl0aXZlVmFsdWUgPSB0cnVlOworICAgIH0KKworICAg IENTU1ByaW1pdGl2ZVZhbHVlKGNvbnN0IFN0cmluZyYgc3RyLCBVbml0VHlwZXMgdHlwZSkKKyAg ICAgICAgOiBtX3R5cGUodHlwZSkKKyAgICAgICAgLCBtX2hhc0NhY2hlZENTU1RleHQoZmFsc2Up CisgICAgeworICAgICAgICBtX2lzUHJpbWl0aXZlVmFsdWUgPSB0cnVlOworICAgICAgICBpZiAo KG1fdmFsdWUuc3RyaW5nID0gc3RyLmltcGwoKSkpCisgICAgICAgICAgICBtX3ZhbHVlLnN0cmlu Zy0+cmVmKCk7CisgICAgfQorCisKIAogcHJpdmF0ZToKLSAgICBDU1NQcmltaXRpdmVWYWx1ZSgp OwotICAgIENTU1ByaW1pdGl2ZVZhbHVlKHVuc2lnbmVkIGNvbG9yKTsgLy8gUkdCIHZhbHVlCi0g ICAgQ1NTUHJpbWl0aXZlVmFsdWUoY29uc3QgTGVuZ3RoJik7CisgICAgQ1NTUHJpbWl0aXZlVmFs dWUoKQorICAgICAgICA6IG1fdHlwZSgwKQorICAgICAgICAsIG1faGFzQ2FjaGVkQ1NTVGV4dChm YWxzZSkKKyAgICB7CisgICAgICAgIG1faXNQcmltaXRpdmVWYWx1ZSA9IHRydWU7CisgICAgfQor CisgICAgQ1NTUHJpbWl0aXZlVmFsdWUoUkdCQTMyIGNvbG9yKQorICAgICAgICA6IG1fdHlwZShD U1NfUkdCQ09MT1IpCisgICAgICAgICwgbV9oYXNDYWNoZWRDU1NUZXh0KGZhbHNlKQorICAgIHsK KyAgICAgICAgbV9pc1ByaW1pdGl2ZVZhbHVlID0gdHJ1ZTsKKyAgICAgICAgbV92YWx1ZS5yZ2Jj b2xvciA9IGNvbG9yOworICAgIH0KKworICAgIENTU1ByaW1pdGl2ZVZhbHVlKGNvbnN0IExlbmd0 aCYgbGVuZ3RoKQorICAgICAgICA6IG1faGFzQ2FjaGVkQ1NTVGV4dChmYWxzZSkKKyAgICB7Cisg ICAgICAgIG1faXNQcmltaXRpdmVWYWx1ZSA9IHRydWU7CisgICAgICAgIHN3aXRjaCAobGVuZ3Ro LnR5cGUoKSkgeworICAgICAgICBjYXNlIEF1dG86CisgICAgICAgICAgICBtX3R5cGUgPSBDU1Nf SURFTlQ7CisgICAgICAgICAgICBtX3ZhbHVlLmlkZW50ID0gQ1NTVmFsdWVBdXRvOworICAgICAg ICAgICAgYnJlYWs7CisgICAgICAgIGNhc2UgV2ViQ29yZTo6Rml4ZWQ6CisgICAgICAgICAgICBt X3R5cGUgPSBDU1NfUFg7CisgICAgICAgICAgICBBU1NFUlQoaXNmaW5pdGUobGVuZ3RoLnZhbHVl KCkpKTsKKyAgICAgICAgICAgIG1fdmFsdWUubnVtID0gbGVuZ3RoLnZhbHVlKCk7CisgICAgICAg ICAgICBicmVhazsKKyAgICAgICAgY2FzZSBJbnRyaW5zaWM6CisgICAgICAgICAgICBtX3R5cGUg PSBDU1NfSURFTlQ7CisgICAgICAgICAgICBtX3ZhbHVlLmlkZW50ID0gQ1NTVmFsdWVJbnRyaW5z aWM7CisgICAgICAgICAgICBicmVhazsKKyAgICAgICAgY2FzZSBNaW5JbnRyaW5zaWM6CisgICAg ICAgICAgICBtX3R5cGUgPSBDU1NfSURFTlQ7CisgICAgICAgICAgICBtX3ZhbHVlLmlkZW50ID0g Q1NTVmFsdWVNaW5JbnRyaW5zaWM7CisgICAgICAgICAgICBicmVhazsKKyAgICAgICAgY2FzZSBQ ZXJjZW50OgorICAgICAgICAgICAgbV90eXBlID0gQ1NTX1BFUkNFTlRBR0U7CisgICAgICAgICAg ICBBU1NFUlQoaXNmaW5pdGUobGVuZ3RoLnBlcmNlbnQoKSkpOworICAgICAgICAgICAgbV92YWx1 ZS5udW0gPSBsZW5ndGgucGVyY2VudCgpOworICAgICAgICAgICAgYnJlYWs7CisgICAgICAgIGNh c2UgUmVsYXRpdmU6CisgICAgICAgICAgICBBU1NFUlRfTk9UX1JFQUNIRUQoKTsKKyAgICAgICAg ICAgIGJyZWFrOworICAgICAgICB9CisgICAgfQogCiAgICAgdGVtcGxhdGU8dHlwZW5hbWUgVD4g Q1NTUHJpbWl0aXZlVmFsdWUoVCk7IC8vIERlZmluZWQgaW4gQ1NTUHJpbWl0aXZlVmFsdWVNYXBw aW5ncy5oCiAgICAgdGVtcGxhdGU8dHlwZW5hbWUgVD4gQ1NTUHJpbWl0aXZlVmFsdWUoVCogdmFs KSB7IGluaXQoUGFzc1JlZlB0cjxUPih2YWwpKTsgfQpAQCAtMjMyLDggKzMwMyw2IEBAIHByaXZh dGU6CiAKICAgICBkb3VibGUgY29tcHV0ZUxlbmd0aERvdWJsZShSZW5kZXJTdHlsZSogY3VycmVu dFN0eWxlLCBSZW5kZXJTdHlsZSogcm9vdFN0eWxlLCBkb3VibGUgbXVsdGlwbGllciwgYm9vbCBj b21wdXRpbmdGb250U2l6ZSk7CiAKLSAgICB2aXJ0dWFsIGJvb2wgaXNQcmltaXRpdmVWYWx1ZSgp IGNvbnN0IHsgcmV0dXJuIHRydWU7IH0KLQogICAgIHZpcnR1YWwgdW5zaWduZWQgc2hvcnQgY3Nz VmFsdWVUeXBlKCkgY29uc3Q7CiAKICAgICBzaWduZWQgbV90eXBlIDogMzE7CmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViQ29yZS9jc3MvQ1NTVmFsdWUuaCBiL1NvdXJjZS9XZWJDb3JlL2Nzcy9DU1NW YWx1ZS5oCmluZGV4IDEwYWMzNWMuLjg0NjdlNjcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3Jl L2Nzcy9DU1NWYWx1ZS5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL2Nzcy9DU1NWYWx1ZS5oCkBAIC0y Miw2ICsyMiw3IEBACiAjZGVmaW5lIENTU1ZhbHVlX2gKIAogI2luY2x1ZGUgIktVUkxIYXNoLmgi CisjaW5jbHVkZSA8d3RmL0Fsd2F5c0lubGluZS5oPgogI2luY2x1ZGUgPHd0Zi9MaXN0SGFzaFNl dC5oPgogI2luY2x1ZGUgPHd0Zi9SZWZQdHIuaD4KIApAQCAtMzMsNiArMzQsMTIgQEAgdHlwZWRl ZiBpbnQgRXhjZXB0aW9uQ29kZTsKIAogY2xhc3MgQ1NTVmFsdWUgOiBwdWJsaWMgUmVmQ291bnRl ZDxDU1NWYWx1ZT4gewogcHVibGljOgorCisgICAgQ1NTVmFsdWUoKQorICAgICAgICA6IG1faXNQ cmltaXRpdmVWYWx1ZShmYWxzZSkKKyAgICB7CisgICAgfQorCiAgICAgLy8gRklYTUU6IENoYW5n ZSBuYW1lIHRvIFR5cGUuCiAgICAgZW51bSBVbml0VHlwZXMgewogICAgICAgICBDU1NfSU5IRVJJ VCA9IDAsCkBAIC02Miw3ICs2OSw3IEBAIHB1YmxpYzoKICAgICB2aXJ0dWFsIGJvb2wgaXNJbWFn ZUdlbmVyYXRvclZhbHVlKCkgY29uc3QgeyByZXR1cm4gZmFsc2U7IH0KICAgICB2aXJ0dWFsIGJv b2wgaXNJbWFnZVZhbHVlKCkgY29uc3QgeyByZXR1cm4gZmFsc2U7IH0KICAgICB2aXJ0dWFsIGJv b2wgaXNJbXBsaWNpdEluaXRpYWxWYWx1ZSgpIGNvbnN0IHsgcmV0dXJuIGZhbHNlOyB9Ci0gICAg dmlydHVhbCBib29sIGlzUHJpbWl0aXZlVmFsdWUoKSBjb25zdCB7IHJldHVybiBmYWxzZTsgfQor ICAgIEFMV0FZU19JTkxJTkUgYm9vbCBpc1ByaW1pdGl2ZVZhbHVlKCkgY29uc3QgeyByZXR1cm4g bV9pc1ByaW1pdGl2ZVZhbHVlOyB9CiAgICAgdmlydHVhbCBib29sIGlzUmVmbGVjdFZhbHVlKCkg Y29uc3QgeyByZXR1cm4gZmFsc2U7IH0KICAgICB2aXJ0dWFsIGJvb2wgaXNTaGFkb3dWYWx1ZSgp IGNvbnN0IHsgcmV0dXJuIGZhbHNlOyB9CiAgICAgdmlydHVhbCBib29sIGlzVGltaW5nRnVuY3Rp b25WYWx1ZSgpIGNvbnN0IHsgcmV0dXJuIGZhbHNlOyB9CkBAIC03Niw2ICs4Myw5IEBAIHB1Ymxp YzoKICNlbmRpZgogCiAgICAgdmlydHVhbCB2b2lkIGFkZFN1YnJlc291cmNlU3R5bGVVUkxzKExp c3RIYXNoU2V0PEtVUkw+JiwgY29uc3QgQ1NTU3R5bGVTaGVldCopIHsgfQorCitwcm90ZWN0ZWQ6 CisgICAgYm9vbCBtX2lzUHJpbWl0aXZlVmFsdWU7CiB9OwogCiB9IC8vIG5hbWVzcGFjZSBXZWJD b3JlCi0tIAoxLjcuMQoK