64675 2011-07-17 21:59:59 -0700 [SVG] [Chromium] zero-path-square-cap-rendering.svg is failing 2012-01-25 19:47:58 -0800 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 71820 1 rniwa schenney jamesr rwlbuis schenney tony zimmermann oldest_to_newest 438333 0 rniwa 2011-07-17 21:59:59 -0700 Two tests added by http://trac.webkit.org/changeset/91125/ are failing on Chromium Linux: Results: http://build.webkit.org/results/Chromium%20Linux%20Release%20(Tests)/r91171%20(21141)/svg/W3C-SVG-1.1-SE/painting-control-04-f-diffs.html http://build.webkit.org/results/Chromium%20Linux%20Release%20(Tests)/r91171%20(21141)/svg/custom/zero-path-square-cap-rendering-diffs.html Flakiness dashboard: http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=svg%2FW3C-SVG-1.1-SE%2Fpainting-control-04-f.svg%2Csvg%2Fcustom%2Fzero-path-square-cap-rendering.svg&revision=91126&group=%40ToT%20-%20webkit.org 438334 1 rniwa 2011-07-17 22:01:09 -0700 They are also failing on Chromium Windows: http://build.webkit.org/results/Chromium%20Linux%20Release%20(Tests)/r91171%20(21141)/svg/W3C-SVG-1.1-SE/painting-control-04-f-diffs.html http://build.webkit.org/results/Chromium%20Linux%20Release%20(Tests)/r91171%20(21141)/svg/custom/zero-path-square-cap-rendering-diffs.html 438561 2 rwlbuis 2011-07-18 10:41:51 -0700 Hi, (In reply to comment #1) > They are also failing on Chromium Windows: > > http://build.webkit.org/results/Chromium%20Linux%20Release%20(Tests)/r91171%20(21141)/svg/W3C-SVG-1.1-SE/painting-control-04-f-diffs.html > > http://build.webkit.org/results/Chromium%20Linux%20Release%20(Tests)/r91171%20(21141)/svg/custom/zero-path-square-cap-rendering-diffs.html This should have improved after r91191. Cheers, Rob. 438684 3 rniwa 2011-07-18 13:41:12 -0700 Nope. They're still failing :( This might be Skia related. 438720 4 rniwa 2011-07-18 14:27:15 -0700 Committed r91211: <http://trac.webkit.org/changeset/91211> 438723 5 rniwa 2011-07-18 14:27:54 -0700 svg/W3C-SVG-1.1-SE/painting-control-04-f.svg is now passing but zero-path-square-cap-rendering.svg is not. 438738 6 rwlbuis 2011-07-18 14:49:49 -0700 Hi, (In reply to comment #5) > svg/W3C-SVG-1.1-SE/painting-control-04-f.svg is now passing but zero-path-square-cap-rendering.svg is not. For anyone looking into the problem on chromium, one thing to check first is check that the m_fillBoundingBox width and height is really zero. This comes from Path which is platform specific. So, the question is what Skia returns for bbox of a path "M 100 100 Z", if width/height is not exactly zero, the new special handling of zero-length paths will not kick in. Cheers, Rob. 516842 7 schenney 2011-12-07 12:39:25 -0800 This is Skia 398: http://code.google.com/p/skia/issues/detail?id=398 Skia throws away the closing "z" in "m 50 50 z" because it considers it redundant. This then causes the Skia SkPath::isEmpty call to fail because Skia considers a path "m 50 50" to be empty. This makes it impossible to correctly implement SVG zero-length linecaps for such paths. 533362 8 schenney 2012-01-10 14:00:41 -0800 This will be fixed with 71820, I hope. 542851 9 schenney 2012-01-25 19:47:58 -0800 Changes r105878 and r105921 fix the issue.