64472 2011-07-13 11:24:42 -0700 WIN: NRWT runs compositing tests on configurations that don't support compositing 2011-08-11 12:53:38 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC Windows 7 RESOLVED FIXED P2 Normal --- 38756 1 aroben eric abarth dpranke eric rniwa webkit.review.bot oldest_to_newest 436545 0 aroben 2011-07-13 11:24:42 -0700 old-run-webkit-tests has code to detect when accelerated compositing is supported, and skips various tests if it is not supported. new-run-webkit-tests needs to do this too. 436610 1 aroben 2011-07-13 12:41:34 -0700 The relevant code in ORWT is here: <http://trac.webkit.org/browser/trunk/Tools/Scripts/old-run-webkit-tests?rev=90125#L544>. 436616 2 eric 2011-07-13 13:03:47 -0700 Thank you for the report. Should be very easy to fix. 436704 3 eric 2011-07-13 15:27:03 -0700 The support is all written, but it must be broken somehow. Someone with python familiarity and a windows build of webkit should be able to debug this. I don't have a windows build handy. :( http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/layout_tests/port/webkit.py#L276 http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/layout_tests/port/webkit.py#L236 http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/layout_tests/port/webkit.py#L253 436712 4 dpranke 2011-07-13 15:36:48 -0700 I will take a look. In theory, you should be able to verify this with --platform mock-win and not need the build around. 436720 5 dpranke 2011-07-13 15:50:05 -0700 (In reply to comment #4) > I will take a look. In theory, you should be able to verify this with --platform mock-win and not need the build around. Er, scratch that, obviously it won't work for feature detection. 449230 6 eric 2011-08-10 10:45:06 -0700 If someone with a windows box could tell me what DRT output looks like I can easily unittest (and hopefully fix) this code without needing to set up a windows machine: Basically I just need the output from: ./DumpRenderTree --print-supported-features 2>&1 It would be nice to know if --print-supported-features is actually writing to stderr, because I'd like to get rid of the 2>&1 nonsense if possible. :) 449231 7 eric 2011-08-10 10:45:42 -0700 It looks like it does not print to stderr: if (printSupportedFeatures) { BOOL acceleratedCompositingAvailable; standardPreferences->acceleratedCompositingEnabled(&acceleratedCompositingAvailable); #if ENABLE(3D_RENDERING) // In theory, we could have a software-based 3D rendering implementation that we use when // hardware-acceleration is not available. But we don't have any such software // implementation, so 3D rendering is only available when hardware-acceleration is. BOOL threeDRenderingAvailable = acceleratedCompositingAvailable; #else BOOL threeDRenderingAvailable = FALSE; #endif printf("SupportedFeatures:%s %s\n", acceleratedCompositingAvailable ? "AcceleratedCompositing" : "", threeDRenderingAvailable ? "3DRendering" : ""); return 0; } 449251 8 103507 eric 2011-08-10 11:03:53 -0700 Created attachment 103507 Patch 449253 9 103507 abarth 2011-08-10 11:09:47 -0700 Comment on attachment 103507 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=103507&action=review > Tools/Scripts/webkitpy/layout_tests/port/webkit.py:232 > + supported_features_command = [self._path_to_driver(), '--print-supported-features'] > + output = self._executive.run_command(supported_features_command) I would just merge these lines. 449305 10 103507 webkit.review.bot 2011-08-10 12:35:15 -0700 Comment on attachment 103507 Patch Clearing flags on attachment: 103507 Committed r92784: <http://trac.webkit.org/changeset/92784> 449306 11 webkit.review.bot 2011-08-10 12:35:20 -0700 All reviewed patches have been landed. Closing bug. 449514 12 rniwa 2011-08-10 17:26:29 -0700 This patch broke nrwt on Snow Leopard :( http://build.webkit.org/builders/SnowLeopard%20Intel%20Release%20%28Tests%29/builds/32181 It's completely blocking my work at the moment. 449517 13 rniwa 2011-08-10 17:28:11 -0700 When I run it locally, I get the following error: Traceback (most recent call last): File "/Volumes/Data/webkit3/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py", line 436, in <module> sys.exit(main()) File "/Volumes/Data/webkit3/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py", line 431, in main return run(port, options, args) File "/Volumes/Data/webkit3/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py", line 98, in run manager.parse_expectations() File "/Volumes/Data/webkit3/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py", line 375, in parse_expectations port.test_expectations(), File "/Volumes/Data/webkit3/Tools/Scripts/webkitpy/layout_tests/port/webkit.py", line 327, in test_expectations expectations = self._skipped_list_as_expectations() File "/Volumes/Data/webkit3/Tools/Scripts/webkitpy/layout_tests/port/webkit.py", line 343, in _skipped_list_as_expectations tests_to_skip = self.skipped_layout_tests() File "/Volumes/Data/webkit3/Tools/Scripts/webkitpy/layout_tests/port/webkit.py", line 351, in skipped_layout_tests tests_to_skip.update(self._skipped_tests_for_unsupported_features()) File "/Volumes/Data/webkit3/Tools/Scripts/webkitpy/layout_tests/port/webkit.py", line 274, in _skipped_tests_for_unsupported_features feature_list = self._runtime_feature_list() File "/Volumes/Data/webkit3/Tools/Scripts/webkitpy/layout_tests/port/webkit.py", line 232, in _runtime_feature_list output = self._executive.run_command(supported_features_command) File "/Volumes/Data/webkit3/Tools/Scripts/webkitpy/common/system/executive.py", line 441, in run_command (error_handler or self.default_error_handler)(script_error) File "/Volumes/Data/webkit3/Tools/Scripts/webkitpy/common/system/executive.py", line 358, in default_error_handler raise error webkitpy.common.system.executive.ScriptError: Failed to run "[u'/Volumes/Data/webkit3/WebKitBuild/Debug/DumpRenderTree', u'--print-supported-features']" exit_code: 1 449528 14 rniwa 2011-08-10 17:48:57 -0700 It appears that the regression has been fixed. 449950 15 eric 2011-08-11 12:53:38 -0700 Yup. Thank you for the report. 103507 2011-08-10 11:03:53 -0700 2011-08-10 12:35:15 -0700 Patch bug-64472-20110810110351.patch text/plain 4616 eric U3VidmVyc2lvbiBSZXZpc2lvbjogOTI3NzUKZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBi L1Rvb2xzL0NoYW5nZUxvZwppbmRleCBmZTlhNDU0Y2IxNzU0YTRiYWVkY2RiNDU4NTVkZjVlODdl NDY2MzFhLi42OTJiZTJlODA2ZDMwOWVkYjAwM2QyZjI5NTJmYThhNzRkYzc1MjFlIDEwMDY0NAot LS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjMg QEAKKzIwMTEtMDgtMTAgIEVyaWMgU2VpZGVsICA8ZXJpY0B3ZWJraXQub3JnPgorCisgICAgICAg IFdJTjogTlJXVCBydW5zIGNvbXBvc2l0aW5nIHRlc3RzIG9uIGNvbmZpZ3VyYXRpb25zIHRoYXQg ZG9uJ3Qgc3VwcG9ydCBjb21wb3NpdGluZworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9NjQ0NzIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBJIHRoaW5rIHRoZSBjb2RlIHdhcyBqdXN0IHdyb25nLiAgSXQgd2Fz IG5ldmVyIHNwbGl0dGluZyB0aGUgc3RyaW5nCisgICAgICAgIGludG8gbGlzdCBwaWVjZXMgYmVm b3JlLgorICAgICAgICBJJ3ZlIG5vdyB0ZXN0ZWQgdGhlIHN1cHBvcnRlZF9mZWF0dXJlcyBjb2Rl IGFuZCB0aGVvcmV0aWNhbGx5IGl0CisgICAgICAgIHNob3VsZCBub3cgd29yayB3aXRoIFdpbmRv d3MgRFJULgorCisgICAgICAgIEkgYWxzbyBtYWRlIHRoZSBsaXN0LWxvb2t1cCBmdW5jdGlvbnMg YWx3YXlzIHJldHVybiBsaXN0cywgdG8gbWFrZQorICAgICAgICBpdCBwb3NzaWJsZSB0byBjbGVh biB1cCB0aGUgbGlzdC10cmFuc2Zvcm0gY29kZSBpbiB0aGUgZnV0dXJlCisgICAgICAgIChJIG9w dGVkIG5vdCB0byBkbyB0aGF0IGNsZWFudXAgaW4gdGhpcyBwYXRjaCwgYnV0IGF0IGxlYXN0IG5v dworICAgICAgICBib3RoIHR5cGVzIG9mIGZlYXR1cmUgbG9va3VwIGZ1bmN0aW9ucyBtYXRjaCBy ZXR1cm4gdHlwZXMuKQorCisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMv cG9ydC93ZWJraXQucHk6CisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMv cG9ydC93ZWJraXRfdW5pdHRlc3QucHk6CisKIDIwMTEtMDgtMTAgIERpbWl0cmkgR2xhemtvdiAg PGRnbGF6a292QGNocm9taXVtLm9yZz4KIAogICAgICAgICBVbm11ZGRsZSBjb25zdHJ1Y3Rpb24g b3B0aW9ucyBmb3IgVGVzdENvbmZpZ3VyYXRpb24uCmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRz L3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L3dlYmtpdC5weSBiL1Rvb2xzL1NjcmlwdHMvd2Vi a2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQvd2Via2l0LnB5CmluZGV4IDE2MzBjMTMyNjhmOTAyNjE2 NDBhZmVlNjdjN2RhZjAyNjQ5ZGI4MDcuLjczMjY2YmY0ODY3YWM4Yjc4MGI1MDUyNmY3ODJjZDJl OGIyOTk2OTMgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3Rz L3BvcnQvd2Via2l0LnB5CisrKyBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3Rz L3BvcnQvd2Via2l0LnB5CkBAIC0yMjAsNyArMjIwLDcgQEAgY2xhc3MgV2ViS2l0UG9ydChQb3J0 KToKICAgICAgICAgZW50cmllcyA9IHNlbGYuX2ZpbGVzeXN0ZW0uZ2xvYihzZWxmLl93ZWJraXRf YmFzZWxpbmVfcGF0aCgnKicpKQogICAgICAgICBkaXJzX3RvX3NraXAgPSBbXQogICAgICAgICBm b3IgZW50cnkgaW4gZW50cmllczoKLSAgICAgICAgICAgIGlmIHNlbGYuX2ZpbGVzeXN0ZW0uaXNk aXIoZW50cnkpIGFuZCBub3QgZW50cnkgaW4gc2VsZi5iYXNlbGluZV9zZWFyY2hfcGF0aCgpOgor ICAgICAgICAgICAgaWYgc2VsZi5fZmlsZXN5c3RlbS5pc2RpcihlbnRyeSkgYW5kIGVudHJ5IG5v dCBpbiBzZWxmLmJhc2VsaW5lX3NlYXJjaF9wYXRoKCk6CiAgICAgICAgICAgICAgICAgYmFzZW5h bWUgPSBzZWxmLl9maWxlc3lzdGVtLmJhc2VuYW1lKGVudHJ5KQogICAgICAgICAgICAgICAgIGRp cnNfdG9fc2tpcC5hcHBlbmQoJ3BsYXRmb3JtLyVzJyAlIGJhc2VuYW1lKQogICAgICAgICByZXR1 cm4gZGlyc190b19za2lwCkBAIC0yMjgsMTcgKzIyOCwxOSBAQCBjbGFzcyBXZWJLaXRQb3J0KFBv cnQpOgogICAgIGRlZiBfcnVudGltZV9mZWF0dXJlX2xpc3Qoc2VsZik6CiAgICAgICAgICIiIlJl dHVybiB0aGUgc3VwcG9ydGVkIGZlYXR1cmVzIG9mIERSVC4gSWYgYSBwb3J0IGRvZXNuJ3Qgc3Vw cG9ydAogICAgICAgICB0aGlzIERSVCBzd2l0Y2gsIGl0IGhhcyB0byBvdmVycmlkZSB0aGlzIG1l dGhvZCB0byByZXR1cm4gTm9uZSIiIgotICAgICAgICBkcml2ZXJfcGF0aCA9IHNlbGYuX3BhdGhf dG9fZHJpdmVyKCkKLSAgICAgICAgZmVhdHVyZV9saXN0ID0gJyAnLmpvaW4ob3MucG9wZW4oZHJp dmVyX3BhdGggKyAiIC0tcHJpbnQtc3VwcG9ydGVkLWZlYXR1cmVzIDI+JjEiKS5yZWFkbGluZXMo KSkKLSAgICAgICAgaWYgIlN1cHBvcnRlZEZlYXR1cmVzOiIgaW4gZmVhdHVyZV9saXN0OgotICAg ICAgICAgICAgcmV0dXJuIGZlYXR1cmVfbGlzdAotICAgICAgICByZXR1cm4gTm9uZQorICAgICAg ICBzdXBwb3J0ZWRfZmVhdHVyZXNfY29tbWFuZCA9IFtzZWxmLl9wYXRoX3RvX2RyaXZlcigpLCAn LS1wcmludC1zdXBwb3J0ZWQtZmVhdHVyZXMnXQorICAgICAgICBvdXRwdXQgPSBzZWxmLl9leGVj dXRpdmUucnVuX2NvbW1hbmQoc3VwcG9ydGVkX2ZlYXR1cmVzX2NvbW1hbmQpCisgICAgICAgICMg Tm90ZTogd2luL0R1bXBSZW5kZXJUcmVlLmNwcCBkb2VzIG5vdCBwcmludCBhIGxlYWRpbmcgc3Bh Y2UgYmVmb3JlIHRoZSBmZWF0dXJlc19zdHJpbmcuCisgICAgICAgIG1hdGNoX29iamVjdCA9IHJl Lm1hdGNoKCJTdXBwb3J0ZWRGZWF0dXJlczpccyooP1A8ZmVhdHVyZXNfc3RyaW5nPi4qKVxzKiIs IG91dHB1dCkKKyAgICAgICAgaWYgbm90IG1hdGNoX29iamVjdDoKKyAgICAgICAgICAgIHJldHVy biBbXQorICAgICAgICByZXR1cm4gbWF0Y2hfb2JqZWN0Lmdyb3VwKCdmZWF0dXJlc19zdHJpbmcn KS5zcGxpdCgnICcpCiAKICAgICBkZWYgX3N1cHBvcnRlZF9zeW1ib2xfbGlzdChzZWxmKToKICAg ICAgICAgIiIiUmV0dXJuIHRoZSBzdXBwb3J0ZWQgc3ltYm9scyBvZiBXZWJDb3JlLiIiIgogICAg ICAgICB3ZWJjb3JlX2xpYnJhcnlfcGF0aCA9IHNlbGYuX3BhdGhfdG9fd2ViY29yZV9saWJyYXJ5 KCkKICAgICAgICAgaWYgbm90IHdlYmNvcmVfbGlicmFyeV9wYXRoOgotICAgICAgICAgICAgcmV0 dXJuIE5vbmUKKyAgICAgICAgICAgIHJldHVybiBbXQogICAgICAgICBzeW1ib2xfbGlzdCA9ICcg Jy5qb2luKG9zLnBvcGVuKCJubSAiICsgd2ViY29yZV9saWJyYXJ5X3BhdGgpLnJlYWRsaW5lcygp KQogICAgICAgICByZXR1cm4gc3ltYm9sX2xpc3QKIApkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0 cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC93ZWJraXRfdW5pdHRlc3QucHkgYi9Ub29scy9T Y3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L3dlYmtpdF91bml0dGVzdC5weQppbmRl eCBmMWQ3NjFlZDFhODc5ZTYwY2JmYTdlZGE4MmJiNjA1ZTI0YmU3OGJhLi40ZTZkYTE2MzkzNDM5 MjEwYWJhODUwNTQwMTUzZGU4NmZhMmE4Y2Q1IDEwMDc1NQotLS0gYS9Ub29scy9TY3JpcHRzL3dl YmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L3dlYmtpdF91bml0dGVzdC5weQorKysgYi9Ub29scy9T Y3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L3dlYmtpdF91bml0dGVzdC5weQpAQCAt MTAxLDYgKzEwMSwxMyBAQCBjbGFzcyBXZWJLaXRQb3J0VGVzdChwb3J0X3Rlc3RjYXNlLlBvcnRU ZXN0Q2FzZSk6CiAgICAgICAgIHJlc3VsdF9kaXJlY3RvcmllcyA9IHNldChUZXN0V2ViS2l0UG9y dChzdXBwb3J0ZWRfc3ltYm9scywgTm9uZSkuX3NraXBwZWRfdGVzdHNfZm9yX3Vuc3VwcG9ydGVk X2ZlYXR1cmVzKCkpCiAgICAgICAgIHNlbGYuYXNzZXJ0RXF1YWwocmVzdWx0X2RpcmVjdG9yaWVz LCBleHBlY3RlZF9kaXJlY3RvcmllcykKIAorICAgIGRlZiB0ZXN0X3J1bnRpbWVfZmVhdHVyZV9s aXN0KHNlbGYpOgorICAgICAgICBwb3J0ID0gV2ViS2l0UG9ydChleGVjdXRpdmU9TW9ja0V4ZWN1 dGl2ZSgpKQorICAgICAgICBwb3J0Ll9leGVjdXRpdmUucnVuX2NvbW1hbmQgPSBsYW1iZGEgY29t bWFuZCwgY3dkPU5vbmU6ICJOb25zZW5zZSIKKyAgICAgICAgc2VsZi5hc3NlcnRFcXVhbHMocG9y dC5fcnVudGltZV9mZWF0dXJlX2xpc3QoKSwgW10pCisgICAgICAgIHBvcnQuX2V4ZWN1dGl2ZS5y dW5fY29tbWFuZCA9IGxhbWJkYSBjb21tYW5kLCBjd2Q9Tm9uZTogIlN1cHBvcnRlZEZlYXR1cmVz OmZvbyBiYXIiCisgICAgICAgIHNlbGYuYXNzZXJ0RXF1YWxzKHBvcnQuX3J1bnRpbWVfZmVhdHVy ZV9saXN0KCksIFsnZm9vJywgJ2JhciddKQorCiAgICAgZGVmIHRlc3Rfc2tpcHBlZF9kaXJlY3Rv cmllc19mb3JfZmVhdHVyZXMoc2VsZik6CiAgICAgICAgIHN1cHBvcnRlZF9mZWF0dXJlcyA9IFsi QWNjZWxlcmF0ZWQgQ29tcG9zaXRpbmciLCAiRm9vIEZlYXR1cmUiXQogICAgICAgICBleHBlY3Rl ZF9kaXJlY3RvcmllcyA9IHNldChbImFuaW1hdGlvbnMvM2QiLCAidHJhbnNmb3Jtcy8zZCJdKQo=