64178 2011-07-08 10:49:58 -0700 remove (empty) indirection between GraphicsContextPlatformPrivate and PlatformContextSkia 2011-07-08 13:29:14 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 reed reed jamesr senorblanco webkit.review.bot oldest_to_newest 434148 0 reed 2011-07-08 10:49:58 -0700 remove (empty) indirection between GraphicsContextPlatformPrivate and PlatformContextSkia 434150 1 100133 reed 2011-07-08 10:50:58 -0700 Created attachment 100133 Patch 434154 2 100133 senorblanco 2011-07-08 10:54:33 -0700 Comment on attachment 100133 Patch Good idea! Will just let it pass the EWS bots, then I'll r+. 434218 3 senorblanco 2011-07-08 12:08:57 -0700 Looks good. r=me 434268 4 100133 webkit.review.bot 2011-07-08 13:29:09 -0700 Comment on attachment 100133 Patch Clearing flags on attachment: 100133 Committed r90661: <http://trac.webkit.org/changeset/90661> 434269 5 webkit.review.bot 2011-07-08 13:29:14 -0700 All reviewed patches have been landed. Closing bug. 100133 2011-07-08 10:50:58 -0700 2011-07-08 13:29:09 -0700 Patch bug-64178-20110708135057.patch text/plain 5583 reed SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDkwNjQyKQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTkgQEAKKzIwMTEtMDctMDggIE1pa2UgUmVl ZCAgPHJlZWRAZ29vZ2xlLmNvbT4KKworICAgICAgICByZW1vdmUgKGVtcHR5KSBpbmRpcmVjdGlv biBiZXR3ZWVuIEdyYXBoaWNzQ29udGV4dFBsYXRmb3JtUHJpdmF0ZSBhbmQgUGxhdGZvcm1Db250 ZXh0U2tpYQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 NjQxNzgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBO byBuZXcgdGVzdHMuIG5vIGZ1bmN0aW9uYWxpdHkgY2hhbmdlLCBvdGhlciB0aGFuIHJlbW92aW5n IGFuIGluZGlyZWN0aW9uIHRoYXQgaXMgbm90IG5lZWRlZAorCisgICAgICAgICogcGxhdGZvcm0v Z3JhcGhpY3MvR3JhcGhpY3NDb250ZXh0Lmg6CisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3Mv c2tpYS9HcmFwaGljc0NvbnRleHRQbGF0Zm9ybVByaXZhdGUuaDogUmVtb3ZlZC4KKyAgICAgICAg KiBwbGF0Zm9ybS9ncmFwaGljcy9za2lhL0dyYXBoaWNzQ29udGV4dFNraWEuY3BwOgorICAgICAg ICAoV2ViQ29yZTo6R3JhcGhpY3NDb250ZXh0OjpwbGF0Zm9ybUluaXQpOgorICAgICAgICAoV2Vi Q29yZTo6R3JhcGhpY3NDb250ZXh0OjpwbGF0Zm9ybURlc3Ryb3kpOgorICAgICAgICAoV2ViQ29y ZTo6R3JhcGhpY3NDb250ZXh0OjpwbGF0Zm9ybUNvbnRleHQpOgorCiAyMDExLTA3LTA4ICBNaWhu ZWEgT3ZpZGVuaWUgIDxtaWhuZWFAYWRvYmUuY29tPgogCiAgICAgICAgIFtDU1NSZWdpb25zXVBh cnNlIGNvbnRlbnQ6IC13ZWJraXQtZnJvbS1mbG93CkluZGV4OiBTb3VyY2UvV2ViQ29yZS9wbGF0 Zm9ybS9ncmFwaGljcy9HcmFwaGljc0NvbnRleHQuaAo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9wbGF0Zm9ybS9ncmFwaGljcy9HcmFwaGljc0NvbnRleHQuaAkocmV2aXNpb24gOTA2MjMp CisrKyBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9HcmFwaGljc0NvbnRleHQuaAko d29ya2luZyBjb3B5KQpAQCAtNzksNiArNzksNyBAQCBjbGFzcyB3eFdpbmRvd0RDOwogI2VsaWYg VVNFKFNLSUEpCiBuYW1lc3BhY2UgV2ViQ29yZSB7CiBjbGFzcyBQbGF0Zm9ybUNvbnRleHRTa2lh OwordHlwZWRlZiBQbGF0Zm9ybUNvbnRleHRTa2lhIEdyYXBoaWNzQ29udGV4dFBsYXRmb3JtUHJp dmF0ZTsKIH0KIHR5cGVkZWYgV2ViQ29yZTo6UGxhdGZvcm1Db250ZXh0U2tpYSBQbGF0Zm9ybUdy YXBoaWNzQ29udGV4dDsKICNlbGlmIFBMQVRGT1JNKEhBSUtVKQpAQCAtMTIwLDcgKzEyMSw5IEBA IG5hbWVzcGFjZSBXZWJDb3JlIHsKICAgICBjbGFzcyBEcmF3aW5nQnVmZmVyOwogICAgIGNsYXNz IEZvbnQ7CiAgICAgY2xhc3MgR2VuZXJhdG9yOworI2lmICFVU0UoU0tJQSkKICAgICBjbGFzcyBH cmFwaGljc0NvbnRleHRQbGF0Zm9ybVByaXZhdGU7CisjZW5kaWYKICAgICBjbGFzcyBJbWFnZUJ1 ZmZlcjsKICAgICBjbGFzcyBJbnRSZWN0OwogICAgIGNsYXNzIFJvdW5kZWRJbnRSZWN0OwpJbmRl eDogU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mvc2tpYS9HcmFwaGljc0NvbnRleHRQ bGF0Zm9ybVByaXZhdGUuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9n cmFwaGljcy9za2lhL0dyYXBoaWNzQ29udGV4dFBsYXRmb3JtUHJpdmF0ZS5oCShyZXZpc2lvbiA5 MDYyMykKKysrIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3NraWEvR3JhcGhpY3ND b250ZXh0UGxhdGZvcm1Qcml2YXRlLmgJKHdvcmtpbmcgY29weSkKQEAgLTEsNTUgKzAsMCBAQAot LyoKLSAqIENvcHlyaWdodCAoYykgMjAwOCwgR29vZ2xlIEluYy4gQWxsIHJpZ2h0cyByZXNlcnZl ZC4KLSAqIAotICogUmVkaXN0cmlidXRpb24gYW5kIHVzZSBpbiBzb3VyY2UgYW5kIGJpbmFyeSBm b3Jtcywgd2l0aCBvciB3aXRob3V0Ci0gKiBtb2RpZmljYXRpb24sIGFyZSBwZXJtaXR0ZWQgcHJv dmlkZWQgdGhhdCB0aGUgZm9sbG93aW5nIGNvbmRpdGlvbnMgYXJlCi0gKiBtZXQ6Ci0gKiAKLSAq ICAgICAqIFJlZGlzdHJpYnV0aW9ucyBvZiBzb3VyY2UgY29kZSBtdXN0IHJldGFpbiB0aGUgYWJv dmUgY29weXJpZ2h0Ci0gKiBub3RpY2UsIHRoaXMgbGlzdCBvZiBjb25kaXRpb25zIGFuZCB0aGUg Zm9sbG93aW5nIGRpc2NsYWltZXIuCi0gKiAgICAgKiBSZWRpc3RyaWJ1dGlvbnMgaW4gYmluYXJ5 IGZvcm0gbXVzdCByZXByb2R1Y2UgdGhlIGFib3ZlCi0gKiBjb3B5cmlnaHQgbm90aWNlLCB0aGlz IGxpc3Qgb2YgY29uZGl0aW9ucyBhbmQgdGhlIGZvbGxvd2luZyBkaXNjbGFpbWVyCi0gKiBpbiB0 aGUgZG9jdW1lbnRhdGlvbiBhbmQvb3Igb3RoZXIgbWF0ZXJpYWxzIHByb3ZpZGVkIHdpdGggdGhl Ci0gKiBkaXN0cmlidXRpb24uCi0gKiAgICAgKiBOZWl0aGVyIHRoZSBuYW1lIG9mIEdvb2dsZSBJ bmMuIG5vciB0aGUgbmFtZXMgb2YgaXRzCi0gKiBjb250cmlidXRvcnMgbWF5IGJlIHVzZWQgdG8g ZW5kb3JzZSBvciBwcm9tb3RlIHByb2R1Y3RzIGRlcml2ZWQgZnJvbQotICogdGhpcyBzb2Z0d2Fy ZSB3aXRob3V0IHNwZWNpZmljIHByaW9yIHdyaXR0ZW4gcGVybWlzc2lvbi4KLSAqIAotICogVEhJ UyBTT0ZUV0FSRSBJUyBQUk9WSURFRCBCWSBUSEUgQ09QWVJJR0hUIEhPTERFUlMgQU5EIENPTlRS SUJVVE9SUwotICogIkFTIElTIiBBTkQgQU5ZIEVYUFJFU1MgT1IgSU1QTElFRCBXQVJSQU5USUVT LCBJTkNMVURJTkcsIEJVVCBOT1QKLSAqIExJTUlURUQgVE8sIFRIRSBJTVBMSUVEIFdBUlJBTlRJ RVMgT0YgTUVSQ0hBTlRBQklMSVRZIEFORCBGSVRORVNTIEZPUgotICogQSBQQVJUSUNVTEFSIFBV UlBPU0UgQVJFIERJU0NMQUlNRUQuIElOIE5PIEVWRU5UIFNIQUxMIFRIRSBDT1BZUklHSFQKLSAq IE9XTkVSIE9SIENPTlRSSUJVVE9SUyBCRSBMSUFCTEUgRk9SIEFOWSBESVJFQ1QsIElORElSRUNU LCBJTkNJREVOVEFMLAotICogU1BFQ0lBTCwgRVhFTVBMQVJZLCBPUiBDT05TRVFVRU5USUFMIERB TUFHRVMgKElOQ0xVRElORywgQlVUIE5PVAotICogTElNSVRFRCBUTywgUFJPQ1VSRU1FTlQgT0Yg U1VCU1RJVFVURSBHT09EUyBPUiBTRVJWSUNFUzsgTE9TUyBPRiBVU0UsCi0gKiBEQVRBLCBPUiBQ Uk9GSVRTOyBPUiBCVVNJTkVTUyBJTlRFUlJVUFRJT04pIEhPV0VWRVIgQ0FVU0VEIEFORCBPTiBB TlkKLSAqIFRIRU9SWSBPRiBMSUFCSUxJVFksIFdIRVRIRVIgSU4gQ09OVFJBQ1QsIFNUUklDVCBM SUFCSUxJVFksIE9SIFRPUlQKLSAqIChJTkNMVURJTkcgTkVHTElHRU5DRSBPUiBPVEhFUldJU0Up IEFSSVNJTkcgSU4gQU5ZIFdBWSBPVVQgT0YgVEhFIFVTRQotICogT0YgVEhJUyBTT0ZUV0FSRSwg RVZFTiBJRiBBRFZJU0VEIE9GIFRIRSBQT1NTSUJJTElUWSBPRiBTVUNIIERBTUFHRS4KLSAqLwot Ci0jaWZuZGVmIEdyYXBoaWNzQ29udGV4dFBsYXRmb3JtUHJpdmF0ZV9oCi0jZGVmaW5lIEdyYXBo aWNzQ29udGV4dFBsYXRmb3JtUHJpdmF0ZV9oCi0KLQotY2xhc3MgUGxhdGZvcm1Db250ZXh0U2tp YTsKLQotbmFtZXNwYWNlIFdlYkNvcmUgewotCi0vLyBUaGlzIGNsYXNzIGp1c3QgaG9sZHMgb250 byBhIFBsYXRmb3JtQ29udGV4dFNraWEgZm9yIEdyYXBoaWNzQ29udGV4dC4KLWNsYXNzIEdyYXBo aWNzQ29udGV4dFBsYXRmb3JtUHJpdmF0ZSB7Ci0gICAgV1RGX01BS0VfTk9OQ09QWUFCTEUoR3Jh cGhpY3NDb250ZXh0UGxhdGZvcm1Qcml2YXRlKTsKLXB1YmxpYzoKLSAgICBHcmFwaGljc0NvbnRl eHRQbGF0Zm9ybVByaXZhdGUoUGxhdGZvcm1Db250ZXh0U2tpYSogcGxhdGZvcm1Db250ZXh0KQot ICAgICAgICA6IG1fY29udGV4dChwbGF0Zm9ybUNvbnRleHQpIHsgfQotCi0gICAgUGxhdGZvcm1D b250ZXh0U2tpYSogY29udGV4dCgpIHsgcmV0dXJuIG1fY29udGV4dDsgfQotCi1wcml2YXRlOgot ICAgIC8vIE5vbi1vd25pbmcgcG9pbnRlciB0byB0aGUgUGxhdGZvcm1Db250ZXh0LgotICAgIFBs YXRmb3JtQ29udGV4dFNraWEqIG1fY29udGV4dDsKLX07Ci0KLX0gIC8vIG5hbWVzcGFjZSBXZWJD b3JlCi0KLSNlbmRpZiAgLy8gR3JhcGhpY3NDb250ZXh0UGxhdGZvcm1Qcml2YXRlX2gKSW5kZXg6 IFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3NraWEvR3JhcGhpY3NDb250ZXh0U2tp YS5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mvc2tp YS9HcmFwaGljc0NvbnRleHRTa2lhLmNwcAkocmV2aXNpb24gOTA2MjMpCisrKyBTb3VyY2UvV2Vi Q29yZS9wbGF0Zm9ybS9ncmFwaGljcy9za2lhL0dyYXBoaWNzQ29udGV4dFNraWEuY3BwCSh3b3Jr aW5nIGNvcHkpCkBAIC0zNiw3ICszNiw2IEBACiAjaW5jbHVkZSAiRmxvYXRSZWN0LmgiCiAjaW5j bHVkZSAiR3JhZGllbnQuaCIKICNpbmNsdWRlICJHcmFwaGljc0NvbnRleHRHUFUuaCIKLSNpbmNs dWRlICJHcmFwaGljc0NvbnRleHRQbGF0Zm9ybVByaXZhdGUuaCIKICNpbmNsdWRlICJJbWFnZUJ1 ZmZlci5oIgogI2luY2x1ZGUgIkludFJlY3QuaCIKICNpbmNsdWRlICJOYXRpdmVJbWFnZVNraWEu aCIKQEAgLTIyNiwxOSArMjI1LDE5IEBAIHZvaWQgYWRkQ29ybmVyQXJjKFNrUGF0aCogcGF0aCwg Y29uc3QgU2sKIC8vIG5vIHBhaW50aW5nLgogdm9pZCBHcmFwaGljc0NvbnRleHQ6OnBsYXRmb3Jt SW5pdChQbGF0Zm9ybUdyYXBoaWNzQ29udGV4dCogZ2MpCiB7Ci0gICAgbV9kYXRhID0gbmV3IEdy YXBoaWNzQ29udGV4dFBsYXRmb3JtUHJpdmF0ZShnYyk7Ci0gICAgc2V0UGFpbnRpbmdEaXNhYmxl ZCghZ2MgfHwgIXBsYXRmb3JtQ29udGV4dCgpLT5jYW52YXMoKSk7CisgICAgLy8gdGhlIGNhbGxl ciBvd25zIHRoZSBnYworICAgIG1fZGF0YSA9IGdjOworICAgIHNldFBhaW50aW5nRGlzYWJsZWQo IWdjIHx8ICFnYy0+Y2FudmFzKCkpOwogfQogCiB2b2lkIEdyYXBoaWNzQ29udGV4dDo6cGxhdGZv cm1EZXN0cm95KCkKIHsKLSAgICBkZWxldGUgbV9kYXRhOwogfQogCiBQbGF0Zm9ybUdyYXBoaWNz Q29udGV4dCogR3JhcGhpY3NDb250ZXh0OjpwbGF0Zm9ybUNvbnRleHQoKSBjb25zdAogewogICAg IEFTU0VSVCghcGFpbnRpbmdEaXNhYmxlZCgpKTsKLSAgICByZXR1cm4gbV9kYXRhLT5jb250ZXh0 KCk7CisgICAgcmV0dXJuIG1fZGF0YTsKIH0KIAogLy8gU3RhdGUgc2F2aW5nIC0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0K