64092 2011-07-07 08:30:14 -0700 REGRESSION(90419) NRWT's httpd locking is broken for --child-processes=1 2011-07-08 12:22:00 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All Linux RESOLVED FIXED P1 Normal --- 34984 63116 1 abecsi dpranke abarth dpranke eric kkristof ojan ossy webkit.review.bot oldest_to_newest 433467 0 abecsi 2011-07-07 08:30:14 -0700 ORWT's httpd locking and scheduling mechanism was implemented to be able to run multiple run-webkit-tests sessions besides each other without interfering, so the the tests needing httpd should mutually exclude each other. Since http://trac.webkit.org/changeset/90419 this mechanism is broken when using --child-processes=1 in two ways: 1) The httpd is started without using the checking mechanism implemented in http://trac.webkit.org/changeset/89414 and the script is crashing when there is no httpd present. 2) The httpd locks are acquired even if not running any http or websocket tests, so one testing session entirely blocks another. 433556 1 eric 2011-07-07 10:13:05 -0700 Oh? Do we need to turn off NRWT for Qt for the meanwhile? 433563 2 dpranke 2011-07-07 10:17:02 -0700 Hm. Neither of these things should be true. There was a bug introduced yesterday on chromium windows where we weren't checking for the http server properly, but the rest of this stuff should be working. I will investigate further. 433861 3 100065 dpranke 2011-07-07 19:18:43 -0700 Created attachment 100065 Patch 433862 4 dpranke 2011-07-07 19:19:06 -0700 Yup, I definitely broke it. This patch should fix things. 434226 5 100065 webkit.review.bot 2011-07-08 12:21:55 -0700 Comment on attachment 100065 Patch Clearing flags on attachment: 100065 Committed r90651: <http://trac.webkit.org/changeset/90651> 434227 6 webkit.review.bot 2011-07-08 12:22:00 -0700 All reviewed patches have been landed. Closing bug. 100065 2011-07-07 19:18:43 -0700 2011-07-08 12:21:55 -0700 Patch bug-64092-20110707191842.patch text/plain 3940 dpranke U3VidmVyc2lvbiBSZXZpc2lvbjogOTA1ODgKZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBi L1Rvb2xzL0NoYW5nZUxvZwppbmRleCA5MWY1ZTEyYTFjZmUzMzQ1NWJjZWIxN2E0MThkNjA1NzRi N2E0ZjM3Li5hMDkwNmM1YWEwODAxMmY0OWM0MmM1ZDEzOTlkOTcxY2Q4NjQwNDRhIDEwMDY0NAot LS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYg QEAKKzIwMTEtMDctMDcgIERpcmsgUHJhbmtlICA8ZHByYW5rZUBjaHJvbWl1bS5vcmc+CisKKyAg ICAgICAgUkVHUkVTU0lPTig5MDQxOSkgTlJXVCdzIGh0dHBkIGxvY2tpbmcgaXMgYnJva2VuIGZv ciAtLWNoaWxkLXByb2Nlc3Nlcz0xCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD02NDA5MgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIFRoZSBjb2RlIHdhcyBpbmNvcnJlY3RseSBjcmVhdGluZyBlbXB0eSBzaGFy ZHMgaW4gdGhlCisgICAgICAgIHNoYXJkX2luX3R3byBjYXNlLgorCisgICAgICAgICogU2NyaXB0 cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvY29udHJvbGxlcnMvbWFuYWdlci5weToKKyAgICAgICAg KiBTY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9jb250cm9sbGVycy9tYW5hZ2VyX3VuaXR0 ZXN0LnB5OgorCiAyMDExLTA3LTA3ICBBZGFtIFJvYmVuICA8YXJvYmVuQGFwcGxlLmNvbT4KIAog ICAgICAgICBNYWtlIENoZWNrb3V0IHVzZSBTQ00ncyBFeGVjdXRpdmUgaW5zdGVhZCBvZiBjb25q dXJpbmcgdXAgaXRzIG93bgpkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlv dXRfdGVzdHMvY29udHJvbGxlcnMvbWFuYWdlci5weSBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkv bGF5b3V0X3Rlc3RzL2NvbnRyb2xsZXJzL21hbmFnZXIucHkKaW5kZXggNjkxMzNhYjc0OTk2NzU1 YWMzMmYwZTI4MzQ0ZmIxYjU0YTBmMmFkOS4uYzcyN2MwMzgxYTkxYzVlOTI0M2Q1NzhhZWYyZjNl MGYyNGM4ZmJkNyAxMDA2NDQKLS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVz dHMvY29udHJvbGxlcnMvbWFuYWdlci5weQorKysgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xh eW91dF90ZXN0cy9jb250cm9sbGVycy9tYW5hZ2VyLnB5CkBAIC01NjksNyArNTY5LDE1IEBAIGNs YXNzIE1hbmFnZXIob2JqZWN0KToKICAgICAgICAgICAgICAgICBsb2NrZWRfaW5wdXRzLmFwcGVu ZCh0ZXN0X2lucHV0KQogICAgICAgICAgICAgZWxzZToKICAgICAgICAgICAgICAgICB1bmxvY2tl ZF9pbnB1dHMuYXBwZW5kKHRlc3RfaW5wdXQpCi0gICAgICAgIHJldHVybiBbVGVzdFNoYXJkKCds b2NrZWRfdGVzdHMnLCBsb2NrZWRfaW5wdXRzKV0sIFtUZXN0U2hhcmQoJ3VubG9ja2VkX3Rlc3Rz JywgdW5sb2NrZWRfaW5wdXRzKV0KKworICAgICAgICBsb2NrZWRfc2hhcmRzID0gW10KKyAgICAg ICAgdW5sb2NrZWRfc2hhcmRzID0gW10KKyAgICAgICAgaWYgbG9ja2VkX2lucHV0czoKKyAgICAg ICAgICAgIGxvY2tlZF9zaGFyZHMgPSBbVGVzdFNoYXJkKCdsb2NrZWRfdGVzdHMnLCBsb2NrZWRf aW5wdXRzKV0KKyAgICAgICAgaWYgdW5sb2NrZWRfaW5wdXRzOgorICAgICAgICAgICAgdW5sb2Nr ZWRfc2hhcmRzID0gW1Rlc3RTaGFyZCgndW5sb2NrZWRfdGVzdHMnLCB1bmxvY2tlZF9pbnB1dHMp XQorCisgICAgICAgIHJldHVybiBsb2NrZWRfc2hhcmRzLCB1bmxvY2tlZF9zaGFyZHMKIAogICAg IGRlZiBfc2hhcmRfZXZlcnlfZmlsZShzZWxmLCB0ZXN0X2ZpbGVzKToKICAgICAgICAgIiIiUmV0 dXJucyB0d28gbGlzdHMgb2Ygc2hhcmRzLCBlYWNoIHNoYXJkIGNvbnRhaW5pbmcgYSBzaW5nbGUg dGVzdCBmaWxlLgpkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVz dHMvY29udHJvbGxlcnMvbWFuYWdlcl91bml0dGVzdC5weSBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0 cHkvbGF5b3V0X3Rlc3RzL2NvbnRyb2xsZXJzL21hbmFnZXJfdW5pdHRlc3QucHkKaW5kZXggOTk3 ZGE1MzYxMjY1NmY4ZmM2MTY4NmZhN2I2YzhmYjRiYjU5MTA3OC4uYzFhMzFkMzFlYTZhODkxMDcx Njc3NjRjYzg2MmNhYTI3ODI2ZmEzMiAxMDA2NDQKLS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJraXRw eS9sYXlvdXRfdGVzdHMvY29udHJvbGxlcnMvbWFuYWdlcl91bml0dGVzdC5weQorKysgYi9Ub29s cy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9jb250cm9sbGVycy9tYW5hZ2VyX3VuaXR0 ZXN0LnB5CkBAIC02NywxMSArNjcsMTIgQEAgY2xhc3MgU2hhcmRpbmdUZXN0cyh1bml0dGVzdC5U ZXN0Q2FzZSk6CiAgICAgICAgICJkb20vaHRtbC9sZXZlbDIvaHRtbC9IVE1MQW5jaG9yRWxlbWVu dDA2Lmh0bWwiLAogICAgIF0KIAotICAgIGRlZiBnZXRfc2hhcmRzKHNlbGYsIG51bV93b3JrZXJz LCBmdWxseV9wYXJhbGxlbCk6CisgICAgZGVmIGdldF9zaGFyZHMoc2VsZiwgbnVtX3dvcmtlcnMs IGZ1bGx5X3BhcmFsbGVsLCB0ZXN0X2xpc3Q9Tm9uZSk6CisgICAgICAgIHRlc3RfbGlzdCA9IHRl c3RfbGlzdCBvciBzZWxmLnRlc3RfbGlzdAogICAgICAgICBwb3J0ID0gbGF5b3V0X3Rlc3RzLnBv cnQuZ2V0KHBvcnRfbmFtZT0ndGVzdCcpCiAgICAgICAgIHBvcnQuX2ZpbGVzeXN0ZW0gPSBmaWxl c3lzdGVtX21vY2suTW9ja0ZpbGVTeXN0ZW0oKQogICAgICAgICBzZWxmLm1hbmFnZXIgPSBNYW5h Z2VyV3JhcHBlcihwb3J0PXBvcnQsIG9wdGlvbnM9TW9jaygpLCBwcmludGVyPU1vY2soKSkKLSAg ICAgICAgcmV0dXJuIHNlbGYubWFuYWdlci5fc2hhcmRfdGVzdHMoc2VsZi50ZXN0X2xpc3QsIG51 bV93b3JrZXJzLCBmdWxseV9wYXJhbGxlbCkKKyAgICAgICAgcmV0dXJuIHNlbGYubWFuYWdlci5f c2hhcmRfdGVzdHModGVzdF9saXN0LCBudW1fd29ya2VycywgZnVsbHlfcGFyYWxsZWwpCiAKICAg ICBkZWYgdGVzdF9zaGFyZF9ieV9kaXIoc2VsZik6CiAgICAgICAgIGxvY2tlZCwgdW5sb2NrZWQg PSBzZWxmLmdldF9zaGFyZHMobnVtX3dvcmtlcnM9MiwgZnVsbHlfcGFyYWxsZWw9RmFsc2UpCkBA IC0xMjYsNiArMTI3LDE4IEBAIGNsYXNzIFNoYXJkaW5nVGVzdHModW5pdHRlc3QuVGVzdENhc2Up OgogICAgICAgICAgICAgICAgICAgICAgICAgJ2lldGVzdGNlbnRlci9KYXZhc2NyaXB0LzExLjEu NV80LTQtYy0xLmh0bWwnLAogICAgICAgICAgICAgICAgICAgICAgICAgJ2RvbS9odG1sL2xldmVs Mi9odG1sL0hUTUxBbmNob3JFbGVtZW50MDYuaHRtbCddKV0pCiAKKyAgICBkZWYgdGVzdF9zaGFy ZF9pbl90d29faGFzX25vX2xvY2tlZF9zaGFyZHMoc2VsZik6CisgICAgICAgIGxvY2tlZCwgdW5s b2NrZWQgPSBzZWxmLmdldF9zaGFyZHMobnVtX3dvcmtlcnM9MSwgZnVsbHlfcGFyYWxsZWw9RmFs c2UsCisgICAgICAgICAgICAgdGVzdF9saXN0PVsnYW5pbWF0aW9ucy9rZXlmcmFtZS5odG1sJ10p CisgICAgICAgIHNlbGYuYXNzZXJ0RXF1YWxzKGxlbihsb2NrZWQpLCAwKQorICAgICAgICBzZWxm LmFzc2VydEVxdWFscyhsZW4odW5sb2NrZWQpLCAxKQorCisgICAgZGVmIHRlc3Rfc2hhcmRfaW5f dHdvX2hhc19ub191bmxvY2tlZF9zaGFyZHMoc2VsZik6CisgICAgICAgIGxvY2tlZCwgdW5sb2Nr ZWQgPSBzZWxmLmdldF9zaGFyZHMobnVtX3dvcmtlcnM9MSwgZnVsbHlfcGFyYWxsZWw9RmFsc2Us CisgICAgICAgICAgICAgdGVzdF9saXN0PVsnaHR0cC90ZXN0cy93ZWJjb2tldC90ZXN0cy91bmlj b2RlLmh0bSddKQorICAgICAgICBzZWxmLmFzc2VydEVxdWFscyhsZW4obG9ja2VkKSwgMSkKKyAg ICAgICAgc2VsZi5hc3NlcnRFcXVhbHMobGVuKHVubG9ja2VkKSwgMCkKKwogCiBjbGFzcyBNYW5h Z2VyVGVzdCh1bml0dGVzdC5UZXN0Q2FzZSk6CiAgICAgZGVmIHRlc3RfaHR0cF9sb2NraW5nKHRl c3Rlcik6Cg==