<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>64071</bug_id>
          
          <creation_ts>2011-07-07 01:02:07 -0700</creation_ts>
          <short_desc>new-run-webkit-tests does not support qt-4.8 results</short_desc>
          <delta_ts>2011-10-14 07:11:22 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Tools / Tests</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          <dependson>69944</dependson>
          <blocked>34984</blocked>
          <everconfirmed>1</everconfirmed>
          <reporter name="Eric Seidel (no email)">eric</reporter>
          <assigned_to name="Kristóf Kosztyó">kkristof</assigned_to>
          <cc>abarth</cc>
    
    <cc>abecsi</cc>
    
    <cc>kbalazs</cc>
    
    <cc>kkristof</cc>
    
    <cc>kling</cc>
    
    <cc>ossy</cc>
    
    <cc>rgabor</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>433336</commentid>
    <comment_count>0</comment_count>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2011-07-07 01:02:07 -0700</bug_when>
    <thetext>new-run-webkit-tests does not support qt-arm or qt-4.8 results

We&apos;ve not added support yet.  It&apos;s not clear if these results are even in use.  I don&apos;t see any bots on build.webkit.org

It&apos;s unclear if &quot;arm&quot; is both the architecture and the OS here?  Should that really be qt-linux-arm?

And what about qt-4.8?  Is that qt-4.8-linux?  Or do those results match on all platforms with 4.8?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>433343</commentid>
    <comment_count>1</comment_count>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2011-07-07 01:23:29 -0700</bug_when>
    <thetext>I believe the fallback orders in ORWT are:

qt-arm, qt
qt-4.8, qt

But I suspect those aren&apos;t really right.

From my investigation it appears that the qt-mac results aren&apos;t really used either.  They&apos;re certainly very out of date.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>434541</commentid>
    <comment_count>2</comment_count>
    <who name="Csaba Osztrogonác">ossy</who>
    <bug_when>2011-07-10 00:12:57 -0700</bug_when>
    <thetext>(In reply to comment #1)
&gt; I believe the fallback orders in ORWT are:
&gt; 
&gt; qt-arm, qt
&gt; qt-4.8, qt
&gt; 
&gt; But I suspect those aren&apos;t really right.
&gt; 
&gt; From my investigation it appears that the qt-mac results aren&apos;t really used either.  They&apos;re certainly very out of date.

Now qt, qt-arm, qt-4.8 and qt-mac platforms are used by buildbots run 
on http://build.webkit.sed.hu/waterfall . qt-linux and qt-win platforms
aren&apos;t really used.

The reference OS for Qt port is Linux, so all qt-* platforms should
fallback to qt platform. qt-4.8 is for development, result must be
same as on qt (4.7) platform when Qt-4.8 is released. AFAIK theses
bugs are fixed in Qt trunk, but I&apos;m going to check it in 1-2 days.

On qt-mac platform we only use Skipped list now, because we haven&apos;t
human resource to maintain expected files day by day. We always add
failing tests to this skipped list with changeset number.

I think making NRWT work with these platforms isn&apos;t priority for us now,
because there are major problems with NRWT for Qt port now. But Szeged team 
will fix this bug later.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>434554</commentid>
    <comment_count>3</comment_count>
    <who name="Balazs Kelemen">kbalazs</who>
    <bug_when>2011-07-10 07:48:44 -0700</bug_when>
    <thetext>&gt; I think making NRWT work with these platforms isn&apos;t priority for us now,
&gt; because there are major problems with NRWT for Qt port now. But Szeged team 
&gt; will fix this bug later.

What are those major problems exactly? I think it is a priority for us to use the test infrastructure that has become the official one for the WebKit project.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>434896</commentid>
    <comment_count>4</comment_count>
    <who name="Csaba Osztrogonác">ossy</who>
    <bug_when>2011-07-11 08:38:09 -0700</bug_when>
    <thetext>I disabled NRWT for qt-arm and qt-4.8 platforms until fix:
http://trac.webkit.org/changeset/90746

Gábor started working on this bug.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>435847</commentid>
    <comment_count>5</comment_count>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2011-07-12 12:16:38 -0700</bug_when>
    <thetext>It&apos;s easy to support these two platforms.  But it would make the logic for generating these names cleaner if the platform directories were renamed to include the OS, so:

qt-4.8-linux
qt-linux-arm

Which fit a more easy generated pattern of:

PORT-VERSION-OS
and
PORT-OS-ARCH

Where both OS and ARCH are optional.

In either case it doesn&apos;t matter much, but we&apos;ll need to special case the fallback.

chromium-linux-x86 definitely follows the PORT-OS-ARCH pattern, I don&apos;t really see any other ports which have a VERSION for their port, but not their OS.  (mac-leopard, win-xp are 2 of many examples of using OSVERSION in the names).

This is all part of our continuing effort to simplify our fallback rules.  qt-4.8 and qt-arm didn&apos;t easily fit any existing fallback rules, so I didn&apos;t add support for them in the first-pass implementation of the QtPort for NRWT.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>435849</commentid>
    <comment_count>6</comment_count>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2011-07-12 12:17:09 -0700</bug_when>
    <thetext>(In reply to comment #2)
&gt; Now qt, qt-arm, qt-4.8 and qt-mac platforms are used by buildbots run 
&gt; on http://build.webkit.sed.hu/waterfall . qt-linux and qt-win platforms
&gt; aren&apos;t really used.

Can we delete qt-linux and qt-win then?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>435852</commentid>
    <comment_count>7</comment_count>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2011-07-12 12:19:27 -0700</bug_when>
    <thetext>(In reply to comment #2)
&gt; The reference OS for Qt port is Linux, so all qt-* platforms should
&gt; fallback to qt platform. qt-4.8 is for development, result must be
&gt; same as on qt (4.7) platform when Qt-4.8 is released. AFAIK theses
&gt; bugs are fixed in Qt trunk, but I&apos;m going to check it in 1-2 days.

The Apple folks have historically used &quot;mac&quot; to mean the &quot;Development version&quot; and specific numbered versions for older versions.

I think Qt should consider doing similar (which means that some of the 4.8 results should move into qt/ and some of the 4.7-specific results in qt/ should move up into a qt-4.7.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>463386</commentid>
    <comment_count>8</comment_count>
    <who name="Csaba Osztrogonác">ossy</who>
    <bug_when>2011-09-07 09:41:33 -0700</bug_when>
    <thetext>Now the baseline search path on qt-wk platform: qt-wk2 -&gt; qt-linux -&gt; qt -&gt; generic

It should be: qt-wk2 -&gt; ((qt-linux -&gt;)) qt-4.8 -&gt; qt -&gt; generic

If it is fixed, we can enable ~400 tests on qt-wk2 platform.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>463387</commentid>
    <comment_count>9</comment_count>
    <who name="Csaba Osztrogonác">ossy</who>
    <bug_when>2011-09-07 09:42:23 -0700</bug_when>
    <thetext>(In reply to comment #6)
&gt; Can we delete qt-linux and qt-win then?

Not yet, they might be used in the future.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>463390</commentid>
    <comment_count>10</comment_count>
    <who name="Csaba Osztrogonác">ossy</who>
    <bug_when>2011-09-07 09:45:12 -0700</bug_when>
    <thetext>(In reply to comment #7)
&gt; (In reply to comment #2)
&gt; &gt; The reference OS for Qt port is Linux, so all qt-* platforms should
&gt; &gt; fallback to qt platform. qt-4.8 is for development, result must be
&gt; &gt; same as on qt (4.7) platform when Qt-4.8 is released. AFAIK theses
&gt; &gt; bugs are fixed in Qt trunk, but I&apos;m going to check it in 1-2 days.
&gt; 
&gt; The Apple folks have historically used &quot;mac&quot; to mean the &quot;Development version&quot; and specific numbered versions for older versions.
&gt; 
&gt; I think Qt should consider doing similar (which means that some of the 4.8 results should move into qt/ and some of the 4.7-specific results in qt/ should move up into a qt-4.7.

Now the Qt 4.7 is the default, and 4.8 exceptions are stored in qt-4.8. But after 4.8 is released we will merge qt-4.8 to qt and after then we can remove qt-4.8 platform. (Because qt will means Qt 4.8 and 4.7 won&apos;t be supported anymore.)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>463394</commentid>
    <comment_count>11</comment_count>
    <who name="Csaba Osztrogonác">ossy</who>
    <bug_when>2011-09-07 09:48:25 -0700</bug_when>
    <thetext>(In reply to comment #8)
&gt; Now the baseline search path on qt-wk platform: qt-wk2 -&gt; qt-linux -&gt; qt -&gt; generic
&gt; 
&gt; It should be: qt-wk2 -&gt; ((qt-linux -&gt;)) qt-4.8 -&gt; qt -&gt; generic
&gt; 
&gt; If it is fixed, we can enable ~400 tests on qt-wk2 platform.

I forgot to mention why we need this search path: Because to build WebKit2, the minimum Qt version is 5.0 (which based on 4.8).</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>463489</commentid>
    <comment_count>12</comment_count>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2011-09-07 11:30:05 -0700</bug_when>
    <thetext>It sounds like your troubles could very easily be fixed by moving qt-4.8 to qt and qt to qt-4.7, right?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>463492</commentid>
    <comment_count>13</comment_count>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2011-09-07 11:31:21 -0700</bug_when>
    <thetext>The reason why I propose moving instead of hacking the tool is that there are long-term benefits to every project using similar fallback systems.

We would still need to add 4.7 as an explicit version number (I think), but otherwise NRWT should just work &quot;out of the box&quot; including getting the wk2 fallback path correctly then, right?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>464005</commentid>
    <comment_count>14</comment_count>
    <who name="Csaba Osztrogonác">ossy</who>
    <bug_when>2011-09-08 06:02:50 -0700</bug_when>
    <thetext>(In reply to comment #13)
&gt; We would still need to add 4.7 as an explicit version number (I think), but otherwise NRWT should just work &quot;out of the box&quot; including getting the wk2 fallback path correctly then, right?

Do you mean we should add a qt-4.7 platform too?
And then the search paths would be in general: 
qt-wk2|none -&gt; qt-(linux|win|mac) -&gt; qt-(4.7|4.8) -&gt; generic

examples:
qt-wk2 -&gt; qt-linux -&gt; qt-4.8 -&gt; qt -&gt; generic
          qt-linux -&gt; qt-4.8 -&gt; qt -&gt; generic
          qt-linux -&gt; qt-4.7 -&gt; qt -&gt; generic

It sounds good to me. Now wk2 won&apos;t depends on Qt version. (You can&apos;t build it with Qt 4.7, only Qt 5.0, so version will be qt-48 always, because qt-4.7 == Qt-4.7.x and qt-4.8 == Qt-4.8.x or newer)

We only need to add a Qt version checker function similar to in webkitdirs.pm:
sub getQtVersion()
{
    my $qtVersion = `$qmakebin --version`;
    $qtVersion =~ s/^(.*)Qt version (\d\.\d)(.*)/$2/s ;
    return $qtVersion;
}</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>464009</commentid>
    <comment_count>15</comment_count>
    <who name="Csaba Osztrogonác">ossy</who>
    <bug_when>2011-09-08 06:05:08 -0700</bug_when>
    <thetext>Removing qt-arm, and filed a new bug report about it: https://bugs.webkit.org/show_bug.cgi?id=67777</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>464051</commentid>
    <comment_count>16</comment_count>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2011-09-08 08:04:06 -0700</bug_when>
    <thetext>(In reply to comment #14)
&gt; (In reply to comment #13)
&gt; &gt; We would still need to add 4.7 as an explicit version number (I think), but otherwise NRWT should just work &quot;out of the box&quot; including getting the wk2 fallback path correctly then, right?
&gt; 
&gt; Do you mean we should add a qt-4.7 platform too?
&gt; And then the search paths would be in general: 
&gt; qt-wk2|none -&gt; qt-(linux|win|mac) -&gt; qt-(4.7|4.8) -&gt; generic
&gt; 
&gt; examples:
&gt; qt-wk2 -&gt; qt-linux -&gt; qt-4.8 -&gt; qt -&gt; generic
&gt;           qt-linux -&gt; qt-4.8 -&gt; qt -&gt; generic
&gt;           qt-linux -&gt; qt-4.7 -&gt; qt -&gt; generic

No, in order to match the other WebKit ports, the search paths would need to be:

qt-wk2 -&gt; qt -&gt; qt-4.8 -&gt; qt-4.7 -&gt; generic

That matches mac/win:
mac-wk2 -&gt; mac -&gt; mac-lion -&gt; mac-snow-leopard -&gt; mac-leopard -&gt; generic
win-wk2 -&gt; win -&gt; win-win7sp0 -&gt; win-xp -&gt; generic

I&apos;m not sure where qt-linux vs. qt-mac, etc. falls in.  We should look at how Chromium does their fallback.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>464053</commentid>
    <comment_count>17</comment_count>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2011-09-08 08:08:10 -0700</bug_when>
    <thetext>(In reply to comment #16)
&gt; (In reply to comment #14)
&gt; &gt; (In reply to comment #13)
&gt; &gt; &gt; We would still need to add 4.7 as an explicit version number (I think), but otherwise NRWT should just work &quot;out of the box&quot; including getting the wk2 fallback path correctly then, right?
&gt; &gt; 
&gt; &gt; Do you mean we should add a qt-4.7 platform too?
&gt; &gt; And then the search paths would be in general: 
&gt; &gt; qt-wk2|none -&gt; qt-(linux|win|mac) -&gt; qt-(4.7|4.8) -&gt; generic
&gt; &gt; 
&gt; &gt; examples:
&gt; &gt; qt-wk2 -&gt; qt-linux -&gt; qt-4.8 -&gt; qt -&gt; generic
&gt; &gt;           qt-linux -&gt; qt-4.8 -&gt; qt -&gt; generic
&gt; &gt;           qt-linux -&gt; qt-4.7 -&gt; qt -&gt; generic
&gt; 
&gt; No, in order to match the other WebKit ports, the search paths would need to be:
&gt; 
&gt; qt-wk2 -&gt; qt -&gt; qt-4.8 -&gt; qt-4.7 -&gt; generic
&gt; 
&gt; That matches mac/win:
&gt; mac-wk2 -&gt; mac -&gt; mac-lion -&gt; mac-snow-leopard -&gt; mac-leopard -&gt; generic
&gt; win-wk2 -&gt; win -&gt; win-win7sp0 -&gt; win-xp -&gt; generic
&gt; 
&gt; I&apos;m not sure where qt-linux vs. qt-mac, etc. falls in.  We should look at how Chromium does their fallback.

Sorry, my comment was just wrong.  I guess I should wake up more before commenting on bugs.

Mac/Win work like this:
http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/layout_tests/port/mac_unittest.py#L128
http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/layout_tests/port/win_unittest.py#L78

aka:

mac-wk2 -&gt; mac-lion -&gt; mac-snow-leopard ... -&gt; mac

which is closer to what you said than what I said, with the exception of where you placed qt-4.7</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>473736</commentid>
    <comment_count>18</comment_count>
      <attachid>108797</attachid>
    <who name="Kristóf Kosztyó">kkristof</who>
    <bug_when>2011-09-27 00:26:05 -0700</bug_when>
    <thetext>Created attachment 108797
proposed fix</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>473741</commentid>
    <comment_count>19</comment_count>
      <attachid>108797</attachid>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2011-09-27 00:30:50 -0700</bug_when>
    <thetext>Comment on attachment 108797
proposed fix

View in context: https://bugs.webkit.org/attachment.cgi?id=108797&amp;action=review

It&apos;s not immediately clear what the fallback path looks like here.  But it seems that 4.8 results should fallback on 4.7 results, or vice versa, similar to how Mac/Win work.

&gt; Tools/Scripts/webkitpy/layout_tests/port/qt.py:93
&gt; +    def get_qt_version(self):

I might instead make this qt_version(self) and have it be @memoized.  We don&apos;t usually use &quot;get&quot; in function names in WebKit.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>473745</commentid>
    <comment_count>20</comment_count>
      <attachid>108797</attachid>
    <who name="Csaba Osztrogonác">ossy</who>
    <bug_when>2011-09-27 00:34:58 -0700</bug_when>
    <thetext>Comment on attachment 108797
proposed fix

r- now, because you missed to add the unit test change.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>473748</commentid>
    <comment_count>21</comment_count>
    <who name="Csaba Osztrogonác">ossy</who>
    <bug_when>2011-09-27 00:37:51 -0700</bug_when>
    <thetext>(In reply to comment #19)
&gt; (From update of attachment 108797 [details])
&gt; View in context: https://bugs.webkit.org/attachment.cgi?id=108797&amp;action=review
&gt; 
&gt; It&apos;s not immediately clear what the fallback path looks like here.  But it seems that 4.8 results should fallback on 4.7 results, or vice versa, similar to how Mac/Win work.

Absolutely no. qt-4.8 shouldn&apos;t fallback to qt-4.7 or vice versa. qt-4.7 and qt-4.8 should fallback to qt and then generic. qt-4.7 and qt-4.8 doesn&apos;t depends on each other. There are failing tests on qt-4.7 which pass on qt-4.8 and vice-versa.

 
&gt; &gt; Tools/Scripts/webkitpy/layout_tests/port/qt.py:93
&gt; &gt; +    def get_qt_version(self):
&gt; 
&gt; I might instead make this qt_version(self) and have it be @memoized.  We don&apos;t usually use &quot;get&quot; in function names in WebKit.

Good point.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>473971</commentid>
    <comment_count>22</comment_count>
    <who name="Adam Barth">abarth</who>
    <bug_when>2011-09-27 09:14:10 -0700</bug_when>
    <thetext>You&apos;re welcome to have whatever fallback path you like, but the common way we do fallbacks in WebKit is to have older versions fall back to newer versions.  For example, Leopard falls back to Snow Leopard, which falls back to Lion.  Here&apos;s a diagram I drew a while back:

https://docs.google.com/drawings/d/1z65SKkWrD4Slm6jobIphHwwRADyUtjOAxwGBVKBY8Kc/edit?hl=en_US

I agree that it sounds goofy, but it seems to work pretty well.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>474680</commentid>
    <comment_count>23</comment_count>
      <attachid>109006</attachid>
    <who name="Kristóf Kosztyó">kkristof</who>
    <bug_when>2011-09-28 05:08:10 -0700</bug_when>
    <thetext>Created attachment 109006
proposed fix</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>478406</commentid>
    <comment_count>24</comment_count>
      <attachid>109006</attachid>
    <who name="Csaba Osztrogonác">ossy</who>
    <bug_when>2011-10-05 09:06:09 -0700</bug_when>
    <thetext>Comment on attachment 109006
proposed fix

View in context: https://bugs.webkit.org/attachment.cgi?id=109006&amp;action=review

The development of Qt was faster than this patch&apos;s. :) So please update the patch. 

Now qt-wk2 should fallback to a new qt-5.0 platform. ( After Qt 4.8 will be releases,
we are going to stop supporting qt-4.7 test results and then we&apos;re going to merge
qt-4.8 results to general qt platform. But it is a mid-term plan.) Otherwise the patch LGTM.

Is there any objection against landing the fixed patch?

&gt; Tools/Scripts/webkitpy/layout_tests/port/qt.py:33
&gt;  import logging
&gt;  import sys
&gt; +import re

style: alphabetic order

&gt; Tools/Scripts/webkitpy/layout_tests/port/qt.py:111
&gt; +        if &apos;4.7&apos; in version:
&gt; +            search_paths.append(&apos;qt-4.7&apos;)
&gt; +        elif version:
&gt; +            search_paths.append(&apos;qt-4.8&apos;)

if &apos;4.7&apos; in version:
    search_paths.append(&apos;qt-4.7&apos;)
elif &apos;4.8&apos; in version:
    search_paths.append(&apos;qt-4.8&apos;)
elif version:
    search_paths.append(&apos;qt-5.0&apos;)

&gt; Tools/Scripts/webkitpy/layout_tests/port/qt_unittest.py:36
&gt;  from webkitpy.layout_tests.port.qt import QtPort
&gt;  from webkitpy.layout_tests.port import port_testcase
&gt;  from webkitpy.tool.mocktool import MockOptions, MockUser, MockExecutive
&gt; +from webkitpy.common.system.executive_mock import MockExecutive2

style: alphabetic order

&gt; Tools/Scripts/webkitpy/layout_tests/port/qt_unittest.py:59
&gt; +            return &apos;QMake version 2.01a\nUsing Qt version 4.8.2 in /usr/local/Trolltech/Qt-4.8.2/lib&apos;

nit: s/4.8.2/4.8.0/g

&gt; Tools/Scripts/webkitpy/layout_tests/port/qt_unittest.py:78
&gt; +        self._assert_search_path([&apos;qt-wk2&apos;, &apos;qt-mac&apos;, &apos;qt-4.8&apos;, &apos;qt&apos;], &apos;darwin&apos;, use_webkit2=True, qt_version=&apos;5.0&apos;)
&gt; +        self._assert_search_path([&apos;qt-wk2&apos;, &apos;qt-win&apos;, &apos;qt-4.8&apos;, &apos;qt&apos;], &apos;cygwin&apos;, use_webkit2=True, qt_version=&apos;5.0&apos;)
&gt; +        self._assert_search_path([&apos;qt-wk2&apos;, &apos;qt-linux&apos;, &apos;qt-4.8&apos;, &apos;qt&apos;], &apos;linux2&apos;, use_webkit2=True, qt_version=&apos;5.0&apos;)

s/qt-4.8/qt-5.0/g</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>479091</commentid>
    <comment_count>25</comment_count>
      <attachid>109951</attachid>
    <who name="Kristóf Kosztyó">kkristof</who>
    <bug_when>2011-10-06 05:47:28 -0700</bug_when>
    <thetext>Created attachment 109951
updated fallback path</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>479119</commentid>
    <comment_count>26</comment_count>
      <attachid>109951</attachid>
    <who name="Csaba Osztrogonác">ossy</who>
    <bug_when>2011-10-06 06:25:58 -0700</bug_when>
    <thetext>Comment on attachment 109951
updated fallback path

View in context: https://bugs.webkit.org/attachment.cgi?id=109951&amp;action=review

In general LGTM, but please fix these little things.

&gt; Tools/ChangeLog:9
&gt; +        * Scripts/webkitpy/layout_tests/port/qt_unittest.py: Removed.

Removed ????

&gt; Tools/Scripts/webkitpy/layout_tests/port/qt.py:93
&gt; +    def qt_version(self):

@memoized is still missing

&gt; Tools/Scripts/webkitpy/layout_tests/port/qt_unittest.py:59
&gt; +            return &apos;QMake version 2.01a\nUsing Qt version 4.8.0 in /usr/local/Trolltech/Qt-4.8.2/lib&apos;

one more s/4.8.2/4.8.0 :)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>479144</commentid>
    <comment_count>27</comment_count>
    <who name="Kristóf Kosztyó">kkristof</who>
    <bug_when>2011-10-06 07:16:06 -0700</bug_when>
    <thetext>(In reply to comment #26)
&gt; (From update of attachment 109951 [details])
&gt; View in context: https://bugs.webkit.org/attachment.cgi?id=109951&amp;action=review
&gt; 
&gt; In general LGTM, but please fix these little things.
&gt; 
&gt; &gt; Tools/ChangeLog:9
&gt; &gt; +        * Scripts/webkitpy/layout_tests/port/qt_unittest.py: Removed.
&gt; 
&gt; Removed ????
&gt; 

Uups, I had a little problem with the git.
One moment, and I will fix it.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>479146</commentid>
    <comment_count>28</comment_count>
      <attachid>109960</attachid>
    <who name="Kristóf Kosztyó">kkristof</who>
    <bug_when>2011-10-06 07:25:51 -0700</bug_when>
    <thetext>Created attachment 109960
proposed fix</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>479225</commentid>
    <comment_count>29</comment_count>
      <attachid>109960</attachid>
    <who name="Csaba Osztrogonác">ossy</who>
    <bug_when>2011-10-06 09:49:53 -0700</bug_when>
    <thetext>Comment on attachment 109960
proposed fix

View in context: https://bugs.webkit.org/attachment.cgi?id=109960&amp;action=review

I tested your patch, but I found one more thing. Skipped 
file in qt-&lt;version&gt; directory is ignored, but we need it.

Could you override _skipped_file_search_paths too?

&gt; Tools/Scripts/webkitpy/layout_tests/port/qt.py:93
&gt; +    def qt_version(self):

@memoized is still missing :-/</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>479966</commentid>
    <comment_count>30</comment_count>
      <attachid>110135</attachid>
    <who name="Kristóf Kosztyó">kkristof</who>
    <bug_when>2011-10-07 06:39:36 -0700</bug_when>
    <thetext>Created attachment 110135
proposed fix

I created also the Skipped files for qt-4.7 and qt-5.0</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>482345</commentid>
    <comment_count>31</comment_count>
      <attachid>110135</attachid>
    <who name="Csaba Osztrogonác">ossy</who>
    <bug_when>2011-10-12 04:25:11 -0700</bug_when>
    <thetext>Comment on attachment 110135
proposed fix

r=me</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>482348</commentid>
    <comment_count>32</comment_count>
      <attachid>110135</attachid>
    <who name="Csaba Osztrogonác">ossy</who>
    <bug_when>2011-10-12 04:27:33 -0700</bug_when>
    <thetext>Comment on attachment 110135
proposed fix

Landed in http://trac.webkit.org/changeset/97252</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>482536</commentid>
    <comment_count>33</comment_count>
    <who name="Adam Barth">abarth</who>
    <bug_when>2011-10-12 11:07:50 -0700</bug_when>
    <thetext>http://build.webkit.org/builders/SnowLeopard%20Intel%20Debug%20%28Tests%29/builds/2541/steps/webkitpy-test/logs/stdio

You can&apos;t call out to qmake when determining the baseline paths:

    for line in self._executive.run_command([&apos;qmake&apos;, &apos;-v&apos;]).split(&apos;\n&apos;):

We need to be able to determine the baseline paths on all systems, even those without qmake.  Mac and Win also need to solve this problem.  It&apos;s probably a good idea to follow their approach.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>482682</commentid>
    <comment_count>34</comment_count>
    <who name="Csaba Osztrogonác">ossy</who>
    <bug_when>2011-10-12 14:05:05 -0700</bug_when>
    <thetext>We can&apos;t determine baseline path without calling qmake ... :((</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>482692</commentid>
    <comment_count>35</comment_count>
    <who name="Adam Barth">abarth</who>
    <bug_when>2011-10-12 14:14:42 -0700</bug_when>
    <thetext>&gt; We can&apos;t determine baseline path without calling qmake ... :((

Can you explain why in more detail?  I understand that you might not be able to determine which baseline path you&apos;d like to use without calling qmake (or otherwise inspecting the environment), but you should be able to determine the universe of possible baseline paths without reading any information from the environment.

Put another way, we have a requirement that you can enumerate the universe of baseline paths for all ports when running on any platform.  For example, on a Mac without qmake installed, you should be able to know where the Qt port stores its baselines and what the fallback behavior is between them.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>483966</commentid>
    <comment_count>36</comment_count>
    <who name="Csaba Osztrogonác">ossy</who>
    <bug_when>2011-10-14 07:11:22 -0700</bug_when>
    <thetext>Fixed patch landed in http://trac.webkit.org/changeset/97461.
It wasn&apos;t the best solution, but this patch was very important for us.

I filed a new bug to fix Qt port for baselineoptimizer: https://bugs.webkit.org/show_bug.cgi?id=70108</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>108797</attachid>
            <date>2011-09-27 00:26:05 -0700</date>
            <delta_ts>2011-09-28 05:08:10 -0700</delta_ts>
            <desc>proposed fix</desc>
            <filename>27.patch</filename>
            <type>text/plain</type>
            <size>1883</size>
            <attacher name="Kristóf Kosztyó">kkristof</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCAxMzU3
ZmQwLi44ZjNjZmE2IDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh
bmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTEtMDktMjcgIEtyaXN0w7NmIEtvc3p0ecOzICA8
a2tyaXN0b2ZAaW5mLnUtc3plZ2VkLmh1PgorCisgICAgICAgIG5ldy1ydW4td2Via2l0LXRlc3Rz
IGRvZXMgbm90IHN1cHBvcnQgcXQtNC44IHJlc3VsdHMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl
YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTY0MDcxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C
T0RZIChPT1BTISkuCisKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9w
b3J0L3F0LnB5OgorCiAyMDExLTA5LTI2ICBDc2FiYSBPc3p0cm9nb27DoWMgIDxvc3N5QHdlYmtp
dC5vcmc+CiAKICAgICAgICAgW1F0XVtXSzJdIE9uZSBtb3JlIHVucmV2aWV3ZWQgYnVpbGRmaXgg
YWZ0ZXIgcjk2MDA1LgpkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRf
dGVzdHMvcG9ydC9xdC5weSBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3Bv
cnQvcXQucHkKaW5kZXggZTVmNWY4NC4uZjcyMTQ1NyAxMDA2NDQKLS0tIGEvVG9vbHMvU2NyaXB0
cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC9xdC5weQorKysgYi9Ub29scy9TY3JpcHRzL3dl
YmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L3F0LnB5CkBAIC0zMCw2ICszMCw3IEBACiAKIGltcG9y
dCBsb2dnaW5nCiBpbXBvcnQgc3lzCitpbXBvcnQgcmUKIAogaW1wb3J0IHdlYmtpdAogCkBAIC04
OSw2ICs5MCwyOCBAQCBjbGFzcyBRdFBvcnQoV2ViS2l0UG9ydCk6CiAgICAgZGVmIF9wYXRoX3Rv
X3dlYmNvcmVfbGlicmFyeShzZWxmKToKICAgICAgICAgcmV0dXJuIHNlbGYuX2J1aWxkX3BhdGgo
J2xpYi9saWJRdFdlYktpdC5zbycpCiAKKyAgICBkZWYgZ2V0X3F0X3ZlcnNpb24oc2VsZik6Cisg
ICAgICAgIHZlcnNpb24gPSAnJworICAgICAgICBmb3IgbGluZSBpbiBzZWxmLl9leGVjdXRpdmUu
cnVuX2NvbW1hbmQoWydxbWFrZScsICctdiddKS5zcGxpdCgnXG4nKToKKyAgICAgICAgICAgIG1h
dGNoID0gcmUuc2VhcmNoKCdRdFxzdmVyc2lvblxzKD9QPHZlcnNpb24+XGRcLlxkKScsIGxpbmUp
CisgICAgICAgICAgICBpZiBtYXRjaDoKKyAgICAgICAgICAgICAgICB2ZXJzaW9uID0gbWF0Y2gu
Z3JvdXAoJ3ZlcnNpb24nKQorICAgICAgICAgICAgICAgIGJyZWFrCisgICAgICAgIHJldHVybiB2
ZXJzaW9uCisKKyAgICBkZWYgYmFzZWxpbmVfc2VhcmNoX3BhdGgoc2VsZik6CisgICAgICAgIHNl
YXJjaF9wYXRocyA9IFtdCisgICAgICAgIGlmIHNlbGYuZ2V0X29wdGlvbignd2Via2l0X3Rlc3Rf
cnVubmVyJyk6CisgICAgICAgICAgICBzZWFyY2hfcGF0aHMuYXBwZW5kKHNlbGYuX3drMl9wb3J0
X25hbWUoKSkKKyAgICAgICAgc2VhcmNoX3BhdGhzLmFwcGVuZChzZWxmLm5hbWUoKSkKKyAgICAg
ICAgdmVyc2lvbiA9IHNlbGYuZ2V0X3F0X3ZlcnNpb24oKQorICAgICAgICBpZiAnNC43JyBpbiB2
ZXJzaW9uOgorICAgICAgICAgICAgc2VhcmNoX3BhdGhzLmFwcGVuZCgncXQtNC43JykKKyAgICAg
ICAgZWxpZiB2ZXJzaW9uOgorICAgICAgICAgICAgc2VhcmNoX3BhdGhzLmFwcGVuZCgncXQtNC44
JykKKyAgICAgICAgc2VhcmNoX3BhdGhzLmFwcGVuZChzZWxmLnBvcnRfbmFtZSkKKyAgICAgICAg
cmV0dXJuIG1hcChzZWxmLl93ZWJraXRfYmFzZWxpbmVfcGF0aCwgc2VhcmNoX3BhdGhzKQorCiAg
ICAgZGVmIF9ydW50aW1lX2ZlYXR1cmVfbGlzdChzZWxmKToKICAgICAgICAgcmV0dXJuIE5vbmUK
IAo=
</data>
<flag name="review"
          id="105850"
          type_id="1"
          status="-"
          setter="ossy"
    />
    <flag name="commit-queue"
          id="105851"
          type_id="3"
          status="-"
          setter="ossy"
    />
          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>109006</attachid>
            <date>2011-09-28 05:08:10 -0700</date>
            <delta_ts>2011-10-06 05:47:28 -0700</delta_ts>
            <desc>proposed fix</desc>
            <filename>28.patch</filename>
            <type>text/plain</type>
            <size>5852</size>
            <attacher name="Kristóf Kosztyó">kkristof</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCA4NDVh
YzRlLi5mMmU4ZjUzIDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh
bmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTEtMDktMjggIEtyaXN0w7NmIEtvc3p0ecOzICA8
a2tyaXN0b2ZAaW5mLnUtc3plZ2VkLmh1PgorCisgICAgICAgIG5ldy1ydW4td2Via2l0LXRlc3Rz
IGRvZXMgbm90IHN1cHBvcnQgcXQtNC44IHJlc3VsdHMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl
YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTY0MDcxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C
T0RZIChPT1BTISkuCisKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9w
b3J0L3F0LnB5OgorICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQv
cXRfdW5pdHRlc3QucHk6CisKIDIwMTEtMDktMjggIFBoaWxpcHBlIE5vcm1hbmQgIDxwbm9ybWFu
ZEBpZ2FsaWEuY29tPgogCiAgICAgICAgIFtHVEtdIG1pc3NpbmcgV2ViS2l0MiBzdXBwb3J0IGlu
IHJ1bi1ndGstdGVzdHMKZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0
X3Rlc3RzL3BvcnQvcXQucHkgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9w
b3J0L3F0LnB5CmluZGV4IGU1ZjVmODQuLjI5MzI0MmYgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1Njcmlw
dHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQvcXQucHkKKysrIGIvVG9vbHMvU2NyaXB0cy93
ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC9xdC5weQpAQCAtMzAsNiArMzAsNyBAQAogCiBpbXBv
cnQgbG9nZ2luZwogaW1wb3J0IHN5cworaW1wb3J0IHJlCiAKIGltcG9ydCB3ZWJraXQKIApAQCAt
ODksNiArOTAsMjggQEAgY2xhc3MgUXRQb3J0KFdlYktpdFBvcnQpOgogICAgIGRlZiBfcGF0aF90
b193ZWJjb3JlX2xpYnJhcnkoc2VsZik6CiAgICAgICAgIHJldHVybiBzZWxmLl9idWlsZF9wYXRo
KCdsaWIvbGliUXRXZWJLaXQuc28nKQogCisgICAgZGVmIHF0X3ZlcnNpb24oc2VsZik6CisgICAg
ICAgIHZlcnNpb24gPSAnJworICAgICAgICBmb3IgbGluZSBpbiBzZWxmLl9leGVjdXRpdmUucnVu
X2NvbW1hbmQoWydxbWFrZScsICctdiddKS5zcGxpdCgnXG4nKToKKyAgICAgICAgICAgIG1hdGNo
ID0gcmUuc2VhcmNoKCdRdFxzdmVyc2lvblxzKD9QPHZlcnNpb24+XGRcLlxkKScsIGxpbmUpCisg
ICAgICAgICAgICBpZiBtYXRjaDoKKyAgICAgICAgICAgICAgICB2ZXJzaW9uID0gbWF0Y2guZ3Jv
dXAoJ3ZlcnNpb24nKQorICAgICAgICAgICAgICAgIGJyZWFrCisgICAgICAgIHJldHVybiB2ZXJz
aW9uCisKKyAgICBkZWYgYmFzZWxpbmVfc2VhcmNoX3BhdGgoc2VsZik6CisgICAgICAgIHNlYXJj
aF9wYXRocyA9IFtdCisgICAgICAgIGlmIHNlbGYuZ2V0X29wdGlvbignd2Via2l0X3Rlc3RfcnVu
bmVyJyk6CisgICAgICAgICAgICBzZWFyY2hfcGF0aHMuYXBwZW5kKHNlbGYuX3drMl9wb3J0X25h
bWUoKSkKKyAgICAgICAgc2VhcmNoX3BhdGhzLmFwcGVuZChzZWxmLm5hbWUoKSkKKyAgICAgICAg
dmVyc2lvbiA9IHNlbGYucXRfdmVyc2lvbigpCisgICAgICAgIGlmICc0LjcnIGluIHZlcnNpb246
CisgICAgICAgICAgICBzZWFyY2hfcGF0aHMuYXBwZW5kKCdxdC00LjcnKQorICAgICAgICBlbGlm
IHZlcnNpb246CisgICAgICAgICAgICBzZWFyY2hfcGF0aHMuYXBwZW5kKCdxdC00LjgnKQorICAg
ICAgICBzZWFyY2hfcGF0aHMuYXBwZW5kKHNlbGYucG9ydF9uYW1lKQorICAgICAgICByZXR1cm4g
bWFwKHNlbGYuX3dlYmtpdF9iYXNlbGluZV9wYXRoLCBzZWFyY2hfcGF0aHMpCisKICAgICBkZWYg
X3J1bnRpbWVfZmVhdHVyZV9saXN0KHNlbGYpOgogICAgICAgICByZXR1cm4gTm9uZQogCmRpZmYg
LS1naXQgYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L3F0X3VuaXR0
ZXN0LnB5IGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC9xdF91bml0
dGVzdC5weQppbmRleCAxNzhjYTZkLi42ZmRmZjZlIDEwMDY0NAotLS0gYS9Ub29scy9TY3JpcHRz
L3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L3F0X3VuaXR0ZXN0LnB5CisrKyBiL1Rvb2xzL1Nj
cmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQvcXRfdW5pdHRlc3QucHkKQEAgLTMzLDEz
ICszMywxNCBAQCBmcm9tIHdlYmtpdHB5LmNvbW1vbi5zeXN0ZW0ub3V0cHV0Y2FwdHVyZSBpbXBv
cnQgT3V0cHV0Q2FwdHVyZQogZnJvbSB3ZWJraXRweS5sYXlvdXRfdGVzdHMucG9ydC5xdCBpbXBv
cnQgUXRQb3J0CiBmcm9tIHdlYmtpdHB5LmxheW91dF90ZXN0cy5wb3J0IGltcG9ydCBwb3J0X3Rl
c3RjYXNlCiBmcm9tIHdlYmtpdHB5LnRvb2wubW9ja3Rvb2wgaW1wb3J0IE1vY2tPcHRpb25zLCBN
b2NrVXNlciwgTW9ja0V4ZWN1dGl2ZQorZnJvbSB3ZWJraXRweS5jb21tb24uc3lzdGVtLmV4ZWN1
dGl2ZV9tb2NrIGltcG9ydCBNb2NrRXhlY3V0aXZlMgogCiAKIGNsYXNzIFF0UG9ydFRlc3QocG9y
dF90ZXN0Y2FzZS5Qb3J0VGVzdENhc2UpOgogICAgIGRlZiBwb3J0X21ha2VyKHNlbGYsIHBsYXRm
b3JtKToKICAgICAgICAgcmV0dXJuIFF0UG9ydAogCi0gICAgZGVmIF9hc3NlcnRfc2VhcmNoX3Bh
dGgoc2VsZiwgc2VhcmNoX3BhdGhzLCBzeXNfcGxhdGZvcm0sIHVzZV93ZWJraXQyPUZhbHNlKToK
KyAgICBkZWYgX2Fzc2VydF9zZWFyY2hfcGF0aChzZWxmLCBzZWFyY2hfcGF0aHMsIHN5c19wbGF0
Zm9ybSwgdXNlX3dlYmtpdDI9RmFsc2UsIHF0X3ZlcnNpb249JzQuNycpOgogICAgICAgICAjIEZJ
WE1FOiBQb3J0IGNvbnN0cnVjdG9ycyBzaG91bGQgbm90ICJwYXJzZSIgdGhlIHBvcnQgbmFtZSwg
YnV0CiAgICAgICAgICMgcmF0aGVyIGJlIHBhc3NlZCBjb21wb25lbnRzIChkaXJlY3RseSBvciB2
aWEgc2V0dGVycykuICBPbmNlCiAgICAgICAgICMgd2UgZml4IHRoYXQsIHRoaXMgbWV0aG9kIHdp
bGwgbmVlZCBhIHJlLXdyaXRlLgpAQCAtNDcsMjAgKzQ4LDM0IEBAIGNsYXNzIFF0UG9ydFRlc3Qo
cG9ydF90ZXN0Y2FzZS5Qb3J0VGVzdENhc2UpOgogICAgICAgICAgICAgb3B0aW9ucz1Nb2NrT3B0
aW9ucyh3ZWJraXRfdGVzdF9ydW5uZXI9dXNlX3dlYmtpdDIpLAogICAgICAgICAgICAgZmlsZXN5
c3RlbT1Nb2NrRmlsZVN5c3RlbSgpLAogICAgICAgICAgICAgdXNlcj1Nb2NrVXNlcigpLAotICAg
ICAgICAgICAgZXhlY3V0aXZlPU1vY2tFeGVjdXRpdmUoKSkKKyAgICAgICAgICAgIGV4ZWN1dGl2
ZT1Nb2NrRXhlY3V0aXZlMihzZWxmLl9xdF92ZXJzaW9uKHF0X3ZlcnNpb24pKSkKICAgICAgICAg
YWJzb2x1dGVfc2VhcmNoX3BhdGhzID0gbWFwKHBvcnQuX3dlYmtpdF9iYXNlbGluZV9wYXRoLCBz
ZWFyY2hfcGF0aHMpCiAgICAgICAgIHNlbGYuYXNzZXJ0RXF1YWxzKHBvcnQuYmFzZWxpbmVfc2Vh
cmNoX3BhdGgoKSwgYWJzb2x1dGVfc2VhcmNoX3BhdGhzKQogCisgICAgZGVmIF9xdF92ZXJzaW9u
KHNlbGYsIHF0X3ZlcnNpb249JzQuNycpOgorICAgICAgICBpZiBxdF92ZXJzaW9uIGluICc0Ljcn
OgorICAgICAgICAgICAgcmV0dXJuICdRTWFrZSB2ZXJzaW9uIDIuMDFhXG5Vc2luZyBRdCB2ZXJz
aW9uIDQuNy4zIGluIC91c3IvbG9jYWwvVHJvbGx0ZWNoL1F0LTQuNy4zL2xpYicKKyAgICAgICAg
aWYgcXRfdmVyc2lvbiBpbiAnNC44JzoKKyAgICAgICAgICAgIHJldHVybiAnUU1ha2UgdmVyc2lv
biAyLjAxYVxuVXNpbmcgUXQgdmVyc2lvbiA0LjguMiBpbiAvdXNyL2xvY2FsL1Ryb2xsdGVjaC9R
dC00LjguMi9saWInCisgICAgICAgIGlmIHF0X3ZlcnNpb24gaW4gJzUuMCc6CisgICAgICAgICAg
ICByZXR1cm4gJ1FNYWtlIHZlcnNpb24gMi4wMWFcblVzaW5nIFF0IHZlcnNpb24gNS4wLjAgaW4g
L3Vzci9sb2NhbC9Ucm9sbHRlY2gvUXQtNS4wLjAvbGliJworCiAgICAgZGVmIHRlc3RfYmFzZWxp
bmVfc2VhcmNoX3BhdGgoc2VsZik6Ci0gICAgICAgIHNlbGYuX2Fzc2VydF9zZWFyY2hfcGF0aChb
J3F0LW1hYycsICdxdCddLCAnZGFyd2luJykKLSAgICAgICAgc2VsZi5fYXNzZXJ0X3NlYXJjaF9w
YXRoKFsncXQtd2luJywgJ3F0J10sICd3aW4zMicpCi0gICAgICAgIHNlbGYuX2Fzc2VydF9zZWFy
Y2hfcGF0aChbJ3F0LXdpbicsICdxdCddLCAnY3lnd2luJykKLSAgICAgICAgc2VsZi5fYXNzZXJ0
X3NlYXJjaF9wYXRoKFsncXQtbGludXgnLCAncXQnXSwgJ2xpbnV4MicpCi0gICAgICAgIHNlbGYu
X2Fzc2VydF9zZWFyY2hfcGF0aChbJ3F0LWxpbnV4JywgJ3F0J10sICdsaW51eDMnKQorICAgICAg
ICBzZWxmLl9hc3NlcnRfc2VhcmNoX3BhdGgoWydxdC1tYWMnLCAncXQtNC43JywgJ3F0J10sICdk
YXJ3aW4nKQorICAgICAgICBzZWxmLl9hc3NlcnRfc2VhcmNoX3BhdGgoWydxdC13aW4nLCAncXQt
NC43JywgJ3F0J10sICd3aW4zMicpCisgICAgICAgIHNlbGYuX2Fzc2VydF9zZWFyY2hfcGF0aChb
J3F0LXdpbicsICdxdC00LjcnLCAncXQnXSwgJ2N5Z3dpbicpCisgICAgICAgIHNlbGYuX2Fzc2Vy
dF9zZWFyY2hfcGF0aChbJ3F0LWxpbnV4JywgJ3F0LTQuNycsICdxdCddLCAnbGludXgyJykKKyAg
ICAgICAgc2VsZi5fYXNzZXJ0X3NlYXJjaF9wYXRoKFsncXQtbGludXgnLCAncXQtNC43JywgJ3F0
J10sICdsaW51eDMnKQorCisgICAgICAgIHNlbGYuX2Fzc2VydF9zZWFyY2hfcGF0aChbJ3F0LW1h
YycsICdxdC00LjgnLCAncXQnXSwgJ2RhcndpbicsIHF0X3ZlcnNpb249JzQuOCcpCisgICAgICAg
IHNlbGYuX2Fzc2VydF9zZWFyY2hfcGF0aChbJ3F0LXdpbicsICdxdC00LjgnLCAncXQnXSwgJ3dp
bjMyJywgcXRfdmVyc2lvbj0nNC44JykKKyAgICAgICAgc2VsZi5fYXNzZXJ0X3NlYXJjaF9wYXRo
KFsncXQtd2luJywgJ3F0LTQuOCcsICdxdCddLCAnY3lnd2luJywgcXRfdmVyc2lvbj0nNC44JykK
KyAgICAgICAgc2VsZi5fYXNzZXJ0X3NlYXJjaF9wYXRoKFsncXQtbGludXgnLCAncXQtNC44Jywg
J3F0J10sICdsaW51eDInLCBxdF92ZXJzaW9uPSc0LjgnKQorICAgICAgICBzZWxmLl9hc3NlcnRf
c2VhcmNoX3BhdGgoWydxdC1saW51eCcsICdxdC00LjgnLCAncXQnXSwgJ2xpbnV4MycsIHF0X3Zl
cnNpb249JzQuOCcpCiAKLSAgICAgICAgc2VsZi5fYXNzZXJ0X3NlYXJjaF9wYXRoKFsncXQtd2sy
JywgJ3F0LW1hYycsICdxdCddLCAnZGFyd2luJywgdXNlX3dlYmtpdDI9VHJ1ZSkKLSAgICAgICAg
c2VsZi5fYXNzZXJ0X3NlYXJjaF9wYXRoKFsncXQtd2syJywgJ3F0LXdpbicsICdxdCddLCAnY3ln
d2luJywgdXNlX3dlYmtpdDI9VHJ1ZSkKLSAgICAgICAgc2VsZi5fYXNzZXJ0X3NlYXJjaF9wYXRo
KFsncXQtd2syJywgJ3F0LWxpbnV4JywgJ3F0J10sICdsaW51eDInLCB1c2Vfd2Via2l0Mj1UcnVl
KQorICAgICAgICBzZWxmLl9hc3NlcnRfc2VhcmNoX3BhdGgoWydxdC13azInLCAncXQtbWFjJywg
J3F0LTQuOCcsICdxdCddLCAnZGFyd2luJywgdXNlX3dlYmtpdDI9VHJ1ZSwgcXRfdmVyc2lvbj0n
NS4wJykKKyAgICAgICAgc2VsZi5fYXNzZXJ0X3NlYXJjaF9wYXRoKFsncXQtd2syJywgJ3F0LXdp
bicsICdxdC00LjgnLCAncXQnXSwgJ2N5Z3dpbicsIHVzZV93ZWJraXQyPVRydWUsIHF0X3ZlcnNp
b249JzUuMCcpCisgICAgICAgIHNlbGYuX2Fzc2VydF9zZWFyY2hfcGF0aChbJ3F0LXdrMicsICdx
dC1saW51eCcsICdxdC00LjgnLCAncXQnXSwgJ2xpbnV4MicsIHVzZV93ZWJraXQyPVRydWUsIHF0
X3ZlcnNpb249JzUuMCcpCiAKICAgICBkZWYgdGVzdF9zaG93X3Jlc3VsdHNfaHRtbF9maWxlKHNl
bGYpOgogICAgICAgICBwb3J0ID0gc2VsZi5tYWtlX3BvcnQoKQo=
</data>
<flag name="review"
          id="106124"
          type_id="1"
          status="-"
          setter="ossy"
    />
    <flag name="commit-queue"
          id="106125"
          type_id="3"
          status="-"
          setter="ossy"
    />
          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>109951</attachid>
            <date>2011-10-06 05:47:28 -0700</date>
            <delta_ts>2011-10-06 07:25:51 -0700</delta_ts>
            <desc>updated fallback path</desc>
            <filename>06.patch</filename>
            <type>text/plain</type>
            <size>5951</size>
            <attacher name="Kristóf Kosztyó">kkristof</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCAyNzk4
ZGY5Li41MzhlOGU3IDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh
bmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTEtMTAtMDYgIEtyaXN0w7NmIEtvc3p0ecOzICA8
a2tyaXN0b2ZAaW5mLnUtc3plZ2VkLmh1PgorCisgICAgICAgIG5ldy1ydW4td2Via2l0LXRlc3Rz
IGRvZXMgbm90IHN1cHBvcnQgcXQtNC44IHJlc3VsdHMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl
YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTY0MDcxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C
T0RZIChPT1BTISkuCisKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9w
b3J0L3F0LnB5OgorICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQv
cXRfdW5pdHRlc3QucHk6IFJlbW92ZWQuCisKIDIwMTEtMTAtMDMgIEhhbnMgV2VubmJvcmcgIDxo
YW5zQGNocm9taXVtLm9yZz4KIAogICAgICAgICBJbmRleGVkREI6IFJlbW92ZSBTUUxpdGUtTGV2
ZWxEQiBtaWdyYXRpb24gY29kZQpkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9s
YXlvdXRfdGVzdHMvcG9ydC9xdC5weSBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rl
c3RzL3BvcnQvcXQucHkKaW5kZXggZTVmNWY4NC4uNzAwZTI0OCAxMDA2NDQKLS0tIGEvVG9vbHMv
U2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC9xdC5weQorKysgYi9Ub29scy9TY3Jp
cHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L3F0LnB5CkBAIC0yOSw2ICsyOSw3IEBACiAi
IiJRdFdlYktpdCBpbXBsZW1lbnRhdGlvbiBvZiB0aGUgUG9ydCBpbnRlcmZhY2UuIiIiCiAKIGlt
cG9ydCBsb2dnaW5nCitpbXBvcnQgcmUKIGltcG9ydCBzeXMKIAogaW1wb3J0IHdlYmtpdApAQCAt
ODksNiArOTAsMzAgQEAgY2xhc3MgUXRQb3J0KFdlYktpdFBvcnQpOgogICAgIGRlZiBfcGF0aF90
b193ZWJjb3JlX2xpYnJhcnkoc2VsZik6CiAgICAgICAgIHJldHVybiBzZWxmLl9idWlsZF9wYXRo
KCdsaWIvbGliUXRXZWJLaXQuc28nKQogCisgICAgZGVmIHF0X3ZlcnNpb24oc2VsZik6CisgICAg
ICAgIHZlcnNpb24gPSAnJworICAgICAgICBmb3IgbGluZSBpbiBzZWxmLl9leGVjdXRpdmUucnVu
X2NvbW1hbmQoWydxbWFrZScsICctdiddKS5zcGxpdCgnXG4nKToKKyAgICAgICAgICAgIG1hdGNo
ID0gcmUuc2VhcmNoKCdRdFxzdmVyc2lvblxzKD9QPHZlcnNpb24+XGRcLlxkKScsIGxpbmUpCisg
ICAgICAgICAgICBpZiBtYXRjaDoKKyAgICAgICAgICAgICAgICB2ZXJzaW9uID0gbWF0Y2guZ3Jv
dXAoJ3ZlcnNpb24nKQorICAgICAgICAgICAgICAgIGJyZWFrCisgICAgICAgIHJldHVybiB2ZXJz
aW9uCisKKyAgICBkZWYgYmFzZWxpbmVfc2VhcmNoX3BhdGgoc2VsZik6CisgICAgICAgIHNlYXJj
aF9wYXRocyA9IFtdCisgICAgICAgIGlmIHNlbGYuZ2V0X29wdGlvbignd2Via2l0X3Rlc3RfcnVu
bmVyJyk6CisgICAgICAgICAgICBzZWFyY2hfcGF0aHMuYXBwZW5kKHNlbGYuX3drMl9wb3J0X25h
bWUoKSkKKyAgICAgICAgc2VhcmNoX3BhdGhzLmFwcGVuZChzZWxmLm5hbWUoKSkKKyAgICAgICAg
dmVyc2lvbiA9IHNlbGYucXRfdmVyc2lvbigpCisgICAgICAgIGlmICc0LjcnIGluIHZlcnNpb246
CisgICAgICAgICAgICBzZWFyY2hfcGF0aHMuYXBwZW5kKCdxdC00LjcnKQorICAgICAgICBlbGlm
ICc0LjgnIGluIHZlcnNpb246CisgICAgICAgICAgICBzZWFyY2hfcGF0aHMuYXBwZW5kKCdxdC00
LjgnKQorICAgICAgICBlbGlmIHZlcnNpb246CisgICAgICAgICAgICBzZWFyY2hfcGF0aHMuYXBw
ZW5kKCdxdC01LjAnKQorICAgICAgICBzZWFyY2hfcGF0aHMuYXBwZW5kKHNlbGYucG9ydF9uYW1l
KQorICAgICAgICByZXR1cm4gbWFwKHNlbGYuX3dlYmtpdF9iYXNlbGluZV9wYXRoLCBzZWFyY2hf
cGF0aHMpCisKICAgICBkZWYgX3J1bnRpbWVfZmVhdHVyZV9saXN0KHNlbGYpOgogICAgICAgICBy
ZXR1cm4gTm9uZQogCmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90
ZXN0cy9wb3J0L3F0X3VuaXR0ZXN0LnB5IGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRf
dGVzdHMvcG9ydC9xdF91bml0dGVzdC5weQppbmRleCAxNzhjYTZkLi42ZjE3NWQ3IDEwMDY0NAot
LS0gYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L3F0X3VuaXR0ZXN0
LnB5CisrKyBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQvcXRfdW5p
dHRlc3QucHkKQEAgLTI4LDYgKzI4LDcgQEAKIAogaW1wb3J0IHVuaXR0ZXN0CiAKK2Zyb20gd2Vi
a2l0cHkuY29tbW9uLnN5c3RlbS5leGVjdXRpdmVfbW9jayBpbXBvcnQgTW9ja0V4ZWN1dGl2ZTIK
IGZyb20gd2Via2l0cHkuY29tbW9uLnN5c3RlbS5maWxlc3lzdGVtX21vY2sgaW1wb3J0IE1vY2tG
aWxlU3lzdGVtCiBmcm9tIHdlYmtpdHB5LmNvbW1vbi5zeXN0ZW0ub3V0cHV0Y2FwdHVyZSBpbXBv
cnQgT3V0cHV0Q2FwdHVyZQogZnJvbSB3ZWJraXRweS5sYXlvdXRfdGVzdHMucG9ydC5xdCBpbXBv
cnQgUXRQb3J0CkBAIC0zOSw3ICs0MCw3IEBAIGNsYXNzIFF0UG9ydFRlc3QocG9ydF90ZXN0Y2Fz
ZS5Qb3J0VGVzdENhc2UpOgogICAgIGRlZiBwb3J0X21ha2VyKHNlbGYsIHBsYXRmb3JtKToKICAg
ICAgICAgcmV0dXJuIFF0UG9ydAogCi0gICAgZGVmIF9hc3NlcnRfc2VhcmNoX3BhdGgoc2VsZiwg
c2VhcmNoX3BhdGhzLCBzeXNfcGxhdGZvcm0sIHVzZV93ZWJraXQyPUZhbHNlKToKKyAgICBkZWYg
X2Fzc2VydF9zZWFyY2hfcGF0aChzZWxmLCBzZWFyY2hfcGF0aHMsIHN5c19wbGF0Zm9ybSwgdXNl
X3dlYmtpdDI9RmFsc2UsIHF0X3ZlcnNpb249JzQuNycpOgogICAgICAgICAjIEZJWE1FOiBQb3J0
IGNvbnN0cnVjdG9ycyBzaG91bGQgbm90ICJwYXJzZSIgdGhlIHBvcnQgbmFtZSwgYnV0CiAgICAg
ICAgICMgcmF0aGVyIGJlIHBhc3NlZCBjb21wb25lbnRzIChkaXJlY3RseSBvciB2aWEgc2V0dGVy
cykuICBPbmNlCiAgICAgICAgICMgd2UgZml4IHRoYXQsIHRoaXMgbWV0aG9kIHdpbGwgbmVlZCBh
IHJlLXdyaXRlLgpAQCAtNDcsMjAgKzQ4LDM0IEBAIGNsYXNzIFF0UG9ydFRlc3QocG9ydF90ZXN0
Y2FzZS5Qb3J0VGVzdENhc2UpOgogICAgICAgICAgICAgb3B0aW9ucz1Nb2NrT3B0aW9ucyh3ZWJr
aXRfdGVzdF9ydW5uZXI9dXNlX3dlYmtpdDIpLAogICAgICAgICAgICAgZmlsZXN5c3RlbT1Nb2Nr
RmlsZVN5c3RlbSgpLAogICAgICAgICAgICAgdXNlcj1Nb2NrVXNlcigpLAotICAgICAgICAgICAg
ZXhlY3V0aXZlPU1vY2tFeGVjdXRpdmUoKSkKKyAgICAgICAgICAgIGV4ZWN1dGl2ZT1Nb2NrRXhl
Y3V0aXZlMihzZWxmLl9xdF92ZXJzaW9uKHF0X3ZlcnNpb24pKSkKICAgICAgICAgYWJzb2x1dGVf
c2VhcmNoX3BhdGhzID0gbWFwKHBvcnQuX3dlYmtpdF9iYXNlbGluZV9wYXRoLCBzZWFyY2hfcGF0
aHMpCiAgICAgICAgIHNlbGYuYXNzZXJ0RXF1YWxzKHBvcnQuYmFzZWxpbmVfc2VhcmNoX3BhdGgo
KSwgYWJzb2x1dGVfc2VhcmNoX3BhdGhzKQogCisgICAgZGVmIF9xdF92ZXJzaW9uKHNlbGYsIHF0
X3ZlcnNpb24pOgorICAgICAgICBpZiBxdF92ZXJzaW9uIGluICc0LjcnOgorICAgICAgICAgICAg
cmV0dXJuICdRTWFrZSB2ZXJzaW9uIDIuMDFhXG5Vc2luZyBRdCB2ZXJzaW9uIDQuNy4zIGluIC91
c3IvbG9jYWwvVHJvbGx0ZWNoL1F0LTQuNy4zL2xpYicKKyAgICAgICAgaWYgcXRfdmVyc2lvbiBp
biAnNC44JzoKKyAgICAgICAgICAgIHJldHVybiAnUU1ha2UgdmVyc2lvbiAyLjAxYVxuVXNpbmcg
UXQgdmVyc2lvbiA0LjguMCBpbiAvdXNyL2xvY2FsL1Ryb2xsdGVjaC9RdC00LjguMi9saWInCisg
ICAgICAgIGlmIHF0X3ZlcnNpb24gaW4gJzUuMCc6CisgICAgICAgICAgICByZXR1cm4gJ1FNYWtl
IHZlcnNpb24gMi4wMWFcblVzaW5nIFF0IHZlcnNpb24gNS4wLjAgaW4gL3Vzci9sb2NhbC9Ucm9s
bHRlY2gvUXQtNS4wLjAvbGliJworCiAgICAgZGVmIHRlc3RfYmFzZWxpbmVfc2VhcmNoX3BhdGgo
c2VsZik6Ci0gICAgICAgIHNlbGYuX2Fzc2VydF9zZWFyY2hfcGF0aChbJ3F0LW1hYycsICdxdCdd
LCAnZGFyd2luJykKLSAgICAgICAgc2VsZi5fYXNzZXJ0X3NlYXJjaF9wYXRoKFsncXQtd2luJywg
J3F0J10sICd3aW4zMicpCi0gICAgICAgIHNlbGYuX2Fzc2VydF9zZWFyY2hfcGF0aChbJ3F0LXdp
bicsICdxdCddLCAnY3lnd2luJykKLSAgICAgICAgc2VsZi5fYXNzZXJ0X3NlYXJjaF9wYXRoKFsn
cXQtbGludXgnLCAncXQnXSwgJ2xpbnV4MicpCi0gICAgICAgIHNlbGYuX2Fzc2VydF9zZWFyY2hf
cGF0aChbJ3F0LWxpbnV4JywgJ3F0J10sICdsaW51eDMnKQorICAgICAgICBzZWxmLl9hc3NlcnRf
c2VhcmNoX3BhdGgoWydxdC1tYWMnLCAncXQtNC43JywgJ3F0J10sICdkYXJ3aW4nKQorICAgICAg
ICBzZWxmLl9hc3NlcnRfc2VhcmNoX3BhdGgoWydxdC13aW4nLCAncXQtNC43JywgJ3F0J10sICd3
aW4zMicpCisgICAgICAgIHNlbGYuX2Fzc2VydF9zZWFyY2hfcGF0aChbJ3F0LXdpbicsICdxdC00
LjcnLCAncXQnXSwgJ2N5Z3dpbicpCisgICAgICAgIHNlbGYuX2Fzc2VydF9zZWFyY2hfcGF0aChb
J3F0LWxpbnV4JywgJ3F0LTQuNycsICdxdCddLCAnbGludXgyJykKKyAgICAgICAgc2VsZi5fYXNz
ZXJ0X3NlYXJjaF9wYXRoKFsncXQtbGludXgnLCAncXQtNC43JywgJ3F0J10sICdsaW51eDMnKQor
CisgICAgICAgIHNlbGYuX2Fzc2VydF9zZWFyY2hfcGF0aChbJ3F0LW1hYycsICdxdC00LjgnLCAn
cXQnXSwgJ2RhcndpbicsIHF0X3ZlcnNpb249JzQuOCcpCisgICAgICAgIHNlbGYuX2Fzc2VydF9z
ZWFyY2hfcGF0aChbJ3F0LXdpbicsICdxdC00LjgnLCAncXQnXSwgJ3dpbjMyJywgcXRfdmVyc2lv
bj0nNC44JykKKyAgICAgICAgc2VsZi5fYXNzZXJ0X3NlYXJjaF9wYXRoKFsncXQtd2luJywgJ3F0
LTQuOCcsICdxdCddLCAnY3lnd2luJywgcXRfdmVyc2lvbj0nNC44JykKKyAgICAgICAgc2VsZi5f
YXNzZXJ0X3NlYXJjaF9wYXRoKFsncXQtbGludXgnLCAncXQtNC44JywgJ3F0J10sICdsaW51eDIn
LCBxdF92ZXJzaW9uPSc0LjgnKQorICAgICAgICBzZWxmLl9hc3NlcnRfc2VhcmNoX3BhdGgoWydx
dC1saW51eCcsICdxdC00LjgnLCAncXQnXSwgJ2xpbnV4MycsIHF0X3ZlcnNpb249JzQuOCcpCiAK
LSAgICAgICAgc2VsZi5fYXNzZXJ0X3NlYXJjaF9wYXRoKFsncXQtd2syJywgJ3F0LW1hYycsICdx
dCddLCAnZGFyd2luJywgdXNlX3dlYmtpdDI9VHJ1ZSkKLSAgICAgICAgc2VsZi5fYXNzZXJ0X3Nl
YXJjaF9wYXRoKFsncXQtd2syJywgJ3F0LXdpbicsICdxdCddLCAnY3lnd2luJywgdXNlX3dlYmtp
dDI9VHJ1ZSkKLSAgICAgICAgc2VsZi5fYXNzZXJ0X3NlYXJjaF9wYXRoKFsncXQtd2syJywgJ3F0
LWxpbnV4JywgJ3F0J10sICdsaW51eDInLCB1c2Vfd2Via2l0Mj1UcnVlKQorICAgICAgICBzZWxm
Ll9hc3NlcnRfc2VhcmNoX3BhdGgoWydxdC13azInLCAncXQtbWFjJywgJ3F0LTUuMCcsICdxdCdd
LCAnZGFyd2luJywgdXNlX3dlYmtpdDI9VHJ1ZSwgcXRfdmVyc2lvbj0nNS4wJykKKyAgICAgICAg
c2VsZi5fYXNzZXJ0X3NlYXJjaF9wYXRoKFsncXQtd2syJywgJ3F0LXdpbicsICdxdC01LjAnLCAn
cXQnXSwgJ2N5Z3dpbicsIHVzZV93ZWJraXQyPVRydWUsIHF0X3ZlcnNpb249JzUuMCcpCisgICAg
ICAgIHNlbGYuX2Fzc2VydF9zZWFyY2hfcGF0aChbJ3F0LXdrMicsICdxdC1saW51eCcsICdxdC01
LjAnLCAncXQnXSwgJ2xpbnV4MicsIHVzZV93ZWJraXQyPVRydWUsIHF0X3ZlcnNpb249JzUuMCcp
CiAKICAgICBkZWYgdGVzdF9zaG93X3Jlc3VsdHNfaHRtbF9maWxlKHNlbGYpOgogICAgICAgICBw
b3J0ID0gc2VsZi5tYWtlX3BvcnQoKQo=
</data>
<flag name="review"
          id="107298"
          type_id="1"
          status="-"
          setter="ossy"
    />
    <flag name="commit-queue"
          id="107299"
          type_id="3"
          status="-"
          setter="ossy"
    />
          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>109960</attachid>
            <date>2011-10-06 07:25:51 -0700</date>
            <delta_ts>2011-10-07 06:39:36 -0700</delta_ts>
            <desc>proposed fix</desc>
            <filename>b.patch</filename>
            <type>text/plain</type>
            <size>5942</size>
            <attacher name="Kristóf Kosztyó">kkristof</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCAyNzk4
ZGY5Li44YmY3NWY3IDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh
bmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTEtMTAtMDYgIEtyaXN0w7NmIEtvc3p0ecOzICA8
a2tyaXN0b2ZAaW5mLnUtc3plZ2VkLmh1PgorCisgICAgICAgIG5ldy1ydW4td2Via2l0LXRlc3Rz
IGRvZXMgbm90IHN1cHBvcnQgcXQtNC44IHJlc3VsdHMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl
YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTY0MDcxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C
T0RZIChPT1BTISkuCisKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9w
b3J0L3F0LnB5OgorICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQv
cXRfdW5pdHRlc3QucHk6CisKIDIwMTEtMTAtMDMgIEhhbnMgV2VubmJvcmcgIDxoYW5zQGNocm9t
aXVtLm9yZz4KIAogICAgICAgICBJbmRleGVkREI6IFJlbW92ZSBTUUxpdGUtTGV2ZWxEQiBtaWdy
YXRpb24gY29kZQpkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVz
dHMvcG9ydC9xdC5weSBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQv
cXQucHkKaW5kZXggZTVmNWY4NC4uNzAwZTI0OCAxMDA2NDQKLS0tIGEvVG9vbHMvU2NyaXB0cy93
ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC9xdC5weQorKysgYi9Ub29scy9TY3JpcHRzL3dlYmtp
dHB5L2xheW91dF90ZXN0cy9wb3J0L3F0LnB5CkBAIC0yOSw2ICsyOSw3IEBACiAiIiJRdFdlYktp
dCBpbXBsZW1lbnRhdGlvbiBvZiB0aGUgUG9ydCBpbnRlcmZhY2UuIiIiCiAKIGltcG9ydCBsb2dn
aW5nCitpbXBvcnQgcmUKIGltcG9ydCBzeXMKIAogaW1wb3J0IHdlYmtpdApAQCAtODksNiArOTAs
MzAgQEAgY2xhc3MgUXRQb3J0KFdlYktpdFBvcnQpOgogICAgIGRlZiBfcGF0aF90b193ZWJjb3Jl
X2xpYnJhcnkoc2VsZik6CiAgICAgICAgIHJldHVybiBzZWxmLl9idWlsZF9wYXRoKCdsaWIvbGli
UXRXZWJLaXQuc28nKQogCisgICAgZGVmIHF0X3ZlcnNpb24oc2VsZik6CisgICAgICAgIHZlcnNp
b24gPSAnJworICAgICAgICBmb3IgbGluZSBpbiBzZWxmLl9leGVjdXRpdmUucnVuX2NvbW1hbmQo
WydxbWFrZScsICctdiddKS5zcGxpdCgnXG4nKToKKyAgICAgICAgICAgIG1hdGNoID0gcmUuc2Vh
cmNoKCdRdFxzdmVyc2lvblxzKD9QPHZlcnNpb24+XGRcLlxkKScsIGxpbmUpCisgICAgICAgICAg
ICBpZiBtYXRjaDoKKyAgICAgICAgICAgICAgICB2ZXJzaW9uID0gbWF0Y2guZ3JvdXAoJ3ZlcnNp
b24nKQorICAgICAgICAgICAgICAgIGJyZWFrCisgICAgICAgIHJldHVybiB2ZXJzaW9uCisKKyAg
ICBkZWYgYmFzZWxpbmVfc2VhcmNoX3BhdGgoc2VsZik6CisgICAgICAgIHNlYXJjaF9wYXRocyA9
IFtdCisgICAgICAgIGlmIHNlbGYuZ2V0X29wdGlvbignd2Via2l0X3Rlc3RfcnVubmVyJyk6Cisg
ICAgICAgICAgICBzZWFyY2hfcGF0aHMuYXBwZW5kKHNlbGYuX3drMl9wb3J0X25hbWUoKSkKKyAg
ICAgICAgc2VhcmNoX3BhdGhzLmFwcGVuZChzZWxmLm5hbWUoKSkKKyAgICAgICAgdmVyc2lvbiA9
IHNlbGYucXRfdmVyc2lvbigpCisgICAgICAgIGlmICc0LjcnIGluIHZlcnNpb246CisgICAgICAg
ICAgICBzZWFyY2hfcGF0aHMuYXBwZW5kKCdxdC00LjcnKQorICAgICAgICBlbGlmICc0LjgnIGlu
IHZlcnNpb246CisgICAgICAgICAgICBzZWFyY2hfcGF0aHMuYXBwZW5kKCdxdC00LjgnKQorICAg
ICAgICBlbGlmIHZlcnNpb246CisgICAgICAgICAgICBzZWFyY2hfcGF0aHMuYXBwZW5kKCdxdC01
LjAnKQorICAgICAgICBzZWFyY2hfcGF0aHMuYXBwZW5kKHNlbGYucG9ydF9uYW1lKQorICAgICAg
ICByZXR1cm4gbWFwKHNlbGYuX3dlYmtpdF9iYXNlbGluZV9wYXRoLCBzZWFyY2hfcGF0aHMpCisK
ICAgICBkZWYgX3J1bnRpbWVfZmVhdHVyZV9saXN0KHNlbGYpOgogICAgICAgICByZXR1cm4gTm9u
ZQogCmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0
L3F0X3VuaXR0ZXN0LnB5IGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9y
dC9xdF91bml0dGVzdC5weQppbmRleCAxNzhjYTZkLi4yMDVkMTBkIDEwMDY0NAotLS0gYS9Ub29s
cy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L3F0X3VuaXR0ZXN0LnB5CisrKyBi
L1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQvcXRfdW5pdHRlc3QucHkK
QEAgLTI4LDYgKzI4LDcgQEAKIAogaW1wb3J0IHVuaXR0ZXN0CiAKK2Zyb20gd2Via2l0cHkuY29t
bW9uLnN5c3RlbS5leGVjdXRpdmVfbW9jayBpbXBvcnQgTW9ja0V4ZWN1dGl2ZTIKIGZyb20gd2Vi
a2l0cHkuY29tbW9uLnN5c3RlbS5maWxlc3lzdGVtX21vY2sgaW1wb3J0IE1vY2tGaWxlU3lzdGVt
CiBmcm9tIHdlYmtpdHB5LmNvbW1vbi5zeXN0ZW0ub3V0cHV0Y2FwdHVyZSBpbXBvcnQgT3V0cHV0
Q2FwdHVyZQogZnJvbSB3ZWJraXRweS5sYXlvdXRfdGVzdHMucG9ydC5xdCBpbXBvcnQgUXRQb3J0
CkBAIC0zOSw3ICs0MCw3IEBAIGNsYXNzIFF0UG9ydFRlc3QocG9ydF90ZXN0Y2FzZS5Qb3J0VGVz
dENhc2UpOgogICAgIGRlZiBwb3J0X21ha2VyKHNlbGYsIHBsYXRmb3JtKToKICAgICAgICAgcmV0
dXJuIFF0UG9ydAogCi0gICAgZGVmIF9hc3NlcnRfc2VhcmNoX3BhdGgoc2VsZiwgc2VhcmNoX3Bh
dGhzLCBzeXNfcGxhdGZvcm0sIHVzZV93ZWJraXQyPUZhbHNlKToKKyAgICBkZWYgX2Fzc2VydF9z
ZWFyY2hfcGF0aChzZWxmLCBzZWFyY2hfcGF0aHMsIHN5c19wbGF0Zm9ybSwgdXNlX3dlYmtpdDI9
RmFsc2UsIHF0X3ZlcnNpb249JzQuNycpOgogICAgICAgICAjIEZJWE1FOiBQb3J0IGNvbnN0cnVj
dG9ycyBzaG91bGQgbm90ICJwYXJzZSIgdGhlIHBvcnQgbmFtZSwgYnV0CiAgICAgICAgICMgcmF0
aGVyIGJlIHBhc3NlZCBjb21wb25lbnRzIChkaXJlY3RseSBvciB2aWEgc2V0dGVycykuICBPbmNl
CiAgICAgICAgICMgd2UgZml4IHRoYXQsIHRoaXMgbWV0aG9kIHdpbGwgbmVlZCBhIHJlLXdyaXRl
LgpAQCAtNDcsMjAgKzQ4LDM0IEBAIGNsYXNzIFF0UG9ydFRlc3QocG9ydF90ZXN0Y2FzZS5Qb3J0
VGVzdENhc2UpOgogICAgICAgICAgICAgb3B0aW9ucz1Nb2NrT3B0aW9ucyh3ZWJraXRfdGVzdF9y
dW5uZXI9dXNlX3dlYmtpdDIpLAogICAgICAgICAgICAgZmlsZXN5c3RlbT1Nb2NrRmlsZVN5c3Rl
bSgpLAogICAgICAgICAgICAgdXNlcj1Nb2NrVXNlcigpLAotICAgICAgICAgICAgZXhlY3V0aXZl
PU1vY2tFeGVjdXRpdmUoKSkKKyAgICAgICAgICAgIGV4ZWN1dGl2ZT1Nb2NrRXhlY3V0aXZlMihz
ZWxmLl9xdF92ZXJzaW9uKHF0X3ZlcnNpb24pKSkKICAgICAgICAgYWJzb2x1dGVfc2VhcmNoX3Bh
dGhzID0gbWFwKHBvcnQuX3dlYmtpdF9iYXNlbGluZV9wYXRoLCBzZWFyY2hfcGF0aHMpCiAgICAg
ICAgIHNlbGYuYXNzZXJ0RXF1YWxzKHBvcnQuYmFzZWxpbmVfc2VhcmNoX3BhdGgoKSwgYWJzb2x1
dGVfc2VhcmNoX3BhdGhzKQogCisgICAgZGVmIF9xdF92ZXJzaW9uKHNlbGYsIHF0X3ZlcnNpb24p
OgorICAgICAgICBpZiBxdF92ZXJzaW9uIGluICc0LjcnOgorICAgICAgICAgICAgcmV0dXJuICdR
TWFrZSB2ZXJzaW9uIDIuMDFhXG5Vc2luZyBRdCB2ZXJzaW9uIDQuNy4zIGluIC91c3IvbG9jYWwv
VHJvbGx0ZWNoL1F0LTQuNy4zL2xpYicKKyAgICAgICAgaWYgcXRfdmVyc2lvbiBpbiAnNC44JzoK
KyAgICAgICAgICAgIHJldHVybiAnUU1ha2UgdmVyc2lvbiAyLjAxYVxuVXNpbmcgUXQgdmVyc2lv
biA0LjguMCBpbiAvdXNyL2xvY2FsL1Ryb2xsdGVjaC9RdC00LjguMC9saWInCisgICAgICAgIGlm
IHF0X3ZlcnNpb24gaW4gJzUuMCc6CisgICAgICAgICAgICByZXR1cm4gJ1FNYWtlIHZlcnNpb24g
Mi4wMWFcblVzaW5nIFF0IHZlcnNpb24gNS4wLjAgaW4gL3Vzci9sb2NhbC9Ucm9sbHRlY2gvUXQt
NS4wLjAvbGliJworCiAgICAgZGVmIHRlc3RfYmFzZWxpbmVfc2VhcmNoX3BhdGgoc2VsZik6Ci0g
ICAgICAgIHNlbGYuX2Fzc2VydF9zZWFyY2hfcGF0aChbJ3F0LW1hYycsICdxdCddLCAnZGFyd2lu
JykKLSAgICAgICAgc2VsZi5fYXNzZXJ0X3NlYXJjaF9wYXRoKFsncXQtd2luJywgJ3F0J10sICd3
aW4zMicpCi0gICAgICAgIHNlbGYuX2Fzc2VydF9zZWFyY2hfcGF0aChbJ3F0LXdpbicsICdxdCdd
LCAnY3lnd2luJykKLSAgICAgICAgc2VsZi5fYXNzZXJ0X3NlYXJjaF9wYXRoKFsncXQtbGludXgn
LCAncXQnXSwgJ2xpbnV4MicpCi0gICAgICAgIHNlbGYuX2Fzc2VydF9zZWFyY2hfcGF0aChbJ3F0
LWxpbnV4JywgJ3F0J10sICdsaW51eDMnKQorICAgICAgICBzZWxmLl9hc3NlcnRfc2VhcmNoX3Bh
dGgoWydxdC1tYWMnLCAncXQtNC43JywgJ3F0J10sICdkYXJ3aW4nKQorICAgICAgICBzZWxmLl9h
c3NlcnRfc2VhcmNoX3BhdGgoWydxdC13aW4nLCAncXQtNC43JywgJ3F0J10sICd3aW4zMicpCisg
ICAgICAgIHNlbGYuX2Fzc2VydF9zZWFyY2hfcGF0aChbJ3F0LXdpbicsICdxdC00LjcnLCAncXQn
XSwgJ2N5Z3dpbicpCisgICAgICAgIHNlbGYuX2Fzc2VydF9zZWFyY2hfcGF0aChbJ3F0LWxpbnV4
JywgJ3F0LTQuNycsICdxdCddLCAnbGludXgyJykKKyAgICAgICAgc2VsZi5fYXNzZXJ0X3NlYXJj
aF9wYXRoKFsncXQtbGludXgnLCAncXQtNC43JywgJ3F0J10sICdsaW51eDMnKQorCisgICAgICAg
IHNlbGYuX2Fzc2VydF9zZWFyY2hfcGF0aChbJ3F0LW1hYycsICdxdC00LjgnLCAncXQnXSwgJ2Rh
cndpbicsIHF0X3ZlcnNpb249JzQuOCcpCisgICAgICAgIHNlbGYuX2Fzc2VydF9zZWFyY2hfcGF0
aChbJ3F0LXdpbicsICdxdC00LjgnLCAncXQnXSwgJ3dpbjMyJywgcXRfdmVyc2lvbj0nNC44JykK
KyAgICAgICAgc2VsZi5fYXNzZXJ0X3NlYXJjaF9wYXRoKFsncXQtd2luJywgJ3F0LTQuOCcsICdx
dCddLCAnY3lnd2luJywgcXRfdmVyc2lvbj0nNC44JykKKyAgICAgICAgc2VsZi5fYXNzZXJ0X3Nl
YXJjaF9wYXRoKFsncXQtbGludXgnLCAncXQtNC44JywgJ3F0J10sICdsaW51eDInLCBxdF92ZXJz
aW9uPSc0LjgnKQorICAgICAgICBzZWxmLl9hc3NlcnRfc2VhcmNoX3BhdGgoWydxdC1saW51eCcs
ICdxdC00LjgnLCAncXQnXSwgJ2xpbnV4MycsIHF0X3ZlcnNpb249JzQuOCcpCiAKLSAgICAgICAg
c2VsZi5fYXNzZXJ0X3NlYXJjaF9wYXRoKFsncXQtd2syJywgJ3F0LW1hYycsICdxdCddLCAnZGFy
d2luJywgdXNlX3dlYmtpdDI9VHJ1ZSkKLSAgICAgICAgc2VsZi5fYXNzZXJ0X3NlYXJjaF9wYXRo
KFsncXQtd2syJywgJ3F0LXdpbicsICdxdCddLCAnY3lnd2luJywgdXNlX3dlYmtpdDI9VHJ1ZSkK
LSAgICAgICAgc2VsZi5fYXNzZXJ0X3NlYXJjaF9wYXRoKFsncXQtd2syJywgJ3F0LWxpbnV4Jywg
J3F0J10sICdsaW51eDInLCB1c2Vfd2Via2l0Mj1UcnVlKQorICAgICAgICBzZWxmLl9hc3NlcnRf
c2VhcmNoX3BhdGgoWydxdC13azInLCAncXQtbWFjJywgJ3F0LTUuMCcsICdxdCddLCAnZGFyd2lu
JywgdXNlX3dlYmtpdDI9VHJ1ZSwgcXRfdmVyc2lvbj0nNS4wJykKKyAgICAgICAgc2VsZi5fYXNz
ZXJ0X3NlYXJjaF9wYXRoKFsncXQtd2syJywgJ3F0LXdpbicsICdxdC01LjAnLCAncXQnXSwgJ2N5
Z3dpbicsIHVzZV93ZWJraXQyPVRydWUsIHF0X3ZlcnNpb249JzUuMCcpCisgICAgICAgIHNlbGYu
X2Fzc2VydF9zZWFyY2hfcGF0aChbJ3F0LXdrMicsICdxdC1saW51eCcsICdxdC01LjAnLCAncXQn
XSwgJ2xpbnV4MicsIHVzZV93ZWJraXQyPVRydWUsIHF0X3ZlcnNpb249JzUuMCcpCiAKICAgICBk
ZWYgdGVzdF9zaG93X3Jlc3VsdHNfaHRtbF9maWxlKHNlbGYpOgogICAgICAgICBwb3J0ID0gc2Vs
Zi5tYWtlX3BvcnQoKQo=
</data>
<flag name="review"
          id="107316"
          type_id="1"
          status="-"
          setter="ossy"
    />
    <flag name="commit-queue"
          id="107317"
          type_id="3"
          status="-"
          setter="ossy"
    />
          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>110135</attachid>
            <date>2011-10-07 06:39:36 -0700</date>
            <delta_ts>2011-10-12 04:27:33 -0700</delta_ts>
            <desc>proposed fix</desc>
            <filename>0001-new-run-webkit-tests-does-not-support-qt-4.8-results.patch</filename>
            <type>text/plain</type>
            <size>8196</size>
            <attacher name="Kristóf Kosztyó">kkristof</attacher>
            
              <data encoding="base64">RnJvbSA5ZjQxMzk0OTBjZTRiZDE4ZDBhZTUwYmExMGZkYzEzYjcwYTRjNzZmIE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiA9P1VURi04P3E/S3Jpc3Q9QzM9QjNmPTIwS29zenR5PUMzPUIz
Pz0gPGtrcmlzdG9mQGluZi51LXN6ZWdlZC5odT4KRGF0ZTogRnJpLCA3IE9jdCAyMDExIDE1OjM2
OjA2ICswMjAwClN1YmplY3Q6IFtQQVRDSF0gbmV3LXJ1bi13ZWJraXQtdGVzdHMgZG9lcyBub3Qg
c3VwcG9ydCBxdC00LjggcmVzdWx0cwogaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu
Y2dpP2lkPTY0MDcxCgotLS0KIExheW91dFRlc3RzL0NoYW5nZUxvZyAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgIHwgICAxMCArKysrKwogVG9vbHMvQ2hhbmdlTG9nICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgfCAgIDEwICsrKysrCiBUb29scy9TY3JpcHRzL3dlYmtpdHB5
L2xheW91dF90ZXN0cy9wb3J0L3F0LnB5ICAgICB8ICAgNDAgKysrKysrKysrKysrKysrKysrKysK
IC4uLi93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC9xdF91bml0dGVzdC5weSAgICAgIHwgICAz
NSArKysrKysrKysrKystLS0tLQogNCBmaWxlcyBjaGFuZ2VkLCA4NSBpbnNlcnRpb25zKCspLCAx
MCBkZWxldGlvbnMoLSkKIGNyZWF0ZSBtb2RlIDEwMDY0NCBMYXlvdXRUZXN0cy9wbGF0Zm9ybS9x
dC00LjcvU2tpcHBlZAogY3JlYXRlIG1vZGUgMTAwNjQ0IExheW91dFRlc3RzL3BsYXRmb3JtL3F0
LTUuMC9Ta2lwcGVkCgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nIGIvTGF5b3V0
VGVzdHMvQ2hhbmdlTG9nCmluZGV4IDEwNGQ2NTYuLjhlYTkwNzkgMTAwNjQ0Ci0tLSBhL0xheW91
dFRlc3RzL0NoYW5nZUxvZworKysgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwx
MyBAQAorMjAxMS0xMC0wNyAgS3Jpc3TDs2YgS29zenR5w7MgIDxra3Jpc3RvZkBpbmYudS1zemVn
ZWQuaHU+CisKKyAgICAgICAgbmV3LXJ1bi13ZWJraXQtdGVzdHMgZG9lcyBub3Qgc3VwcG9ydCBx
dC00LjggcmVzdWx0cworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j
Z2k/aWQ9NjQwNzEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg
ICAgICAqIHBsYXRmb3JtL3F0LTQuNy9Ta2lwcGVkOiBBZGRlZC4KKyAgICAgICAgKiBwbGF0Zm9y
bS9xdC01LjAvU2tpcHBlZDogQWRkZWQuCisKIDIwMTEtMTAtMDcgIEtlbnQgVGFtdXJhICA8dGtl
bnRAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFRlc3QgdXBkYXRlIGZvciByOTY4OTMuCmRpZmYg
LS1naXQgYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9xdC00LjcvU2tpcHBlZCBiL0xheW91dFRlc3Rz
L3BsYXRmb3JtL3F0LTQuNy9Ta2lwcGVkCm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAw
MDAuLmU2OWRlMjkKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL3BsYXRmb3JtL3F0LTUuMC9Ta2lw
cGVkIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vcXQtNS4wL1NraXBwZWQKbmV3IGZpbGUgbW9kZSAx
MDA2NDQKaW5kZXggMDAwMDAwMC4uZTY5ZGUyOQpkaWZmIC0tZ2l0IGEvVG9vbHMvQ2hhbmdlTG9n
IGIvVG9vbHMvQ2hhbmdlTG9nCmluZGV4IGM4NjkxODguLjZlMDJlZjEgMTAwNjQ0Ci0tLSBhL1Rv
b2xzL0NoYW5nZUxvZworKysgYi9Ub29scy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBAQAorMjAx
MS0xMC0wNyAgS3Jpc3TDs2YgS29zenR5w7MgIDxra3Jpc3RvZkBpbmYudS1zemVnZWQuaHU+CisK
KyAgICAgICAgbmV3LXJ1bi13ZWJraXQtdGVzdHMgZG9lcyBub3Qgc3VwcG9ydCBxdC00LjggcmVz
dWx0cworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjQw
NzEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFNj
cmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQvcXQucHk6CisgICAgICAgICogU2NyaXB0
cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC9xdF91bml0dGVzdC5weToKKwogMjAxMS0xMC0w
NiAgQWRhbSBCYXJ0aCAgPGFiYXJ0aEB3ZWJraXQub3JnPgogCiAgICAgICAgIFBvcnQgUGl4ZWxa
b29tZXIgdG8gd29yayBpbiBnYXJkZW4tby1tYXRpYwpkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0
cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC9xdC5weSBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0
cHkvbGF5b3V0X3Rlc3RzL3BvcnQvcXQucHkKaW5kZXggZTVmNWY4NC4uZGNmODViNSAxMDA2NDQK
LS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC9xdC5weQorKysg
Yi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L3F0LnB5CkBAIC0yOSwx
MCArMjksMTIgQEAKICIiIlF0V2ViS2l0IGltcGxlbWVudGF0aW9uIG9mIHRoZSBQb3J0IGludGVy
ZmFjZS4iIiIKIAogaW1wb3J0IGxvZ2dpbmcKK2ltcG9ydCByZQogaW1wb3J0IHN5cwogCiBpbXBv
cnQgd2Via2l0CiAKK2Zyb20gd2Via2l0cHkuY29tbW9uLm1lbW9pemVkIGltcG9ydCBtZW1vaXpl
ZAogZnJvbSB3ZWJraXRweS5sYXlvdXRfdGVzdHMubW9kZWxzLnRlc3RfY29uZmlndXJhdGlvbiBp
bXBvcnQgVGVzdENvbmZpZ3VyYXRpb24KIGZyb20gd2Via2l0cHkubGF5b3V0X3Rlc3RzLnBvcnQu
d2Via2l0IGltcG9ydCBXZWJLaXRQb3J0CiAKQEAgLTg5LDYgKzkxLDQ0IEBAIGNsYXNzIFF0UG9y
dChXZWJLaXRQb3J0KToKICAgICBkZWYgX3BhdGhfdG9fd2ViY29yZV9saWJyYXJ5KHNlbGYpOgog
ICAgICAgICByZXR1cm4gc2VsZi5fYnVpbGRfcGF0aCgnbGliL2xpYlF0V2ViS2l0LnNvJykKIAor
ICAgIEBtZW1vaXplZAorICAgIGRlZiBxdF92ZXJzaW9uKHNlbGYpOgorICAgICAgICB2ZXJzaW9u
ID0gJycKKyAgICAgICAgZm9yIGxpbmUgaW4gc2VsZi5fZXhlY3V0aXZlLnJ1bl9jb21tYW5kKFsn
cW1ha2UnLCAnLXYnXSkuc3BsaXQoJ1xuJyk6CisgICAgICAgICAgICBtYXRjaCA9IHJlLnNlYXJj
aCgnUXRcc3ZlcnNpb25ccyg/UDx2ZXJzaW9uPlxkXC5cZCknLCBsaW5lKQorICAgICAgICAgICAg
aWYgbWF0Y2g6CisgICAgICAgICAgICAgICAgdmVyc2lvbiA9IG1hdGNoLmdyb3VwKCd2ZXJzaW9u
JykKKyAgICAgICAgICAgICAgICBicmVhaworICAgICAgICByZXR1cm4gdmVyc2lvbgorCisgICAg
ZGVmIGJhc2VsaW5lX3NlYXJjaF9wYXRoKHNlbGYpOgorICAgICAgICBzZWFyY2hfcGF0aHMgPSBb
XQorICAgICAgICBpZiBzZWxmLmdldF9vcHRpb24oJ3dlYmtpdF90ZXN0X3J1bm5lcicpOgorICAg
ICAgICAgICAgc2VhcmNoX3BhdGhzLmFwcGVuZChzZWxmLl93azJfcG9ydF9uYW1lKCkpCisgICAg
ICAgIHNlYXJjaF9wYXRocy5hcHBlbmQoc2VsZi5uYW1lKCkpCisgICAgICAgIHZlcnNpb24gPSBz
ZWxmLnF0X3ZlcnNpb24oKQorICAgICAgICBpZiAnNC43JyBpbiB2ZXJzaW9uOgorICAgICAgICAg
ICAgc2VhcmNoX3BhdGhzLmFwcGVuZCgncXQtNC43JykKKyAgICAgICAgZWxpZiAnNC44JyBpbiB2
ZXJzaW9uOgorICAgICAgICAgICAgc2VhcmNoX3BhdGhzLmFwcGVuZCgncXQtNC44JykKKyAgICAg
ICAgZWxpZiB2ZXJzaW9uOgorICAgICAgICAgICAgc2VhcmNoX3BhdGhzLmFwcGVuZCgncXQtNS4w
JykKKyAgICAgICAgc2VhcmNoX3BhdGhzLmFwcGVuZChzZWxmLnBvcnRfbmFtZSkKKyAgICAgICAg
cmV0dXJuIG1hcChzZWxmLl93ZWJraXRfYmFzZWxpbmVfcGF0aCwgc2VhcmNoX3BhdGhzKQorCisg
ICAgZGVmIF9za2lwcGVkX2ZpbGVfc2VhcmNoX3BhdGhzKHNlbGYpOgorICAgICAgICBzZWFyY2hf
cGF0aHMgPSBzZXQoW3NlbGYucG9ydF9uYW1lLCBzZWxmLm5hbWUoKV0pCisgICAgICAgIHZlcnNp
b24gPSBzZWxmLnF0X3ZlcnNpb24oKQorICAgICAgICBpZiAnNC43JyBpbiB2ZXJzaW9uOgorICAg
ICAgICAgICAgc2VhcmNoX3BhdGhzLmFkZCgncXQtNC43JykKKyAgICAgICAgZWxpZiAnNC44JyBp
biB2ZXJzaW9uOgorICAgICAgICAgICAgc2VhcmNoX3BhdGhzLmFkZCgncXQtNC44JykKKyAgICAg
ICAgZWxpZiB2ZXJzaW9uOgorICAgICAgICAgICAgc2VhcmNoX3BhdGhzLmFkZCgncXQtNS4wJykK
KyAgICAgICAgaWYgc2VsZi5nZXRfb3B0aW9uKCd3ZWJraXRfdGVzdF9ydW5uZXInKToKKyAgICAg
ICAgICAgIHNlYXJjaF9wYXRocy51cGRhdGUoWydxdC13azInLCAnd2syJ10pCisgICAgICAgIHJl
dHVybiBzZWFyY2hfcGF0aHMKKwogICAgIGRlZiBfcnVudGltZV9mZWF0dXJlX2xpc3Qoc2VsZik6
CiAgICAgICAgIHJldHVybiBOb25lCiAKZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0
cHkvbGF5b3V0X3Rlc3RzL3BvcnQvcXRfdW5pdHRlc3QucHkgYi9Ub29scy9TY3JpcHRzL3dlYmtp
dHB5L2xheW91dF90ZXN0cy9wb3J0L3F0X3VuaXR0ZXN0LnB5CmluZGV4IDE3OGNhNmQuLjIwNWQx
MGQgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQv
cXRfdW5pdHRlc3QucHkKKysrIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMv
cG9ydC9xdF91bml0dGVzdC5weQpAQCAtMjgsNiArMjgsNyBAQAogCiBpbXBvcnQgdW5pdHRlc3QK
IAorZnJvbSB3ZWJraXRweS5jb21tb24uc3lzdGVtLmV4ZWN1dGl2ZV9tb2NrIGltcG9ydCBNb2Nr
RXhlY3V0aXZlMgogZnJvbSB3ZWJraXRweS5jb21tb24uc3lzdGVtLmZpbGVzeXN0ZW1fbW9jayBp
bXBvcnQgTW9ja0ZpbGVTeXN0ZW0KIGZyb20gd2Via2l0cHkuY29tbW9uLnN5c3RlbS5vdXRwdXRj
YXB0dXJlIGltcG9ydCBPdXRwdXRDYXB0dXJlCiBmcm9tIHdlYmtpdHB5LmxheW91dF90ZXN0cy5w
b3J0LnF0IGltcG9ydCBRdFBvcnQKQEAgLTM5LDcgKzQwLDcgQEAgY2xhc3MgUXRQb3J0VGVzdChw
b3J0X3Rlc3RjYXNlLlBvcnRUZXN0Q2FzZSk6CiAgICAgZGVmIHBvcnRfbWFrZXIoc2VsZiwgcGxh
dGZvcm0pOgogICAgICAgICByZXR1cm4gUXRQb3J0CiAKLSAgICBkZWYgX2Fzc2VydF9zZWFyY2hf
cGF0aChzZWxmLCBzZWFyY2hfcGF0aHMsIHN5c19wbGF0Zm9ybSwgdXNlX3dlYmtpdDI9RmFsc2Up
OgorICAgIGRlZiBfYXNzZXJ0X3NlYXJjaF9wYXRoKHNlbGYsIHNlYXJjaF9wYXRocywgc3lzX3Bs
YXRmb3JtLCB1c2Vfd2Via2l0Mj1GYWxzZSwgcXRfdmVyc2lvbj0nNC43Jyk6CiAgICAgICAgICMg
RklYTUU6IFBvcnQgY29uc3RydWN0b3JzIHNob3VsZCBub3QgInBhcnNlIiB0aGUgcG9ydCBuYW1l
LCBidXQKICAgICAgICAgIyByYXRoZXIgYmUgcGFzc2VkIGNvbXBvbmVudHMgKGRpcmVjdGx5IG9y
IHZpYSBzZXR0ZXJzKS4gIE9uY2UKICAgICAgICAgIyB3ZSBmaXggdGhhdCwgdGhpcyBtZXRob2Qg
d2lsbCBuZWVkIGEgcmUtd3JpdGUuCkBAIC00NywyMCArNDgsMzQgQEAgY2xhc3MgUXRQb3J0VGVz
dChwb3J0X3Rlc3RjYXNlLlBvcnRUZXN0Q2FzZSk6CiAgICAgICAgICAgICBvcHRpb25zPU1vY2tP
cHRpb25zKHdlYmtpdF90ZXN0X3J1bm5lcj11c2Vfd2Via2l0MiksCiAgICAgICAgICAgICBmaWxl
c3lzdGVtPU1vY2tGaWxlU3lzdGVtKCksCiAgICAgICAgICAgICB1c2VyPU1vY2tVc2VyKCksCi0g
ICAgICAgICAgICBleGVjdXRpdmU9TW9ja0V4ZWN1dGl2ZSgpKQorICAgICAgICAgICAgZXhlY3V0
aXZlPU1vY2tFeGVjdXRpdmUyKHNlbGYuX3F0X3ZlcnNpb24ocXRfdmVyc2lvbikpKQogICAgICAg
ICBhYnNvbHV0ZV9zZWFyY2hfcGF0aHMgPSBtYXAocG9ydC5fd2Via2l0X2Jhc2VsaW5lX3BhdGgs
IHNlYXJjaF9wYXRocykKICAgICAgICAgc2VsZi5hc3NlcnRFcXVhbHMocG9ydC5iYXNlbGluZV9z
ZWFyY2hfcGF0aCgpLCBhYnNvbHV0ZV9zZWFyY2hfcGF0aHMpCiAKKyAgICBkZWYgX3F0X3ZlcnNp
b24oc2VsZiwgcXRfdmVyc2lvbik6CisgICAgICAgIGlmIHF0X3ZlcnNpb24gaW4gJzQuNyc6Cisg
ICAgICAgICAgICByZXR1cm4gJ1FNYWtlIHZlcnNpb24gMi4wMWFcblVzaW5nIFF0IHZlcnNpb24g
NC43LjMgaW4gL3Vzci9sb2NhbC9Ucm9sbHRlY2gvUXQtNC43LjMvbGliJworICAgICAgICBpZiBx
dF92ZXJzaW9uIGluICc0LjgnOgorICAgICAgICAgICAgcmV0dXJuICdRTWFrZSB2ZXJzaW9uIDIu
MDFhXG5Vc2luZyBRdCB2ZXJzaW9uIDQuOC4wIGluIC91c3IvbG9jYWwvVHJvbGx0ZWNoL1F0LTQu
OC4wL2xpYicKKyAgICAgICAgaWYgcXRfdmVyc2lvbiBpbiAnNS4wJzoKKyAgICAgICAgICAgIHJl
dHVybiAnUU1ha2UgdmVyc2lvbiAyLjAxYVxuVXNpbmcgUXQgdmVyc2lvbiA1LjAuMCBpbiAvdXNy
L2xvY2FsL1Ryb2xsdGVjaC9RdC01LjAuMC9saWInCisKICAgICBkZWYgdGVzdF9iYXNlbGluZV9z
ZWFyY2hfcGF0aChzZWxmKToKLSAgICAgICAgc2VsZi5fYXNzZXJ0X3NlYXJjaF9wYXRoKFsncXQt
bWFjJywgJ3F0J10sICdkYXJ3aW4nKQotICAgICAgICBzZWxmLl9hc3NlcnRfc2VhcmNoX3BhdGgo
WydxdC13aW4nLCAncXQnXSwgJ3dpbjMyJykKLSAgICAgICAgc2VsZi5fYXNzZXJ0X3NlYXJjaF9w
YXRoKFsncXQtd2luJywgJ3F0J10sICdjeWd3aW4nKQotICAgICAgICBzZWxmLl9hc3NlcnRfc2Vh
cmNoX3BhdGgoWydxdC1saW51eCcsICdxdCddLCAnbGludXgyJykKLSAgICAgICAgc2VsZi5fYXNz
ZXJ0X3NlYXJjaF9wYXRoKFsncXQtbGludXgnLCAncXQnXSwgJ2xpbnV4MycpCisgICAgICAgIHNl
bGYuX2Fzc2VydF9zZWFyY2hfcGF0aChbJ3F0LW1hYycsICdxdC00LjcnLCAncXQnXSwgJ2Rhcndp
bicpCisgICAgICAgIHNlbGYuX2Fzc2VydF9zZWFyY2hfcGF0aChbJ3F0LXdpbicsICdxdC00Ljcn
LCAncXQnXSwgJ3dpbjMyJykKKyAgICAgICAgc2VsZi5fYXNzZXJ0X3NlYXJjaF9wYXRoKFsncXQt
d2luJywgJ3F0LTQuNycsICdxdCddLCAnY3lnd2luJykKKyAgICAgICAgc2VsZi5fYXNzZXJ0X3Nl
YXJjaF9wYXRoKFsncXQtbGludXgnLCAncXQtNC43JywgJ3F0J10sICdsaW51eDInKQorICAgICAg
ICBzZWxmLl9hc3NlcnRfc2VhcmNoX3BhdGgoWydxdC1saW51eCcsICdxdC00LjcnLCAncXQnXSwg
J2xpbnV4MycpCisKKyAgICAgICAgc2VsZi5fYXNzZXJ0X3NlYXJjaF9wYXRoKFsncXQtbWFjJywg
J3F0LTQuOCcsICdxdCddLCAnZGFyd2luJywgcXRfdmVyc2lvbj0nNC44JykKKyAgICAgICAgc2Vs
Zi5fYXNzZXJ0X3NlYXJjaF9wYXRoKFsncXQtd2luJywgJ3F0LTQuOCcsICdxdCddLCAnd2luMzIn
LCBxdF92ZXJzaW9uPSc0LjgnKQorICAgICAgICBzZWxmLl9hc3NlcnRfc2VhcmNoX3BhdGgoWydx
dC13aW4nLCAncXQtNC44JywgJ3F0J10sICdjeWd3aW4nLCBxdF92ZXJzaW9uPSc0LjgnKQorICAg
ICAgICBzZWxmLl9hc3NlcnRfc2VhcmNoX3BhdGgoWydxdC1saW51eCcsICdxdC00LjgnLCAncXQn
XSwgJ2xpbnV4MicsIHF0X3ZlcnNpb249JzQuOCcpCisgICAgICAgIHNlbGYuX2Fzc2VydF9zZWFy
Y2hfcGF0aChbJ3F0LWxpbnV4JywgJ3F0LTQuOCcsICdxdCddLCAnbGludXgzJywgcXRfdmVyc2lv
bj0nNC44JykKIAotICAgICAgICBzZWxmLl9hc3NlcnRfc2VhcmNoX3BhdGgoWydxdC13azInLCAn
cXQtbWFjJywgJ3F0J10sICdkYXJ3aW4nLCB1c2Vfd2Via2l0Mj1UcnVlKQotICAgICAgICBzZWxm
Ll9hc3NlcnRfc2VhcmNoX3BhdGgoWydxdC13azInLCAncXQtd2luJywgJ3F0J10sICdjeWd3aW4n
LCB1c2Vfd2Via2l0Mj1UcnVlKQotICAgICAgICBzZWxmLl9hc3NlcnRfc2VhcmNoX3BhdGgoWydx
dC13azInLCAncXQtbGludXgnLCAncXQnXSwgJ2xpbnV4MicsIHVzZV93ZWJraXQyPVRydWUpCisg
ICAgICAgIHNlbGYuX2Fzc2VydF9zZWFyY2hfcGF0aChbJ3F0LXdrMicsICdxdC1tYWMnLCAncXQt
NS4wJywgJ3F0J10sICdkYXJ3aW4nLCB1c2Vfd2Via2l0Mj1UcnVlLCBxdF92ZXJzaW9uPSc1LjAn
KQorICAgICAgICBzZWxmLl9hc3NlcnRfc2VhcmNoX3BhdGgoWydxdC13azInLCAncXQtd2luJywg
J3F0LTUuMCcsICdxdCddLCAnY3lnd2luJywgdXNlX3dlYmtpdDI9VHJ1ZSwgcXRfdmVyc2lvbj0n
NS4wJykKKyAgICAgICAgc2VsZi5fYXNzZXJ0X3NlYXJjaF9wYXRoKFsncXQtd2syJywgJ3F0LWxp
bnV4JywgJ3F0LTUuMCcsICdxdCddLCAnbGludXgyJywgdXNlX3dlYmtpdDI9VHJ1ZSwgcXRfdmVy
c2lvbj0nNS4wJykKIAogICAgIGRlZiB0ZXN0X3Nob3dfcmVzdWx0c19odG1sX2ZpbGUoc2VsZik6
CiAgICAgICAgIHBvcnQgPSBzZWxmLm1ha2VfcG9ydCgpCi0tIAoxLjcuMQoK
</data>

          </attachment>
      

    </bug>

</bugzilla>