<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>63981</bug_id>
          
          <creation_ts>2011-07-06 02:02:19 -0700</creation_ts>
          <short_desc>new-run-webkit-tests does not correctly identify timeouts on Mac</short_desc>
          <delta_ts>2012-06-08 15:59:46 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Tools / Tests</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          <dependson>70435</dependson>
          <blocked>64491</blocked>
          <everconfirmed>1</everconfirmed>
          <reporter name="Eric Seidel (no email)">eric</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>abarth</cc>
    
    <cc>dpranke</cc>
    
    <cc>ojan</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>432689</commentid>
    <comment_count>0</comment_count>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2011-07-06 02:02:19 -0700</bug_when>
    <thetext>new-run-webkit-tests does not correctly identify timeouts on Mac

Example:
2011-07-06 01:55:41,276 43149 printing.py:470 INFO 10 slowest tests that are not marked as SLOW and did not timeout/crash:
2011-07-06 01:55:41,276 43149 printing.py:470 INFO   fast/workers/storage/interrupt-database.html took 30.0 seconds
2011-07-06 01:55:41,276 43149 printing.py:470 INFO   fast/workers/worker-close-more.html took 30.0 seconds
2011-07-06 01:55:41,276 43149 printing.py:470 INFO   fast/workers/shared-worker-frame-lifecycle.html took 30.0 seconds
2011-07-06 01:55:41,276 43149 printing.py:470 INFO   fast/workers/shared-worker-lifecycle.html took 30.0 seconds
2011-07-06 01:55:41,276 43149 printing.py:470 INFO   fast/workers/worker-lifecycle.html took 30.0 seconds

What&apos;s happening is that we&apos;re not reading stderr correctly in ServerProcess, so we never see the timeout notification.

At least I think that&apos;s what&apos;s happening.

I believe this to be very related to bug 63683.  Which is about listening for #CRASHED correctly on stderr.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>486946</commentid>
    <comment_count>1</comment_count>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2011-10-19 13:26:25 -0700</bug_when>
    <thetext>I&apos;m not sure my original theory was correct.  I don&apos;t see any #TIMEOUT notifications over stderr.

However, once bug 70435 lands, this would be very easy to fix were there #TIMEOUT notifications in stderr.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>489428</commentid>
    <comment_count>2</comment_count>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2011-10-24 10:38:16 -0700</bug_when>
    <thetext>I&apos;m moving this to the polish bug, since it&apos;s clearly not stopped us from switching the mac bots.  I&apos;m not sure this is still an issue.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>645100</commentid>
    <comment_count>3</comment_count>
    <who name="Dirk Pranke">dpranke</who>
    <bug_when>2012-06-08 15:59:46 -0700</bug_when>
    <thetext>I don&apos;t think this is an issue any more; closing. Please reopen (or file a new bug) if I&apos;m mistaken.</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>