63921 2011-07-04 18:41:02 -0700 keyPath of createIndex() must not be nullable 2011-07-06 17:11:11 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) All All CLOSED INVALID P2 Normal --- 0 haraken webkit-unassigned ap dglazkov dgrogan hans haraken tony oldest_to_newest 432078 0 haraken 2011-07-04 18:41:02 -0700 keyPath of createIndex() must not be nullable (http://dvcs.w3.org/hg/IndexedDB/raw-file/tip/Overview.html#widl-IDBObjectStore-createIndex-IDBIndex-DOMString-name-DOMString-keyPath-Object-optionalParameters). However, LayoutTests/storage/indexeddb/mozilla/create-index-null-name.html is trying to test that null is accepted as the keyPath of createIndex(). 432080 1 99663 haraken 2011-07-04 18:52:20 -0700 Created attachment 99663 Patch 432121 2 ap 2011-07-05 00:08:40 -0700 If WebKit behavior is incorrect, then it should be fixed, and regression test should be corrected to test for proper behavior. How does removing a test help? 432129 3 haraken 2011-07-05 00:27:45 -0700 > If WebKit behavior is incorrect, then it should be fixed, and regression test should be corrected to test for proper behavior. How does removing a test help? I am trying to fix a keypath parser in WebKit bug 62288, and then found that storage/indexeddb/mozilla/create-index-null-name.html fails with my patch. So I thought that we should first remove the test (because the test is against the spec) as another bug. If you think that I should remove the test in bug 62288, I would like to just close this bug and do it in bug 62288. 432132 4 ap 2011-07-05 00:34:02 -0700 Yes, we regularly make changes to code and tests in the same patch. That minimizes confusion when looking at the changes later (for example to study them, to revert or to merge on a branch). 432845 5 tony 2011-07-06 10:00:25 -0700 In addition to keeping the test changes with the code changes, can we update the test to reflect the correct behavior rather than removing it completely? 432849 6 ap 2011-07-06 10:08:21 -0700 > I would like to just close this bug and do it in bug 62288. So, let's do that. 433129 7 haraken 2011-07-06 17:11:11 -0700 (In reply to comment #5) > In addition to keeping the test changes with the code changes, can we update the test to reflect the correct behavior rather than removing it completely? Yes, I am doing this in bug 62288. In bug 62288, I removed create-index-null-name.html and instead added the test that reflects the correct behavior to keypath-basics.html. Closing this bug. 99663 2011-07-04 18:52:20 -0700 2011-07-06 10:08:27 -0700 Patch bug-63921-20110705105219.patch text/plain 4455 haraken U3VidmVyc2lvbiBSZXZpc2lvbjogOTAzNDcKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5n ZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCA3NWVjMjY0OWRiZGQzYTM4ZDk0OWYy Yjg1ZWEyZTczZTZhNjFlYTUwLi5mYWYwNGE4OTZlNDhmNDk0ZjM2ZDIyZTQ1ZGYwODBlMWU0YTYy M2FkIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMv Q2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTEtMDctMDQgIEtlbnRhcm8gSGFyYSAgPGhh cmFrZW5AZ29vZ2xlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICBSZW1vdmUgY3JlYXRlLWluZGV4LW51bGwtbmFtZS5odG1sCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02MzkyMQorCisgICAgICAgIEFj Y29yZGluZyB0byB0aGUgc3BlYywga2V5UGF0aCBvZiBjcmVhdGVJbmRleCgpIG11c3Qgbm90IGJl IG51bGxhYmxlLgorICAgICAgICBIb3dldmVyLCBjcmVhdGUtaW5kZXgtbnVsbC1uYW1lLmh0bWwg aXMgdHJ5aW5nIHRvIHRlc3QgdGhhdCBudWxsIGlzIGFjY2VwdGVkCisgICAgICAgIGFzIHRoZSBr ZXlQYXRoIG9mIGNyZWF0ZUluZGV4KCkuIFRodXMsIHJlbW92ZWQgdGhlIHRlc3QuCisKKyAgICAg ICAgKiBzdG9yYWdlL2luZGV4ZWRkYi9tb3ppbGxhL2NyZWF0ZS1pbmRleC1udWxsLW5hbWUtZXhw ZWN0ZWQudHh0OiBSZW1vdmVkLgorICAgICAgICAqIHN0b3JhZ2UvaW5kZXhlZGRiL21vemlsbGEv Y3JlYXRlLWluZGV4LW51bGwtbmFtZS5odG1sOiBSZW1vdmVkLgorCiAyMDExLTA3LTAxICBHYXZp biBCYXJyYWNsb3VnaCAgPGJhcnJhY2xvdWdoQGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZpZXdl ZCBieSBTYW0gV2VpbmlnLgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvc3RvcmFnZS9pbmRleGVk ZGIvbW96aWxsYS9jcmVhdGUtaW5kZXgtbnVsbC1uYW1lLWV4cGVjdGVkLnR4dCBiL0xheW91dFRl c3RzL3N0b3JhZ2UvaW5kZXhlZGRiL21vemlsbGEvY3JlYXRlLWluZGV4LW51bGwtbmFtZS1leHBl Y3RlZC50eHQKZGVsZXRlZCBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IGM0ZTY2MGU1YTAwYTZlYTc5 YTUyZDhkMTdlOTQ0MDc1OGU3ZDJlN2QuLjAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAKLS0tIGEvTGF5b3V0VGVzdHMvc3RvcmFnZS9pbmRleGVkZGIvbW96aWxsYS9jcmVh dGUtaW5kZXgtbnVsbC1uYW1lLWV4cGVjdGVkLnR4dAorKysgL2Rldi9udWxsCkBAIC0xLDIxICsw LDAgQEAKLVRlc3QgSW5kZXhlZERCJ3MgY3JlYXRpbmcgaW5kZXggd2l0aCBudWxsIG5hbWUKLQot T24gc3VjY2VzcywgeW91IHdpbGwgc2VlIGEgc2VyaWVzIG9mICJQQVNTIiBtZXNzYWdlcywgZm9s bG93ZWQgYnkgIlRFU1QgQ09NUExFVEUiLgotCi0KLWluZGV4ZWREQiA9IHdpbmRvdy5pbmRleGVk REIgfHwgd2luZG93LndlYmtpdEluZGV4ZWREQiB8fCB3aW5kb3cubW96SW5kZXhlZERCOwotUEFT UyBpbmRleGVkREIgPT0gbnVsbCBpcyBmYWxzZQotSURCRGF0YWJhc2VFeGNlcHRpb24gPSB3aW5k b3cuSURCRGF0YWJhc2VFeGNlcHRpb24gfHwgd2luZG93LndlYmtpdElEQkRhdGFiYXNlRXhjZXB0 aW9uOwotUEFTUyBJREJEYXRhYmFzZUV4Y2VwdGlvbiA9PSBudWxsIGlzIGZhbHNlCi1pbmRleGVk REIub3BlbihuYW1lLCBkZXNjcmlwdGlvbikKLWRiID0gZXZlbnQudGFyZ2V0LnJlc3VsdAotcmVx dWVzdCA9IGRiLnNldFZlcnNpb24oJzEnKQotRGVsZXRlZCBhbGwgb2JqZWN0IHN0b3Jlcy4KLW9i amVjdFN0b3JlID0gZGIuY3JlYXRlT2JqZWN0U3RvcmUoJ2EnLCB7IGtleVBhdGg6ICdpZCcsIGF1 dG9JbmNyZW1lbnQ6IHRydWUgfSk7Ci1pbmRleCA9IG9iamVjdFN0b3JlLmNyZWF0ZUluZGV4KG51 bGwsIG51bGwpOwotUEFTUyBpbmRleC5uYW1lIGlzICdudWxsJwotUEFTUyBpbmRleC5rZXlQYXRo IGlzICdudWxsJwotUEFTUyBzdWNjZXNzZnVsbHlQYXJzZWQgaXMgdHJ1ZQotCi1URVNUIENPTVBM RVRFCi0KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL3N0b3JhZ2UvaW5kZXhlZGRiL21vemlsbGEv Y3JlYXRlLWluZGV4LW51bGwtbmFtZS5odG1sIGIvTGF5b3V0VGVzdHMvc3RvcmFnZS9pbmRleGVk ZGIvbW96aWxsYS9jcmVhdGUtaW5kZXgtbnVsbC1uYW1lLmh0bWwKZGVsZXRlZCBmaWxlIG1vZGUg MTAwNjQ0CmluZGV4IDg4Y2MzYjJhNGVmMmIxN2RjZDA4NTQwZmFlZjMzZjEwNTcxYTljNjkuLjAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAKLS0tIGEvTGF5b3V0VGVzdHMv c3RvcmFnZS9pbmRleGVkZGIvbW96aWxsYS9jcmVhdGUtaW5kZXgtbnVsbC1uYW1lLmh0bWwKKysr IC9kZXYvbnVsbApAQCAtMSw2NyArMCwwIEBACi08IURPQ1RZUEUgaHRtbD4KLTwhLS0KLSAgb3Jp Z2luYWwgdGVzdDogaHR0cDovL214ci5tb3ppbGxhLm9yZy9tb3ppbGxhMi4wL3NvdXJjZS9kb20v aW5kZXhlZERCL3Rlc3QvdGVzdF9jcmVhdGVfaW5kZXguaHRtbAotICBsaWNlbnNlIG9mIG9yaWdp bmFsIHRlc3Q6Ci0gICAgIiBBbnkgY29weXJpZ2h0IGlzIGRlZGljYXRlZCB0byB0aGUgUHVibGlj IERvbWFpbi4KLSAgICAgIGh0dHA6Ly9jcmVhdGl2ZWNvbW1vbnMub3JnL3B1YmxpY2RvbWFpbi96 ZXJvLzEuMC8gIgotLS0+Ci08aHRtbD4KLTxoZWFkPgotPGxpbmsgcmVsPSJzdHlsZXNoZWV0IiBo cmVmPSIuLi8uLi8uLi9mYXN0L2pzL3Jlc291cmNlcy9qcy10ZXN0LXN0eWxlLmNzcyI+Ci08c2Ny aXB0IHNyYz0iLi4vLi4vLi4vZmFzdC9qcy9yZXNvdXJjZXMvanMtdGVzdC1wcmUuanMiPjwvc2Ny aXB0PgotPHNjcmlwdCBzcmM9Ii4uLy4uLy4uL2Zhc3QvanMvcmVzb3VyY2VzL2pzLXRlc3QtcG9z dC1mdW5jdGlvbi5qcyI+PC9zY3JpcHQ+Ci08c2NyaXB0IHNyYz0iLi4vcmVzb3VyY2VzL3NoYXJl ZC5qcyI+PC9zY3JpcHQ+Ci08L2hlYWQ+Ci08Ym9keT4KLTxwIGlkPSJkZXNjcmlwdGlvbiI+PC9w PgotPGRpdiBpZD0iY29uc29sZSI+PC9kaXY+Ci08c2NyaXB0PgotCi1kZXNjcmlwdGlvbigiVGVz dCBJbmRleGVkREIncyBjcmVhdGluZyBpbmRleCB3aXRoIG51bGwgbmFtZSIpOwotaWYgKHdpbmRv dy5sYXlvdXRUZXN0Q29udHJvbGxlcikKLSAgICBsYXlvdXRUZXN0Q29udHJvbGxlci53YWl0VW50 aWxEb25lKCk7Ci0KLWZ1bmN0aW9uIHRlc3QoKQotewotICAgIGluZGV4ZWREQiA9IGV2YWxBbmRM b2coImluZGV4ZWREQiA9IHdpbmRvdy5pbmRleGVkREIgfHwgd2luZG93LndlYmtpdEluZGV4ZWRE QiB8fCB3aW5kb3cubW96SW5kZXhlZERCOyIpOwotICAgIHNob3VsZEJlRmFsc2UoImluZGV4ZWRE QiA9PSBudWxsIik7Ci0gICAgSURCRGF0YWJhc2VFeGNlcHRpb24gPSBldmFsQW5kTG9nKCJJREJE YXRhYmFzZUV4Y2VwdGlvbiA9IHdpbmRvdy5JREJEYXRhYmFzZUV4Y2VwdGlvbiB8fCB3aW5kb3cu d2Via2l0SURCRGF0YWJhc2VFeGNlcHRpb247Iik7Ci0gICAgc2hvdWxkQmVGYWxzZSgiSURCRGF0 YWJhc2VFeGNlcHRpb24gPT0gbnVsbCIpOwotCi0gICAgbmFtZSA9IHdpbmRvdy5sb2NhdGlvbi5w YXRobmFtZTsKLSAgICBkZXNjcmlwdGlvbiA9ICJNeSBUZXN0IERhdGFiYXNlIjsKLSAgICByZXF1 ZXN0ID0gZXZhbEFuZExvZygiaW5kZXhlZERCLm9wZW4obmFtZSwgZGVzY3JpcHRpb24pIik7Ci0g ICAgcmVxdWVzdC5vbnN1Y2Nlc3MgPSBvcGVuU3VjY2VzczsKLSAgICByZXF1ZXN0Lm9uZXJyb3Ig PSB1bmV4cGVjdGVkRXJyb3JDYWxsYmFjazsKLX0KLQotZnVuY3Rpb24gb3BlblN1Y2Nlc3MoKQot ewotICAgIGRiID0gZXZhbEFuZExvZygiZGIgPSBldmVudC50YXJnZXQucmVzdWx0Iik7Ci0KLSAg ICByZXF1ZXN0ID0gZXZhbEFuZExvZygicmVxdWVzdCA9IGRiLnNldFZlcnNpb24oJzEnKSIpOwot ICAgIHJlcXVlc3Qub25zdWNjZXNzID0gY2xlYW5EYXRhYmFzZTsKLSAgICByZXF1ZXN0Lm9uZXJy b3IgPSB1bmV4cGVjdGVkRXJyb3JDYWxsYmFjazsKLX0KLQotZnVuY3Rpb24gY2xlYW5EYXRhYmFz ZSgpCi17Ci0gICAgZGVsZXRlQWxsT2JqZWN0U3RvcmVzKGRiKTsKLQotICAgIG9iamVjdFN0b3Jl ID0gZXZhbEFuZExvZygib2JqZWN0U3RvcmUgPSBkYi5jcmVhdGVPYmplY3RTdG9yZSgnYScsIHsg a2V5UGF0aDogJ2lkJywgYXV0b0luY3JlbWVudDogdHJ1ZSB9KTsiKTsKLQotICAgIGluZGV4ID0g ZXZhbEFuZExvZygiaW5kZXggPSBvYmplY3RTdG9yZS5jcmVhdGVJbmRleChudWxsLCBudWxsKTsi KTsKLSAgICBzaG91bGRCZSgiaW5kZXgubmFtZSIsICInbnVsbCciKTsKLSAgICBzaG91bGRCZSgi aW5kZXgua2V5UGF0aCIsICInbnVsbCciKTsKLQotICAgIGRvbmUoKTsKLX0KLQotdmFyIHN1Y2Nl c3NmdWxseVBhcnNlZCA9IHRydWU7Ci0KLXRlc3QoKTsKLQotPC9zY3JpcHQ+Ci08L2JvZHk+Ci08 L2h0bWw+Ci0K