63914 2011-07-04 11:20:19 -0700 SVGAnimateTransform does not support calcMode=discrete 2011-07-07 13:17:22 -0700 1 1 1 Unclassified WebKit SVG 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 64104 41761 37250 1 krit krit martin.hejral zimmermann oldest_to_newest 431999 0 krit 2011-07-04 11:20:19 -0700 SVGAnimateTransform does not support calcMode=discrete. I have a fix here, just unsure how to test. The animation testing API seems to be unstable for animateTransform. Sometimes the animation does not affect the transform of the target element. 433547 1 krit 2011-07-07 10:02:28 -0700 Can't create a regression test, see bug 64104. 433649 2 100017 krit 2011-07-07 12:24:36 -0700 Created attachment 100017 Patch 433659 3 100017 rwlbuis 2011-07-07 12:51:50 -0700 Comment on attachment 100017 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=100017&action=review Ok with some comments that you need to fix before landing. > Source/WebCore/ChangeLog:8 > + Apply transform at 0% of animation if current percentage is smaller than 0.5 and at 100% if not. Could be made more clear, you could start with Implement calcMode=discrete by... This sounds like a programmer speaking :) Try to incorporate the "This specifies that the animation function will jump from one value to the next without any interpolation." and why 0.5 was chosen. > Source/WebCore/ChangeLog:10 > + Added a manual test. DRT crashes on an automated test with the SVG animation API. Opened a new bug report: 64104. Could add the tracking bug for the animation framework problem. > Source/WebCore/manual-tests/svg-animateTransform-calcMode-discrete.svg:2 > +<text x="10" y="20">Testing calcMode="discrete" for &lt;animateTransform&gt;. The rect should move without an interpoalted translation after 2s.</text> interpoalted? Maybe reword a bit, maybe you can just use "jump" like in the spec definition. 433667 4 krit 2011-07-07 13:17:22 -0700 Committed r90585: <http://trac.webkit.org/changeset/90585> 100017 2011-07-07 12:24:36 -0700 2011-07-07 12:51:50 -0700 Patch bug-63914-20110707212434.patch text/plain 2266 krit SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDkwNTgzKQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTggQEAKKzIwMTEtMDctMDcgIERpcmsgU2No dWx6ZSAgPGtyaXRAd2Via2l0Lm9yZz4KKworICAgICAgICBTVkdBbmltYXRlVHJhbnNmb3JtIGRv ZXMgbm90IHN1cHBvcnQgY2FsY01vZGU9ZGlzY3JldGUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTYzOTE0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisgICAgICAgIAorICAgICAgICBBcHBseSB0cmFuc2Zvcm0gYXQgMCUgb2Yg YW5pbWF0aW9uIGlmIGN1cnJlbnQgcGVyY2VudGFnZSBpcyBzbWFsbGVyIHRoYW4gMC41IGFuZCBh dCAxMDAlIGlmIG5vdC4KKworICAgICAgICBBZGRlZCBhIG1hbnVhbCB0ZXN0LiBEUlQgY3Jhc2hl cyBvbiBhbiBhdXRvbWF0ZWQgdGVzdCB3aXRoIHRoZSBTVkcgYW5pbWF0aW9uIEFQSS4gT3BlbmVk IGEgbmV3IGJ1ZyByZXBvcnQ6IDY0MTA0LgorCisgICAgICAgICogbWFudWFsLXRlc3RzL3N2Zy1h bmltYXRlVHJhbnNmb3JtLWNhbGNNb2RlLWRpc2NyZXRlLnN2ZzogQWRkZWQuCisgICAgICAgICog c3ZnL1NWR0FuaW1hdGVUcmFuc2Zvcm1FbGVtZW50LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlNW R0FuaW1hdGVUcmFuc2Zvcm1FbGVtZW50OjpjYWxjdWxhdGVBbmltYXRlZFZhbHVlKToKKwogMjAx MS0wNy0wNyAgRGlyayBTY2h1bHplICA8a3JpdEB3ZWJraXQub3JnPgogCiAgICAgICAgIFJldmll d2VkIGJ5IFJvYiBCdWlzLgpJbmRleDogU291cmNlL1dlYkNvcmUvbWFudWFsLXRlc3RzL3N2Zy1h bmltYXRlVHJhbnNmb3JtLWNhbGNNb2RlLWRpc2NyZXRlLnN2Zwo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3Vy Y2UvV2ViQ29yZS9tYW51YWwtdGVzdHMvc3ZnLWFuaW1hdGVUcmFuc2Zvcm0tY2FsY01vZGUtZGlz Y3JldGUuc3ZnCShyZXZpc2lvbiAwKQorKysgU291cmNlL1dlYkNvcmUvbWFudWFsLXRlc3RzL3N2 Zy1hbmltYXRlVHJhbnNmb3JtLWNhbGNNb2RlLWRpc2NyZXRlLnN2ZwkocmV2aXNpb24gMCkKQEAg LTAsMCArMSw2IEBACis8c3ZnIHhtbG5zPSJodHRwOi8vd3d3LnczLm9yZy8yMDAwL3N2ZyI+Cis8 dGV4dCB4PSIxMCIgeT0iMjAiPlRlc3RpbmcgY2FsY01vZGU9ImRpc2NyZXRlIiBmb3IgJmx0O2Fu aW1hdGVUcmFuc2Zvcm0mZ3Q7LiBUaGUgcmVjdCBzaG91bGQgbW92ZSB3aXRob3V0IGFuIGludGVy cG9hbHRlZCB0cmFuc2xhdGlvbiBhZnRlciAycy48L3RleHQ+Cis8cmVjdCB5PSIzMCIgd2lkdGg9 IjEwMHB4IiBoZWlnaHQ9IjEwMHB4IiBmaWxsPSJncmVlbiI+CisgICAgPGFuaW1hdGVUcmFuc2Zv cm0gYXR0cmlidXRlTmFtZT0idHJhbnNmb3JtIiB0eXBlPSJ0cmFuc2xhdGUiIGZyb209IjAsMCIg dG89IjEwMCwwIiBjYWxjTW9kZT0iZGlzY3JldGUiIGZpbGw9ImZyZWV6ZSIgZHVyPSI0cyIvPgor PC9yZWN0PgorPC9zdmc+CkluZGV4OiBTb3VyY2UvV2ViQ29yZS9zdmcvU1ZHQW5pbWF0ZVRyYW5z Zm9ybUVsZW1lbnQuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3N2Zy9TVkdBbmlt YXRlVHJhbnNmb3JtRWxlbWVudC5jcHAJKHJldmlzaW9uIDkwNTU1KQorKysgU291cmNlL1dlYkNv cmUvc3ZnL1NWR0FuaW1hdGVUcmFuc2Zvcm1FbGVtZW50LmNwcAkod29ya2luZyBjb3B5KQpAQCAt MTU4LDYgKzE1OCw5IEBAIHZvaWQgU1ZHQW5pbWF0ZVRyYW5zZm9ybUVsZW1lbnQ6OmNhbGN1bGEK ICAgICAgICAgcmV0dXJuOwogICAgIFNWR1RyYW5zZm9ybUxpc3QqIHRyYW5zZm9ybUxpc3QgPSB0 cmFuc2Zvcm1MaXN0Rm9yKHRhcmdldEVsZW1lbnQpOwogICAgIEFTU0VSVCh0cmFuc2Zvcm1MaXN0 KTsKKyAgICAKKyAgICBpZiAoY2FsY01vZGUoKSA9PSBDYWxjTW9kZURpc2NyZXRlKQorICAgICAg ICBwZXJjZW50YWdlID0gcGVyY2VudGFnZSA8IDAuNSA/IDAgOiAxOwogCiAgICAgaWYgKCFpc0Fk ZGl0aXZlKCkpCiAgICAgICAgIHRyYW5zZm9ybUxpc3QtPmNsZWFyKCk7Cg==