63831 2011-07-01 12:32:27 -0700 [Qt] Fix build when --media-stream flag is used 2011-07-04 03:57:04 -0700 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED Qt P2 Normal --- 0 danilo.eu webkit-unassigned ademar igor.oliveira webkit.review.bot oldest_to_newest 431349 0 danilo.eu 2011-07-01 12:32:27 -0700 Fixing Qt port build when media-stream flag is enabled. 431351 1 99505 danilo.eu 2011-07-01 12:33:54 -0700 Created attachment 99505 diff adding the new rule on features.pri Forgot the patch 431354 2 webkit.review.bot 2011-07-01 12:36:22 -0700 Attachment 99505 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebCore/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 431357 3 99507 danilo.eu 2011-07-01 12:40:48 -0700 Created attachment 99507 mediastreamflag.patch 431372 4 igor.oliveira 2011-07-01 13:02:33 -0700 You should remove the "No new tests" line because Commit Bot can complain. And add [Qt] tag in the beginning of commit title. (In reply to comment #3) > Created an attachment (id=99507) [details] > mediastreamflag.patch 431385 5 ademar 2011-07-01 13:13:21 -0700 from build-webkit --help: --[no-]media-stream Toggle Media Stream API support (implies Blob support, currently Chromium and GTK only) (default: 0) Do you get anything useful on Qt with --media-stream? If yes, then maybe your patch should also remove this note from build-webkit. 431424 6 99519 danilo.eu 2011-07-01 14:06:14 -0700 Created attachment 99519 mediastream.patch Fixing commit message. 431872 7 webkit.review.bot 2011-07-04 03:55:37 -0700 The commit-queue encountered the following flaky tests while processing attachment 99519: http/tests/local/blob/send-sliced-data-blob.html bug 63598 (author: kinuko@chromium.org) The commit-queue is continuing to process your patch. 431873 8 99519 webkit.review.bot 2011-07-04 03:57:00 -0700 Comment on attachment 99519 mediastream.patch Clearing flags on attachment: 99519 Committed r90359: <http://trac.webkit.org/changeset/90359> 431874 9 webkit.review.bot 2011-07-04 03:57:04 -0700 All reviewed patches have been landed. Closing bug. 99505 2011-07-01 12:33:54 -0700 2011-07-01 12:40:48 -0700 diff adding the new rule on features.pri mediastream.patch text/plain 1985 danilo.eu ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCAxZDUwMmU5Li5hMGU5Zjc3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMg QEAKKzIwMTEtMDctMDEgIERhbmlsbyBDZXNhciBMZW1lcyBkZSBQYXVsYSAgPGRhbmlsby5jZXNh ckBjb2xsYWJvcmEuY28udWs+CisKKyAgICAgICAgRml4aW5nIFF0IHBvcnQgYnVpbCB3aXRoIC0t bWVkaWEtc3RyZWFtIGZsYWcgZW5hYmxlZAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIE5vIG5ldyB0ZXN0cy4gKE9PUFMhKQorCisgICAgICAgICogZmVh dHVyZXMucHJpOiBBZGRpbmcgc3VwcG9ydCB0byBFTkFCTEVfTUVESUFfU1RSRUFNIGZsYWcuCisK IDIwMTEtMDctMDEgIEtlbnRhcm8gSGFyYSAgPGhhcmFrZW5AZ29vZ2xlLmNvbT4KIAogICAgICAg ICBSZXZpZXdlZCBieSBLZW50IFRhbXVyYS4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2Zl YXR1cmVzLnByaSBiL1NvdXJjZS9XZWJDb3JlL2ZlYXR1cmVzLnByaQppbmRleCBlNDk5OGRhLi5m MGJmYTY1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9mZWF0dXJlcy5wcmkKKysrIGIvU291 cmNlL1dlYkNvcmUvZmVhdHVyZXMucHJpCkBAIC05MCw2ICs5MCw3IEBAIGNvbnRhaW5zKERFRklO RVMsIEVOQUJMRV9TSU5HTEVfVEhSRUFERUQ9MSkgewogIWNvbnRhaW5zKERFRklORVMsIEVOQUJM RV9XRUJfQVVESU89Lik6IERFRklORVMgKz0gRU5BQkxFX1dFQl9BVURJTz0wCiAhY29udGFpbnMo REVGSU5FUywgRU5BQkxFX1dFQkdMPS4pOiBERUZJTkVTICs9IEVOQUJMRV9XRUJHTD0wCiAhY29u dGFpbnMoREVGSU5FUywgRU5BQkxFX01FRElBX1NUQVRJU1RJQ1M9Lik6IERFRklORVMgKz0gRU5B QkxFX01FRElBX1NUQVRJU1RJQ1M9MAorIWNvbnRhaW5zKERFRklORVMsIEVOQUJMRV9NRURJQV9T VFJFQU09Lik6IERFRklORVMgKz0gRU5BQkxFX01FRElBX1NUUkVBTT0wCiAhY29udGFpbnMoREVG SU5FUywgRU5BQkxFX1ZJREVPX1RSQUNLPS4pOiBERUZJTkVTICs9IEVOQUJMRV9WSURFT19UUkFD Sz0wCiAhY29udGFpbnMoREVGSU5FUywgRU5BQkxFX1RPVUNIX0lDT05fTE9BRElORz0uKTogREVG SU5FUyArPSBFTkFCTEVfVE9VQ0hfSUNPTl9MT0FESU5HPTAKICFjb250YWlucyhERUZJTkVTLCBF TkFCTEVfQU5JTUFUSU9OX0FQST0uKTogREVGSU5FUyArPSBFTkFCTEVfQU5JTUFUSU9OX0FQST0w CkBAIC0yNDksNSArMjUwLDYgQEAgY29udGFpbnMoREVGSU5FUywgRU5BQkxFX1BST0dSRVNTX1RB Rz0xKTogRkVBVFVSRV9ERUZJTkVTX0pBVkFTQ1JJUFQgKz0gRU5BQkxFX1AKIGNvbnRhaW5zKERF RklORVMsIEVOQUJMRV9HRU9MT0NBVElPTj0xKTogRkVBVFVSRV9ERUZJTkVTX0pBVkFTQ1JJUFQg Kz0gRU5BQkxFX0dFT0xPQ0FUSU9OPTEKIGNvbnRhaW5zKERFRklORVMsIEVOQUJMRV9CTE9CPTEp OiBGRUFUVVJFX0RFRklORVNfSkFWQVNDUklQVCArPSBFTkFCTEVfQkxPQj0xCiBjb250YWlucyhE RUZJTkVTLCBFTkFCTEVfTUVESUFfU1RBVElTVElDUz0xKTogRkVBVFVSRV9ERUZJTkVTX0pBVkFT Q1JJUFQgKz0gRU5BQkxFX01FRElBX1NUQVRJU1RJQ1M9MQorY29udGFpbnMoREVGSU5FUywgRU5B QkxFX01FRElBX1NUUkVBTT0xKTogRkVBVFVSRV9ERUZJTkVTX0pBVkFTQ1JJUFQgKz0gRU5BQkxF X01FRElBX1NUUkVBTT0xCiBjb250YWlucyhERUZJTkVTLCBFTkFCTEVfVklERU9fVFJBQ0s9MSk6 IEZFQVRVUkVfREVGSU5FU19KQVZBU0NSSVBUICs9IEVOQUJMRV9WSURFT19UUkFDSz0xCiBjb250 YWlucyhERUZJTkVTLCBFTkFCTEVfREFUQV9UUkFOU0ZFUl9JVEVNUz0xKTogRkVBVFVSRV9ERUZJ TkVTX0pBVkFTQ1JJUFQgKz0gRU5BQkxFX0RBVEFfVFJBTlNGRVJfSVRFTVM9MQo= 99507 2011-07-01 12:40:48 -0700 2011-07-01 14:06:14 -0700 mediastreamflag.patch mediastream.patch text/plain 2040 danilo.eu ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCAxZDUwMmU5Li5kNDhjZDExIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQg QEAKKzIwMTEtMDctMDEgIERhbmlsbyBDZXNhciBMZW1lcyBkZSBQYXVsYSAgPGRhbmlsby5jZXNh ckBjb2xsYWJvcmEuY28udWs+CisKKyAgICAgICAgRml4aW5nIFF0IHBvcnQgYnVpbCB3aXRoIC0t bWVkaWEtc3RyZWFtIGZsYWcgZW5hYmxlZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9NjM4MzEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBObyBuZXcgdGVzdHMuIChPT1BTISkKKworICAgICAgICAqIGZlYXR1 cmVzLnByaTogQWRkaW5nIHN1cHBvcnQgdG8gRU5BQkxFX01FRElBX1NUUkVBTSBmbGFnLgorCiAy MDExLTA3LTAxICBLZW50YXJvIEhhcmEgIDxoYXJha2VuQGdvb2dsZS5jb20+CiAKICAgICAgICAg UmV2aWV3ZWQgYnkgS2VudCBUYW11cmEuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9mZWF0 dXJlcy5wcmkgYi9Tb3VyY2UvV2ViQ29yZS9mZWF0dXJlcy5wcmkKaW5kZXggZTQ5OThkYS4uZjBi ZmE2NSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvZmVhdHVyZXMucHJpCisrKyBiL1NvdXJj ZS9XZWJDb3JlL2ZlYXR1cmVzLnByaQpAQCAtOTAsNiArOTAsNyBAQCBjb250YWlucyhERUZJTkVT LCBFTkFCTEVfU0lOR0xFX1RIUkVBREVEPTEpIHsKICFjb250YWlucyhERUZJTkVTLCBFTkFCTEVf V0VCX0FVRElPPS4pOiBERUZJTkVTICs9IEVOQUJMRV9XRUJfQVVESU89MAogIWNvbnRhaW5zKERF RklORVMsIEVOQUJMRV9XRUJHTD0uKTogREVGSU5FUyArPSBFTkFCTEVfV0VCR0w9MAogIWNvbnRh aW5zKERFRklORVMsIEVOQUJMRV9NRURJQV9TVEFUSVNUSUNTPS4pOiBERUZJTkVTICs9IEVOQUJM RV9NRURJQV9TVEFUSVNUSUNTPTAKKyFjb250YWlucyhERUZJTkVTLCBFTkFCTEVfTUVESUFfU1RS RUFNPS4pOiBERUZJTkVTICs9IEVOQUJMRV9NRURJQV9TVFJFQU09MAogIWNvbnRhaW5zKERFRklO RVMsIEVOQUJMRV9WSURFT19UUkFDSz0uKTogREVGSU5FUyArPSBFTkFCTEVfVklERU9fVFJBQ0s9 MAogIWNvbnRhaW5zKERFRklORVMsIEVOQUJMRV9UT1VDSF9JQ09OX0xPQURJTkc9Lik6IERFRklO RVMgKz0gRU5BQkxFX1RPVUNIX0lDT05fTE9BRElORz0wCiAhY29udGFpbnMoREVGSU5FUywgRU5B QkxFX0FOSU1BVElPTl9BUEk9Lik6IERFRklORVMgKz0gRU5BQkxFX0FOSU1BVElPTl9BUEk9MApA QCAtMjQ5LDUgKzI1MCw2IEBAIGNvbnRhaW5zKERFRklORVMsIEVOQUJMRV9QUk9HUkVTU19UQUc9 MSk6IEZFQVRVUkVfREVGSU5FU19KQVZBU0NSSVBUICs9IEVOQUJMRV9QCiBjb250YWlucyhERUZJ TkVTLCBFTkFCTEVfR0VPTE9DQVRJT049MSk6IEZFQVRVUkVfREVGSU5FU19KQVZBU0NSSVBUICs9 IEVOQUJMRV9HRU9MT0NBVElPTj0xCiBjb250YWlucyhERUZJTkVTLCBFTkFCTEVfQkxPQj0xKTog RkVBVFVSRV9ERUZJTkVTX0pBVkFTQ1JJUFQgKz0gRU5BQkxFX0JMT0I9MQogY29udGFpbnMoREVG SU5FUywgRU5BQkxFX01FRElBX1NUQVRJU1RJQ1M9MSk6IEZFQVRVUkVfREVGSU5FU19KQVZBU0NS SVBUICs9IEVOQUJMRV9NRURJQV9TVEFUSVNUSUNTPTEKK2NvbnRhaW5zKERFRklORVMsIEVOQUJM RV9NRURJQV9TVFJFQU09MSk6IEZFQVRVUkVfREVGSU5FU19KQVZBU0NSSVBUICs9IEVOQUJMRV9N RURJQV9TVFJFQU09MQogY29udGFpbnMoREVGSU5FUywgRU5BQkxFX1ZJREVPX1RSQUNLPTEpOiBG RUFUVVJFX0RFRklORVNfSkFWQVNDUklQVCArPSBFTkFCTEVfVklERU9fVFJBQ0s9MQogY29udGFp bnMoREVGSU5FUywgRU5BQkxFX0RBVEFfVFJBTlNGRVJfSVRFTVM9MSk6IEZFQVRVUkVfREVGSU5F U19KQVZBU0NSSVBUICs9IEVOQUJMRV9EQVRBX1RSQU5TRkVSX0lURU1TPTEK 99519 2011-07-01 14:06:14 -0700 2011-07-04 03:57:00 -0700 mediastream.patch mediastream.patch text/plain 2005 danilo.eu ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCAxZDUwMmU5Li4wMmYzNzEwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIg QEAKKzIwMTEtMDctMDEgIERhbmlsbyBDZXNhciBMZW1lcyBkZSBQYXVsYSAgPGRhbmlsby5jZXNh ckBjb2xsYWJvcmEuY28udWs+CisKKyAgICAgICAgW1F0XSBGaXhpbmcgYnVpbGQgd2l0aCAtLW1l ZGlhLXN0cmVhbSBmbGFnIGVuYWJsZWQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTYzODMxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgKiBmZWF0dXJlcy5wcmk6IEFkZGluZyBzdXBwb3J0IHRvIEVOQUJMRV9N RURJQV9TVFJFQU0gZmxhZy4KKwogMjAxMS0wNy0wMSAgS2VudGFybyBIYXJhICA8aGFyYWtlbkBn b29nbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEtlbnQgVGFtdXJhLgpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYkNvcmUvZmVhdHVyZXMucHJpIGIvU291cmNlL1dlYkNvcmUvZmVhdHVyZXMu cHJpCmluZGV4IGU0OTk4ZGEuLmYwYmZhNjUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2Zl YXR1cmVzLnByaQorKysgYi9Tb3VyY2UvV2ViQ29yZS9mZWF0dXJlcy5wcmkKQEAgLTkwLDYgKzkw LDcgQEAgY29udGFpbnMoREVGSU5FUywgRU5BQkxFX1NJTkdMRV9USFJFQURFRD0xKSB7CiAhY29u dGFpbnMoREVGSU5FUywgRU5BQkxFX1dFQl9BVURJTz0uKTogREVGSU5FUyArPSBFTkFCTEVfV0VC X0FVRElPPTAKICFjb250YWlucyhERUZJTkVTLCBFTkFCTEVfV0VCR0w9Lik6IERFRklORVMgKz0g RU5BQkxFX1dFQkdMPTAKICFjb250YWlucyhERUZJTkVTLCBFTkFCTEVfTUVESUFfU1RBVElTVElD Uz0uKTogREVGSU5FUyArPSBFTkFCTEVfTUVESUFfU1RBVElTVElDUz0wCishY29udGFpbnMoREVG SU5FUywgRU5BQkxFX01FRElBX1NUUkVBTT0uKTogREVGSU5FUyArPSBFTkFCTEVfTUVESUFfU1RS RUFNPTAKICFjb250YWlucyhERUZJTkVTLCBFTkFCTEVfVklERU9fVFJBQ0s9Lik6IERFRklORVMg Kz0gRU5BQkxFX1ZJREVPX1RSQUNLPTAKICFjb250YWlucyhERUZJTkVTLCBFTkFCTEVfVE9VQ0hf SUNPTl9MT0FESU5HPS4pOiBERUZJTkVTICs9IEVOQUJMRV9UT1VDSF9JQ09OX0xPQURJTkc9MAog IWNvbnRhaW5zKERFRklORVMsIEVOQUJMRV9BTklNQVRJT05fQVBJPS4pOiBERUZJTkVTICs9IEVO QUJMRV9BTklNQVRJT05fQVBJPTAKQEAgLTI0OSw1ICsyNTAsNiBAQCBjb250YWlucyhERUZJTkVT LCBFTkFCTEVfUFJPR1JFU1NfVEFHPTEpOiBGRUFUVVJFX0RFRklORVNfSkFWQVNDUklQVCArPSBF TkFCTEVfUAogY29udGFpbnMoREVGSU5FUywgRU5BQkxFX0dFT0xPQ0FUSU9OPTEpOiBGRUFUVVJF X0RFRklORVNfSkFWQVNDUklQVCArPSBFTkFCTEVfR0VPTE9DQVRJT049MQogY29udGFpbnMoREVG SU5FUywgRU5BQkxFX0JMT0I9MSk6IEZFQVRVUkVfREVGSU5FU19KQVZBU0NSSVBUICs9IEVOQUJM RV9CTE9CPTEKIGNvbnRhaW5zKERFRklORVMsIEVOQUJMRV9NRURJQV9TVEFUSVNUSUNTPTEpOiBG RUFUVVJFX0RFRklORVNfSkFWQVNDUklQVCArPSBFTkFCTEVfTUVESUFfU1RBVElTVElDUz0xCitj b250YWlucyhERUZJTkVTLCBFTkFCTEVfTUVESUFfU1RSRUFNPTEpOiBGRUFUVVJFX0RFRklORVNf SkFWQVNDUklQVCArPSBFTkFCTEVfTUVESUFfU1RSRUFNPTEKIGNvbnRhaW5zKERFRklORVMsIEVO QUJMRV9WSURFT19UUkFDSz0xKTogRkVBVFVSRV9ERUZJTkVTX0pBVkFTQ1JJUFQgKz0gRU5BQkxF X1ZJREVPX1RSQUNLPTEKIGNvbnRhaW5zKERFRklORVMsIEVOQUJMRV9EQVRBX1RSQU5TRkVSX0lU RU1TPTEpOiBGRUFUVVJFX0RFRklORVNfSkFWQVNDUklQVCArPSBFTkFCTEVfREFUQV9UUkFOU0ZF Ul9JVEVNUz0xCg==