63704 2011-06-30 05:39:21 -0700 WebSocket: Don't use old Hixie75 handshake in pywebsocket handlers 2011-07-01 01:17:13 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 62795 1 yutak yutak abarth ap tkent webkit.review.bot oldest_to_newest 430335 0 yutak 2011-06-30 05:39:21 -0700 Some pywebsocket handlers still use old Hixie75 handshake format, while our implementation supports Hixie76 format. Fix them. 430348 1 99282 yutak 2011-06-30 06:13:31 -0700 Created attachment 99282 Patch 430931 2 99282 tkent 2011-06-30 19:09:00 -0700 Comment on attachment 99282 Patch Why have the existing tests worked with the older handshake? 430945 3 webkit.review.bot 2011-06-30 19:54:23 -0700 The commit-queue encountered the following flaky tests while processing attachment 99282: http/tests/local/blob/send-sliced-data-blob.html bug 63598 (author: kinuko@chromium.org) The commit-queue is continuing to process your patch. 430948 4 99282 webkit.review.bot 2011-06-30 19:56:04 -0700 Comment on attachment 99282 Patch Clearing flags on attachment: 99282 Committed r90196: <http://trac.webkit.org/changeset/90196> 430949 5 webkit.review.bot 2011-06-30 19:56:08 -0700 All reviewed patches have been landed. Closing bug. 430974 6 yutak 2011-06-30 22:03:26 -0700 (In reply to comment #2) > (From update of attachment 99282 [details]) > Why have the existing tests worked with the older handshake? The tests fail before WebSocketChannel checks handshake format of server's response. So they worked regardless of the handshake format. There is no reason to leave the older handshake in tests, so I wrote this patch. Thank you for your review! 430977 7 yutak 2011-06-30 22:10:43 -0700 I should have said "the tests finish" instead of "the tests fail". (Failing the connection is expected result for these tests.) 99282 2011-06-30 06:13:31 -0700 2011-06-30 19:56:04 -0700 Patch bug-63704-20110630221329.patch text/plain 2645 yutak U3VidmVyc2lvbiBSZXZpc2lvbjogOTAxMDYKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5n ZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCBmNWM3MDM5NWUyOGNmZWFmYzllN2Fl OTI3MzlkYjdiOWNhZmJjOWYwLi43Njk3ZDVlYmNiYjVlZDI4ZDg5ZmZmMzFjMTMzZDgxMGQyNGYw ZjlkIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMv Q2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTEtMDYtMzAgIFl1dGEgS2l0YW11cmEgIDx5 dXRha0BjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgV2ViU29ja2V0OiBEb24ndCB1c2Ugb2xkIEhpeGllNzUgaGFuZHNoYWtlIGlu IHB5d2Vic29ja2V0IGhhbmRsZXJzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD02MzcwNAorCisgICAgICAgICogaHR0cC90ZXN0cy93ZWJzb2NrZXQvdGVz dHMvYmFkLWhhbmRzaGFrZS1jcmFzaF93c2gucHk6CisgICAgICAgIFVzZSBoYW5kc2hha2UgZm9y bWF0IG9mIEhpeGllJ3MgcHJvdG9jb2wgZHJhZnQgNzYgd2hpY2ggd2UgYXJlIGN1cnJlbnRseSBz dXBwb3J0aW5nLgorICAgICAgICAqIGh0dHAvdGVzdHMvd2Vic29ja2V0L3Rlc3RzL2xvbmctaW52 YWxpZC1oZWFkZXJfd3NoLnB5OgorICAgICAgICBDb250ZW50IG9mIHdlYl9zb2NrZXRfdHJhbnNm ZXJfZGF0YSgpIGlzIGNvbXBsZXRlbHkgYm9ndXMuIEl0J3Mgbm90IG5lY2Vzc2FyeS4KKwogMjAx MS0wNi0zMCAgUGhpbGlwcGUgTm9ybWFuZCAgPHBub3JtYW5kQGlnYWxpYS5jb20+CiAKICAgICAg ICAgVW5yZXZpZXdlZCwgc2tpcCBhIGZhaWxpbmcgbWVkaWEgdGVzdCBvbiBHVEsgYmVjYXVzZSBv ZgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvaHR0cC90ZXN0cy93ZWJzb2NrZXQvdGVzdHMvYmFk LWhhbmRzaGFrZS1jcmFzaF93c2gucHkgYi9MYXlvdXRUZXN0cy9odHRwL3Rlc3RzL3dlYnNvY2tl dC90ZXN0cy9iYWQtaGFuZHNoYWtlLWNyYXNoX3dzaC5weQppbmRleCA1MGRkNjllYjI3NTA2Njg1 Yjk1MTIxZDlmMzhkMGQwYmRkYjIzM2ZiLi43NGFhOTJlYjc1MjQxYTM4NTNiYWY1NmZkOGM0ZGYx MjQ0ODgwZDk2IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9odHRwL3Rlc3RzL3dlYnNvY2tldC90 ZXN0cy9iYWQtaGFuZHNoYWtlLWNyYXNoX3dzaC5weQorKysgYi9MYXlvdXRUZXN0cy9odHRwL3Rl c3RzL3dlYnNvY2tldC90ZXN0cy9iYWQtaGFuZHNoYWtlLWNyYXNoX3dzaC5weQpAQCAtMSw5ICsx LDEyIEBACiBkZWYgd2ViX3NvY2tldF9kb19leHRyYV9oYW5kc2hha2UocmVxdWVzdCk6Ci0gICAg bXNnID0gIkhUVFAvMS4xIDEwMSBXZWIgU29ja2V0IFByb3RvY29sIEhhbmRzaGFrZVxyXG4iCisg ICAgbXNnID0gIkhUVFAvMS4xIDEwMSBXZWJTb2NrZXQgUHJvdG9jb2wgSGFuZHNoYWtlXHJcbiIK ICAgICBtc2cgKz0gIlVwZ3JhZGU6IFdlYlNvY2tldFxyXG4iCiAgICAgbXNnICs9ICJDb25uZWN0 aW9uOiBVcGdyYWRlXHJcbiIKKyAgICBtc2cgKz0gIlNlYy1XZWJTb2NrZXQtTG9jYXRpb246ICIg KyByZXF1ZXN0LndzX2xvY2F0aW9uICsgIlxyXG4iCisgICAgbXNnICs9ICJTZWMtV2ViU29ja2V0 LU9yaWdpbjogIiArIHJlcXVlc3Qud3Nfb3JpZ2luICsgIlxyXG4iCiAgICAgbXNnICs9ICJceGE1 OlxyXG4iCiAgICAgbXNnICs9ICJcclxuIgorICAgIG1zZyArPSByZXF1ZXN0LndzX2NoYWxsZW5n ZV9tZDUKICAgICByZXF1ZXN0LmNvbm5lY3Rpb24ud3JpdGUobXNnKQogICAgIHByaW50IG1zZwog CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9odHRwL3Rlc3RzL3dlYnNvY2tldC90ZXN0cy9sb25n LWludmFsaWQtaGVhZGVyX3dzaC5weSBiL0xheW91dFRlc3RzL2h0dHAvdGVzdHMvd2Vic29ja2V0 L3Rlc3RzL2xvbmctaW52YWxpZC1oZWFkZXJfd3NoLnB5CmluZGV4IGE5ZjIwNTNhNGU2NmY1NTIz NGI2ZWUwODQyNWY0MDdhNmRlNzViYTAuLjM4ODdhYjY0NWQyNGI3ZDc5ZmI3OGMyMTgxNzg5NTZl M2U3NDQzZjQgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL2h0dHAvdGVzdHMvd2Vic29ja2V0L3Rl c3RzL2xvbmctaW52YWxpZC1oZWFkZXJfd3NoLnB5CisrKyBiL0xheW91dFRlc3RzL2h0dHAvdGVz dHMvd2Vic29ja2V0L3Rlc3RzL2xvbmctaW52YWxpZC1oZWFkZXJfd3NoLnB5CkBAIC0xLDEwICsx LDggQEAKIGRlZiB3ZWJfc29ja2V0X2RvX2V4dHJhX2hhbmRzaGFrZShyZXF1ZXN0KToKLSAgICBt c2cgPSAiSFRUUC8xLjEgMTAxIFdlYiBTb2NrZXQgUHJvdG9jb2wgSGFuZHNoYWtlXHJcbiIKKyAg ICBtc2cgPSAiSFRUUC8xLjEgMTAxIFdlYlNvY2tldCBQcm90b2NvbCBIYW5kc2hha2VcclxuIgog ICAgIG1zZyArPSAoInAiICogMTAyNCkgKyAiXHJcbiIKICAgICByZXF1ZXN0LmNvbm5lY3Rpb24u d3JpdGUobXNnKQogCiAKIGRlZiB3ZWJfc29ja2V0X3RyYW5zZmVyX2RhdGEocmVxdWVzdCk6Ci0g ICAgbXNnID0gIkhUVFAvMS4xIDEwMSBXZWIgU29ja2V0IFByb3RvY29sIEhhbmRzaGFrZVxyXG4i Ci0gICAgbXNnICs9ICgicCIgKiAxMDI0KSArICJcclxuIgotICAgIHJlcXVlc3QuY29ubmVjdGlv bi53cml0ZShtc2cpCisgICAgcGFzcwo=