63608 2011-06-28 22:33:33 -0700 [EFL][WK2] Add ModuleEfl.cpp 2012-02-07 03:45:51 -0800 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Other Linux RESOLVED FIXED P2 Normal --- 76255 61838 0 youngtaeck.song webkit-unassigned gyuyoung.kim kling lucas.de.marchi rakuco ryuan.choi t.morawski webkit.review.bot oldest_to_newest 429431 0 youngtaeck.song 2011-06-28 22:33:33 -0700 Add First version of ModuleEfl.cpp for WebKit2 492263 1 t.morawski 2011-10-27 23:25:47 -0700 (In reply to comment #0) > Add First version of ModuleEfl.cpp for WebKit2 I seems that you have not added your patch. Could you please add it. 528715 2 120927 youngtaeck.song 2012-01-03 03:47:07 -0800 Created attachment 120927 patch for ModuleEfl 528723 3 rakuco 2012-01-03 04:28:08 -0800 Looks OK. 529143 4 120927 gyuyoung.kim 2012-01-03 16:29:04 -0800 Comment on attachment 120927 patch for ModuleEfl LGTM too. 533581 5 120927 ryuan.choi 2012-01-10 19:32:11 -0800 Comment on attachment 120927 patch for ModuleEfl View in context: https://bugs.webkit.org/attachment.cgi?id=120927&action=review > Source/WebKit2/Platform/efl/ModuleEfl.cpp:51 > + void* symbolPointer = 0; > + > + if (m_module) > + symbolPointer = eina_module_symbol_get(m_module, functionName); > + > + return symbolPointer; Almost looks good to me. As small thing, below is clear for me. if (m_module) return eina_module_symbol_get(m_module, functionName); return 0; 533640 6 youngtaeck.song 2012-01-10 22:20:26 -0800 (In reply to comment #5) > (From update of attachment 120927 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=120927&action=review > > > Source/WebKit2/Platform/efl/ModuleEfl.cpp:51 > > + void* symbolPointer = 0; > > + > > + if (m_module) > > + symbolPointer = eina_module_symbol_get(m_module, functionName); > > + > > + return symbolPointer; > > Almost looks good to me. > > As small thing, below is clear for me. > if (m_module) > return eina_module_symbol_get(m_module, functionName); > > return 0; Sorry. I don't agree with you. because platformFunctionPointer relies on the eina_module_symbol_get, My code is more clear. 533683 7 121985 youngtaeck.song 2012-01-10 23:50:14 -0800 Created attachment 121985 patch for ModuleEfl 533691 8 ryuan.choi 2012-01-10 23:58:25 -0800 (In reply to comment #7) > Created an attachment (id=121985) [details] > patch for ModuleEfl LGTM, too. 534629 9 121985 kling 2012-01-12 00:45:39 -0800 Comment on attachment 121985 patch for ModuleEfl View in context: https://bugs.webkit.org/attachment.cgi?id=121985&action=review > Source/WebKit2/Platform/efl/ModuleEfl.cpp:33 > + m_module = eina_module_new(m_path.utf8().data()); > + if (m_module && eina_module_load(m_module)) > + return true; > + > + return false; If eina_module_load() fails, don't you need to call eina_module_free() before returning false? > Source/WebKit2/Platform/efl/ModuleEfl.cpp:41 > + if (m_module) { > + eina_module_unload(m_module); > + m_module = 0; > + } Is it safe to call eina_module_unload() here if m_module is non-null, but eina_module_load() failed in Module::load()? > Source/WebKit2/Platform/efl/ModuleEfl.cpp:47 > + if (m_module) > + return eina_module_symbol_get(m_module, functionName); Is it safe to call eina_module_symbol_get() here if m_module is non-null, but eina_module_load() failed in Module::load()? 534641 10 ryuan.choi 2012-01-12 01:10:58 -0800 (In reply to comment #9) > (From update of attachment 121985 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=121985&action=review > > > Source/WebKit2/Platform/efl/ModuleEfl.cpp:33 > > + m_module = eina_module_new(m_path.utf8().data()); > > + if (m_module && eina_module_load(m_module)) > > + return true; > > + > > + return false; > > If eina_module_load() fails, don't you need to call eina_module_free() before returning false? > You are right. I checked eina_module, so your point looks correct. And also, nobody calls eina_module_free. > > Source/WebKit2/Platform/efl/ModuleEfl.cpp:41 > > + if (m_module) { > > + eina_module_unload(m_module); > > + m_module = 0; > > + } > > Is it safe to call eina_module_unload() here if m_module is non-null, but eina_module_load() failed in Module::load()? > > > Source/WebKit2/Platform/efl/ModuleEfl.cpp:47 > > + if (m_module) > > + return eina_module_symbol_get(m_module, functionName); > > Is it safe to call eina_module_symbol_get() here if m_module is non-null, but eina_module_load() failed in Module::load()? It is safe because eina_module_symbol_get take care of it. However, we'd better to make it clear in this patch. 534650 11 ryuan.choi 2012-01-12 01:34:52 -0800 After thinking more, It looks good to use OwnPtr<Eina_Module>. youngtaeck, could you make a bug to introduce OwnPtr<Eina_Module> ? 535543 12 youngtaeck.song 2012-01-13 02:19:55 -0800 (In reply to comment #11) > After thinking more, > It looks good to use OwnPtr<Eina_Module>. > > youngtaeck, > could you make a bug to introduce OwnPtr<Eina_Module> ? Thank. I make a bug for OwnPtr<Eina_Module>, 76255. and I attached new patch using OwnPtr. 535545 13 122401 youngtaeck.song 2012-01-13 02:20:43 -0800 Created attachment 122401 patch for ModuleEfl 550762 14 ryuan.choi 2012-02-07 02:58:53 -0800 (In reply to comment #13) > Created an attachment (id=122401) [details] > patch for ModuleEfl Added kling in CCs. Could you take a look at this bug once more ? 550764 15 122401 kling 2012-02-07 03:03:49 -0800 Comment on attachment 122401 patch for ModuleEfl View in context: https://bugs.webkit.org/attachment.cgi?id=122401&action=review r=me, with two suggestions: > Source/WebKit2/Platform/efl/ModuleEfl.cpp:32 > + if (!m_module.get() || !eina_module_load(m_module.get())) { You don't need the .get() when null-checking an OwnPtr as it overrides operator!, this will work just as well: if (!m_module || !eina_module_load(m_module.get())) { > Source/WebKit2/Platform/efl/ModuleEfl.cpp:47 > + if (m_module.get()) Same here: if (m_module) 550780 16 125802 youngtaeck.song 2012-02-07 03:25:43 -0800 Created attachment 125802 Patch 550784 17 125802 ryuan.choi 2012-02-07 03:28:30 -0800 Comment on attachment 125802 Patch Thank you kling. 550798 18 125802 webkit.review.bot 2012-02-07 03:45:45 -0800 Comment on attachment 125802 Patch Clearing flags on attachment: 125802 Committed r106921: <http://trac.webkit.org/changeset/106921> 550799 19 webkit.review.bot 2012-02-07 03:45:51 -0800 All reviewed patches have been landed. Closing bug. 120927 2012-01-03 03:47:07 -0800 2012-01-10 23:50:14 -0800 patch for ModuleEfl patch-[20120102]-[youngtaeck.song@samsung.com]-[Add_moduleEfl].patch text/plain 3543 youngtaeck.song ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCAzMDE5ZGUzLi43ZTBiNjExIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjAg QEAKKzIwMTItMDEtMDIgIFlvdW5nVGFlY2sgU29uZyAgPHlvdW5ndGFlY2suc29uZ0BzYW1zdW5n LmNvbT4KKworICAgICAgICBbRUZMXVtXSzJdIEFkZCBNb2R1bGVFZmwuY3BwCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02MzYwOAorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFkZCBmaXJzdCB2ZXJzaW9uIG9m IE1vZHVsZUVmbC5jcHAgaW5jbHVkaW5nIGxvYWQoKSwgdW5sb2FkKCkgYW5kIHBsYXRmb3JtRnVu Y3Rpb25Qb2ludGVyKCkuCisKKyAgICAgICAgKiBQbGF0Zm9ybS9Nb2R1bGUuY3BwOgorICAgICAg ICAoV2ViS2l0OjpNb2R1bGU6Ok1vZHVsZSk6CisgICAgICAgICogUGxhdGZvcm0vTW9kdWxlLmg6 CisgICAgICAgICogUGxhdGZvcm0vZWZsL01vZHVsZUVmbC5jcHA6IENvcGllZCBmcm9tIFNvdXJj ZS9XZWJLaXQyL1BsYXRmb3JtL01vZHVsZS5jcHAuCisgICAgICAgIChXZWJLaXQ6Ok1vZHVsZTo6 bG9hZCk6CisgICAgICAgIChXZWJLaXQ6Ok1vZHVsZTo6dW5sb2FkKToKKyAgICAgICAgKFdlYktp dDo6TW9kdWxlOjpwbGF0Zm9ybUZ1bmN0aW9uUG9pbnRlcik6CisKIDIwMTItMDEtMDEgIERhbiBC ZXJuc3RlaW4gIDxtaXR6QGFwcGxlLmNvbT4KIAogICAgICAgICBFbnZpcm9ubWVudFV0aWxpdGll czo6c3RyaXBWYWx1ZXNFbmRpbmdXaXRoU3RyaW5nIGVudGVycyBhbiBpbmZpbml0ZSBsb29wIGlm IHRoZSBzZWFyY2ggdmFsdWUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1BsYXRmb3JtL01v ZHVsZS5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9QbGF0Zm9ybS9Nb2R1bGUuY3BwCmluZGV4IGE3OGRi MjkuLmVjYzc2OWQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1BsYXRmb3JtL01vZHVsZS5j cHAKKysrIGIvU291cmNlL1dlYktpdDIvUGxhdGZvcm0vTW9kdWxlLmNwcApAQCAtMzAsNyArMzAs NyBAQCBuYW1lc3BhY2UgV2ViS2l0IHsKIAogTW9kdWxlOjpNb2R1bGUoY29uc3QgU3RyaW5nJiBw YXRoKQogICAgIDogbV9wYXRoKHBhdGgpCi0jaWYgUExBVEZPUk0oV0lOKQorI2lmIFBMQVRGT1JN KFdJTikgfHwgUExBVEZPUk0oRUZMKQogICAgICwgbV9tb2R1bGUoMCkKICNlbmRpZgogI2lmIFBM QVRGT1JNKE1BQykgJiYgIWRlZmluZWQoX19MUDY0X18pCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi S2l0Mi9QbGF0Zm9ybS9Nb2R1bGUuaCBiL1NvdXJjZS9XZWJLaXQyL1BsYXRmb3JtL01vZHVsZS5o CmluZGV4IDczNjcxOGEuLjNiZjUyZWEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1BsYXRm b3JtL01vZHVsZS5oCisrKyBiL1NvdXJjZS9XZWJLaXQyL1BsYXRmb3JtL01vZHVsZS5oCkBAIC00 MSw2ICs0MSwxMCBAQAogdHlwZWRlZiBzdHJ1Y3QgX0dNb2R1bGUgR01vZHVsZTsKICNlbmRpZgog CisjaWYgUExBVEZPUk0oRUZMKQorI2luY2x1ZGUgPEVpbmEuaD4KKyNlbmRpZgorCiBuYW1lc3Bh Y2UgV2ViS2l0IHsKIAogY2xhc3MgTW9kdWxlIHsKQEAgLTc5LDYgKzgzLDggQEAgcHJpdmF0ZToK ICAgICBRTGlicmFyeSBtX2xpYjsKICNlbGlmIFBMQVRGT1JNKEdUSykKICAgICBHTW9kdWxlKiBt X2hhbmRsZTsKKyNlbGlmIFBMQVRGT1JNKEVGTCkKKyAgICBFaW5hX01vZHVsZSogbV9tb2R1bGU7 CiAjZW5kaWYKIH07CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1BsYXRmb3JtL2VmbC9N b2R1bGVFZmwuY3BwIGIvU291cmNlL1dlYktpdDIvUGxhdGZvcm0vZWZsL01vZHVsZUVmbC5jcHAK bmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMC4uYTI5OTEyNQotLS0gL2Rldi9udWxs CisrKyBiL1NvdXJjZS9XZWJLaXQyL1BsYXRmb3JtL2VmbC9Nb2R1bGVFZmwuY3BwCkBAIC0wLDAg KzEsNTQgQEAKKy8qCisgICAgQ29weXJpZ2h0IChDKSAyMDEyIFNhbXN1bmcgRWxlY3Ryb25pY3MK KworICAgIFRoaXMgbGlicmFyeSBpcyBmcmVlIHNvZnR3YXJlOyB5b3UgY2FuIHJlZGlzdHJpYnV0 ZSBpdCBhbmQvb3IKKyAgICBtb2RpZnkgaXQgdW5kZXIgdGhlIHRlcm1zIG9mIHRoZSBHTlUgTGli cmFyeSBHZW5lcmFsIFB1YmxpYworICAgIExpY2Vuc2UgYXMgcHVibGlzaGVkIGJ5IHRoZSBGcmVl IFNvZnR3YXJlIEZvdW5kYXRpb247IGVpdGhlcgorICAgIHZlcnNpb24gMiBvZiB0aGUgTGljZW5z ZSwgb3IgKGF0IHlvdXIgb3B0aW9uKSBhbnkgbGF0ZXIgdmVyc2lvbi4KKworICAgIFRoaXMgbGli cmFyeSBpcyBkaXN0cmlidXRlZCBpbiB0aGUgaG9wZSB0aGF0IGl0IHdpbGwgYmUgdXNlZnVsLAor ICAgIGJ1dCBXSVRIT1VUIEFOWSBXQVJSQU5UWTsgd2l0aG91dCBldmVuIHRoZSBpbXBsaWVkIHdh cnJhbnR5IG9mCisgICAgTUVSQ0hBTlRBQklMSVRZIG9yIEZJVE5FU1MgRk9SIEEgUEFSVElDVUxB UiBQVVJQT1NFLiAgU2VlIHRoZSBHTlUKKyAgICBMaWJyYXJ5IEdlbmVyYWwgUHVibGljIExpY2Vu c2UgZm9yIG1vcmUgZGV0YWlscy4KKworICAgIFlvdSBzaG91bGQgaGF2ZSByZWNlaXZlZCBhIGNv cHkgb2YgdGhlIEdOVSBMaWJyYXJ5IEdlbmVyYWwgUHVibGljIExpY2Vuc2UKKyAgICBhbG9uZyB3 aXRoIHRoaXMgbGlicmFyeTsgc2VlIHRoZSBmaWxlIENPUFlJTkcuTElCLiAgSWYgbm90LCB3cml0 ZSB0bworICAgIHRoZSBGcmVlIFNvZnR3YXJlIEZvdW5kYXRpb24sIEluYy4sIDUxIEZyYW5rbGlu IFN0cmVldCwgRmlmdGggRmxvb3IsCisgICAgQm9zdG9uLCBNQSAwMjExMC0xMzAxLCBVU0EuCisg Ki8KKworI2luY2x1ZGUgImNvbmZpZy5oIgorI2luY2x1ZGUgIk1vZHVsZS5oIgorCisjaW5jbHVk ZSA8d3RmL3RleHQvQ1N0cmluZy5oPgorCituYW1lc3BhY2UgV2ViS2l0IHsKKworYm9vbCBNb2R1 bGU6OmxvYWQoKQoreworICAgIG1fbW9kdWxlID0gZWluYV9tb2R1bGVfbmV3KG1fcGF0aC51dGY4 KCkuZGF0YSgpKTsKKyAgICBpZiAobV9tb2R1bGUgJiYgZWluYV9tb2R1bGVfbG9hZChtX21vZHVs ZSkpCisgICAgICAgIHJldHVybiB0cnVlOworCisgICAgcmV0dXJuIGZhbHNlOworfQorCit2b2lk IE1vZHVsZTo6dW5sb2FkKCkKK3sKKyAgICBpZiAobV9tb2R1bGUpIHsKKyAgICAgICAgZWluYV9t b2R1bGVfdW5sb2FkKG1fbW9kdWxlKTsKKyAgICAgICAgbV9tb2R1bGUgPSAwOworICAgIH0KK30K Kwordm9pZCogTW9kdWxlOjpwbGF0Zm9ybUZ1bmN0aW9uUG9pbnRlcihjb25zdCBjaGFyKiBmdW5j dGlvbk5hbWUpIGNvbnN0Cit7CisgICAgdm9pZCogc3ltYm9sUG9pbnRlciA9IDA7CisKKyAgICBp ZiAobV9tb2R1bGUpCisgICAgICAgIHN5bWJvbFBvaW50ZXIgPSBlaW5hX21vZHVsZV9zeW1ib2xf Z2V0KG1fbW9kdWxlLCBmdW5jdGlvbk5hbWUpOworCisgICAgcmV0dXJuIHN5bWJvbFBvaW50ZXI7 Cit9CisKK30K 121985 2012-01-10 23:50:14 -0800 2012-01-13 02:20:43 -0800 patch for ModuleEfl patch-[20120102]-[youngtaeck.song@samsung.com]-[Add_moduleEfl].patch text/plain 3246 youngtaeck.song ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCAwNjRkN2ZmLi5iMjdmYTc0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYg QEAKKzIwMTItMDEtMTAgIFlvdW5nVGFlY2sgU29uZyAgPHlvdW5ndGFlY2suc29uZ0BzYW1zdW5n LmNvbT4KKworICAgICAgICBbRUZMXVtXSzJdIEFkZCBNb2R1bGVFZmwuY3BwCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02MzYwOAorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFkZCBmaXJzdCB2ZXJzaW9uIG9m IE1vZHVsZUVmbC5jcHAgaW5jbHVkaW5nIGxvYWQoKSwgdW5sb2FkKCkgYW5kIHBsYXRmb3JtRnVu Y3Rpb25Qb2ludGVyKCkuCisKKyAgICAgICAgKiBQbGF0Zm9ybS9Nb2R1bGUuY3BwOgorICAgICAg ICAoV2ViS2l0OjpNb2R1bGU6Ok1vZHVsZSk6CisgICAgICAgICogUGxhdGZvcm0vTW9kdWxlLmg6 CisKIDIwMTItMDEtMTAgIE1hcmsgUm93ZSAgPG1yb3dlQGFwcGxlLmNvbT4KIAogICAgICAgICBS RUdSRVNTSU9OIChyMTA0Mzc3KTogQWxsIHBhZ2VzIHByaW50IGJsYW5rIG9uIFNub3cgTGVvcGFy ZApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvUGxhdGZvcm0vTW9kdWxlLmNwcCBiL1NvdXJj ZS9XZWJLaXQyL1BsYXRmb3JtL01vZHVsZS5jcHAKaW5kZXggYTc4ZGIyOS4uZWNjNzY5ZCAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYktpdDIvUGxhdGZvcm0vTW9kdWxlLmNwcAorKysgYi9Tb3VyY2Uv V2ViS2l0Mi9QbGF0Zm9ybS9Nb2R1bGUuY3BwCkBAIC0zMCw3ICszMCw3IEBAIG5hbWVzcGFjZSBX ZWJLaXQgewogCiBNb2R1bGU6Ok1vZHVsZShjb25zdCBTdHJpbmcmIHBhdGgpCiAgICAgOiBtX3Bh dGgocGF0aCkKLSNpZiBQTEFURk9STShXSU4pCisjaWYgUExBVEZPUk0oV0lOKSB8fCBQTEFURk9S TShFRkwpCiAgICAgLCBtX21vZHVsZSgwKQogI2VuZGlmCiAjaWYgUExBVEZPUk0oTUFDKSAmJiAh ZGVmaW5lZChfX0xQNjRfXykKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1BsYXRmb3JtL01v ZHVsZS5oIGIvU291cmNlL1dlYktpdDIvUGxhdGZvcm0vTW9kdWxlLmgKaW5kZXggNzM2NzE4YS4u M2JmNTJlYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvUGxhdGZvcm0vTW9kdWxlLmgKKysr IGIvU291cmNlL1dlYktpdDIvUGxhdGZvcm0vTW9kdWxlLmgKQEAgLTQxLDYgKzQxLDEwIEBACiB0 eXBlZGVmIHN0cnVjdCBfR01vZHVsZSBHTW9kdWxlOwogI2VuZGlmCiAKKyNpZiBQTEFURk9STShF RkwpCisjaW5jbHVkZSA8RWluYS5oPgorI2VuZGlmCisKIG5hbWVzcGFjZSBXZWJLaXQgewogCiBj bGFzcyBNb2R1bGUgewpAQCAtNzksNiArODMsOCBAQCBwcml2YXRlOgogICAgIFFMaWJyYXJ5IG1f bGliOwogI2VsaWYgUExBVEZPUk0oR1RLKQogICAgIEdNb2R1bGUqIG1faGFuZGxlOworI2VsaWYg UExBVEZPUk0oRUZMKQorICAgIEVpbmFfTW9kdWxlKiBtX21vZHVsZTsKICNlbmRpZgogfTsKIApk aWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvUGxhdGZvcm0vZWZsL01vZHVsZUVmbC5jcHAgYi9T b3VyY2UvV2ViS2l0Mi9QbGF0Zm9ybS9lZmwvTW9kdWxlRWZsLmNwcApuZXcgZmlsZSBtb2RlIDEw MDY0NAppbmRleCAwMDAwMDAwLi5kOTY1YzYyCi0tLSAvZGV2L251bGwKKysrIGIvU291cmNlL1dl YktpdDIvUGxhdGZvcm0vZWZsL01vZHVsZUVmbC5jcHAKQEAgLTAsMCArMSw1MiBAQAorLyoKKyAg ICBDb3B5cmlnaHQgKEMpIDIwMTIgU2Ftc3VuZyBFbGVjdHJvbmljcworCisgICAgVGhpcyBsaWJy YXJ5IGlzIGZyZWUgc29mdHdhcmU7IHlvdSBjYW4gcmVkaXN0cmlidXRlIGl0IGFuZC9vcgorICAg IG1vZGlmeSBpdCB1bmRlciB0aGUgdGVybXMgb2YgdGhlIEdOVSBMaWJyYXJ5IEdlbmVyYWwgUHVi bGljCisgICAgTGljZW5zZSBhcyBwdWJsaXNoZWQgYnkgdGhlIEZyZWUgU29mdHdhcmUgRm91bmRh dGlvbjsgZWl0aGVyCisgICAgdmVyc2lvbiAyIG9mIHRoZSBMaWNlbnNlLCBvciAoYXQgeW91ciBv cHRpb24pIGFueSBsYXRlciB2ZXJzaW9uLgorCisgICAgVGhpcyBsaWJyYXJ5IGlzIGRpc3RyaWJ1 dGVkIGluIHRoZSBob3BlIHRoYXQgaXQgd2lsbCBiZSB1c2VmdWwsCisgICAgYnV0IFdJVEhPVVQg QU5ZIFdBUlJBTlRZOyB3aXRob3V0IGV2ZW4gdGhlIGltcGxpZWQgd2FycmFudHkgb2YKKyAgICBN RVJDSEFOVEFCSUxJVFkgb3IgRklUTkVTUyBGT1IgQSBQQVJUSUNVTEFSIFBVUlBPU0UuICBTZWUg dGhlIEdOVQorICAgIExpYnJhcnkgR2VuZXJhbCBQdWJsaWMgTGljZW5zZSBmb3IgbW9yZSBkZXRh aWxzLgorCisgICAgWW91IHNob3VsZCBoYXZlIHJlY2VpdmVkIGEgY29weSBvZiB0aGUgR05VIExp YnJhcnkgR2VuZXJhbCBQdWJsaWMgTGljZW5zZQorICAgIGFsb25nIHdpdGggdGhpcyBsaWJyYXJ5 OyBzZWUgdGhlIGZpbGUgQ09QWUlORy5MSUIuICBJZiBub3QsIHdyaXRlIHRvCisgICAgdGhlIEZy ZWUgU29mdHdhcmUgRm91bmRhdGlvbiwgSW5jLiwgNTEgRnJhbmtsaW4gU3RyZWV0LCBGaWZ0aCBG bG9vciwKKyAgICBCb3N0b24sIE1BIDAyMTEwLTEzMDEsIFVTQS4KKyAqLworCisjaW5jbHVkZSAi Y29uZmlnLmgiCisjaW5jbHVkZSAiTW9kdWxlLmgiCisKKyNpbmNsdWRlIDx3dGYvdGV4dC9DU3Ry aW5nLmg+CisKK25hbWVzcGFjZSBXZWJLaXQgeworCitib29sIE1vZHVsZTo6bG9hZCgpCit7Cisg ICAgbV9tb2R1bGUgPSBlaW5hX21vZHVsZV9uZXcobV9wYXRoLnV0ZjgoKS5kYXRhKCkpOworICAg IGlmIChtX21vZHVsZSAmJiBlaW5hX21vZHVsZV9sb2FkKG1fbW9kdWxlKSkKKyAgICAgICAgcmV0 dXJuIHRydWU7CisKKyAgICByZXR1cm4gZmFsc2U7Cit9CisKK3ZvaWQgTW9kdWxlOjp1bmxvYWQo KQoreworICAgIGlmIChtX21vZHVsZSkgeworICAgICAgICBlaW5hX21vZHVsZV91bmxvYWQobV9t b2R1bGUpOworICAgICAgICBtX21vZHVsZSA9IDA7CisgICAgfQorfQorCit2b2lkKiBNb2R1bGU6 OnBsYXRmb3JtRnVuY3Rpb25Qb2ludGVyKGNvbnN0IGNoYXIqIGZ1bmN0aW9uTmFtZSkgY29uc3QK K3sKKyAgICBpZiAobV9tb2R1bGUpCisgICAgICAgIHJldHVybiBlaW5hX21vZHVsZV9zeW1ib2xf Z2V0KG1fbW9kdWxlLCBmdW5jdGlvbk5hbWUpOworCisgICAgcmV0dXJuIDA7Cit9CisKK30K 122401 2012-01-13 02:20:43 -0800 2012-02-07 03:25:35 -0800 patch for ModuleEfl patch-[20120102]-[youngtaeck.song@samsung.com]-[Add_moduleEfl].patch text/plain 3052 youngtaeck.song ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCA0ZDFhMDUyLi4wNmQ2OGFjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTgg QEAKKzIwMTItMDEtMTMgIFlvdW5nVGFlY2sgU29uZyAgPHlvdW5ndGFlY2suc29uZ0BzYW1zdW5n LmNvbT4KKworICAgICAgICBbRUZMXVtXSzJdIEFkZCBNb2R1bGVFZmwuY3BwCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02MzYwOAorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFkZCBmaXJzdCB2ZXJzaW9uIG9m IE1vZHVsZUVmbC5jcHAgaW5jbHVkaW5nIGxvYWQoKSwgdW5sb2FkKCkgYW5kIHBsYXRmb3JtRnVu Y3Rpb25Qb2ludGVyKCkuCisKKyAgICAgICAgKiBQbGF0Zm9ybS9Nb2R1bGUuaDoKKyAgICAgICAg KiBQbGF0Zm9ybS9lZmwvTW9kdWxlRWZsLmNwcDogQWRkZWQuCisgICAgICAgIChXZWJLaXQ6Ok1v ZHVsZTo6bG9hZCk6CisgICAgICAgIChXZWJLaXQ6Ok1vZHVsZTo6dW5sb2FkKToKKyAgICAgICAg KFdlYktpdDo6TW9kdWxlOjpwbGF0Zm9ybUZ1bmN0aW9uUG9pbnRlcik6CisKIDIwMTItMDEtMTIg IE1hcnRpbiBSb2JpbnNvbiAgPG1yb2JpbnNvbkBpZ2FsaWEuY29tPgogCiAgICAgICAgIFtHVEtd IFtXZWJLaXQyXSBXZWJLaXRVUklSZXF1ZXN0IGFuZCBXZWJLaXRVUklSZXNwb25zZSBzaG91bGQg d3JhcCB0aGUgY29ycmVzcG9uZGluZyBXZWJDb3JlIGNsYXNzZXMKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJLaXQyL1BsYXRmb3JtL01vZHVsZS5oIGIvU291cmNlL1dlYktpdDIvUGxhdGZvcm0vTW9k dWxlLmgKaW5kZXggNzM2NzE4YS4uNDFjMmM3MSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIv UGxhdGZvcm0vTW9kdWxlLmgKKysrIGIvU291cmNlL1dlYktpdDIvUGxhdGZvcm0vTW9kdWxlLmgK QEAgLTQxLDYgKzQxLDEwIEBACiB0eXBlZGVmIHN0cnVjdCBfR01vZHVsZSBHTW9kdWxlOwogI2Vu ZGlmCiAKKyNpZiBQTEFURk9STShFRkwpCisjaW5jbHVkZSA8RWluYS5oPgorI2VuZGlmCisKIG5h bWVzcGFjZSBXZWJLaXQgewogCiBjbGFzcyBNb2R1bGUgewpAQCAtNzksNiArODMsOCBAQCBwcml2 YXRlOgogICAgIFFMaWJyYXJ5IG1fbGliOwogI2VsaWYgUExBVEZPUk0oR1RLKQogICAgIEdNb2R1 bGUqIG1faGFuZGxlOworI2VsaWYgUExBVEZPUk0oRUZMKQorICAgIE93blB0cjxFaW5hX01vZHVs ZT4gbV9tb2R1bGU7CiAjZW5kaWYKIH07CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1Bs YXRmb3JtL2VmbC9Nb2R1bGVFZmwuY3BwIGIvU291cmNlL1dlYktpdDIvUGxhdGZvcm0vZWZsL01v ZHVsZUVmbC5jcHAKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMC4uNTNmZDMyMAot LS0gL2Rldi9udWxsCisrKyBiL1NvdXJjZS9XZWJLaXQyL1BsYXRmb3JtL2VmbC9Nb2R1bGVFZmwu Y3BwCkBAIC0wLDAgKzEsNTMgQEAKKy8qCisgICAgQ29weXJpZ2h0IChDKSAyMDEyIFNhbXN1bmcg RWxlY3Ryb25pY3MKKworICAgIFRoaXMgbGlicmFyeSBpcyBmcmVlIHNvZnR3YXJlOyB5b3UgY2Fu IHJlZGlzdHJpYnV0ZSBpdCBhbmQvb3IKKyAgICBtb2RpZnkgaXQgdW5kZXIgdGhlIHRlcm1zIG9m IHRoZSBHTlUgTGlicmFyeSBHZW5lcmFsIFB1YmxpYworICAgIExpY2Vuc2UgYXMgcHVibGlzaGVk IGJ5IHRoZSBGcmVlIFNvZnR3YXJlIEZvdW5kYXRpb247IGVpdGhlcgorICAgIHZlcnNpb24gMiBv ZiB0aGUgTGljZW5zZSwgb3IgKGF0IHlvdXIgb3B0aW9uKSBhbnkgbGF0ZXIgdmVyc2lvbi4KKwor ICAgIFRoaXMgbGlicmFyeSBpcyBkaXN0cmlidXRlZCBpbiB0aGUgaG9wZSB0aGF0IGl0IHdpbGwg YmUgdXNlZnVsLAorICAgIGJ1dCBXSVRIT1VUIEFOWSBXQVJSQU5UWTsgd2l0aG91dCBldmVuIHRo ZSBpbXBsaWVkIHdhcnJhbnR5IG9mCisgICAgTUVSQ0hBTlRBQklMSVRZIG9yIEZJVE5FU1MgRk9S IEEgUEFSVElDVUxBUiBQVVJQT1NFLiAgU2VlIHRoZSBHTlUKKyAgICBMaWJyYXJ5IEdlbmVyYWwg UHVibGljIExpY2Vuc2UgZm9yIG1vcmUgZGV0YWlscy4KKworICAgIFlvdSBzaG91bGQgaGF2ZSBy ZWNlaXZlZCBhIGNvcHkgb2YgdGhlIEdOVSBMaWJyYXJ5IEdlbmVyYWwgUHVibGljIExpY2Vuc2UK KyAgICBhbG9uZyB3aXRoIHRoaXMgbGlicmFyeTsgc2VlIHRoZSBmaWxlIENPUFlJTkcuTElCLiAg SWYgbm90LCB3cml0ZSB0bworICAgIHRoZSBGcmVlIFNvZnR3YXJlIEZvdW5kYXRpb24sIEluYy4s IDUxIEZyYW5rbGluIFN0cmVldCwgRmlmdGggRmxvb3IsCisgICAgQm9zdG9uLCBNQSAwMjExMC0x MzAxLCBVU0EuCisgKi8KKworI2luY2x1ZGUgImNvbmZpZy5oIgorI2luY2x1ZGUgIk1vZHVsZS5o IgorCisjaW5jbHVkZSA8d3RmL093blB0ci5oPgorI2luY2x1ZGUgPHd0Zi9QYXNzT3duUHRyLmg+ CisjaW5jbHVkZSA8d3RmL3RleHQvQ1N0cmluZy5oPgorCituYW1lc3BhY2UgV2ViS2l0IHsKKwor Ym9vbCBNb2R1bGU6OmxvYWQoKQoreworICAgIG1fbW9kdWxlID0gYWRvcHRQdHIoZWluYV9tb2R1 bGVfbmV3KG1fcGF0aC51dGY4KCkuZGF0YSgpKSk7CisgICAgaWYgKCFtX21vZHVsZS5nZXQoKSB8 fCAhZWluYV9tb2R1bGVfbG9hZChtX21vZHVsZS5nZXQoKSkpIHsKKyAgICAgICAgbV9tb2R1bGUg PSBudWxscHRyOworICAgICAgICByZXR1cm4gZmFsc2U7CisgICAgfQorCisgICAgcmV0dXJuIHRy dWU7Cit9CisKK3ZvaWQgTW9kdWxlOjp1bmxvYWQoKQoreworICAgIG1fbW9kdWxlID0gbnVsbHB0 cjsKK30KKwordm9pZCogTW9kdWxlOjpwbGF0Zm9ybUZ1bmN0aW9uUG9pbnRlcihjb25zdCBjaGFy KiBmdW5jdGlvbk5hbWUpIGNvbnN0Cit7CisgICAgaWYgKG1fbW9kdWxlLmdldCgpKQorICAgICAg ICByZXR1cm4gZWluYV9tb2R1bGVfc3ltYm9sX2dldChtX21vZHVsZS5nZXQoKSwgZnVuY3Rpb25O YW1lKTsKKworICAgIHJldHVybiAwOworfQorCit9Cg== 125802 2012-02-07 03:25:43 -0800 2012-02-07 03:45:45 -0800 Patch bug-63608-20120207202542.patch text/plain 3203 youngtaeck.song U3VidmVyc2lvbiBSZXZpc2lvbjogMTA2OTE5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggNDEwZDBhNjIyMDdkYTNi YTkwMjRjYTBmODU1NDQzZGVjZjM0MjEwZC4uNWMzOTUzZWM0MWUwODY1MWMxNmQ1YTI0ZDU2N2Fk YWVlNmViODhmZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEyLTAyLTA3ICBZb3Vu Z1RhZWNrIFNvbmcgIDx5b3VuZ3RhZWNrLnNvbmdAc2Ftc3VuZy5jb20+CisKKyAgICAgICAgW0VG TF1bV0syXSBBZGQgTW9kdWxlRWZsLmNwcAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9NjM2MDgKKworICAgICAgICBSZXZpZXdlZCBieSBBbmRyZWFzIEts aW5nLgorCisgICAgICAgIEFkZCBmaXJzdCB2ZXJzaW9uIG9mIE1vZHVsZUVmbC5jcHAgaW5jbHVk aW5nIGxvYWQoKSwgdW5sb2FkKCkgYW5kIHBsYXRmb3JtRnVuY3Rpb25Qb2ludGVyKCkuCisKKyAg ICAgICAgKiBQbGF0Zm9ybS9Nb2R1bGUuaDoKKyAgICAgICAgKiBQbGF0Zm9ybS9lZmwvTW9kdWxl RWZsLmNwcDogQWRkZWQuCisgICAgICAgIChXZWJLaXQ6Ok1vZHVsZTo6bG9hZCk6CisgICAgICAg IChXZWJLaXQ6Ok1vZHVsZTo6dW5sb2FkKToKKyAgICAgICAgKFdlYktpdDo6TW9kdWxlOjpwbGF0 Zm9ybUZ1bmN0aW9uUG9pbnRlcik6CisKIDIwMTItMDItMDYgIFNoaW55YSBLYXdhbmFrYSAgPHNo aW55YWtAZ29vZ2xlLmNvbT4KIAogICAgICAgICBSZW1vdmUgRWxlbWVudDo6ZW5zdXJlU2hhZG93 Um9vdCBleHBvcnQuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9QbGF0Zm9ybS9Nb2R1bGUu aCBiL1NvdXJjZS9XZWJLaXQyL1BsYXRmb3JtL01vZHVsZS5oCmluZGV4IDczNjcxOGE4YjdlOTk3 MTE5OTQwMmU5OTNiMGNlN2UzNGI1YzU0MDkuLjQxYzJjNzE4MGVhZWViYmFlNDRjZGU3NjM1OGJl MGFlZDJlZGViNTQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1BsYXRmb3JtL01vZHVsZS5o CisrKyBiL1NvdXJjZS9XZWJLaXQyL1BsYXRmb3JtL01vZHVsZS5oCkBAIC00MSw2ICs0MSwxMCBA QAogdHlwZWRlZiBzdHJ1Y3QgX0dNb2R1bGUgR01vZHVsZTsKICNlbmRpZgogCisjaWYgUExBVEZP Uk0oRUZMKQorI2luY2x1ZGUgPEVpbmEuaD4KKyNlbmRpZgorCiBuYW1lc3BhY2UgV2ViS2l0IHsK IAogY2xhc3MgTW9kdWxlIHsKQEAgLTc5LDYgKzgzLDggQEAgcHJpdmF0ZToKICAgICBRTGlicmFy eSBtX2xpYjsKICNlbGlmIFBMQVRGT1JNKEdUSykKICAgICBHTW9kdWxlKiBtX2hhbmRsZTsKKyNl bGlmIFBMQVRGT1JNKEVGTCkKKyAgICBPd25QdHI8RWluYV9Nb2R1bGU+IG1fbW9kdWxlOwogI2Vu ZGlmCiB9OwogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9QbGF0Zm9ybS9lZmwvTW9kdWxl RWZsLmNwcCBiL1NvdXJjZS9XZWJLaXQyL1BsYXRmb3JtL2VmbC9Nb2R1bGVFZmwuY3BwCm5ldyBm aWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAuLmY0MGIxM2IxMDY2ZWJiODdhOWM1Y2Q3YTFmYjRjYTAxMDA4OGI5MWEKLS0tIC9kZXYv bnVsbAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9QbGF0Zm9ybS9lZmwvTW9kdWxlRWZsLmNwcApAQCAt MCwwICsxLDUzIEBACisvKgorICAgIENvcHlyaWdodCAoQykgMjAxMiBTYW1zdW5nIEVsZWN0cm9u aWNzCisKKyAgICBUaGlzIGxpYnJhcnkgaXMgZnJlZSBzb2Z0d2FyZTsgeW91IGNhbiByZWRpc3Ry aWJ1dGUgaXQgYW5kL29yCisgICAgbW9kaWZ5IGl0IHVuZGVyIHRoZSB0ZXJtcyBvZiB0aGUgR05V IExpYnJhcnkgR2VuZXJhbCBQdWJsaWMKKyAgICBMaWNlbnNlIGFzIHB1Ymxpc2hlZCBieSB0aGUg RnJlZSBTb2Z0d2FyZSBGb3VuZGF0aW9uOyBlaXRoZXIKKyAgICB2ZXJzaW9uIDIgb2YgdGhlIExp Y2Vuc2UsIG9yIChhdCB5b3VyIG9wdGlvbikgYW55IGxhdGVyIHZlcnNpb24uCisKKyAgICBUaGlz IGxpYnJhcnkgaXMgZGlzdHJpYnV0ZWQgaW4gdGhlIGhvcGUgdGhhdCBpdCB3aWxsIGJlIHVzZWZ1 bCwKKyAgICBidXQgV0lUSE9VVCBBTlkgV0FSUkFOVFk7IHdpdGhvdXQgZXZlbiB0aGUgaW1wbGll ZCB3YXJyYW50eSBvZgorICAgIE1FUkNIQU5UQUJJTElUWSBvciBGSVRORVNTIEZPUiBBIFBBUlRJ Q1VMQVIgUFVSUE9TRS4gIFNlZSB0aGUgR05VCisgICAgTGlicmFyeSBHZW5lcmFsIFB1YmxpYyBM aWNlbnNlIGZvciBtb3JlIGRldGFpbHMuCisKKyAgICBZb3Ugc2hvdWxkIGhhdmUgcmVjZWl2ZWQg YSBjb3B5IG9mIHRoZSBHTlUgTGlicmFyeSBHZW5lcmFsIFB1YmxpYyBMaWNlbnNlCisgICAgYWxv bmcgd2l0aCB0aGlzIGxpYnJhcnk7IHNlZSB0aGUgZmlsZSBDT1BZSU5HLkxJQi4gIElmIG5vdCwg d3JpdGUgdG8KKyAgICB0aGUgRnJlZSBTb2Z0d2FyZSBGb3VuZGF0aW9uLCBJbmMuLCA1MSBGcmFu a2xpbiBTdHJlZXQsIEZpZnRoIEZsb29yLAorICAgIEJvc3RvbiwgTUEgMDIxMTAtMTMwMSwgVVNB LgorICovCisKKyNpbmNsdWRlICJjb25maWcuaCIKKyNpbmNsdWRlICJNb2R1bGUuaCIKKworI2lu Y2x1ZGUgPHd0Zi9Pd25QdHIuaD4KKyNpbmNsdWRlIDx3dGYvUGFzc093blB0ci5oPgorI2luY2x1 ZGUgPHd0Zi90ZXh0L0NTdHJpbmcuaD4KKworbmFtZXNwYWNlIFdlYktpdCB7CisKK2Jvb2wgTW9k dWxlOjpsb2FkKCkKK3sKKyAgICBtX21vZHVsZSA9IGFkb3B0UHRyKGVpbmFfbW9kdWxlX25ldyht X3BhdGgudXRmOCgpLmRhdGEoKSkpOworICAgIGlmICghbV9tb2R1bGUgfHwgIWVpbmFfbW9kdWxl X2xvYWQobV9tb2R1bGUuZ2V0KCkpKSB7CisgICAgICAgIG1fbW9kdWxlID0gbnVsbHB0cjsKKyAg ICAgICAgcmV0dXJuIGZhbHNlOworICAgIH0KKworICAgIHJldHVybiB0cnVlOworfQorCit2b2lk IE1vZHVsZTo6dW5sb2FkKCkKK3sKKyAgICBtX21vZHVsZSA9IG51bGxwdHI7Cit9CisKK3ZvaWQq IE1vZHVsZTo6cGxhdGZvcm1GdW5jdGlvblBvaW50ZXIoY29uc3QgY2hhciogZnVuY3Rpb25OYW1l KSBjb25zdAoreworICAgIGlmIChtX21vZHVsZSkKKyAgICAgICAgcmV0dXJuIGVpbmFfbW9kdWxl X3N5bWJvbF9nZXQobV9tb2R1bGUuZ2V0KCksIGZ1bmN0aW9uTmFtZSk7CisKKyAgICByZXR1cm4g MDsKK30KKworfQo=