63549 2011-06-28 11:28:55 -0700 new-run-webkit-tests should not run mthml tests when MHTML suppport is disabled 2011-06-29 17:18:04 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 34984 1 eric eric abarth dpranke ojan ossy tony webkit.review.bot oldest_to_newest 429026 0 eric 2011-06-28 11:28:55 -0700 new-run-webkit-tests should not run mthml tests when MHTML suppport is disabled 429030 1 98950 eric 2011-06-28 11:31:19 -0700 Created attachment 98950 Patch 429040 2 eric 2011-06-28 11:38:44 -0700 Just slowly burning down the list of failures on http://build.webkit.org/builders/SnowLeopard%20Intel%20Release%20%28NRWT%29 429044 3 98950 tony 2011-06-28 11:45:04 -0700 Comment on attachment 98950 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=98950&action=review > Tools/Scripts/webkitpy/layout_tests/port/webkit_unittest.py:89 > + expected_directories = set(["mathml", "fast/canvas/webgl", "compositing/webgl", "http/tests/canvas/webgl", "fast/wcss", "mhtml"]) Nit: Should we sort these alphabetically? 429046 4 98950 eric 2011-06-28 11:48:36 -0700 Comment on attachment 98950 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=98950&action=review Thanks for the review! >> Tools/Scripts/webkitpy/layout_tests/port/webkit_unittest.py:89 >> + expected_directories = set(["mathml", "fast/canvas/webgl", "compositing/webgl", "http/tests/canvas/webgl", "fast/wcss", "mhtml"]) > > Nit: Should we sort these alphabetically? I'm not sure it really matters given that they're a set. :) 429051 5 tony 2011-06-28 11:55:49 -0700 (In reply to comment #4) > (From update of attachment 98950 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=98950&action=review > > Thanks for the review! > > >> Tools/Scripts/webkitpy/layout_tests/port/webkit_unittest.py:89 > >> + expected_directories = set(["mathml", "fast/canvas/webgl", "compositing/webgl", "http/tests/canvas/webgl", "fast/wcss", "mhtml"]) > > > > Nit: Should we sort these alphabetically? > > I'm not sure it really matters given that they're a set. :) The sorting is to make it easier for humans to read, not the computer :) 429077 6 98950 webkit.review.bot 2011-06-28 12:33:40 -0700 Comment on attachment 98950 Patch Clearing flags on attachment: 98950 Committed r89949: <http://trac.webkit.org/changeset/89949> 429078 7 webkit.review.bot 2011-06-28 12:33:45 -0700 All reviewed patches have been landed. Closing bug. 430019 8 eric 2011-06-29 17:18:04 -0700 *** Bug 63523 has been marked as a duplicate of this bug. *** 98950 2011-06-28 11:31:19 -0700 2011-06-28 12:33:40 -0700 Patch bug-63549-20110628113118.patch text/plain 4179 eric U3VidmVyc2lvbiBSZXZpc2lvbjogODk5NDAKZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBi L1Rvb2xzL0NoYW5nZUxvZwppbmRleCA4ZjM0MmMxNWNhZmVhOWU2M2NkMmUyZDZmN2M0YzU3NDVh Y2MxMTIzLi5iMWU3YzFjODM3MjI4OWRkNmYwNDEzNmRjMWRkZmM0NDJmODA4NDc2IDEwMDY0NAot LS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkg QEAKKzIwMTEtMDYtMjggIEVyaWMgU2VpZGVsICA8ZXJpY0B3ZWJraXQub3JnPgorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIG5ldy1ydW4td2Via2l0LXRl c3RzIHNob3VsZCBub3QgcnVuIG10aG1sIHRlc3RzIHdoZW4gTUhUTUwgc3VwcG9ydCBpcyBkaXNh YmxlZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjM1 NDkKKworICAgICAgICBUaGlzIHdheSBtaHRtbCB0ZXN0cyB3b24ndCBzaG93IHVwIGFzICJtaXNz aW5nIiByZXN1bHRzIG9uIGFsbCBub24tY2hyb21pdW0gcGxhdGZvcm1zLgorICAgICAgICBJIGhh cHBlbiB0byBnbyBsb29raW5nIGZvciB3aGF0IGNvZGUgd2FzIGRlY2lkaW5nIHRoYXQgLm1odCB3 YXMgYSBzdXBwb3J0ZWQKKyAgICAgICAgZXh0ZW5zaW9uLCBmb3VuZCB0ZXN0X2ZpbGVzLnB5IGFu ZCB0aGVuIHJlbW92ZWQgc29tZSByZWR1bmRhbnQgZG9jLXN0cmluZ3MgYW5kCisgICAgICAgIGlm IGJyYW5jaGluZy4KKworICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3Bv cnQvdGVzdF9maWxlcy5weToKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0 cy9wb3J0L3dlYmtpdC5weToKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0 cy9wb3J0L3dlYmtpdF91bml0dGVzdC5weToKKwogMjAxMS0wNi0yOCAgQWRhbSBSb2JlbiAgPGFy b2JlbkBhcHBsZS5jb20+CiAKICAgICAgICAgUm9sbCBvdXQgcjg5OTI0IGFuZCByODk5MjUKZGlm ZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQvdGVzdF9m aWxlcy5weSBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQvdGVzdF9m aWxlcy5weQppbmRleCBkOWY1YTZiODQ3ODlhM2U3MGNlMjI1MDNhYTczNGUzZjg3MTEzYWZkLi5i OWUxYzk3ZmVkNjBlMjAzN2I5M2MxMjM1YWExYmY2NzJkNmMwOTVjIDEwMDY0NAotLS0gYS9Ub29s cy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L3Rlc3RfZmlsZXMucHkKKysrIGIv VG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC90ZXN0X2ZpbGVzLnB5CkBA IC05OSwyMSArOTksMTQgQEAgZGVmIG5vcm1hbGl6ZWRfZmluZChmaWxlc3lzdGVtLCBwYXRocyk6 CiAKIAogZGVmIF9oYXNfc3VwcG9ydGVkX2V4dGVuc2lvbihmaWxlc3lzdGVtLCBmaWxlbmFtZSk6 Ci0gICAgIiIiUmV0dXJuIHRydWUgaWYgZmlsZW5hbWUgaXMgb25lIG9mIHRoZSBmaWxlIGV4dGVu c2lvbnMgd2Ugd2FudCB0byBydW4gYQotICAgIHRlc3Qgb24uIiIiCisgICAgIiIiUmV0dXJuIHRy dWUgaWYgZmlsZW5hbWUgaXMgb25lIG9mIHRoZSBmaWxlIGV4dGVuc2lvbnMgd2Ugd2FudCB0byBy dW4gYSB0ZXN0IG9uLiIiIgogICAgIGV4dGVuc2lvbiA9IGZpbGVzeXN0ZW0uc3BsaXRleHQoZmls ZW5hbWUpWzFdCiAgICAgcmV0dXJuIGV4dGVuc2lvbiBpbiBfc3VwcG9ydGVkX2ZpbGVfZXh0ZW5z aW9ucwogCiAKIGRlZiBpc19yZWZlcmVuY2VfaHRtbF9maWxlKGZpbGVuYW1lKToKLSAgICAiIiJS ZXR1cm4gdHJ1ZSBpZiB0aGUgZmlsZW5hbWUgcG9pbnRzIHRvIGEgcmVmZXJlbmNlIEhUTUwgZmls ZS4iIiIKLSAgICBpZiAoZmlsZW5hbWUuZW5kc3dpdGgoJy1leHBlY3RlZC5odG1sJykgb3IKLSAg ICAgICAgZmlsZW5hbWUuZW5kc3dpdGgoJy1leHBlY3RlZC1taXNtYXRjaC5odG1sJykpOgotICAg ICAgICByZXR1cm4gVHJ1ZQotICAgIHJldHVybiBGYWxzZQorICAgIHJldHVybiBmaWxlbmFtZS5l bmRzd2l0aCgnLWV4cGVjdGVkLmh0bWwnKSBvciBmaWxlbmFtZS5lbmRzd2l0aCgnLWV4cGVjdGVk LW1pc21hdGNoLmh0bWwnKQogCiAKIGRlZiBfaXNfdGVzdF9maWxlKGZpbGVzeXN0ZW0sIGRpcm5h bWUsIGZpbGVuYW1lKToKLSAgICAiIiJSZXR1cm4gdHJ1ZSBpZiB0aGUgZmlsZW5hbWUgcG9pbnRz IHRvIGEgdGVzdCBmaWxlLiIiIgotICAgIHJldHVybiAoX2hhc19zdXBwb3J0ZWRfZXh0ZW5zaW9u KGZpbGVzeXN0ZW0sIGZpbGVuYW1lKSBhbmQKLSAgICAgICAgICAgIG5vdCBpc19yZWZlcmVuY2Vf aHRtbF9maWxlKGZpbGVuYW1lKSkKKyAgICByZXR1cm4gX2hhc19zdXBwb3J0ZWRfZXh0ZW5zaW9u KGZpbGVzeXN0ZW0sIGZpbGVuYW1lKSBhbmQgbm90IGlzX3JlZmVyZW5jZV9odG1sX2ZpbGUoZmls ZW5hbWUpCmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9w b3J0L3dlYmtpdC5weSBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQv d2Via2l0LnB5CmluZGV4IGUxM2M1N2ZkZTkzYTUzYTMxMDQ3MWRhMDQ2MGNjM2M2N2QxYzRjOGQu LjU4NmYzMGZhNDQ3NDNhMzdkMjU3NmZkMjg0NmRjNzhkMjZjYTJlNWYgMTAwNjQ0Ci0tLSBhL1Rv b2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQvd2Via2l0LnB5CisrKyBiL1Rv b2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQvd2Via2l0LnB5CkBAIC0yNTEs NiArMjUxLDcgQEAgY2xhc3MgV2ViS2l0UG9ydChiYXNlLlBvcnQpOgogICAgICAgICAgICAgIldl YkdMU2hhZGVyIjogWyJmYXN0L2NhbnZhcy93ZWJnbCIsICJjb21wb3NpdGluZy93ZWJnbCIsICJo dHRwL3Rlc3RzL2NhbnZhcy93ZWJnbCJdLAogICAgICAgICAgICAgInBhcnNlV0NTU0lucHV0UHJv cGVydHkiOiBbImZhc3Qvd2NzcyJdLAogICAgICAgICAgICAgImlzWEhUTUxNUERvY3VtZW50Ijog WyJmYXN0L3hodG1sbXAiXSwKKyAgICAgICAgICAgICJNSFRNTEFyY2hpdmUiOiBbIm1odG1sIl0s CiAgICAgICAgIH0KICAgICAgICAgcmV0dXJuIGRpcmVjdG9yaWVzX2Zvcl9zeW1ib2wKIApkaWZm IC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC93ZWJraXRf dW5pdHRlc3QucHkgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L3dl YmtpdF91bml0dGVzdC5weQppbmRleCA2YThkN2UxMTBkNjA0ODczMzgwNzg5NjMxYzdmNTVmMDQ4 ZTU3ODY1Li41ZGYzYmUyM2U2OTVmMjRjYzM5MDExZTg2MWZlNWM4NWMwOWQ1MTBjIDEwMDc1NQot LS0gYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L3dlYmtpdF91bml0 dGVzdC5weQorKysgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L3dl YmtpdF91bml0dGVzdC5weQpAQCAtODYsNyArODYsNyBAQCBjbGFzcyBXZWJLaXRQb3J0VGVzdChw b3J0X3Rlc3RjYXNlLlBvcnRUZXN0Q2FzZSk6CiAKICAgICBkZWYgdGVzdF9za2lwcGVkX2RpcmVj dG9yaWVzX2Zvcl9zeW1ib2xzKHNlbGYpOgogICAgICAgICBzdXBwb3J0ZWRfc3ltYm9scyA9IFsi R3JhcGhpY3NMYXllciIsICJXZWJDb3JlSGFzM0RSZW5kZXJpbmciLCAiaXNYSFRNTE1QRG9jdW1l bnQiLCAiZm9vU3ltYm9sIl0KLSAgICAgICAgZXhwZWN0ZWRfZGlyZWN0b3JpZXMgPSBzZXQoWyJt YXRobWwiLCAiZmFzdC9jYW52YXMvd2ViZ2wiLCAiY29tcG9zaXRpbmcvd2ViZ2wiLCAiaHR0cC90 ZXN0cy9jYW52YXMvd2ViZ2wiLCAiZmFzdC93Y3NzIl0pCisgICAgICAgIGV4cGVjdGVkX2RpcmVj dG9yaWVzID0gc2V0KFsibWF0aG1sIiwgImZhc3QvY2FudmFzL3dlYmdsIiwgImNvbXBvc2l0aW5n L3dlYmdsIiwgImh0dHAvdGVzdHMvY2FudmFzL3dlYmdsIiwgImZhc3Qvd2NzcyIsICJtaHRtbCJd KQogICAgICAgICByZXN1bHRfZGlyZWN0b3JpZXMgPSBzZXQoVGVzdFdlYktpdFBvcnQoc3VwcG9y dGVkX3N5bWJvbHMsIE5vbmUpLl9za2lwcGVkX3Rlc3RzX2Zvcl91bnN1cHBvcnRlZF9mZWF0dXJl cygpKQogICAgICAgICBzZWxmLmFzc2VydEVxdWFsKHJlc3VsdF9kaXJlY3RvcmllcywgZXhwZWN0 ZWRfZGlyZWN0b3JpZXMpCiAK