6350 2006-01-03 03:29:54 -0800 Selection shouldn't exclude collapsed whitespace 2023-02-25 07:37:06 -0800 1 1 1 Unclassified WebKit HTML Editing 420+ Mac OS X 10.4 RESOLVED CONFIGURATION CHANGED HasReduction, InRadar P2 Normal --- 23793 1 ap webkit-unassigned ahmad.saleem792 bfulgham emacemac7 eric evan ian michael.vm rniwa webkit-bug-importer oldest_to_newest 27580 0 ap 2006-01-03 03:29:54 -0800 If a selection range set via setBaseAndExtent starts or ends with collapsed whitespace, it is excluded from the range, which doesn't happen in Firefox. 27581 1 5446 ap 2006-01-03 03:30:34 -0800 Created attachment 5446 test case 27719 2 justin.garcia 2006-01-04 01:23:55 -0800 Here's why this happens: Positions passed to Selection::setBaseAndExtent are used to construct VisiblePositions. VisiblePositions take the input position and find its canonical position: the position that is visually equivalent but "deep" and at a rendered offset (this canonical position is referred to internally as a "deep equivalent" and is returned by VisiblePosition::deepEquivalent()) For example: <div><b>hello world</b></div> A VisiblePosition created with the Position (div, 0), would have a "deep equivalent" of (textnode, 0). A VisiblePosition created with the Positions (textnode, 6), (textnode, 7), and (textnode, 8) would all have deep equivalents of (textnode, 8). The behavior you see is caused because SelectionController takes the Positions passed to setBaseAndExxtent, creates VisiblePositions, then sets the base and the extent to the deep equivalents of those VisiblePositions. SelectionController does even more fiddling with its positions. When it creates start/end (from base/ extent), it upstream()s the end and downstream()s the start. Comments in SelectionController claim that this is necessary to "constrain" the selection to the fewest possible nodes, in order to make it canonical for purposes of comparison with other selections. I'm not sure why this is necessary, since VisiblePosition's are already canonical. Both of these things need to be addressed to fix this kind of bug (when ranges change when they are used to make selections). 65615 3 ap 2007-12-29 11:17:38 -0800 See also: bug 15256. 1887868 4 ahmad.saleem792 2022-07-30 10:25:51 -0700 I am able to reproduce this bug using attached test case in Safari 15.6 on macOS 12.5 and it shows offSet of 1 & 7 rather than 0 and 8. *** Safari 15.6 on macOS 12.5 *** body.firstChild.nodeValue: \n123456\n anchor: [object Text], offset: 1 focus: [object Text], offset: 7 *** Chrome Canary 106 *** body.firstChild.nodeValue: \n123456\n anchor: [object Text], offset: 0 focus: [object Text], offset: 8 *** Firefox Nightly 105 *** body.firstChild.nodeValue: \n123456\n anchor: [object Text], offset: 0 focus: [object Text], offset: 8 ________ I am not sure on web-spec but just wanted to share latest test results. Thanks! 1887871 5 webkit-bug-importer 2022-07-30 10:41:38 -0700 <rdar://problem/97840483> 1936751 6 ahmad.saleem792 2023-02-25 07:37:06 -0800 Fixed by Live Range Selection API. Confirmed on Safari Technology Preview 164. Marking this as "RESOLVED CONFIGURATION CHANGED". Thanks! 5446 2006-01-03 03:30:34 -0800 2006-01-03 03:30:34 -0800 test case collapsed-newline.html text/html 1544 ap PGh0bWw+CjxoZWFkPgo8c3R5bGU+CmJvZHkgeyBtYXJnaW46IDEwOyBwYWRkaW5nOiAwIH0KPC9z dHlsZT4KPC9oZWFkPgo8Ym9keSA+CjEyMzQ1Ngo8c2NyaXB0IHR5cGU9InRleHQvamF2YXNjcmlw dCI+CgogICAgdmFyIGNvbnNvbGVfbWVzc2FnZXMgPSBkb2N1bWVudC5jcmVhdGVFbGVtZW50KCJv bCIpOwogICAgCiAgICBmdW5jdGlvbiBsb2cobWVzc2FnZSkKICAgIHsKICAgICAgICB2YXIgaXRl bSA9IGRvY3VtZW50LmNyZWF0ZUVsZW1lbnQoImxpIik7CiAgICAgICAgaXRlbS5hcHBlbmRDaGls ZChkb2N1bWVudC5jcmVhdGVUZXh0Tm9kZShTdHJpbmcobWVzc2FnZSkucmVwbGFjZSgvMHhbMC05 YS1mQS1GXXs4fS9nLCAiMHhYWFhYWFhYWCIpLnJlcGxhY2UoL1xuL2csICJcXG4iKS5yZXBsYWNl KC9cdC9nLCAiXFx0IikpKTsKICAgICAgICBjb25zb2xlX21lc3NhZ2VzLmFwcGVuZENoaWxkKGl0 ZW0pOwogICAgfQogICAgCiAgICBpZiAod2luZG93LmxheW91dFRlc3RDb250cm9sbGVyKQogICAg ICAgIGxheW91dFRlc3RDb250cm9sbGVyLmR1bXBBc1RleHQoKTsKICAgICAgICAKICAgIHRyeSB7 CiAgICAKICAgICAgICBsb2coImJvZHkuZmlyc3RDaGlsZC5ub2RlVmFsdWU6ICIgKyBkb2N1bWVu dC5ib2R5LmZpcnN0Q2hpbGQubm9kZVZhbHVlKTsKCiAgICAgICAgcmFuZ2UgPSBkb2N1bWVudC5j cmVhdGVSYW5nZSgpOwogICAgICAgIHJhbmdlLnNldFN0YXJ0KGRvY3VtZW50LmJvZHkuZmlyc3RD aGlsZCwgMCk7CiAgICAgICAgcmFuZ2Uuc2V0RW5kKGRvY3VtZW50LmJvZHkuZmlyc3RDaGlsZCwg OCk7CgogICAgICAgIHRyeSB7CiAgICAgICAgICAgIHdpbmRvdy5nZXRTZWxlY3Rpb24oKS5hZGRS YW5nZShyYW5nZSk7CiAgICAgICAgfSBjYXRjaCAoZXgpIHsKICAgICAgICAgICAgd2luZG93Lmdl dFNlbGVjdGlvbigpLnNldEJhc2VBbmRFeHRlbnQocmFuZ2Uuc3RhcnRDb250YWluZXIsIHJhbmdl LnN0YXJ0T2Zmc2V0LCByYW5nZS5lbmRDb250YWluZXIsIHJhbmdlLmVuZE9mZnNldCk7CiAgICAg ICAgfQoKICAgICAgICBsb2coImFuY2hvcjogIiArIHdpbmRvdy5nZXRTZWxlY3Rpb24oKS5hbmNo b3JOb2RlICsgIiwgb2Zmc2V0OiAiICsgd2luZG93LmdldFNlbGVjdGlvbigpLmFuY2hvck9mZnNl dCk7CiAgICAgICAgbG9nKCJmb2N1czogIiArIHdpbmRvdy5nZXRTZWxlY3Rpb24oKS5mb2N1c05v ZGUgKyAiLCBvZmZzZXQ6ICIgKyB3aW5kb3cuZ2V0U2VsZWN0aW9uKCkuZm9jdXNPZmZzZXQpOwog ICAgICAgIGxvZygiKG9mZnNldHMgc2hvdWxkIGJlIDAgYW5kIDgsIHJlc3BlY3RpdmVseSkiKTsK CiAgICB9IGNhdGNoIChleCkgewogICAgICAgIGxvZygiRXhjZXB0aW9uOiAiICsgZXguZGVzY3Jp cHRpb24pOwogICAgfQogICAgCiAgICB2YXIgY29uc29sZSA9IGRvY3VtZW50LmNyZWF0ZUVsZW1l bnQoInAiKTsKICAgIGNvbnNvbGUuYXBwZW5kQ2hpbGQoY29uc29sZV9tZXNzYWdlcyk7CiAgICBk b2N1bWVudC5ib2R5LmFwcGVuZENoaWxkKGNvbnNvbGUpOwoKPC9zY3JpcHQ+CjwvYm9keT4KPC9o dG1sPgo=