63273 2011-06-23 12:37:22 -0700 FloatRect should implement the same methods as IntRect 2011-06-23 15:15:17 -0700 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 61896 1 eae eae eric leviw simon.fraser webkit.review.bot oldest_to_newest 426367 0 eae 2011-06-23 12:37:22 -0700 FloatRect is currently missing a couple of methods implemented by IntRect. 426371 1 98382 eae 2011-06-23 12:39:43 -0700 Created attachment 98382 Patch 426451 2 98382 eric 2011-06-23 14:13:20 -0700 Comment on attachment 98382 Patch Seems reasonable. 426535 3 98382 webkit.review.bot 2011-06-23 15:15:12 -0700 Comment on attachment 98382 Patch Clearing flags on attachment: 98382 Committed r89625: <http://trac.webkit.org/changeset/89625> 426536 4 webkit.review.bot 2011-06-23 15:15:17 -0700 All reviewed patches have been landed. Closing bug. 98382 2011-06-23 12:39:43 -0700 2011-06-23 15:15:12 -0700 Patch bug-63273-20110623123942.patch text/plain 5588 eae SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDg5NjAwKQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMzMgQEAKKzIwMTEtMDYtMjMgIEVtaWwgQSBF a2x1bmQgIDxlYWVAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIEZsb2F0UmVjdCBzaG91bGQgaW1wbGVtZW50IHRoZSBzYW1lIG1l dGhvZHMgYXMgSW50UmVjdAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9NjMyNzMKKyAgICAgICAgCisgICAgICAgIEFkZCBtaXNzaW5nIG1ldGhvZHMgZnJv bSBJbnRSZWN0IHRvIEZsb2F0UmVjdCBpbiBwcmVwYXJhdGlvbiBmb3IgbW92aW5nCisgICAgICAg IHRoZSByZW5kZXJpbmcgdHJlZSBvdmVyIHRvIGZsb2F0cy4KKworICAgICAgICAqIHBsYXRmb3Jt L2dyYXBoaWNzL0Zsb2F0UG9pbnQuaDoKKyAgICAgICAgKFdlYkNvcmU6OkZsb2F0UG9pbnQ6OmV4 cGFuZGVkVG8pOgorICAgICAgICAoV2ViQ29yZTo6RmxvYXRQb2ludDo6dHJhbnNwb3NlZFBvaW50 KToKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9GbG9hdFJlY3QuaDoKKyAgICAgICAgKFdl YkNvcmU6OkZsb2F0UmVjdDo6bW92ZSk6CisgICAgICAgIChXZWJDb3JlOjpGbG9hdFJlY3Q6OmV4 cGFuZCk6CisgICAgICAgIChXZWJDb3JlOjpGbG9hdFJlY3Q6OmNvbnRyYWN0KToKKyAgICAgICAg KFdlYkNvcmU6OkZsb2F0UmVjdDo6c2hpZnRYRWRnZVRvKToKKyAgICAgICAgKFdlYkNvcmU6OkZs b2F0UmVjdDo6c2hpZnRNYXhYRWRnZVRvKToKKyAgICAgICAgKFdlYkNvcmU6OkZsb2F0UmVjdDo6 c2hpZnRZRWRnZVRvKToKKyAgICAgICAgKFdlYkNvcmU6OkZsb2F0UmVjdDo6c2hpZnRNYXhZRWRn ZVRvKToKKyAgICAgICAgKFdlYkNvcmU6OkZsb2F0UmVjdDo6bWluWE1pbllDb3JuZXIpOgorICAg ICAgICAoV2ViQ29yZTo6RmxvYXRSZWN0OjptYXhYTWluWUNvcm5lcik6CisgICAgICAgIChXZWJD b3JlOjpGbG9hdFJlY3Q6Om1pblhNYXhZQ29ybmVyKToKKyAgICAgICAgKFdlYkNvcmU6OkZsb2F0 UmVjdDo6bWF4WE1heFlDb3JuZXIpOgorICAgICAgICAoV2ViQ29yZTo6RmxvYXRSZWN0Ojp0cmFu c3Bvc2VkUmVjdCk6CisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvRmxvYXRTaXplLmg6Cisg ICAgICAgIChXZWJDb3JlOjpGbG9hdFNpemU6OmV4cGFuZCk6CisgICAgICAgIChXZWJDb3JlOjpG bG9hdFNpemU6OnRyYW5zcG9zZWRTaXplKToKKwogMjAxMS0wNi0yMyAgSmF5IENpdmVsbGkgIDxq Y2l2ZWxsaUBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgQWRhbSBCYXJ0aC4K SW5kZXg6IFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL0Zsb2F0UG9pbnQuaAo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9GbG9hdFBvaW50LmgJ KHJldmlzaW9uIDg5NDg2KQorKysgU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvRmxv YXRQb2ludC5oCSh3b3JraW5nIGNvcHkpCkBAIC0xMjMsNyArMTIzLDEyIEBAIHB1YmxpYzoKICAg ICBGbG9hdFBvaW50IGV4cGFuZGVkVG8oY29uc3QgRmxvYXRQb2ludCYgb3RoZXIpIGNvbnN0CiAg ICAgewogICAgICAgICByZXR1cm4gRmxvYXRQb2ludChzdGQ6Om1heChtX3gsIG90aGVyLm1feCks IHN0ZDo6bWF4KG1feSwgb3RoZXIubV95KSk7Ci0gICAgfSAgIAorICAgIH0KKworICAgIEZsb2F0 UG9pbnQgdHJhbnNwb3NlZFBvaW50KCkgY29uc3QKKyAgICB7CisgICAgICAgIHJldHVybiBGbG9h dFBvaW50KG1feSwgbV94KTsKKyAgICB9CiAKICNpZiBVU0UoQ0cpIHx8IFVTRShTS0lBX09OX01B Q19DSFJPTUUpCiAgICAgRmxvYXRQb2ludChjb25zdCBDR1BvaW50Jik7CkluZGV4OiBTb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9GbG9hdFJlY3QuaAo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3Vy Y2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9GbG9hdFJlY3QuaAkocmV2aXNpb24gODk0ODYp CisrKyBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9GbG9hdFJlY3QuaAkod29ya2lu ZyBjb3B5KQpAQCAtMTA2LDggKzEwNiw0MSBAQCBwdWJsaWM6CiAgICAgRmxvYXRQb2ludCBjZW50 ZXIoKSBjb25zdCB7IHJldHVybiBGbG9hdFBvaW50KHgoKSArIHdpZHRoKCkgLyAyLCB5KCkgKyBo ZWlnaHQoKSAvIDIpOyB9CiAKICAgICB2b2lkIG1vdmUoY29uc3QgRmxvYXRTaXplJiBkZWx0YSkg eyBtX2xvY2F0aW9uICs9IGRlbHRhOyB9IAotICAgIHZvaWQgbW92ZShmbG9hdCBkeCwgZmxvYXQg ZHkpIHsgbV9sb2NhdGlvbi5tb3ZlKGR4LCBkeSk7IH0KICAgICB2b2lkIG1vdmVCeShjb25zdCBG bG9hdFBvaW50JiBkZWx0YSkgeyBtX2xvY2F0aW9uLm1vdmUoZGVsdGEueCgpLCBkZWx0YS55KCkp OyB9CisgICAgdm9pZCBtb3ZlKGZsb2F0IGR4LCBmbG9hdCBkeSkgeyBtX2xvY2F0aW9uLm1vdmUo ZHgsIGR5KTsgfQorCisgICAgdm9pZCBleHBhbmQoY29uc3QgRmxvYXRTaXplJiBzaXplKSB7IG1f c2l6ZSArPSBzaXplOyB9CisgICAgdm9pZCBleHBhbmQoZmxvYXQgZHcsIGZsb2F0IGRoKSB7IG1f c2l6ZS5leHBhbmQoZHcsIGRoKTsgfQorICAgIHZvaWQgY29udHJhY3QoY29uc3QgRmxvYXRTaXpl JiBzaXplKSB7IG1fc2l6ZSAtPSBzaXplOyB9CisgICAgdm9pZCBjb250cmFjdChmbG9hdCBkdywg ZmxvYXQgZGgpIHsgbV9zaXplLmV4cGFuZCgtZHcsIC1kaCk7IH0KKworICAgIHZvaWQgc2hpZnRY RWRnZVRvKGZsb2F0IGVkZ2UpCisgICAgeworICAgICAgICBmbG9hdCBkZWx0YSA9IGVkZ2UgLSB4 KCk7CisgICAgICAgIHNldFgoZWRnZSk7CisgICAgICAgIHNldFdpZHRoKHN0ZDo6bWF4KDAuMGYs IHdpZHRoKCkgLSBkZWx0YSkpOworICAgIH0KKyAgICB2b2lkIHNoaWZ0TWF4WEVkZ2VUbyhmbG9h dCBlZGdlKQorICAgIHsKKyAgICAgICAgZmxvYXQgZGVsdGEgPSBlZGdlIC0gbWF4WCgpOworICAg ICAgICBzZXRXaWR0aChzdGQ6Om1heCgwLjBmLCB3aWR0aCgpICsgZGVsdGEpKTsKKyAgICB9Cisg ICAgdm9pZCBzaGlmdFlFZGdlVG8oZmxvYXQgZWRnZSkKKyAgICB7CisgICAgICAgIGZsb2F0IGRl bHRhID0gZWRnZSAtIHkoKTsKKyAgICAgICAgc2V0WShlZGdlKTsKKyAgICAgICAgc2V0SGVpZ2h0 KHN0ZDo6bWF4KDAuMGYsIGhlaWdodCgpIC0gZGVsdGEpKTsKKyAgICB9CisgICAgdm9pZCBzaGlm dE1heFlFZGdlVG8oZmxvYXQgZWRnZSkKKyAgICB7CisgICAgICAgIGZsb2F0IGRlbHRhID0gZWRn ZSAtIG1heFkoKTsKKyAgICAgICAgc2V0SGVpZ2h0KHN0ZDo6bWF4KDAuMGYsIGhlaWdodCgpICsg ZGVsdGEpKTsKKyAgICB9CisKKyAgICBGbG9hdFBvaW50IG1pblhNaW5ZQ29ybmVyKCkgY29uc3Qg eyByZXR1cm4gbV9sb2NhdGlvbjsgfSAvLyB0eXBpY2FsbHkgdG9wTGVmdAorICAgIEZsb2F0UG9p bnQgbWF4WE1pbllDb3JuZXIoKSBjb25zdCB7IHJldHVybiBGbG9hdFBvaW50KG1fbG9jYXRpb24u eCgpICsgbV9zaXplLndpZHRoKCksIG1fbG9jYXRpb24ueSgpKTsgfSAvLyB0eXBpY2FsbHkgdG9w UmlnaHQKKyAgICBGbG9hdFBvaW50IG1pblhNYXhZQ29ybmVyKCkgY29uc3QgeyByZXR1cm4gRmxv YXRQb2ludChtX2xvY2F0aW9uLngoKSwgbV9sb2NhdGlvbi55KCkgKyBtX3NpemUuaGVpZ2h0KCkp OyB9IC8vIHR5cGljYWxseSBib3R0b21MZWZ0CisgICAgRmxvYXRQb2ludCBtYXhYTWF4WUNvcm5l cigpIGNvbnN0IHsgcmV0dXJuIEZsb2F0UG9pbnQobV9sb2NhdGlvbi54KCkgKyBtX3NpemUud2lk dGgoKSwgbV9sb2NhdGlvbi55KCkgKyBtX3NpemUuaGVpZ2h0KCkpOyB9IC8vIHR5cGljYWxseSBi b3R0b21SaWdodAogCiAgICAgYm9vbCBpbnRlcnNlY3RzKGNvbnN0IEZsb2F0UmVjdCYpIGNvbnN0 OwogICAgIGJvb2wgY29udGFpbnMoY29uc3QgRmxvYXRSZWN0JikgY29uc3Q7CkBAIC0xMzQsNiAr MTY3LDggQEAgcHVibGljOgogICAgIHZvaWQgc2NhbGUoZmxvYXQgcykgeyBzY2FsZShzLCBzKTsg fQogICAgIHZvaWQgc2NhbGUoZmxvYXQgc3gsIGZsb2F0IHN5KTsKIAorICAgIEZsb2F0UmVjdCB0 cmFuc3Bvc2VkUmVjdCgpIGNvbnN0IHsgcmV0dXJuIEZsb2F0UmVjdChtX2xvY2F0aW9uLnRyYW5z cG9zZWRQb2ludCgpLCBtX3NpemUudHJhbnNwb3NlZFNpemUoKSk7IH0KKwogICAgIC8vIFJlLWlu aXRpYWxpemVzIHRoaXMgcmVjdGFuZ2xlIHRvIGZpdCB0aGUgc2V0cyBvZiBwYXNzZWQgcG9pbnRz LgogICAgIHZvaWQgZml0VG9Qb2ludHMoY29uc3QgRmxvYXRQb2ludCYgcDAsIGNvbnN0IEZsb2F0 UG9pbnQmIHAxKTsKICAgICB2b2lkIGZpdFRvUG9pbnRzKGNvbnN0IEZsb2F0UG9pbnQmIHAwLCBj b25zdCBGbG9hdFBvaW50JiBwMSwgY29uc3QgRmxvYXRQb2ludCYgcDIpOwpJbmRleDogU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvRmxvYXRTaXplLmgKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvRmxvYXRTaXplLmgJKHJldmlzaW9uIDg5NDg2 KQorKysgU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvRmxvYXRTaXplLmgJKHdvcmtp bmcgY29weSkKQEAgLTY1LDYgKzY1LDEyIEBAIHB1YmxpYzoKIAogICAgIGZsb2F0IGFzcGVjdFJh dGlvKCkgY29uc3QgeyByZXR1cm4gbV93aWR0aCAvIG1faGVpZ2h0OyB9CiAKKyAgICB2b2lkIGV4 cGFuZChmbG9hdCB3aWR0aCwgZmxvYXQgaGVpZ2h0KQorICAgIHsKKyAgICAgICAgbV93aWR0aCAr PSB3aWR0aDsKKyAgICAgICAgbV9oZWlnaHQgKz0gaGVpZ2h0OworICAgIH0KKwogICAgIHZvaWQg c2NhbGUoZmxvYXQgcykgeyBzY2FsZShzLCBzKTsgfQogCiAgICAgdm9pZCBzY2FsZShmbG9hdCBz Y2FsZVgsIGZsb2F0IHNjYWxlWSkKQEAgLTkxLDYgKzk3LDExIEBAIHB1YmxpYzoKICAgICAgICAg cmV0dXJuIG1fd2lkdGggKiBtX3dpZHRoICsgbV9oZWlnaHQgKiBtX2hlaWdodDsKICAgICB9CiAK KyAgICBGbG9hdFNpemUgdHJhbnNwb3NlZFNpemUoKSBjb25zdAorICAgIHsKKyAgICAgICAgcmV0 dXJuIEZsb2F0U2l6ZShtX2hlaWdodCwgbV93aWR0aCk7CisgICAgfQorCiAjaWYgVVNFKENHKSB8 fCAoUExBVEZPUk0oV1gpICYmIE9TKERBUldJTikpIHx8IFVTRShTS0lBX09OX01BQ19DSFJPTUUp CiAgICAgZXhwbGljaXQgRmxvYXRTaXplKGNvbnN0IENHU2l6ZSYpOyAvLyBkb24ndCBkbyB0aGlz IGltcGxpY2l0bHkgc2luY2UgaXQncyBsb3NzeQogICAgIG9wZXJhdG9yIENHU2l6ZSgpIGNvbnN0 Owo=