63251 2011-06-23 06:19:48 -0700 [WebKit2] Forward focus events to windowless plugins on the windows port. 2011-07-09 12:47:29 -0700 1 1 1 Unclassified WebKit Plug-ins 528+ (Nightly build) PC Windows 7 RESOLVED FIXED P2 Normal --- 1 noel.gordon noel.gordon aroben levin webkit.review.bot oldest_to_newest 426113 0 noel.gordon 2011-06-23 06:19:48 -0700 notImplemented(); 426114 1 98341 noel.gordon 2011-06-23 06:26:18 -0700 Created attachment 98341 Patch 426122 2 noel.gordon 2011-06-23 06:44:25 -0700 Running run-webkit-tests --debug -2 LayoutTests/plugins/mouse-events.html produces the correct output sometimes for me, but just as often does not. Either my setup or WebKitTestRunner is unreliable for this test. First time I've tried to do a WebKit2 change, perhaps what I'm seeing is normal. I need to dismantle my VS2005 setup and move to VS2008/10 for work reasons anyway, and so I'll be unable to test this change once that's done. 433942 3 100089 noel.gordon 2011-07-08 01:10:08 -0700 Created attachment 100089 Patch Update after http://trac.webkit.org/changeset/90327 434254 4 100089 aroben 2011-07-08 12:56:50 -0700 Comment on attachment 100089 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=100089&action=review > Source/WebKit2/ChangeLog:10 > +2011-07-08 Noel Gordon <noel.gordon@gmail.com> > + > + Reviewed by NOBODY (OOPS!). > + > + [WebKit2] Forward focus events to windowless plugins on the windows port. > + https://bugs.webkit.org/show_bug.cgi?id=63251 > + > + * WebProcess/Plugins/Netscape/win/NetscapePluginWin.cpp: > + (WebKit::NetscapePlugin::platformSetFocus): > + Please mention what test(s) this is covered by, for posterity's sake. > Source/WebKit2/WebProcess/Plugins/Netscape/win/NetscapePluginWin.cpp:316 > CurrentPluginSetter setCurrentPlugin(this); > > - notImplemented(); > + if (m_isWindowed) > + return; Maybe we should put the early return above the CurrentPluginSetter? 434255 5 100089 aroben 2011-07-08 12:57:34 -0700 Comment on attachment 100089 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=100089&action=review >> Source/WebKit2/WebProcess/Plugins/Netscape/win/NetscapePluginWin.cpp:316 >> + return; > > Maybe we should put the early return above the CurrentPluginSetter? I guess there's existing code that does it the way you did. 434413 6 noel.gordon 2011-07-08 17:37:27 -0700 > Please mention what test(s) this is covered by, for posterity's sake. Done. 434414 7 noel.gordon 2011-07-08 17:40:43 -0700 > >> Source/WebKit2/WebProcess/Plugins/Netscape/win/NetscapePluginWin.cpp:316 > >> + return; > > > > Maybe we should put the early return above the CurrentPluginSetter? > > I guess there's existing code that does it the way you did. Yes, I just followed the existing code. 434415 8 100190 noel.gordon 2011-07-08 17:41:34 -0700 Created attachment 100190 Patch 434519 9 100190 webkit.review.bot 2011-07-09 12:47:22 -0700 Comment on attachment 100190 Patch Clearing flags on attachment: 100190 Committed r90686: <http://trac.webkit.org/changeset/90686> 434520 10 webkit.review.bot 2011-07-09 12:47:29 -0700 All reviewed patches have been landed. Closing bug. 98341 2011-06-23 06:26:18 -0700 2011-07-08 17:41:34 -0700 Patch plugin-win-webkit2-focus.git.diff text/plain 1599 noel.gordon ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCAwNGZmZTkxLi4zNjBlZWMxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMg QEAKKzIwMTEtMDYtMjMgIE5vZWwgR29yZG9uICA8bm9lbC5nb3Jkb25AZ21haWwuY29tPgorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtXZWJLaXQyXSBG b3J3YXJkIGZvY3VzIGV2ZW50cyB0byB3aW5kb3dsZXNzIHBsdWdpbnMgb24gdGhlIHdpbmRvd3Mg cG9ydC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTYz MjUxCisKKyAgICAgICAgKiBXZWJQcm9jZXNzL1BsdWdpbnMvTmV0c2NhcGUvd2luL05ldHNjYXBl UGx1Z2luV2luLmNwcDoKKyAgICAgICAgKFdlYktpdDo6TmV0c2NhcGVQbHVnaW46OnBsYXRmb3Jt U2V0Rm9jdXMpOgorCiAyMDExLTA2LTIxICBNT1JJVEEgSGFqaW1lICA8bW9ycml0YUBnb29nbGUu Y29tPgogCiAgICAgICAgIFVucmV2aWV3ZWQsIHJvbGxpbmcgb3V0IHI4OTQwMSBhbmQgcjg5NDAz LgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9QbHVnaW5zL05ldHNjYXBl L3dpbi9OZXRzY2FwZVBsdWdpbldpbi5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1Bs dWdpbnMvTmV0c2NhcGUvd2luL05ldHNjYXBlUGx1Z2luV2luLmNwcAppbmRleCBlOWQzNTZlLi5i N2E0NWYyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1BsdWdpbnMvTmV0 c2NhcGUvd2luL05ldHNjYXBlUGx1Z2luV2luLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9XZWJQ cm9jZXNzL1BsdWdpbnMvTmV0c2NhcGUvd2luL05ldHNjYXBlUGx1Z2luV2luLmNwcApAQCAtMzA4 LDExICszMDgsMjIgQEAgYm9vbCBOZXRzY2FwZVBsdWdpbjo6cGxhdGZvcm1IYW5kbGVXaGVlbEV2 ZW50KGNvbnN0IFdlYldoZWVsRXZlbnQmKQogICAgIHJldHVybiBmYWxzZTsKIH0KIAotdm9pZCBO ZXRzY2FwZVBsdWdpbjo6cGxhdGZvcm1TZXRGb2N1cyhib29sKQordm9pZCBOZXRzY2FwZVBsdWdp bjo6cGxhdGZvcm1TZXRGb2N1cyhib29sIGhhc0ZvY3VzKQogewogICAgIEN1cnJlbnRQbHVnaW5T ZXR0ZXIgc2V0Q3VycmVudFBsdWdpbih0aGlzKTsKIAotICAgIG5vdEltcGxlbWVudGVkKCk7Cisg ICAgaWYgKG1faXNXaW5kb3dlZCkKKyAgICAgICAgcmV0dXJuOworCisgICAgbV9wbHVnaW5Db250 cm9sbGVyLT53aWxsU2VuZEV2ZW50VG9QbHVnaW4oKTsKKworICAgIE5QRXZlbnQgbnBFdmVudDsK KworICAgIG5wRXZlbnQuZXZlbnQgPSBoYXNGb2N1cyA/IFdNX1NFVEZPQ1VTIDogV01fS0lMTEZP Q1VTOworICAgIG5wRXZlbnQud1BhcmFtID0gMDsKKyAgICBucEV2ZW50LmxQYXJhbSA9IDA7CisK KyAgICBOUFBfSGFuZGxlRXZlbnQoJm5wRXZlbnQpOwogfQogCiBib29sIE5ldHNjYXBlUGx1Z2lu OjpwbGF0Zm9ybUhhbmRsZU1vdXNlRW50ZXJFdmVudChjb25zdCBXZWJNb3VzZUV2ZW50JiBldmVu dCkK 100089 2011-07-08 01:10:08 -0700 2011-07-08 17:41:34 -0700 Patch plugin-focus-webkit2.git.diff text/plain 1577 noel.gordon ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCBmYmUxZWExLi40YjYzZTFkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMg QEAKKzIwMTEtMDctMDggIE5vZWwgR29yZG9uICA8bm9lbC5nb3Jkb25AZ21haWwuY29tPgorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtXZWJLaXQyXSBG b3J3YXJkIGZvY3VzIGV2ZW50cyB0byB3aW5kb3dsZXNzIHBsdWdpbnMgb24gdGhlIHdpbmRvd3Mg cG9ydC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTYz MjUxCisKKyAgICAgICAgKiBXZWJQcm9jZXNzL1BsdWdpbnMvTmV0c2NhcGUvd2luL05ldHNjYXBl UGx1Z2luV2luLmNwcDoKKyAgICAgICAgKFdlYktpdDo6TmV0c2NhcGVQbHVnaW46OnBsYXRmb3Jt U2V0Rm9jdXMpOgorCiAyMDExLTA3LTA3ICBBbmRyZWFzIEtsaW5nICA8a2xpbmdAd2Via2l0Lm9y Zz4KIAogICAgICAgICBbUXRdW1dLMl0gUmVtb3ZlIFN5bWJpYW4gY29kZS4KZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvUGx1Z2lucy9OZXRzY2FwZS93aW4vTmV0c2NhcGVQ bHVnaW5XaW4uY3BwIGIvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9QbHVnaW5zL05ldHNjYXBl L3dpbi9OZXRzY2FwZVBsdWdpbldpbi5jcHAKaW5kZXggNjA5MTNkOC4uNGU3OTRkYyAxMDA2NDQK LS0tIGEvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9QbHVnaW5zL05ldHNjYXBlL3dpbi9OZXRz Y2FwZVBsdWdpbldpbi5jcHAKKysrIGIvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9QbHVnaW5z L05ldHNjYXBlL3dpbi9OZXRzY2FwZVBsdWdpbldpbi5jcHAKQEAgLTMwOCwxMSArMzA4LDIxIEBA IGJvb2wgTmV0c2NhcGVQbHVnaW46OnBsYXRmb3JtSGFuZGxlV2hlZWxFdmVudChjb25zdCBXZWJX aGVlbEV2ZW50JikKICAgICByZXR1cm4gZmFsc2U7CiB9CiAKLXZvaWQgTmV0c2NhcGVQbHVnaW46 OnBsYXRmb3JtU2V0Rm9jdXMoYm9vbCkKK3ZvaWQgTmV0c2NhcGVQbHVnaW46OnBsYXRmb3JtU2V0 Rm9jdXMoYm9vbCBoYXNGb2N1cykKIHsKICAgICBDdXJyZW50UGx1Z2luU2V0dGVyIHNldEN1cnJl bnRQbHVnaW4odGhpcyk7CiAKLSAgICBub3RJbXBsZW1lbnRlZCgpOworICAgIGlmIChtX2lzV2lu ZG93ZWQpCisgICAgICAgIHJldHVybjsKKworICAgIGNvbnRyb2xsZXIoKS0+d2lsbFNlbmRFdmVu dFRvUGx1Z2luKCk7CisKKyAgICBOUEV2ZW50IG5wRXZlbnQ7CisgICAgbnBFdmVudC5ldmVudCA9 IGhhc0ZvY3VzID8gV01fU0VURk9DVVMgOiBXTV9LSUxMRk9DVVM7CisgICAgbnBFdmVudC53UGFy YW0gPSAwOworICAgIG5wRXZlbnQubFBhcmFtID0gMDsKKworICAgIE5QUF9IYW5kbGVFdmVudCgm bnBFdmVudCk7CiB9CiAKIGJvb2wgTmV0c2NhcGVQbHVnaW46OnBsYXRmb3JtSGFuZGxlTW91c2VF bnRlckV2ZW50KGNvbnN0IFdlYk1vdXNlRXZlbnQmIGV2ZW50KQo= 100190 2011-07-08 17:41:34 -0700 2011-07-09 12:47:22 -0700 Patch plugin-win-webkit2-focus.git.diff text/plain 1724 noel.gordon ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCA1YmIyODQ4Li43NDcwMTRiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYg QEAKKzIwMTEtMDctMDggIE5vZWwgR29yZG9uICA8bm9lbC5nb3Jkb25AZ21haWwuY29tPgorCisg ICAgICAgIFJldmlld2VkIGJ5IEFkYW0gUm9iZW4uCisKKyAgICAgICAgW1dlYktpdDJdIEZvcndh cmQgZm9jdXMgZXZlbnRzIHRvIHdpbmRvd2xlc3MgcGx1Z2lucyBvbiB0aGUgd2luZG93cyBwb3J0 LgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjMyNTEK KworICAgICAgICBObyBuZXcgdGVzdHMuIENvdmVyZWQgYnkgZXhpc3RpbmcgdGVzdHM6IHBsdWdp bnMvbW91c2UtZXZlbnRzLmh0bWwgYW5kCisgICAgICAgIHBsdWdpbnMva2V5Ym9hcmQtZXZlbnRz Lmh0bWwuCisKKyAgICAgICAgKiBXZWJQcm9jZXNzL1BsdWdpbnMvTmV0c2NhcGUvd2luL05ldHNj YXBlUGx1Z2luV2luLmNwcDoKKyAgICAgICAgKFdlYktpdDo6TmV0c2NhcGVQbHVnaW46OnBsYXRm b3JtU2V0Rm9jdXMpOgorCiAyMDExLTA3LTA4ICBBbmRyZWFzIEtsaW5nICA8a2xpbmdAd2Via2l0 Lm9yZz4KIAogICAgICAgICBbUXRdW1dLMl0gVmlld3Mgc2hvdWxkIGV4cG9zZSBRQWN0aW9ucyBm b3IgYmFzaWMgbmF2aWdhdGlvbi4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nl c3MvUGx1Z2lucy9OZXRzY2FwZS93aW4vTmV0c2NhcGVQbHVnaW5XaW4uY3BwIGIvU291cmNlL1dl YktpdDIvV2ViUHJvY2Vzcy9QbHVnaW5zL05ldHNjYXBlL3dpbi9OZXRzY2FwZVBsdWdpbldpbi5j cHAKaW5kZXggNjA5MTNkOC4uNGU3OTRkYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvV2Vi UHJvY2Vzcy9QbHVnaW5zL05ldHNjYXBlL3dpbi9OZXRzY2FwZVBsdWdpbldpbi5jcHAKKysrIGIv U291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9QbHVnaW5zL05ldHNjYXBlL3dpbi9OZXRzY2FwZVBs dWdpbldpbi5jcHAKQEAgLTMwOCwxMSArMzA4LDIxIEBAIGJvb2wgTmV0c2NhcGVQbHVnaW46OnBs YXRmb3JtSGFuZGxlV2hlZWxFdmVudChjb25zdCBXZWJXaGVlbEV2ZW50JikKICAgICByZXR1cm4g ZmFsc2U7CiB9CiAKLXZvaWQgTmV0c2NhcGVQbHVnaW46OnBsYXRmb3JtU2V0Rm9jdXMoYm9vbCkK K3ZvaWQgTmV0c2NhcGVQbHVnaW46OnBsYXRmb3JtU2V0Rm9jdXMoYm9vbCBoYXNGb2N1cykKIHsK ICAgICBDdXJyZW50UGx1Z2luU2V0dGVyIHNldEN1cnJlbnRQbHVnaW4odGhpcyk7CiAKLSAgICBu b3RJbXBsZW1lbnRlZCgpOworICAgIGlmIChtX2lzV2luZG93ZWQpCisgICAgICAgIHJldHVybjsK KworICAgIGNvbnRyb2xsZXIoKS0+d2lsbFNlbmRFdmVudFRvUGx1Z2luKCk7CisKKyAgICBOUEV2 ZW50IG5wRXZlbnQ7CisgICAgbnBFdmVudC5ldmVudCA9IGhhc0ZvY3VzID8gV01fU0VURk9DVVMg OiBXTV9LSUxMRk9DVVM7CisgICAgbnBFdmVudC53UGFyYW0gPSAwOworICAgIG5wRXZlbnQubFBh cmFtID0gMDsKKworICAgIE5QUF9IYW5kbGVFdmVudCgmbnBFdmVudCk7CiB9CiAKIGJvb2wgTmV0 c2NhcGVQbHVnaW46OnBsYXRmb3JtSGFuZGxlTW91c2VFbnRlckV2ZW50KGNvbnN0IFdlYk1vdXNl RXZlbnQmIGV2ZW50KQo=