63248 2011-06-23 05:22:45 -0700 [GTK] Install a custom X error handler in plugin process 2011-07-15 03:40:54 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) PC Linux RESOLVED FIXED Gtk P2 Normal --- 60546 1 cgarcia webkit-unassigned oldest_to_newest 426097 0 cgarcia 2011-06-23 05:22:45 -0700 Some plugins, specially flash, can cause X errors that when handled by the default X error handler (or the GDK one) abort the process. See also bug #53016. 426098 1 98336 cgarcia 2011-06-23 05:28:04 -0700 Created attachment 98336 Patch Fixes a crash in plugin process when loading http://www.f1.com 426174 2 98336 mrobinson 2011-06-23 07:58:06 -0700 Comment on attachment 98336 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=98336&action=review > Source/WebKit2/PluginProcess/gtk/PluginProcessMainGtk.cpp:41 > + gchar errorMessage[64]; > + XGetErrorText(xdisplay, error->error_code, errorMessage, 63); Is 64 enough here? 426180 3 cgarcia 2011-06-23 08:07:30 -0700 (In reply to comment #2) > (From update of attachment 98336 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=98336&action=review > > > Source/WebKit2/PluginProcess/gtk/PluginProcessMainGtk.cpp:41 > > + gchar errorMessage[64]; > > + XGetErrorText(xdisplay, error->error_code, errorMessage, 63); > > Is 64 enough here? it's based on GDK code, see: http://git.gnome.org/browse/gtk+/tree/gdk/x11/gdkdisplay-x11.c#n2351 so I guess it's enough, we could use something like 1024 to make sure. 437648 4 cgarcia 2011-07-15 03:40:54 -0700 Committed r91062: <http://trac.webkit.org/changeset/91062> 98336 2011-06-23 05:28:04 -0700 2011-06-23 07:58:06 -0700 Patch wk2-plugin-process-x-errors.diff text/plain 2737 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCA5Mzc2MDcyLi5kZWQ2NTg4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjAg QEAKKzIwMTEtMDYtMjMgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29t PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtHVEtd IEluc3RhbGwgYSBjdXN0b20gWCBlcnJvciBoYW5kbGVyIGluIHBsdWdpbiBwcm9jZXNzCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02MzI0OAorCisgICAg ICAgIFNvbWUgcGx1Z2lucywgc3BlY2lhbGx5IGZsYXNoLCBjYW4gY2F1c2UgWCBlcnJvcnMgdGhh dCB3aGVuCisgICAgICAgIGhhbmRsZWQgYnkgdGhlIGRlZmF1bHQgWCBlcnJvciBoYW5kbGVyIChv ciB0aGUgR0RLIG9uZSkgYWJvcnQgdGhlCisgICAgICAgIHByb2Nlc3MuIFNpbmNlIHdlIGRvbid0 IHdhbnQgdG8gY3Jhc2ggZHVlIHRvIGJ1Z2d5IHBsdWdpbnMsIHdlCisgICAgICAgIGluc3RhbGwg YSBjdXN0b20gZXJyb3IgaGFuZGxlciB0byBzaG93IGEgd2FybmluZyB3aGVuIGEgWCBlcnJvcgor ICAgICAgICBoYXBwZW5zIHdpdGhvdXQgYWJvcnRpbmcuCisKKyAgICAgICAgKiBQbHVnaW5Qcm9j ZXNzL2d0ay9QbHVnaW5Qcm9jZXNzTWFpbkd0ay5jcHA6CisgICAgICAgIChXZWJLaXQ6OndlYmtp dGd0a1hFcnJvcik6CisgICAgICAgIChXZWJLaXQ6OlBsdWdpblByb2Nlc3NNYWluR3RrKToKKwog MjAxMS0wNi0yMiAgQ2FybG9zIEdhcmNpYSBDYW1wb3MgIDxjZ2FyY2lhQGlnYWxpYS5jb20+CiAK ICAgICAgICAgUmV2aWV3ZWQgYnkgTWFydGluIFJvYmluc29uLgpkaWZmIC0tZ2l0IGEvU291cmNl L1dlYktpdDIvUGx1Z2luUHJvY2Vzcy9ndGsvUGx1Z2luUHJvY2Vzc01haW5HdGsuY3BwIGIvU291 cmNlL1dlYktpdDIvUGx1Z2luUHJvY2Vzcy9ndGsvUGx1Z2luUHJvY2Vzc01haW5HdGsuY3BwCmlu ZGV4IDJmYjAwODguLmRlNzdkZDAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1BsdWdpblBy b2Nlc3MvZ3RrL1BsdWdpblByb2Nlc3NNYWluR3RrLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9Q bHVnaW5Qcm9jZXNzL2d0ay9QbHVnaW5Qcm9jZXNzTWFpbkd0ay5jcHAKQEAgLTI4LDEyICsyOCwy NyBAQAogCiAjaW5jbHVkZSAiUGx1Z2luUHJvY2Vzcy5oIgogI2luY2x1ZGUgPFdlYktpdDIvUnVu TG9vcC5oPgorI2luY2x1ZGUgPGdkay9nZGt4Lmg+CiAjaW5jbHVkZSA8Z3RrL2d0ay5oPgogI2lu Y2x1ZGUgPHJ1bnRpbWUvSW5pdGlhbGl6ZVRocmVhZGluZy5oPgogI2luY2x1ZGUgPHd0Zi9UaHJl YWRpbmcuaD4KIAogbmFtZXNwYWNlIFdlYktpdCB7CiAKK3N0YXRpYyBpbnQgd2Via2l0Z3RrWEVy cm9yKERpc3BsYXkqIHhkaXNwbGF5LCBYRXJyb3JFdmVudCogZXJyb3IpCit7CisgICAgZ2NoYXIg ZXJyb3JNZXNzYWdlWzY0XTsKKyAgICBYR2V0RXJyb3JUZXh0KHhkaXNwbGF5LCBlcnJvci0+ZXJy b3JfY29kZSwgZXJyb3JNZXNzYWdlLCA2Myk7CisgICAgZ193YXJuaW5nKCJUaGUgcHJvZ3JhbSAn JXMnIHJlY2VpdmVkIGFuIFggV2luZG93IFN5c3RlbSBlcnJvci5cbiIKKyAgICAgICAgICAgICAg IlRoaXMgcHJvYmFibHkgcmVmbGVjdHMgYSBidWcgaW4gYSBicm93c2VyIHBsdWdpbi5cbiIKKyAg ICAgICAgICAgICAgIlRoZSBlcnJvciB3YXMgJyVzJy5cbiIKKyAgICAgICAgICAgICAgIiAgKERl dGFpbHM6IHNlcmlhbCAlbGQgZXJyb3JfY29kZSAlZCByZXF1ZXN0X2NvZGUgJWQgbWlub3JfY29k ZSAlZClcbiIsCisgICAgICAgICAgICAgIGdfZ2V0X3ByZ25hbWUoKSwgZXJyb3JNZXNzYWdlLAor ICAgICAgICAgICAgICBlcnJvci0+c2VyaWFsLCBlcnJvci0+ZXJyb3JfY29kZSwKKyAgICAgICAg ICAgICAgZXJyb3ItPnJlcXVlc3RfY29kZSwgZXJyb3ItPm1pbm9yX2NvZGUpOworICAgIHJldHVy biAwOworfQorCiBXS19FWFBPUlQgaW50IFBsdWdpblByb2Nlc3NNYWluR3RrKGludCBhcmdjLCBj aGFyKiBhcmd2W10pCiB7CiAgICAgQVNTRVJUKGFyZ2MgPT0gMik7CkBAIC00NCw2ICs1OSwxMSBA QCBXS19FWFBPUlQgaW50IFBsdWdpblByb2Nlc3NNYWluR3RrKGludCBhcmdjLCBjaGFyKiBhcmd2 W10pCiAgICAgV1RGOjppbml0aWFsaXplTWFpblRocmVhZCgpOwogICAgIFJ1bkxvb3A6OmluaXRp YWxpemVNYWluUnVuTG9vcCgpOwogCisgICAgLy8gUGx1Z2lucyBjYW4gcHJvZHVjZSBYIGVycm9y cyB0aGF0IGFyZSBoYW5kbGVkIGJ5IHRoZSBHREsgWCBlcnJvciBoYW5kbGVyLCB3aGljaAorICAg IC8vIGV4aXRzIHRoZSBwcm9jZXNzLiBTaW5jZSB3ZSBkb24ndCB3YW50IHRvIGNyYXNoIGR1ZSB0 byBwbHVnaW4gYnVncywgd2UgaW5zdGFsbCBhCisgICAgLy8gY3VzdG9tIGVycm9yIGhhbmRsZXIg dG8gc2hvdyBhIHdhcm5pbmcgd2hlbiBhIFggZXJyb3IgaGFwcGVucyB3aXRob3V0IGFib3J0aW5n LgorICAgIFhTZXRFcnJvckhhbmRsZXIod2Via2l0Z3RrWEVycm9yKTsKKwogICAgIGludCBzb2Nr ZXQgPSBhdG9pKGFyZ3ZbMV0pOwogICAgIFdlYktpdDo6UGx1Z2luUHJvY2Vzczo6c2hhcmVkKCku aW5pdGlhbGl6ZShzb2NrZXQsIFJ1bkxvb3A6Om1haW4oKSk7CiAgICAgUnVuTG9vcDo6cnVuKCk7 Cg==