63237 2011-06-23 01:56:27 -0700 [Qt] Fix tst_QWebFrame::setUrlWithPendingLoads() API test 2012-11-14 05:29:56 -0800 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) All All RESOLVED FIXED Qt, QtTriaged P2 Normal --- 38654 1 ossy ossy aparna.nand hausmann jturcotte ossy oldest_to_newest 426028 0 ossy 2011-06-23 01:56:27 -0700 http://build.webkit.org/builders/Qt%20Linux%20Release/builds/34519 FAIL! : tst_QWebFrame::setUrlWithPendingLoads() Received a fatal error. Loc: [Unknown file(0)] 426108 1 ossy 2011-06-23 05:51:50 -0700 Marked as expected fails: http://trac.webkit.org/changeset/89561 440527 2 aparna.nand 2011-07-21 11:42:12 -0700 Cause for this failure: 1. setHtml is done first and this makes request to cache loader to load the image. This in turn makes an asynchronous request and even before the asynchronous call is completed setUrl is called. 2. setUrl does not cancel the previous request before loading the new url. Hence the problem. Would it be acceptable to cancel the request before actually going on to clear the frame like: void QWebFrame::setUrl(const QUrl &url) { d->frame->loader()->stopForUserCancel(); clearCoreFrame(d->frame); ... } Alternately the test case would pass if we add waitForSignal between the setHtml and setUrl calls. 766755 3 174131 ossy 2012-11-14 04:42:22 -0800 Created attachment 174131 Patch 766781 4 174131 ossy 2012-11-14 05:29:50 -0800 Comment on attachment 174131 Patch Clearing flags on attachment: 174131 Committed r134596: <http://trac.webkit.org/changeset/134596> 766782 5 ossy 2012-11-14 05:29:56 -0800 All reviewed patches have been landed. Closing bug. 174131 2012-11-14 04:42:22 -0800 2012-11-14 05:29:50 -0800 Patch bug-63237-20121114044021.patch text/plain 1947 ossy U3VidmVyc2lvbiBSZXZpc2lvbjogMTM0NTkyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L3F0 L0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvcXQvQ2hhbmdlTG9nCmluZGV4IGNkZWI0YWE1MGI4 NzVmNWY3YWEwZjJlNDc3MmI2NDRlNjMwODI4MzkuLjFlNzk1NGU2NDEyODI2NjUxZjM4NzQ2ZDli MTUxMTJhYzE4MWU3NjQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvcXQvQ2hhbmdlTG9nCisr KyBiL1NvdXJjZS9XZWJLaXQvcXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTItMTEt MTQgIENzYWJhIE9zenRyb2dvbsOhYyAgPG9zc3lAd2Via2l0Lm9yZz4KKworICAgICAgICBbUXRd IEZpeCB0c3RfUVdlYkZyYW1lOjpzZXRVcmxXaXRoUGVuZGluZ0xvYWRzKCkgQVBJIHRlc3QKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTYzMjM3CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVW5jb21tZW50IHRo aXMgQVBJIHRlc3QsIGJlY2F1c2UgaXQgd29ya3MgZmluZSBub3cuCisKKyAgICAgICAgKiB0ZXN0 cy9xd2ViZnJhbWUvdHN0X3F3ZWJmcmFtZS5jcHA6CisgICAgICAgICh0c3RfUVdlYkZyYW1lKToK KyAgICAgICAgKHRzdF9RV2ViRnJhbWU6OnNldFVybFdpdGhQZW5kaW5nTG9hZHMpOgorCiAyMDEy LTExLTE0ICBBbmRyYXMgQmVjc2kgIDxhbmRyYXMuYmVjc2lAZGlnaWEuY29tPgogCiAgICAgICAg IFtRdF0gUVN0eWxlRmFjYWRlSW1wIHNob3VsZCB1c2UgYSBRUG9pbnRlciB0byBzdG9yZSB0aGUg YXBwbGljYXRpb24gc3R5bGUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvcXQvdGVzdHMvcXdl YmZyYW1lL3RzdF9xd2ViZnJhbWUuY3BwIGIvU291cmNlL1dlYktpdC9xdC90ZXN0cy9xd2ViZnJh bWUvdHN0X3F3ZWJmcmFtZS5jcHAKaW5kZXggZmQxMjZkODIzMzFlNzg1ZjQ2ZTViNmRlMmQ5ZTUw OTMzYjEwZmVmOC4uNTkzN2IyYWU5ZGY0NTgxMmE4NDQyNjU4M2FlM2JiYTMyM2M2ZmIyOCAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYktpdC9xdC90ZXN0cy9xd2ViZnJhbWUvdHN0X3F3ZWJmcmFtZS5j cHAKKysrIGIvU291cmNlL1dlYktpdC9xdC90ZXN0cy9xd2ViZnJhbWUvdHN0X3F3ZWJmcmFtZS5j cHAKQEAgLTg0LDcgKzg0LDcgQEAgcHJpdmF0ZSBRX1NMT1RTOgogICAgIHZvaWQgc2V0Q29udGVu dF9kYXRhKCk7CiAgICAgdm9pZCBzZXRDb250ZW50KCk7CiAgICAgdm9pZCBzZXRDYWNoZUxvYWRD b250cm9sQXR0cmlidXRlKCk7Ci0gICAgLy92b2lkIHNldFVybFdpdGhQZW5kaW5nTG9hZHMoKTsK KyAgICB2b2lkIHNldFVybFdpdGhQZW5kaW5nTG9hZHMoKTsKICAgICB2b2lkIHNldFVybFdpdGhG cmFnbWVudF9kYXRhKCk7CiAgICAgdm9pZCBzZXRVcmxXaXRoRnJhZ21lbnQoKTsKICAgICB2b2lk IHNldFVybFRvRW1wdHkoKTsKQEAgLTExMTcsMTYgKzExMTcsMTIgQEAgdm9pZCB0c3RfUVdlYkZy YW1lOjpzZXRDYWNoZUxvYWRDb250cm9sQXR0cmlidXRlKCkKICAgICBRQ09NUEFSRShtYW5hZ2Vy LT5sYXN0Q2FjaGVMb2FkKCksIFFOZXR3b3JrUmVxdWVzdDo6UHJlZmVyTmV0d29yayk7CiB9CiAK LS8vIFtRdF0gRml4IHRzdF9RV2ViRnJhbWU6OnNldFVybFdpdGhQZW5kaW5nTG9hZHMoKSBBUEkg dGVzdAotLy8gaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTYzMjM3Ci0v Kgogdm9pZCB0c3RfUVdlYkZyYW1lOjpzZXRVcmxXaXRoUGVuZGluZ0xvYWRzKCkKIHsKICAgICBR V2ViUGFnZSBwYWdlOwogICAgIHBhZ2UubWFpbkZyYW1lKCktPnNldEh0bWwoIjxpbWcgc3JjPSdk dW1teTonLz4iKTsKICAgICBwYWdlLm1haW5GcmFtZSgpLT5zZXRVcmwoUVVybCgiYWJvdXQ6Ymxh bmsiKSk7CiB9Ci0qLwogCiB2b2lkIHRzdF9RV2ViRnJhbWU6OnNldFVybFdpdGhGcmFnbWVudF9k YXRhKCkKIHsK