63221 2011-06-22 19:27:23 -0700 sheriffbot can no longer restart 2011-06-23 14:43:55 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 webkit.review.bot abarth abarth eric oldest_to_newest 425888 0 webkit.review.bot 2011-06-22 19:27:23 -0700 sheriffbot can no longer restart Requested by abarth on #webkit. 425889 1 abarth 2011-06-22 19:28:01 -0700 Eric broke this when catching Exception. We use exceptions to terminate! 425906 2 eric 2011-06-22 19:51:37 -0700 Since when do good designs use exceptions for normal control flow? :p. Besides, the unit tests pass. :) 425922 3 abarth 2011-06-22 20:18:05 -0700 You're welcome to change the design when you fix the bug. :) 426335 4 98376 eric 2011-06-23 11:56:57 -0700 Created attachment 98376 Patch 426430 5 98376 abarth 2011-06-23 13:58:57 -0700 Comment on attachment 98376 Patch Nice. I didn't know that about SystemExit. 426487 6 webkit.review.bot 2011-06-23 14:42:10 -0700 The commit-queue encountered the following flaky tests while processing attachment 98376: fast/filesystem/file-writer-truncate-extend.html bug 63292 (author: ericu@chromium.org) The commit-queue is continuing to process your patch. 426490 7 98376 webkit.review.bot 2011-06-23 14:43:50 -0700 Comment on attachment 98376 Patch Clearing flags on attachment: 98376 Committed r89618: <http://trac.webkit.org/changeset/89618> 426491 8 webkit.review.bot 2011-06-23 14:43:55 -0700 All reviewed patches have been landed. Closing bug. 98376 2011-06-23 11:56:57 -0700 2011-06-23 14:43:49 -0700 Patch bug-63221-20110623115656.patch text/plain 5197 eric U3VidmVyc2lvbiBSZXZpc2lvbjogODk1ODkKZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBi L1Rvb2xzL0NoYW5nZUxvZwppbmRleCA4MTZmYzMwMmFhY2ZmZWEwMGI4YzA5ZjEzNmI4YTRjMmEz MjVmOGI5Li45MWIxOGRkYTM3NWQ2ZTJlMzhkZGZiODNiYjY2MzJkYjc3MDQxYzU4IDEwMDY0NAot LS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYg QEAKKzIwMTEtMDYtMjMgIEVyaWMgU2VpZGVsICA8ZXJpY0B3ZWJraXQub3JnPgorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIHNoZXJpZmZib3QgY2FuIG5v IGxvbmdlciByZXN0YXJ0CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD02MzIyMQorCisgICAgICAgIEZpeGVkIGFuZCB1bml0IHRlc3RlZC4KKworICAgICAg ICAqIFNjcmlwdHMvd2Via2l0cHkvdG9vbC9ib3QvcXVldWVlbmdpbmUucHk6CisgICAgICAgICog U2NyaXB0cy93ZWJraXRweS90b29sL2JvdC9zaGVyaWZmaXJjYm90LnB5OgorICAgICAgICAqIFNj cmlwdHMvd2Via2l0cHkvdG9vbC9ib3Qvc2hlcmlmZmlyY2JvdF91bml0dGVzdC5weToKKwogMjAx MS0wNi0yMyAgQWRhbSBSb2JlbiAgPGFyb2JlbkBhcHBsZS5jb20+CiAKICAgICAgICAgTWFrZSBm aW5kaW5nIGV4aXN0aW5nIGJ1Z3MgYW5kIGZpbGluZyBuZXcgYnVncyB3b3JrIG9uIFRlc3RGYWls dXJlcyBldmVuIHdoZW4gbG90cyBvZiB0ZXN0cyBhcmUgZmFpbGluZwpkaWZmIC0tZ2l0IGEvVG9v bHMvU2NyaXB0cy93ZWJraXRweS90b29sL2JvdC9xdWV1ZWVuZ2luZS5weSBiL1Rvb2xzL1Njcmlw dHMvd2Via2l0cHkvdG9vbC9ib3QvcXVldWVlbmdpbmUucHkKaW5kZXggOGIwMTZlOGQ2NGZjNGU3 ZDI5OGQwZTQxMTA0MmUzYTc0YWQyNzA4ZC4uMmYwODdiZmNkNWIyZDk3MmI3YjJkYzhjMWFkMTdj YzY0MmMzNzQ0YSAxMDA2NDQKLS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS90b29sL2JvdC9x dWV1ZWVuZ2luZS5weQorKysgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3Rvb2wvYm90L3F1ZXVl ZW5naW5lLnB5CkBAIC0zNyw2ICszNyw4IEBAIGZyb20gd2Via2l0cHkuY29tbW9uLnN5c3RlbS5l eGVjdXRpdmUgaW1wb3J0IFNjcmlwdEVycm9yCiBmcm9tIHdlYmtpdHB5LmNvbW1vbi5zeXN0ZW0u ZGVwcmVjYXRlZF9sb2dnaW5nIGltcG9ydCBsb2csIE91dHB1dFRlZQogCiAKKyMgRklYTUU6IFRo aXMgd2lsbCBiZSBjYXVnaHQgYnkgImV4Y2VwdCBFeGNlcHRpb246IiBibG9ja3MsIHdlIHNob3Vs ZCBjb25zaWRlcgorIyBtYWtpbmcgdGhpcyBpbmhlcml0IGZyb20gU3lzdGVtRXhpdCBpbnN0ZWFk IChvciBCYXNlRXhjZXB0aW9uLCBleGNlcHQgdGhhdCdzIG5vdCByZWNvbW1lbmRlZCkuCiBjbGFz cyBUZXJtaW5hdGVRdWV1ZShFeGNlcHRpb24pOgogICAgIHBhc3MKIApkaWZmIC0tZ2l0IGEvVG9v bHMvU2NyaXB0cy93ZWJraXRweS90b29sL2JvdC9zaGVyaWZmaXJjYm90LnB5IGIvVG9vbHMvU2Ny aXB0cy93ZWJraXRweS90b29sL2JvdC9zaGVyaWZmaXJjYm90LnB5CmluZGV4IDU1YzVlYWIwOGQy YTIyYTk0Mjg3Y2M5OTdkMTQ5ZmU3NjE3NWIxMmMuLjcyNjljMmVjNTg2NTIwMDE4M2RjNTIxYWYy NmM4ZTIwODNiYzlkYjUgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvdG9vbC9i b3Qvc2hlcmlmZmlyY2JvdC5weQorKysgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3Rvb2wvYm90 L3NoZXJpZmZpcmNib3QucHkKQEAgLTI3LDcgKzI3LDcgQEAKICMgT0YgVEhJUyBTT0ZUV0FSRSwg RVZFTiBJRiBBRFZJU0VEIE9GIFRIRSBQT1NTSUJJTElUWSBPRiBTVUNIIERBTUFHRS4KIAogZnJv bSB3ZWJraXRweS50b29sLmJvdCBpbXBvcnQgaXJjX2NvbW1hbmQKLQorZnJvbSB3ZWJraXRweS50 b29sLmJvdC5xdWV1ZWVuZ2luZSBpbXBvcnQgVGVybWluYXRlUXVldWUKIGZyb20gd2Via2l0cHku Y29tbW9uLm5ldC5pcmMuaXJjYm90IGltcG9ydCBJUkNCb3REZWxlZ2F0ZQogZnJvbSB3ZWJraXRw eS5jb21tb24udGhyZWFkLnRocmVhZGVkbWVzc2FnZXF1ZXVlIGltcG9ydCBUaHJlYWRlZE1lc3Nh Z2VRdWV1ZQogCkBAIC03OCw2ICs3OCw5IEBAIGNsYXNzIFNoZXJpZmZJUkNCb3Qob2JqZWN0KToK ICAgICAgICAgICAgIHJlc3BvbnNlID0gY29tbWFuZCgpLmV4ZWN1dGUocmVxdWVzdGVyX25pY2ss IGFyZ3MsIHNlbGYuX3Rvb2wsIHNlbGYuX3NoZXJpZmYpCiAgICAgICAgICAgICBpZiByZXNwb25z ZToKICAgICAgICAgICAgICAgICBzZWxmLl90b29sLmlyYygpLnBvc3QocmVzcG9uc2UpCisgICAg ICAgIGV4Y2VwdCBUZXJtaW5hdGVRdWV1ZToKKyAgICAgICAgICAgIHJhaXNlCisgICAgICAgICMg VGhpcyB3aWxsIGNhdGNoIGV2ZXJ5dGhpbmcgZWxzZS4gU3lzdGVtRXhpdCBhbmQgS2V5Ym9hcmRJ bnRlcnJ1cHQgYXJlIG5vdCBzdWJjbGFzc2VzIG9mIEV4Y2VwdGlvbiwgc28gd2Ugd29uJ3QgY2F0 Y2ggdGhvc2UuCiAgICAgICAgIGV4Y2VwdCBFeGNlcHRpb24sIGU6CiAgICAgICAgICAgICBzZWxm Ll90b29sLmlyYygpLnBvc3QoIkV4Y2VwdGlvbiBleGVjdXRpbmcgY29tbWFuZDogJXMiICUgZSkK IApkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS90b29sL2JvdC9zaGVyaWZmaXJj Ym90X3VuaXR0ZXN0LnB5IGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS90b29sL2JvdC9zaGVyaWZm aXJjYm90X3VuaXR0ZXN0LnB5CmluZGV4IDZjYjAwZjU4YzQ2YWEyZjgyMTVmN2JkMzJmYTRlMzQ5 MzZkY2M2ZWEuLjYzMjkzYmMzZGFjMjllOTk4ZWFmZjI4MmExZDM0ZDM0NzBhZmUzZjcgMTAwNjQ0 Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvdG9vbC9ib3Qvc2hlcmlmZmlyY2JvdF91bml0 dGVzdC5weQorKysgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3Rvb2wvYm90L3NoZXJpZmZpcmNi b3RfdW5pdHRlc3QucHkKQEAgLTMxLDYgKzMxLDcgQEAgaW1wb3J0IHJhbmRvbQogCiBmcm9tIHdl YmtpdHB5LmNvbW1vbi5zeXN0ZW0ub3V0cHV0Y2FwdHVyZSBpbXBvcnQgT3V0cHV0Q2FwdHVyZQog ZnJvbSB3ZWJraXRweS50b29sLmJvdCBpbXBvcnQgaXJjX2NvbW1hbmQKK2Zyb20gd2Via2l0cHku dG9vbC5ib3QucXVldWVlbmdpbmUgaW1wb3J0IFRlcm1pbmF0ZVF1ZXVlCiBmcm9tIHdlYmtpdHB5 LnRvb2wuYm90LnNoZXJpZmYgaW1wb3J0IFNoZXJpZmYKIGZyb20gd2Via2l0cHkudG9vbC5ib3Qu c2hlcmlmZmlyY2JvdCBpbXBvcnQgU2hlcmlmZklSQ0JvdAogZnJvbSB3ZWJraXRweS50b29sLmJv dC5zaGVyaWZmX3VuaXR0ZXN0IGltcG9ydCBNb2NrU2hlcmlmZkJvdApAQCAtNjcsNiArNjgsMTQg QEAgY2xhc3MgU2hlcmlmZklSQ0JvdFRlc3QodW5pdHRlc3QuVGVzdENhc2UpOgogICAgICAgICBl eHBlY3RlZF9zdGRlcnIgPSAnTU9DSzogaXJjLnBvc3Q6IEV4Y2VwdGlvbiBleGVjdXRpbmcgY29t bWFuZDogbW9ja19leGNlcHRpb25cbicKICAgICAgICAgT3V0cHV0Q2FwdHVyZSgpLmFzc2VydF9v dXRwdXRzKHNlbGYsIGJvdC5wcm9jZXNzX21lc3NhZ2UsIGFyZ3M9WyJtb2NrX25pY2siLCAiaWdu b3JlZCBtZXNzYWdlIl0sIGV4cGVjdGVkX3N0ZGVycj1leHBlY3RlZF9zdGRlcnIpCiAKKyAgICAg ICAgY2xhc3MgQ29tbWFuZFdpdGhFeGNlcHRpb24ob2JqZWN0KToKKyAgICAgICAgICAgIGRlZiBl eGVjdXRlKHNlbGYsIG5pY2ssIGFyZ3MsIHRvb2wsIHNoZXJpZmYpOgorICAgICAgICAgICAgICAg IHJhaXNlIEtleWJvYXJkSW50ZXJydXB0KCkKKworICAgICAgICBib3QuX3BhcnNlX2NvbW1hbmRf YW5kX2FyZ3MgPSBsYW1iZGEgcmVxdWVzdDogKENvbW1hbmRXaXRoRXhjZXB0aW9uLCBbXSkKKyAg ICAgICAgIyBLZXlib2FyZEludGVycnVwdCBhbmQgU3lzdGVtRXhpdCBhcmUgbm90IHN1YmNsYXNz ZXMgb2YgRXhjZXB0aW9uIGFuZCB0aHVzIGNvcnJlY3RseSB3aWxsIG5vdCBiZSBjYXVnaHQuCisg ICAgICAgIE91dHB1dENhcHR1cmUoKS5hc3NlcnRfb3V0cHV0cyhzZWxmLCBib3QucHJvY2Vzc19t ZXNzYWdlLCBhcmdzPVsibW9ja19uaWNrIiwgImlnbm9yZWQgbWVzc2FnZSJdLCBleHBlY3RlZF9l eGNlcHRpb249S2V5Ym9hcmRJbnRlcnJ1cHQpCisKICAgICBkZWYgdGVzdF9oaShzZWxmKToKICAg ICAgICAgcmFuZG9tLnNlZWQoMjMzMjQpCiAgICAgICAgIGV4cGVjdGVkX3N0ZGVyciA9ICdNT0NL OiBpcmMucG9zdDogIk9ubHkgeW91IGNhbiBwcmV2ZW50IGZvcmVzdCBmaXJlcy4iIC0tIFNtb2tl eSB0aGUgQmVhclxuJwpAQCAtODAsNiArODksMTAgQEAgY2xhc3MgU2hlcmlmZklSQ0JvdFRlc3Qo dW5pdHRlc3QuVGVzdENhc2UpOgogICAgICAgICBleHBlY3RlZF9zdGRlcnIgPSAiTU9DSzogaXJj LnBvc3Q6IG1vY2tfbmljazogaHR0cDovL3RyYWMud2Via2l0Lm9yZy9jaGFuZ2VzZXQvOTQ3OVxu IgogICAgICAgICBPdXRwdXRDYXB0dXJlKCkuYXNzZXJ0X291dHB1dHMoc2VsZiwgcnVuLCBhcmdz PVsibGFzdC1ncmVlbi1yZXZpc2lvbiJdLCBleHBlY3RlZF9zdGRlcnI9ZXhwZWN0ZWRfc3RkZXJy KQogCisgICAgZGVmIHRlc3RfcmVzdGFydChzZWxmKToKKyAgICAgICAgZXhwZWN0ZWRfc3RkZXJy ID0gIk1PQ0s6IGlyYy5wb3N0OiBSZXN0YXJ0aW5nLi4uXG4iCisgICAgICAgIE91dHB1dENhcHR1 cmUoKS5hc3NlcnRfb3V0cHV0cyhzZWxmLCBydW4sIGFyZ3M9WyJyZXN0YXJ0Il0sIGV4cGVjdGVk X3N0ZGVycj1leHBlY3RlZF9zdGRlcnIsIGV4cGVjdGVkX2V4Y2VwdGlvbj1UZXJtaW5hdGVRdWV1 ZSkKKwogICAgIGRlZiB0ZXN0X3JvbGxvdXQoc2VsZik6CiAgICAgICAgIGV4cGVjdGVkX3N0ZGVy ciA9ICJNT0NLOiBpcmMucG9zdDogbW9ja19uaWNrLCBhYmFydGgsIGRhcmluLCBlc2VpZGVsOiBQ cmVwYXJpbmcgcm9sbG91dCBmb3IgaHR0cDovL3RyYWMud2Via2l0Lm9yZy9jaGFuZ2VzZXQvMjE2 NTQuLi5cbk1PQ0s6IGlyYy5wb3N0OiBtb2NrX25pY2ssIGFiYXJ0aCwgZGFyaW4sIGVzZWlkZWw6 IENyZWF0ZWQgcm9sbG91dDogaHR0cDovL2V4YW1wbGUuY29tLzM2OTM2XG4iCiAgICAgICAgIE91 dHB1dENhcHR1cmUoKS5hc3NlcnRfb3V0cHV0cyhzZWxmLCBydW4sIGFyZ3M9WyJyb2xsb3V0IDIx NjU0IFRoaXMgcGF0Y2ggYnJva2UgdGhlIHdvcmxkIl0sIGV4cGVjdGVkX3N0ZGVycj1leHBlY3Rl ZF9zdGRlcnIpCg==