63199 2011-06-22 16:12:06 -0700 new-run-webkit-tests: images page switch actual and expected images before they're loaded 2011-06-29 19:30:20 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 34984 1 rniwa abarth abarth dpranke ojan webkit.review.bot oldest_to_newest 425709 0 rniwa 2011-06-22 16:12:06 -0700 Go to http://build.webkit.org/results/Chromium%20Mac%20Release%20(Tests)/r89486%20(8473)/fast/borders/border-radius-wide-border-01-diffs.html The script starts swapping images immediately even before images are loaded. This results in weird behavior where I see the same image for Actual and Expected because one of them haven't been loaded yet. We shouldn't switch between images until both images are loaded. 430086 1 99204 abarth 2011-06-29 18:48:21 -0700 Created attachment 99204 Patch 430090 2 99204 eric 2011-06-29 18:49:33 -0700 Comment on attachment 99204 Patch OK. 430116 3 99204 webkit.review.bot 2011-06-29 19:30:15 -0700 Comment on attachment 99204 Patch Clearing flags on attachment: 99204 Committed r90081: <http://trac.webkit.org/changeset/90081> 430117 4 webkit.review.bot 2011-06-29 19:30:20 -0700 All reviewed patches have been landed. Closing bug. 99204 2011-06-29 18:48:21 -0700 2011-06-29 19:30:15 -0700 Patch bug-63199-20110629184819.patch text/plain 3589 abarth SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDkwMDc3KQorKysgVG9vbHMvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMg KzEsMTYgQEAKKzIwMTEtMDYtMjkgIEFkYW0gQmFydGggIDxhYmFydGhAd2Via2l0Lm9yZz4KKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBuZXctcnVuLXdl YmtpdC10ZXN0czogaW1hZ2VzIHBhZ2Ugc3dpdGNoIGFjdHVhbCBhbmQgZXhwZWN0ZWQgaW1hZ2Vz IGJlZm9yZSB0aGV5J3JlIGxvYWRlZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9NjMxOTkKKworICAgICAgICBXZSBub3cgcHJlbG9hZCB0aGUgaW1hZ2Vz IGFuZCBrZWVwIHRoZSBET00gbm9kZXMgaW4gbWVtb3J5IGluc3RlYWQgb2YKKyAgICAgICAgZ29p bmcgYmFjayB0byB0aGUgTWVtb3J5Q2FjaGUgYWxsIHRoZSB0aW1lLiAgKEFsc28sIHJlbW92ZSBz b21lIG51dHR5CisgICAgICAgIDwvaW1nPiBIVE1MLikKKworICAgICAgICAqIFNjcmlwdHMvd2Vi a2l0cHkvbGF5b3V0X3Rlc3RzL2xheW91dF9wYWNrYWdlL3Rlc3RfcmVzdWx0X3dyaXRlci5weToK KwogMjAxMS0wNi0yOSAgRXJpYyBTZWlkZWwgIDxlcmljQHdlYmtpdC5vcmc+CiAKICAgICAgICAg UmV2aWV3ZWQgYnkgQWRhbSBCYXJ0aC4KSW5kZXg6IFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5 b3V0X3Rlc3RzL2xheW91dF9wYWNrYWdlL3Rlc3RfcmVzdWx0X3dyaXRlci5weQo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBUb29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9sYXlvdXRfcGFja2FnZS90 ZXN0X3Jlc3VsdF93cml0ZXIucHkJKHJldmlzaW9uIDkwMDc2KQorKysgVG9vbHMvU2NyaXB0cy93 ZWJraXRweS9sYXlvdXRfdGVzdHMvbGF5b3V0X3BhY2thZ2UvdGVzdF9yZXN1bHRfd3JpdGVyLnB5 CSh3b3JraW5nIGNvcHkpCkBAIC0yMzIsMjYgKzIzMiw1MiBAQCBjbGFzcyBUZXN0UmVzdWx0V3Jp dGVyKG9iamVjdCk6CiAgICAgICAgIGRpZmZzX2h0bWxfZmlsZW5hbWUgPSBzZWxmLm91dHB1dF9m aWxlbmFtZShzZWxmLkZJTEVOQU1FX1NVRkZJWF9JTUFHRV9ESUZGU19IVE1MKQogICAgICAgICAj IEZJWE1FOiBvbGQtcnVuLXdlYmtpdC10ZXN0cyBzaG93cyB0aGUgZGlmZiBwZXJjZW50YWdlIGFz IHRoZSB0ZXh0IGNvbnRlbnRzIG9mIHRoZSAiZGlmZiIgbGluay4KICAgICAgICAgIyBGSVhNRTog b2xkLXJ1bi13ZWJraXQtdGVzdHMgaW5jbHVkZSBhIGxpbmsgdG8gdGhlIHRlc3QgZmlsZS4KLSAg ICAgICAgaHRtbCA9ICIiIjwhRE9DVFlQRSBIVE1MPjx0aXRsZT4lKHRpdGxlKXM8L3RpdGxlPgor ICAgICAgICBodG1sID0gIiIiPCFET0NUWVBFIEhUTUw+Cis8aHRtbD4KKzxoZWFkPgorPHRpdGxl PiUodGl0bGUpczwvdGl0bGU+CiA8c3R5bGU+LmxhYmVse2ZvbnQtd2VpZ2h0OmJvbGR9PC9zdHls ZT4KKzwvaGVhZD4KKzxib2R5PgogRGlmZmVyZW5jZSBiZXR3ZWVuIGltYWdlczogPGEgaHJlZj0i JShkaWZmX2ZpbGVuYW1lKXMiPmRpZmY8L2E+PGJyPgotPGRpdiBjbGFzcz1pbWFnZVRleHQ+PC9k aXY+PGltZyBjbGFzcz1hbmltYXRlZEltYWdlIGRhdGEtcHJlZml4PSIlKHByZWZpeClzIj48L2lt Zz47Cis8ZGl2IGNsYXNzPWltYWdlVGV4dD48L2Rpdj4KKzxkaXYgY2xhc3M9aW1hZ2VDb250YWlu ZXIgZGF0YS1wcmVmaXg9IiUocHJlZml4KXMiPkxvYWRpbmcuLi48L2Rpdj4KIDxzY3JpcHQ+Ci0g ICAgZnVuY3Rpb24gdG9nZ2xlSW1hZ2VzKCkKLSAgICB7Ci0gICAgICAgIHZhciBpbWFnZSA9IGRv Y3VtZW50LnF1ZXJ5U2VsZWN0b3IoJy5hbmltYXRlZEltYWdlJyk7Ci0gICAgICAgIHZhciB0ZXh0 ID0gZG9jdW1lbnQucXVlcnlTZWxlY3RvcignLmltYWdlVGV4dCcpOworKGZ1bmN0aW9uKCkgewor ICAgIHZhciBwcmVsb2FkZWRJbWFnZUNvdW50ID0gMDsKKyAgICBmdW5jdGlvbiBwcmVsb2FkQ29t cGxldGUoKSB7CisgICAgICAgICsrcHJlbG9hZGVkSW1hZ2VDb3VudDsKKyAgICAgICAgaWYgKHBy ZWxvYWRlZEltYWdlQ291bnQgPCAyKQorICAgICAgICAgICAgcmV0dXJuOworICAgICAgICB0b2dn bGVJbWFnZXMoKTsKKyAgICAgICAgc2V0SW50ZXJ2YWwodG9nZ2xlSW1hZ2VzLCAyMDAwKQorICAg IH0KKworICAgIGZ1bmN0aW9uIHByZWxvYWRJbWFnZSh1cmwpIHsKKyAgICAgICAgaW1hZ2UgPSBu ZXcgSW1hZ2UoKTsKKyAgICAgICAgaW1hZ2UuYWRkRXZlbnRMaXN0ZW5lcignbG9hZCcsIHByZWxv YWRDb21wbGV0ZSk7CisgICAgICAgIGltYWdlLnNyYyA9IHVybDsKKyAgICAgICAgcmV0dXJuIGlt YWdlOworICAgIH0KKworICAgIGZ1bmN0aW9uIHRvZ2dsZUltYWdlcygpIHsKICAgICAgICAgaWYg KHRleHQudGV4dENvbnRlbnQgPT0gJ0V4cGVjdGVkIEltYWdlJykgewogICAgICAgICAgICAgdGV4 dC50ZXh0Q29udGVudCA9ICdBY3R1YWwgSW1hZ2UnOwotICAgICAgICAgICAgaW1hZ2Uuc3JjID0g aW1hZ2UuZ2V0QXR0cmlidXRlKCdkYXRhLXByZWZpeCcpICsgJy1hY3R1YWwucG5nJzsKKyAgICAg ICAgICAgIGNvbnRhaW5lci5yZXBsYWNlQ2hpbGQoYWN0dWFsSW1hZ2UsIGNvbnRhaW5lci5maXJz dENoaWxkKTsKICAgICAgICAgfSBlbHNlIHsKICAgICAgICAgICAgIHRleHQudGV4dENvbnRlbnQg PSAnRXhwZWN0ZWQgSW1hZ2UnOwotICAgICAgICAgICAgaW1hZ2Uuc3JjID0gaW1hZ2UuZ2V0QXR0 cmlidXRlKCdkYXRhLXByZWZpeCcpICsgJy1leHBlY3RlZC5wbmcnOworICAgICAgICAgICAgY29u dGFpbmVyLnJlcGxhY2VDaGlsZChleHBlY3RlZEltYWdlLCBjb250YWluZXIuZmlyc3RDaGlsZCk7 CiAgICAgICAgIH0KICAgICB9Ci0gICAgdG9nZ2xlSW1hZ2VzKCk7Ci0gICAgc2V0SW50ZXJ2YWwo dG9nZ2xlSW1hZ2VzLCAyMDAwKQorCisgICAgdmFyIHRleHQgPSBkb2N1bWVudC5xdWVyeVNlbGVj dG9yKCcuaW1hZ2VUZXh0Jyk7CisgICAgdmFyIGNvbnRhaW5lciA9IGRvY3VtZW50LnF1ZXJ5U2Vs ZWN0b3IoJy5pbWFnZUNvbnRhaW5lcicpOworICAgIHZhciBhY3R1YWxJbWFnZSA9IHByZWxvYWRJ bWFnZShjb250YWluZXIuZ2V0QXR0cmlidXRlKCdkYXRhLXByZWZpeCcpICsgJy1hY3R1YWwucG5n Jyk7CisgICAgdmFyIGV4cGVjdGVkSW1hZ2UgPSBwcmVsb2FkSW1hZ2UoY29udGFpbmVyLmdldEF0 dHJpYnV0ZSgnZGF0YS1wcmVmaXgnKSArICctZXhwZWN0ZWQucG5nJyk7Cit9KSgpOwogPC9zY3Jp cHQ+Cis8L2JvZHk+Cis8L2h0bWw+CiAiIiIgJSB7ICd0aXRsZSc6IHNlbGYuX3Rlc3RuYW1lLCAn ZGlmZl9maWxlbmFtZSc6IHNlbGYuX291dHB1dF90ZXN0bmFtZSgnLWRpZmYucG5nJyksICdwcmVm aXgnOiBzZWxmLl9vdXRwdXRfdGVzdG5hbWUoJycpIH0KICAgICAgICAgc2VsZi5fcG9ydC5fZmls ZXN5c3RlbS53cml0ZV9iaW5hcnlfZmlsZShkaWZmc19odG1sX2ZpbGVuYW1lLCBodG1sKQogCg==