63186 2011-06-22 14:45:32 -0700 svg/zoom/page/zoom-svg-through-object-with-*.xhtml are flaky 2025-09-20 15:26:05 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All RESOLVED FIXED LayoutTestFailure P2 Normal --- 71673 1 aroben adamk adamk andreip dochez jamesr jberlin lforschler mario ossy reed tkent www.fm1985 zherczeg zimmermann oldest_to_newest 425611 0 aroben 2011-06-22 14:45:32 -0700 The svg/zoom/page/zoom-svg-through-object-with-*.xhtml tests are flaky. See dupes for examples. 425614 1 aroben 2011-06-22 14:46:17 -0700 *** Bug 61664 has been marked as a duplicate of this bug. *** 425616 2 aroben 2011-06-22 14:46:20 -0700 *** Bug 61757 has been marked as a duplicate of this bug. *** 425618 3 aroben 2011-06-22 14:46:22 -0700 *** Bug 61918 has been marked as a duplicate of this bug. *** 425620 4 aroben 2011-06-22 14:46:24 -0700 *** Bug 62023 has been marked as a duplicate of this bug. *** 425622 5 aroben 2011-06-22 14:46:27 -0700 *** Bug 62555 has been marked as a duplicate of this bug. *** 425624 6 aroben 2011-06-22 14:47:00 -0700 *** Bug 62558 has been marked as a duplicate of this bug. *** 425627 7 aroben 2011-06-22 14:47:16 -0700 *** Bug 62560 has been marked as a duplicate of this bug. *** 425629 8 aroben 2011-06-22 14:47:20 -0700 *** Bug 62563 has been marked as a duplicate of this bug. *** 425643 9 aroben 2011-06-22 15:02:47 -0700 Disabled the tests in r89484. 426054 10 zimmermann 2011-06-23 03:01:31 -0700 What a pity, these tests are pretty important :( I haven't been able to reproduce this on my SL machines so far, I'll try --random -p runs soon, maybe I can finally see the problem on my own... 427343 11 zimmermann 2011-06-25 02:54:22 -0700 (In reply to comment #10) > What a pity, these tests are pretty important :( > I haven't been able to reproduce this on my SL machines so far, I'll try --random -p runs soon, maybe I can finally see the problem on my own... Some results: run-webkit-tests --tolerance 0 -p --random svg/zoom/page svg/zoom/page.... No errors. run-webkit-tests --tolerance 0 -p --iterations 20 svg/zoom/page svg/... No errors. Also running without pixel tests makes no difference for me :( Note: I moved the foo-disabled files to foo before running the tests, so I am sure they are enabled. I've also tried -1 (singly) runs, w/o luck in reproducing. 427554 12 aroben 2011-06-26 11:12:02 -0700 Perhaps some earlier test affects these ones? Then the tests would pass or fail depending on exactly when DRT is relaunched (which is dependent on which tests crash, how many tests are run in total, etc.). 427968 13 zimmermann 2011-06-27 08:41:40 -0700 (In reply to comment #12) > Perhaps some earlier test affects these ones? Then the tests would pass or fail depending on exactly when DRT is relaunched (which is dependent on which tests crash, how many tests are run in total, etc.). I'll try to debug more tomorrow. 442193 14 zimmermann 2011-07-26 05:49:10 -0700 The root of all evil is probably the bug described in 64974. I'm working on a proper fix. 447608 15 zimmermann 2011-08-06 08:23:44 -0700 (In reply to comment #14) > The root of all evil is probably the bug described in 64974. I'm working on a proper fix. The fix landed in r92545. It's better now, but there's still a problem with the page zoom tests in general, seems easy to trigger on non-mac eg gtk/win. I'm testing following, as it seems to be a problem that we call notifyDone() right after the zooming. - layoutTestController.notifyDone(); + setTimeout(function() { layoutTestController.notifyDone(); }, 0); Let's see. 447995 16 andreip 2011-08-08 07:49:11 -0700 (In reply to comment #15) > (In reply to comment #14) > > The root of all evil is probably the bug described in 64974. I'm working on a proper fix. > > The fix landed in r92545. It's better now, but there's still a problem with the page zoom tests in general, seems easy to trigger on non-mac eg gtk/win. > > I'm testing following, as it seems to be a problem that we call notifyDone() right after the zooming. > - layoutTestController.notifyDone(); > + setTimeout(function() { layoutTestController.notifyDone(); }, 0); > > Let's see. FYI, these tests currently fail on Chromium too. 448012 17 zimmermann 2011-08-08 08:31:50 -0700 (In reply to comment #16) > (In reply to comment #15) > > (In reply to comment #14) > > > The root of all evil is probably the bug described in 64974. I'm working on a proper fix. > > > > The fix landed in r92545. It's better now, but there's still a problem with the page zoom tests in general, seems easy to trigger on non-mac eg gtk/win. > > > > I'm testing following, as it seems to be a problem that we call notifyDone() right after the zooming. > > - layoutTestController.notifyDone(); > > + setTimeout(function() { layoutTestController.notifyDone(); }, 0); > > > > Let's see. > > FYI, these tests currently fail on Chromium too. You mean they're flakey or fail every time? Or do they just need a re-baseline? 448019 18 andreip 2011-08-08 08:39:10 -0700 (In reply to comment #17) > (In reply to comment #16) > > (In reply to comment #15) > > > (In reply to comment #14) > > > > The root of all evil is probably the bug described in 64974. I'm working on a proper fix. > > > > > > The fix landed in r92545. It's better now, but there's still a problem with the page zoom tests in general, seems easy to trigger on non-mac eg gtk/win. > > > > > > I'm testing following, as it seems to be a problem that we call notifyDone() right after the zooming. > > > - layoutTestController.notifyDone(); > > > + setTimeout(function() { layoutTestController.notifyDone(); }, 0); > > > > > > Let's see. > > > > FYI, these tests currently fail on Chromium too. > You mean they're flakey or fail every time? Or do they just need a re-baseline? They fail every time. I am not sure whether they need a re-baseline or not, the actual results look slightly suspicious: http://test-results.appspot.com/dashboards/flakiness_dashboard.html#showExpectations=true&tests=svg%2Fzoom%2Fpage%2Fzoom-svg-through-object-with-absolute-size-2.xhtml 448467 19 zimmermann 2011-08-09 01:22:36 -0700 (In reply to comment #18) > They fail every time. I am not sure whether they need a re-baseline or not, the actual results look slightly suspicious: > > http://test-results.appspot.com/dashboards/flakiness_dashboard.html#showExpectations=true&tests=svg%2Fzoom%2Fpage%2Fzoom-svg-through-object-with-absolute-size-2.xhtml This is a known problem on Chromium (the extra scrollbar). When these svg/zoom/page/zoom-svg-through-object* tests were landed the first time, they were flakey on at least Win/Chromium/Gtk, producing extra-scrollbars on Chromium all the time, but never on other platforms. The tests should now no longer be flakey - the extra scrollbar problem on chromium remains though. We need someone with Chromium to debug this, I fear. Could you rebaseline them for now, to see whether they are stable at least now on Chromium? 448528 20 andreip 2011-08-09 05:39:13 -0700 (In reply to comment #19) > (In reply to comment #18) > > They fail every time. I am not sure whether they need a re-baseline or not, the actual results look slightly suspicious: > > > > http://test-results.appspot.com/dashboards/flakiness_dashboard.html#showExpectations=true&tests=svg%2Fzoom%2Fpage%2Fzoom-svg-through-object-with-absolute-size-2.xhtml > > This is a known problem on Chromium (the extra scrollbar). > When these svg/zoom/page/zoom-svg-through-object* tests were landed the first time, they were flakey on at least Win/Chromium/Gtk, producing extra-scrollbars on Chromium all the time, but never on other platforms. > > The tests should now no longer be flakey - the extra scrollbar problem on chromium remains though. > We need someone with Chromium to debug this, I fear. > > Could you rebaseline them for now, to see whether they are stable at least now on Chromium? Thanks for the background! I have filed: http://code.google.com/p/chromium/issues/detail?id=92037 and Mike Reed was kind enough to volunteer looking into the issue. Mike, would you be ok with me rebaselining the tests for now? 452242 21 aroben 2011-08-17 07:54:34 -0700 *** Bug 62143 has been marked as a duplicate of this bug. *** 461340 22 jamesr 2011-09-02 11:04:46 -0700 They are not stable, the tests are still flaky on all chromium platforms. The text output differs from run to run. 461341 23 jamesr 2011-09-02 11:04:58 -0700 Example test failure (from a mac): --- /b/build/slave/Webkit_Mac10_6__CG__dbg_/build/layout-test-results/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.txt +++ /b/build/slave/Webkit_Mac10_6__CG__dbg_/build/layout-test-results/svg/zoom/page/zoom-svg-through-object-with-percentage-size-actual.txt @@ -25,7 +25,7 @@ RenderTableCell {td} at (1,90) size 343x263 [r=2 c=0 rs=1 cs=1] RenderEmbeddedObject {object} at (5,5) size 333x250 layer at (0,0) size 333x250 - RenderView at (0,0) size 333x250 + RenderView at (0,0) size 318x235 layer at (0,0) size 333x250 RenderSVGRoot {svg} at (0,0) size 333x250 RenderSVGContainer {g} at (18,31) size 260x164 500164 24 zimmermann 2011-11-10 12:51:49 -0800 (In reply to comment #22) > They are not stable, the tests are still flaky on all chromium platforms. The text output differs from run to run. That's correct, I found the root of the problem. Bug 71673 has a patch, I expect all problems to be gone then. 500641 25 zimmermann 2011-11-11 03:50:48 -0800 (In reply to comment #24) > That's correct, I found the root of the problem. Bug 71673 has a patch, I expect all problems to be gone then. r99937 has the fix. We probably need some rebaselines and expectations update for chromium. Crossing fingers and watching the flakiness dashboard, I hope extra scrollbars are gone everywhere. 507834 26 adamk 2011-11-22 15:09:44 -0800 Committed r101028: <http://trac.webkit.org/changeset/101028>