<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>63086</bug_id>
          
          <creation_ts>2011-06-21 12:21:11 -0700</creation_ts>
          <short_desc>[EFL] DRT: Add DumpRenderTreeView, an ewk_view specialization for DRT</short_desc>
          <delta_ts>2011-06-27 08:12:46 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>New Bugs</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          <blocked>62034</blocked>
          <everconfirmed>0</everconfirmed>
          <reporter name="Raphael Kubo da Costa (:rakuco)">rakuco</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>leandro</cc>
    
    <cc>tkent</cc>
    
    <cc>webkit.review.bot</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>424659</commentid>
    <comment_count>0</comment_count>
    <who name="Raphael Kubo da Costa (:rakuco)">rakuco</who>
    <bug_when>2011-06-21 12:21:11 -0700</bug_when>
    <thetext>[EFL] DRT: Add DumpRenderTreeView, an ewk_view specialization for DRT</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>424660</commentid>
    <comment_count>1</comment_count>
      <attachid>98038</attachid>
    <who name="Raphael Kubo da Costa (:rakuco)">rakuco</who>
    <bug_when>2011-06-21 12:21:41 -0700</bug_when>
    <thetext>Created attachment 98038
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>426045</commentid>
    <comment_count>2</comment_count>
      <attachid>98038</attachid>
    <who name="Kent Tamura">tkent</who>
    <bug_when>2011-06-23 02:27:47 -0700</bug_when>
    <thetext>Comment on attachment 98038
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=98038&amp;action=review

&gt; Tools/DumpRenderTree/efl/DumpRenderTreeView.cpp:38
&gt; +static void onConsoleMessage(Ewk_View_Smart_Data* sd, const char* message, unsigned int lineNumber, const char* sourceID)

&apos;sd&apos; isn&apos;t a good name.
Also, we don&apos;t need to write argument names if they aren&apos;t used in the function body.

&gt; Tools/DumpRenderTree/efl/DumpRenderTreeView.cpp:43
&gt; +static void onJavaScriptAlert(Ewk_View_Smart_Data* sd, Evas_Object* frame, const char* message)

ditto.

&gt; Tools/DumpRenderTree/efl/DumpRenderTreeView.cpp:48
&gt; +static Eina_Bool onJavaScriptConfirm(Ewk_View_Smart_Data* sd, Evas_Object* frame, const char* message)

ditto.

&gt; Tools/DumpRenderTree/efl/DumpRenderTreeView.cpp:54
&gt; +static Eina_Bool onJavaScriptPrompt(Ewk_View_Smart_Data* sd, Evas_Object* frame, const char* message, const char* defaultValue, char** value)

ditto.

&gt; Tools/DumpRenderTree/efl/DumpRenderTreeView.cpp:61
&gt; +Evas_Object* drtViewTiledAdd(Evas* e)

&apos;e&apos; is not a good name.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>427915</commentid>
    <comment_count>3</comment_count>
      <attachid>98720</attachid>
    <who name="Raphael Kubo da Costa (:rakuco)">rakuco</who>
    <bug_when>2011-06-27 07:24:54 -0700</bug_when>
    <thetext>Created attachment 98720
New patch following Kent&apos;s suggestions</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>427917</commentid>
    <comment_count>4</comment_count>
    <who name="Raphael Kubo da Costa (:rakuco)">rakuco</who>
    <bug_when>2011-06-27 07:25:44 -0700</bug_when>
    <thetext>CC&apos;ing Kent after a new patch was added after his suggestions.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>427924</commentid>
    <comment_count>5</comment_count>
      <attachid>98720</attachid>
    <who name="Kent Tamura">tkent</who>
    <bug_when>2011-06-27 07:30:55 -0700</bug_when>
    <thetext>Comment on attachment 98720
New patch following Kent&apos;s suggestions

Rubber-stamped by me.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>427945</commentid>
    <comment_count>6</comment_count>
      <attachid>98720</attachid>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2011-06-27 08:12:41 -0700</bug_when>
    <thetext>Comment on attachment 98720
New patch following Kent&apos;s suggestions

Clearing flags on attachment: 98720

Committed r89821: &lt;http://trac.webkit.org/changeset/89821&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>427946</commentid>
    <comment_count>7</comment_count>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2011-06-27 08:12:46 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>98038</attachid>
            <date>2011-06-21 12:21:41 -0700</date>
            <delta_ts>2011-06-27 07:24:45 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-63086-20110621162502.patch</filename>
            <type>text/plain</type>
            <size>6150</size>
            <attacher name="Raphael Kubo da Costa (:rakuco)">rakuco</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogODkzNjkKZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBi
L1Rvb2xzL0NoYW5nZUxvZwppbmRleCA5MTE3OTAyMmQ3NTFlZjhlZWM4NGI1Y2I2NGJkYzk4ZjNl
YzQzMTQyLi43MGYyNWUxNTcxNGE4ODBhMjRlNDM1NGMxMmFkOWNmYTQxNWFkYTI4IDEwMDY0NAot
LS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjAg
QEAKKzIwMTEtMDYtMjEgIFJhcGhhZWwgS3VibyBkYSBDb3N0YSAgPGt1Ym9AcHJvZnVzaW9uLm1v
Ymk+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW0VG
TF0gRFJUOiBBZGQgYW4gZXdrX3ZpZXcgc3BlY2lhbGl6YXRpb24gZm9yIEVGTCdzIER1bXBSZW5k
ZXJUcmVlLgorICAgICAgICBJdCB3aWxsIGJlIHBsdWdnZWQgaW50byB0aGUgYnVpbGQgc3lzdGVt
IGFzIHNvb24gYXMgdGhlIHJlc3Qgb2YgdGhlCisgICAgICAgIERSVCBjb2RlIGlzIGZ1bGx5IHVw
c3RyZWFtZWQuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p
ZD02MzA4NgorCisgICAgICAgICogRHVtcFJlbmRlclRyZWUvZWZsL0R1bXBSZW5kZXJUcmVlVmll
dy5jcHA6IEFkZGVkLgorICAgICAgICAob25Db25zb2xlTWVzc2FnZSk6CisgICAgICAgIChvbkph
dmFTY3JpcHRBbGVydCk6CisgICAgICAgIChvbkphdmFTY3JpcHRDb25maXJtKToKKyAgICAgICAg
KG9uSmF2YVNjcmlwdFByb21wdCk6CisgICAgICAgIChkcnRWaWV3VGlsZWRBZGQpOgorICAgICAg
ICAqIER1bXBSZW5kZXJUcmVlL2VmbC9EdW1wUmVuZGVyVHJlZVZpZXcuaDogQWRkZWQuCisKIDIw
MTEtMDYtMjAgIERtaXRyeSBMb21vdiAgPGRzbG9tb3ZAZ29vZ2xlLmNvbT4KIAogICAgICAgICBS
ZXZpZXdlZCBieSBEYXZpZCBMZXZpbi4KZGlmZiAtLWdpdCBhL1Rvb2xzL0R1bXBSZW5kZXJUcmVl
L2VmbC9EdW1wUmVuZGVyVHJlZVZpZXcuY3BwIGIvVG9vbHMvRHVtcFJlbmRlclRyZWUvZWZsL0R1
bXBSZW5kZXJUcmVlVmlldy5jcHAKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAw
MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uMzdmODMyZjdiNTIxYjI2ODg2ZGRmNjg3
OGM1MTVlOTQ2NzA2ZWJlMQotLS0gL2Rldi9udWxsCisrKyBiL1Rvb2xzL0R1bXBSZW5kZXJUcmVl
L2VmbC9EdW1wUmVuZGVyVHJlZVZpZXcuY3BwCkBAIC0wLDAgKzEsNzcgQEAKKy8qCisgKiBDb3B5
cmlnaHQgKEMpIDIwMTEgUHJvRlVTSU9OIEVtYmVkZGVkIFN5c3RlbXMKKyAqIENvcHlyaWdodCAo
QykgMjAxMSBTYW1zdW5nIEVsZWN0cm9uaWNzCisgKgorICogUmVkaXN0cmlidXRpb24gYW5kIHVz
ZSBpbiBzb3VyY2UgYW5kIGJpbmFyeSBmb3Jtcywgd2l0aCBvciB3aXRob3V0CisgKiBtb2RpZmlj
YXRpb24sIGFyZSBwZXJtaXR0ZWQgcHJvdmlkZWQgdGhhdCB0aGUgZm9sbG93aW5nIGNvbmRpdGlv
bnMKKyAqIGFyZSBtZXQ6CisgKiAxLiAgUmVkaXN0cmlidXRpb25zIG9mIHNvdXJjZSBjb2RlIG11
c3QgcmV0YWluIHRoZSBhYm92ZSBjb3B5cmlnaHQKKyAqICAgICBub3RpY2UsIHRoaXMgbGlzdCBv
ZiBjb25kaXRpb25zIGFuZCB0aGUgZm9sbG93aW5nIGRpc2NsYWltZXIuCisgKiAyLiAgUmVkIGlz
dHJpYnV0aW9ucyBpbiBiaW5hcnkgZm9ybSBtdXN0IHJlcHJvZHVjZSB0aGUgYWJvdmUgY29weXJp
Z2h0CisgKiAgICAgbm90aWNlLCB0aGlzIGxpc3Qgb2YgY29uZGl0aW9ucyBhbmQgdGhlIGZvbGxv
d2luZyBkaXNjbGFpbWVyIGluIHRoZQorICogICAgIGRvY3VtZW50YXRpb24gYW5kL29yIG90aGVy
IG1hdGVyaWFscyBwcm92aWRlZCB3aXRoIHRoZSBkaXN0cmlidXRpb24uCisgKgorICogVEhJUyBT
T0ZUV0FSRSBJUyBQUk9WSURFRCBCWSBBUFBMRSBJTkMuIEFORCBJVFMgQ09OVFJJQlVUT1JTIGBg
QVMgSVMnJyBBTkQgQU5ZCisgKiBFWFBSRVNTIE9SIElNUExJRUQgV0FSUkFOVElFUywgSU5DTFVE
SU5HLCBCVVQgTk9UIExJTUlURUQgVE8sIFRIRSBJTVBMSUVECisgKiBXQVJSQU5USUVTIE9GIE1F
UkNIQU5UQUJJTElUWSBBTkQgRklUTkVTUyBGT1IgQSBQQVJUSUNVTEFSIFBVUlBPU0UgQVJFCisg
KiBESVNDTEFJTUVELiBJTiBOTyBFVkVOVCBTSEFMTCBBUFBMRSBJTkMuIE9SIElUUyBDT05UUklC
VVRPUlMgQkUgTElBQkxFIEZPUiBBTlkKKyAqIERJUkVDVCwgSU5ESVJFQ1QsIElOQ0lERU5UQUws
IFNQRUNJQUwsIEVYRU1QTEFSWSwgT1IgQ09OU0VRVUVOVElBTCBEQU1BR0VTCisgKiAoSU5DTFVE
SU5HLCBCVVQgTk9UIExJTUlURUQgVE8sIFBST0NVUkVNRU5UIE9GIFNVQlNUSVRVVEUgR09PRFMg
T1IgU0VSVklDRVM7CisgKiBMT1NTIE9GIFVTRSwgREFUQSwgT1IgUFJPRklUUzsgT1IgQlVTSU5F
U1MgSU5URVJSVVBUSU9OKSBIT1dFVkVSIENBVVNFRCBBTkQgT04KKyAqIEFOWSBUSEVPUlkgT0Yg
TElBQklMSVRZLCBXSEVUSEVSIElOIENPTlRSQUNULCBTVFJJQ1QgTElBQklMSVRZLCBPUiBUT1JU
CisgKiAoSU5DTFVESU5HIE5FR0xJR0VOQ0UgT1IgT1RIRVJXSVNFKSBBUklTSU5HIElOIEFOWSBX
QVkgT1VUIE9GIFRIRSBVU0UgT0YgVEhJUworICogU09GVFdBUkUsIEVWRU4gSUYgQURWSVNFRCBP
RiBUSEUgUE9TU0lCSUxJVFkgT0YgU1VDSCBEQU1BR0UuCisgKi8KKworI2luY2x1ZGUgImNvbmZp
Zy5oIgorI2luY2x1ZGUgIkR1bXBSZW5kZXJUcmVlVmlldy5oIgorCisjaW5jbHVkZSA8RVdlYktp
dC5oPgorI2luY2x1ZGUgPEVpbmEuaD4KKyNpbmNsdWRlIDxFdmFzLmg+CisjaW5jbHVkZSA8Y3N0
ZGlvPgorCit1c2luZyBuYW1lc3BhY2Ugc3RkOworCitzdGF0aWMgRXdrX1ZpZXdfU21hcnRfQ2xh
c3MgZ1BhcmVudFNtYXJ0Q2xhc3MgPSBFV0tfVklFV19TTUFSVF9DTEFTU19JTklUX05VTEw7CisK
K3N0YXRpYyB2b2lkIG9uQ29uc29sZU1lc3NhZ2UoRXdrX1ZpZXdfU21hcnRfRGF0YSogc2QsIGNv
bnN0IGNoYXIqIG1lc3NhZ2UsIHVuc2lnbmVkIGludCBsaW5lTnVtYmVyLCBjb25zdCBjaGFyKiBz
b3VyY2VJRCkKK3sKKyAgICBwcmludGYoIkNPTlNPTEUgTUVTU0FHRTogbGluZSAldTogJXNcbiIs
IGxpbmVOdW1iZXIsIG1lc3NhZ2UpOworfQorCitzdGF0aWMgdm9pZCBvbkphdmFTY3JpcHRBbGVy
dChFd2tfVmlld19TbWFydF9EYXRhKiBzZCwgRXZhc19PYmplY3QqIGZyYW1lLCBjb25zdCBjaGFy
KiBtZXNzYWdlKQoreworICAgIHByaW50ZigiQUxFUlQ6ICVzXG4iLCBtZXNzYWdlKTsKK30KKwor
c3RhdGljIEVpbmFfQm9vbCBvbkphdmFTY3JpcHRDb25maXJtKEV3a19WaWV3X1NtYXJ0X0RhdGEq
IHNkLCBFdmFzX09iamVjdCogZnJhbWUsIGNvbnN0IGNoYXIqIG1lc3NhZ2UpCit7CisgICAgcHJp
bnRmKCJDT05GSVJNOiAlc1xuIiwgbWVzc2FnZSk7CisgICAgcmV0dXJuIEVJTkFfVFJVRTsKK30K
Kworc3RhdGljIEVpbmFfQm9vbCBvbkphdmFTY3JpcHRQcm9tcHQoRXdrX1ZpZXdfU21hcnRfRGF0
YSogc2QsIEV2YXNfT2JqZWN0KiBmcmFtZSwgY29uc3QgY2hhciogbWVzc2FnZSwgY29uc3QgY2hh
ciogZGVmYXVsdFZhbHVlLCBjaGFyKiogdmFsdWUpCit7CisgICAgcHJpbnRmKCJQUk9NUFQ6ICVz
LCBkZWZhdWx0IHRleHQ6ICVzXG4iLCBtZXNzYWdlLCBkZWZhdWx0VmFsdWUpOworICAgICp2YWx1
ZSA9IHN0cmR1cChkZWZhdWx0VmFsdWUpOworICAgIHJldHVybiBFSU5BX1RSVUU7Cit9CisKK0V2
YXNfT2JqZWN0KiBkcnRWaWV3VGlsZWRBZGQoRXZhcyogZSkKK3sKKyAgICBzdGF0aWMgRXdrX1Zp
ZXdfU21hcnRfQ2xhc3MgYXBpID0gRVdLX1ZJRVdfU01BUlRfQ0xBU1NfSU5JVF9OQU1FX1ZFUlNJ
T04oIkRSVF9WaWV3X1RpbGVkIik7CisKKyAgICBpZiAoIWV3a192aWV3X3RpbGVkX3NtYXJ0X3Nl
dCgmYXBpKSkKKyAgICAgICAgcmV0dXJuIDA7CisKKyAgICBpZiAoRUlOQV9VTkxJS0VMWSghZ1Bh
cmVudFNtYXJ0Q2xhc3Muc2MuYWRkKSkKKyAgICAgICAgZXdrX3ZpZXdfYmFzZV9zbWFydF9zZXQo
JmdQYXJlbnRTbWFydENsYXNzKTsKKworICAgIGFwaS5hZGRfY29uc29sZV9tZXNzYWdlID0gb25D
b25zb2xlTWVzc2FnZTsKKyAgICBhcGkucnVuX2phdmFzY3JpcHRfYWxlcnQgPSBvbkphdmFTY3Jp
cHRBbGVydDsKKyAgICBhcGkucnVuX2phdmFzY3JpcHRfY29uZmlybSA9IG9uSmF2YVNjcmlwdENv
bmZpcm07CisgICAgYXBpLnJ1bl9qYXZhc2NyaXB0X3Byb21wdCA9IG9uSmF2YVNjcmlwdFByb21w
dDsKKworICAgIHJldHVybiBldmFzX29iamVjdF9zbWFydF9hZGQoZSwgZXZhc19zbWFydF9jbGFz
c19uZXcoJmFwaS5zYykpOworfQpkaWZmIC0tZ2l0IGEvVG9vbHMvRHVtcFJlbmRlclRyZWUvZWZs
L0R1bXBSZW5kZXJUcmVlVmlldy5oIGIvVG9vbHMvRHVtcFJlbmRlclRyZWUvZWZsL0R1bXBSZW5k
ZXJUcmVlVmlldy5oCm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAw
MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLjNjOWM2YjFhMmNjMzcyNjIyY2VkMzlhZDYyN2UyOTdj
YmIyMGMzNGIKLS0tIC9kZXYvbnVsbAorKysgYi9Ub29scy9EdW1wUmVuZGVyVHJlZS9lZmwvRHVt
cFJlbmRlclRyZWVWaWV3LmgKQEAgLTAsMCArMSwzMiBAQAorLyoKKyAqIENvcHlyaWdodCAoQykg
MjAxMSBQcm9GVVNJT04gRW1iZWRkZWQgU3lzdGVtcy4gQWxsIHJpZ2h0cyByZXNlcnZlZC4KKyAq
CisgKiBSZWRpc3RyaWJ1dGlvbiBhbmQgdXNlIGluIHNvdXJjZSBhbmQgYmluYXJ5IGZvcm1zLCB3
aXRoIG9yIHdpdGhvdXQKKyAqIG1vZGlmaWNhdGlvbiwgYXJlIHBlcm1pdHRlZCBwcm92aWRlZCB0
aGF0IHRoZSBmb2xsb3dpbmcgY29uZGl0aW9ucworICogYXJlIG1ldDoKKyAqIDEuICBSZWRpc3Ry
aWJ1dGlvbnMgb2Ygc291cmNlIGNvZGUgbXVzdCByZXRhaW4gdGhlIGFib3ZlIGNvcHlyaWdodAor
ICogICAgIG5vdGljZSwgdGhpcyBsaXN0IG9mIGNvbmRpdGlvbnMgYW5kIHRoZSBmb2xsb3dpbmcg
ZGlzY2xhaW1lci4KKyAqIDIuICBSZWQgaXN0cmlidXRpb25zIGluIGJpbmFyeSBmb3JtIG11c3Qg
cmVwcm9kdWNlIHRoZSBhYm92ZSBjb3B5cmlnaHQKKyAqICAgICBub3RpY2UsIHRoaXMgbGlzdCBv
ZiBjb25kaXRpb25zIGFuZCB0aGUgZm9sbG93aW5nIGRpc2NsYWltZXIgaW4gdGhlCisgKiAgICAg
ZG9jdW1lbnRhdGlvbiBhbmQvb3Igb3RoZXIgbWF0ZXJpYWxzIHByb3ZpZGVkIHdpdGggdGhlIGRp
c3RyaWJ1dGlvbi4KKyAqCisgKiBUSElTIFNPRlRXQVJFIElTIFBST1ZJREVEIEJZIEFQUExFIElO
Qy4gQU5EIElUUyBDT05UUklCVVRPUlMgYGBBUyBJUycnIEFORCBBTlkKKyAqIEVYUFJFU1MgT1Ig
SU1QTElFRCBXQVJSQU5USUVTLCBJTkNMVURJTkcsIEJVVCBOT1QgTElNSVRFRCBUTywgVEhFIElN
UExJRUQKKyAqIFdBUlJBTlRJRVMgT0YgTUVSQ0hBTlRBQklMSVRZIEFORCBGSVRORVNTIEZPUiBB
IFBBUlRJQ1VMQVIgUFVSUE9TRSBBUkUKKyAqIERJU0NMQUlNRUQuIElOIE5PIEVWRU5UIFNIQUxM
IEFQUExFIElOQy4gT1IgSVRTIENPTlRSSUJVVE9SUyBCRSBMSUFCTEUgRk9SIEFOWQorICogRElS
RUNULCBJTkRJUkVDVCwgSU5DSURFTlRBTCwgU1BFQ0lBTCwgRVhFTVBMQVJZLCBPUiBDT05TRVFV
RU5USUFMIERBTUFHRVMKKyAqIChJTkNMVURJTkcsIEJVVCBOT1QgTElNSVRFRCBUTywgUFJPQ1VS
RU1FTlQgT0YgU1VCU1RJVFVURSBHT09EUyBPUiBTRVJWSUNFUzsKKyAqIExPU1MgT0YgVVNFLCBE
QVRBLCBPUiBQUk9GSVRTOyBPUiBCVVNJTkVTUyBJTlRFUlJVUFRJT04pIEhPV0VWRVIgQ0FVU0VE
IEFORCBPTgorICogQU5ZIFRIRU9SWSBPRiBMSUFCSUxJVFksIFdIRVRIRVIgSU4gQ09OVFJBQ1Qs
IFNUUklDVCBMSUFCSUxJVFksIE9SIFRPUlQKKyAqIChJTkNMVURJTkcgTkVHTElHRU5DRSBPUiBP
VEhFUldJU0UpIEFSSVNJTkcgSU4gQU5ZIFdBWSBPVVQgT0YgVEhFIFVTRSBPRiBUSElTCisgKiBT
T0ZUV0FSRSwgRVZFTiBJRiBBRFZJU0VEIE9GIFRIRSBQT1NTSUJJTElUWSBPRiBTVUNIIERBTUFH
RS4KKyAqLworCisjaWZuZGVmIER1bXBSZW5kZXJUcmVlVmlld19oCisjZGVmaW5lIER1bXBSZW5k
ZXJUcmVlVmlld19oCisKKyNpbmNsdWRlIDxFdmFzLmg+CisKK0V2YXNfT2JqZWN0KiBkcnRWaWV3
VGlsZWRBZGQoRXZhcyopOworCisjZW5kaWYgLy8gRHVtcFJlbmRlclRyZWVWaWV3X2gK
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>98720</attachid>
            <date>2011-06-27 07:24:54 -0700</date>
            <delta_ts>2011-06-27 08:12:41 -0700</delta_ts>
            <desc>New patch following Kent&apos;s suggestions</desc>
            <filename>bug-63086-20110627112817.patch</filename>
            <type>text/plain</type>
            <size>6112</size>
            <attacher name="Raphael Kubo da Costa (:rakuco)">rakuco</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogODk4MTUKZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBi
L1Rvb2xzL0NoYW5nZUxvZwppbmRleCA2NTYxZGJhYmUyNjM0OThkY2EzZGQ0OThlZTBhODA0YzZi
YzRiNGQwLi41YmViZjIwZDA2MzRiNmRjNTRhNzBiOTk4YjQ5MzgzYWVhMmM3MDM1IDEwMDY0NAot
LS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjAg
QEAKKzIwMTEtMDYtMjcgIFJhcGhhZWwgS3VibyBkYSBDb3N0YSAgPGt1Ym9AcHJvZnVzaW9uLm1v
Ymk+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW0VG
TF0gRFJUOiBBZGQgYW4gZXdrX3ZpZXcgc3BlY2lhbGl6YXRpb24gZm9yIEVGTCdzIER1bXBSZW5k
ZXJUcmVlLgorICAgICAgICBJdCB3aWxsIGJlIHBsdWdnZWQgaW50byB0aGUgYnVpbGQgc3lzdGVt
IGFzIHNvb24gYXMgdGhlIHJlc3Qgb2YgdGhlCisgICAgICAgIERSVCBjb2RlIGlzIGZ1bGx5IHVw
c3RyZWFtZWQuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p
ZD02MzA4NgorCisgICAgICAgICogRHVtcFJlbmRlclRyZWUvZWZsL0R1bXBSZW5kZXJUcmVlVmll
dy5jcHA6IEFkZGVkLgorICAgICAgICAob25Db25zb2xlTWVzc2FnZSk6CisgICAgICAgIChvbkph
dmFTY3JpcHRBbGVydCk6CisgICAgICAgIChvbkphdmFTY3JpcHRDb25maXJtKToKKyAgICAgICAg
KG9uSmF2YVNjcmlwdFByb21wdCk6CisgICAgICAgIChkcnRWaWV3VGlsZWRBZGQpOgorICAgICAg
ICAqIER1bXBSZW5kZXJUcmVlL2VmbC9EdW1wUmVuZGVyVHJlZVZpZXcuaDogQWRkZWQuCisKIDIw
MTEtMDYtMjcgIEVyaWMgU2VpZGVsICA8ZXJpY0B3ZWJraXQub3JnPgogCiAgICAgICAgIFJldmll
d2VkIGJ5IEFkYW0gQmFydGguCmRpZmYgLS1naXQgYS9Ub29scy9EdW1wUmVuZGVyVHJlZS9lZmwv
RHVtcFJlbmRlclRyZWVWaWV3LmNwcCBiL1Rvb2xzL0R1bXBSZW5kZXJUcmVlL2VmbC9EdW1wUmVu
ZGVyVHJlZVZpZXcuY3BwCm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAw
MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLmJlOWIwMGY5ZjQ2N2MzYWQyZWQwNDFkNjA1ZTM1
MzE4ODZlYjg0NTgKLS0tIC9kZXYvbnVsbAorKysgYi9Ub29scy9EdW1wUmVuZGVyVHJlZS9lZmwv
RHVtcFJlbmRlclRyZWVWaWV3LmNwcApAQCAtMCwwICsxLDc3IEBACisvKgorICogQ29weXJpZ2h0
IChDKSAyMDExIFByb0ZVU0lPTiBFbWJlZGRlZCBTeXN0ZW1zCisgKiBDb3B5cmlnaHQgKEMpIDIw
MTEgU2Ftc3VuZyBFbGVjdHJvbmljcworICoKKyAqIFJlZGlzdHJpYnV0aW9uIGFuZCB1c2UgaW4g
c291cmNlIGFuZCBiaW5hcnkgZm9ybXMsIHdpdGggb3Igd2l0aG91dAorICogbW9kaWZpY2F0aW9u
LCBhcmUgcGVybWl0dGVkIHByb3ZpZGVkIHRoYXQgdGhlIGZvbGxvd2luZyBjb25kaXRpb25zCisg
KiBhcmUgbWV0OgorICogMS4gIFJlZGlzdHJpYnV0aW9ucyBvZiBzb3VyY2UgY29kZSBtdXN0IHJl
dGFpbiB0aGUgYWJvdmUgY29weXJpZ2h0CisgKiAgICAgbm90aWNlLCB0aGlzIGxpc3Qgb2YgY29u
ZGl0aW9ucyBhbmQgdGhlIGZvbGxvd2luZyBkaXNjbGFpbWVyLgorICogMi4gIFJlZCBpc3RyaWJ1
dGlvbnMgaW4gYmluYXJ5IGZvcm0gbXVzdCByZXByb2R1Y2UgdGhlIGFib3ZlIGNvcHlyaWdodAor
ICogICAgIG5vdGljZSwgdGhpcyBsaXN0IG9mIGNvbmRpdGlvbnMgYW5kIHRoZSBmb2xsb3dpbmcg
ZGlzY2xhaW1lciBpbiB0aGUKKyAqICAgICBkb2N1bWVudGF0aW9uIGFuZC9vciBvdGhlciBtYXRl
cmlhbHMgcHJvdmlkZWQgd2l0aCB0aGUgZGlzdHJpYnV0aW9uLgorICoKKyAqIFRISVMgU09GVFdB
UkUgSVMgUFJPVklERUQgQlkgQVBQTEUgSU5DLiBBTkQgSVRTIENPTlRSSUJVVE9SUyBgYEFTIElT
JycgQU5EIEFOWQorICogRVhQUkVTUyBPUiBJTVBMSUVEIFdBUlJBTlRJRVMsIElOQ0xVRElORywg
QlVUIE5PVCBMSU1JVEVEIFRPLCBUSEUgSU1QTElFRAorICogV0FSUkFOVElFUyBPRiBNRVJDSEFO
VEFCSUxJVFkgQU5EIEZJVE5FU1MgRk9SIEEgUEFSVElDVUxBUiBQVVJQT1NFIEFSRQorICogRElT
Q0xBSU1FRC4gSU4gTk8gRVZFTlQgU0hBTEwgQVBQTEUgSU5DLiBPUiBJVFMgQ09OVFJJQlVUT1JT
IEJFIExJQUJMRSBGT1IgQU5ZCisgKiBESVJFQ1QsIElORElSRUNULCBJTkNJREVOVEFMLCBTUEVD
SUFMLCBFWEVNUExBUlksIE9SIENPTlNFUVVFTlRJQUwgREFNQUdFUworICogKElOQ0xVRElORywg
QlVUIE5PVCBMSU1JVEVEIFRPLCBQUk9DVVJFTUVOVCBPRiBTVUJTVElUVVRFIEdPT0RTIE9SIFNF
UlZJQ0VTOworICogTE9TUyBPRiBVU0UsIERBVEEsIE9SIFBST0ZJVFM7IE9SIEJVU0lORVNTIElO
VEVSUlVQVElPTikgSE9XRVZFUiBDQVVTRUQgQU5EIE9OCisgKiBBTlkgVEhFT1JZIE9GIExJQUJJ
TElUWSwgV0hFVEhFUiBJTiBDT05UUkFDVCwgU1RSSUNUIExJQUJJTElUWSwgT1IgVE9SVAorICog
KElOQ0xVRElORyBORUdMSUdFTkNFIE9SIE9USEVSV0lTRSkgQVJJU0lORyBJTiBBTlkgV0FZIE9V
VCBPRiBUSEUgVVNFIE9GIFRISVMKKyAqIFNPRlRXQVJFLCBFVkVOIElGIEFEVklTRUQgT0YgVEhF
IFBPU1NJQklMSVRZIE9GIFNVQ0ggREFNQUdFLgorICovCisKKyNpbmNsdWRlICJjb25maWcuaCIK
KyNpbmNsdWRlICJEdW1wUmVuZGVyVHJlZVZpZXcuaCIKKworI2luY2x1ZGUgPEVXZWJLaXQuaD4K
KyNpbmNsdWRlIDxFaW5hLmg+CisjaW5jbHVkZSA8RXZhcy5oPgorI2luY2x1ZGUgPGNzdGRpbz4K
KwordXNpbmcgbmFtZXNwYWNlIHN0ZDsKKworc3RhdGljIEV3a19WaWV3X1NtYXJ0X0NsYXNzIGdQ
YXJlbnRTbWFydENsYXNzID0gRVdLX1ZJRVdfU01BUlRfQ0xBU1NfSU5JVF9OVUxMOworCitzdGF0
aWMgdm9pZCBvbkNvbnNvbGVNZXNzYWdlKEV3a19WaWV3X1NtYXJ0X0RhdGEqLCBjb25zdCBjaGFy
KiBtZXNzYWdlLCB1bnNpZ25lZCBpbnQgbGluZU51bWJlciwgY29uc3QgY2hhciopCit7CisgICAg
cHJpbnRmKCJDT05TT0xFIE1FU1NBR0U6IGxpbmUgJXU6ICVzXG4iLCBsaW5lTnVtYmVyLCBtZXNz
YWdlKTsKK30KKworc3RhdGljIHZvaWQgb25KYXZhU2NyaXB0QWxlcnQoRXdrX1ZpZXdfU21hcnRf
RGF0YSosIEV2YXNfT2JqZWN0KiwgY29uc3QgY2hhciogbWVzc2FnZSkKK3sKKyAgICBwcmludGYo
IkFMRVJUOiAlc1xuIiwgbWVzc2FnZSk7Cit9CisKK3N0YXRpYyBFaW5hX0Jvb2wgb25KYXZhU2Ny
aXB0Q29uZmlybShFd2tfVmlld19TbWFydF9EYXRhKiwgRXZhc19PYmplY3QqLCBjb25zdCBjaGFy
KiBtZXNzYWdlKQoreworICAgIHByaW50ZigiQ09ORklSTTogJXNcbiIsIG1lc3NhZ2UpOworICAg
IHJldHVybiBFSU5BX1RSVUU7Cit9CisKK3N0YXRpYyBFaW5hX0Jvb2wgb25KYXZhU2NyaXB0UHJv
bXB0KEV3a19WaWV3X1NtYXJ0X0RhdGEqLCBFdmFzX09iamVjdCosIGNvbnN0IGNoYXIqIG1lc3Nh
Z2UsIGNvbnN0IGNoYXIqIGRlZmF1bHRWYWx1ZSwgY2hhcioqIHZhbHVlKQoreworICAgIHByaW50
ZigiUFJPTVBUOiAlcywgZGVmYXVsdCB0ZXh0OiAlc1xuIiwgbWVzc2FnZSwgZGVmYXVsdFZhbHVl
KTsKKyAgICAqdmFsdWUgPSBzdHJkdXAoZGVmYXVsdFZhbHVlKTsKKyAgICByZXR1cm4gRUlOQV9U
UlVFOworfQorCitFdmFzX09iamVjdCogZHJ0Vmlld1RpbGVkQWRkKEV2YXMqIGV2YXMpCit7Cisg
ICAgc3RhdGljIEV3a19WaWV3X1NtYXJ0X0NsYXNzIGFwaSA9IEVXS19WSUVXX1NNQVJUX0NMQVNT
X0lOSVRfTkFNRV9WRVJTSU9OKCJEUlRfVmlld19UaWxlZCIpOworCisgICAgaWYgKCFld2tfdmll
d190aWxlZF9zbWFydF9zZXQoJmFwaSkpCisgICAgICAgIHJldHVybiAwOworCisgICAgaWYgKEVJ
TkFfVU5MSUtFTFkoIWdQYXJlbnRTbWFydENsYXNzLnNjLmFkZCkpCisgICAgICAgIGV3a192aWV3
X2Jhc2Vfc21hcnRfc2V0KCZnUGFyZW50U21hcnRDbGFzcyk7CisKKyAgICBhcGkuYWRkX2NvbnNv
bGVfbWVzc2FnZSA9IG9uQ29uc29sZU1lc3NhZ2U7CisgICAgYXBpLnJ1bl9qYXZhc2NyaXB0X2Fs
ZXJ0ID0gb25KYXZhU2NyaXB0QWxlcnQ7CisgICAgYXBpLnJ1bl9qYXZhc2NyaXB0X2NvbmZpcm0g
PSBvbkphdmFTY3JpcHRDb25maXJtOworICAgIGFwaS5ydW5famF2YXNjcmlwdF9wcm9tcHQgPSBv
bkphdmFTY3JpcHRQcm9tcHQ7CisKKyAgICByZXR1cm4gZXZhc19vYmplY3Rfc21hcnRfYWRkKGV2
YXMsIGV2YXNfc21hcnRfY2xhc3NfbmV3KCZhcGkuc2MpKTsKK30KZGlmZiAtLWdpdCBhL1Rvb2xz
L0R1bXBSZW5kZXJUcmVlL2VmbC9EdW1wUmVuZGVyVHJlZVZpZXcuaCBiL1Rvb2xzL0R1bXBSZW5k
ZXJUcmVlL2VmbC9EdW1wUmVuZGVyVHJlZVZpZXcuaApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRl
eCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi4zYzljNmIxYTJjYzM3
MjYyMmNlZDM5YWQ2MjdlMjk3Y2JiMjBjMzRiCi0tLSAvZGV2L251bGwKKysrIGIvVG9vbHMvRHVt
cFJlbmRlclRyZWUvZWZsL0R1bXBSZW5kZXJUcmVlVmlldy5oCkBAIC0wLDAgKzEsMzIgQEAKKy8q
CisgKiBDb3B5cmlnaHQgKEMpIDIwMTEgUHJvRlVTSU9OIEVtYmVkZGVkIFN5c3RlbXMuIEFsbCBy
aWdodHMgcmVzZXJ2ZWQuCisgKgorICogUmVkaXN0cmlidXRpb24gYW5kIHVzZSBpbiBzb3VyY2Ug
YW5kIGJpbmFyeSBmb3Jtcywgd2l0aCBvciB3aXRob3V0CisgKiBtb2RpZmljYXRpb24sIGFyZSBw
ZXJtaXR0ZWQgcHJvdmlkZWQgdGhhdCB0aGUgZm9sbG93aW5nIGNvbmRpdGlvbnMKKyAqIGFyZSBt
ZXQ6CisgKiAxLiAgUmVkaXN0cmlidXRpb25zIG9mIHNvdXJjZSBjb2RlIG11c3QgcmV0YWluIHRo
ZSBhYm92ZSBjb3B5cmlnaHQKKyAqICAgICBub3RpY2UsIHRoaXMgbGlzdCBvZiBjb25kaXRpb25z
IGFuZCB0aGUgZm9sbG93aW5nIGRpc2NsYWltZXIuCisgKiAyLiAgUmVkIGlzdHJpYnV0aW9ucyBp
biBiaW5hcnkgZm9ybSBtdXN0IHJlcHJvZHVjZSB0aGUgYWJvdmUgY29weXJpZ2h0CisgKiAgICAg
bm90aWNlLCB0aGlzIGxpc3Qgb2YgY29uZGl0aW9ucyBhbmQgdGhlIGZvbGxvd2luZyBkaXNjbGFp
bWVyIGluIHRoZQorICogICAgIGRvY3VtZW50YXRpb24gYW5kL29yIG90aGVyIG1hdGVyaWFscyBw
cm92aWRlZCB3aXRoIHRoZSBkaXN0cmlidXRpb24uCisgKgorICogVEhJUyBTT0ZUV0FSRSBJUyBQ
Uk9WSURFRCBCWSBBUFBMRSBJTkMuIEFORCBJVFMgQ09OVFJJQlVUT1JTIGBgQVMgSVMnJyBBTkQg
QU5ZCisgKiBFWFBSRVNTIE9SIElNUExJRUQgV0FSUkFOVElFUywgSU5DTFVESU5HLCBCVVQgTk9U
IExJTUlURUQgVE8sIFRIRSBJTVBMSUVECisgKiBXQVJSQU5USUVTIE9GIE1FUkNIQU5UQUJJTElU
WSBBTkQgRklUTkVTUyBGT1IgQSBQQVJUSUNVTEFSIFBVUlBPU0UgQVJFCisgKiBESVNDTEFJTUVE
LiBJTiBOTyBFVkVOVCBTSEFMTCBBUFBMRSBJTkMuIE9SIElUUyBDT05UUklCVVRPUlMgQkUgTElB
QkxFIEZPUiBBTlkKKyAqIERJUkVDVCwgSU5ESVJFQ1QsIElOQ0lERU5UQUwsIFNQRUNJQUwsIEVY
RU1QTEFSWSwgT1IgQ09OU0VRVUVOVElBTCBEQU1BR0VTCisgKiAoSU5DTFVESU5HLCBCVVQgTk9U
IExJTUlURUQgVE8sIFBST0NVUkVNRU5UIE9GIFNVQlNUSVRVVEUgR09PRFMgT1IgU0VSVklDRVM7
CisgKiBMT1NTIE9GIFVTRSwgREFUQSwgT1IgUFJPRklUUzsgT1IgQlVTSU5FU1MgSU5URVJSVVBU
SU9OKSBIT1dFVkVSIENBVVNFRCBBTkQgT04KKyAqIEFOWSBUSEVPUlkgT0YgTElBQklMSVRZLCBX
SEVUSEVSIElOIENPTlRSQUNULCBTVFJJQ1QgTElBQklMSVRZLCBPUiBUT1JUCisgKiAoSU5DTFVE
SU5HIE5FR0xJR0VOQ0UgT1IgT1RIRVJXSVNFKSBBUklTSU5HIElOIEFOWSBXQVkgT1VUIE9GIFRI
RSBVU0UgT0YgVEhJUworICogU09GVFdBUkUsIEVWRU4gSUYgQURWSVNFRCBPRiBUSEUgUE9TU0lC
SUxJVFkgT0YgU1VDSCBEQU1BR0UuCisgKi8KKworI2lmbmRlZiBEdW1wUmVuZGVyVHJlZVZpZXdf
aAorI2RlZmluZSBEdW1wUmVuZGVyVHJlZVZpZXdfaAorCisjaW5jbHVkZSA8RXZhcy5oPgorCitF
dmFzX09iamVjdCogZHJ0Vmlld1RpbGVkQWRkKEV2YXMqKTsKKworI2VuZGlmIC8vIER1bXBSZW5k
ZXJUcmVlVmlld19oCg==
</data>

          </attachment>
      

    </bug>

</bugzilla>