63028 2011-06-20 17:00:46 -0700 Remove numRequests 2011-06-20 18:00:35 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 29947 1 abarth abarth eric webkit.review.bot oldest_to_newest 424088 0 abarth 2011-06-20 17:00:46 -0700 Remove numRequests 424091 1 97891 abarth 2011-06-20 17:02:24 -0700 Created attachment 97891 Patch 424098 2 97891 darin 2011-06-20 17:07:03 -0700 Comment on attachment 97891 Patch I think that when that function was written, m_frame->document() wasn’t yet guarantee to be non-zero. 424135 3 97891 webkit.review.bot 2011-06-20 18:00:31 -0700 Comment on attachment 97891 Patch Clearing flags on attachment: 97891 Committed r89323: <http://trac.webkit.org/changeset/89323> 424136 4 webkit.review.bot 2011-06-20 18:00:35 -0700 All reviewed patches have been landed. Closing bug. 97891 2011-06-20 17:02:24 -0700 2011-06-20 18:00:31 -0700 Patch bug-63028-20110620170222.patch text/plain 2304 abarth SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDg5MzE1KQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTEtMDYtMjAgIEFkYW0gQmFy dGggIDxhYmFydGhAd2Via2l0Lm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBSZW1vdmUgbnVtUmVxdWVzdHMKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTYzMDI4CisKKyAgICAgICAgbnVtUmVxdWVzdHMg ZXhpc3RzIGp1c3QgdG8gY2FyZ28tY3VsdCBudWxsLWNoZWNrIG1fZnJhbWUtPmRvY3VtZW50KCks CisgICAgICAgIHdoaWNoIGlzIGFsd2F5cyBub24tbnVsbC4KKworICAgICAgICAqIGxvYWRlci9G cmFtZUxvYWRlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpGcmFtZUxvYWRlcjo6Y2hlY2tDb21w bGV0ZWQpOgorICAgICAgICAoV2ViQ29yZTo6RnJhbWVMb2FkZXI6Om51bVBlbmRpbmdPckxvYWRp bmdSZXF1ZXN0cyk6CisKIDIwMTEtMDYtMjAgIE1hcmsgUGlsZ3JpbSAgPHBpbGdyaW1AY2hyb21p dW0ub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEFkYW0gQmFydGguCkluZGV4OiBTb3VyY2Uv V2ViQ29yZS9sb2FkZXIvRnJhbWVMb2FkZXIuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJD b3JlL2xvYWRlci9GcmFtZUxvYWRlci5jcHAJKHJldmlzaW9uIDg5MzE0KQorKysgU291cmNlL1dl YkNvcmUvbG9hZGVyL0ZyYW1lTG9hZGVyLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTU2LDE0ICsx NTYsNiBAQCBib29sIGlzQmFja0ZvcndhcmRMb2FkVHlwZShGcmFtZUxvYWRUeXBlCiAgICAgcmV0 dXJuIGZhbHNlOwogfQogCi1zdGF0aWMgaW50IG51bVJlcXVlc3RzKERvY3VtZW50KiBkb2N1bWVu dCkKLXsKLSAgICBpZiAoIWRvY3VtZW50KQotICAgICAgICByZXR1cm4gMDsKLSAgICAKLSAgICBy ZXR1cm4gZG9jdW1lbnQtPmNhY2hlZFJlc291cmNlTG9hZGVyKCktPnJlcXVlc3RDb3VudCgpOwot fQotCiAvLyBUaGlzIGlzIG5vdCBpbiB0aGUgRnJhbWVMb2FkZXIgY2xhc3MgdG8gZW1waGFzaXpl IHRoYXQgaXQgZG9lcyBub3QgZGVwZW5kIG9uCiAvLyBwcml2YXRlIEZyYW1lTG9hZGVyIGRhdGEs IGFuZCB0byBhdm9pZCBpbmNyZWFzaW5nIHRoZSBudW1iZXIgb2YgcHVibGljIGZ1bmN0aW9ucwog Ly8gd2l0aCBhY2Nlc3MgdG8gcHJpdmF0ZSBkYXRhLiAgU2luY2Ugb25seSB0aGlzIC5jcHAgZmls ZSBuZWVkcyBpdCwgbWFraW5nIGl0CkBAIC03MjIsNyArNzE0LDcgQEAgdm9pZCBGcmFtZUxvYWRl cjo6Y2hlY2tDb21wbGV0ZWQoKQogICAgICAgICByZXR1cm47CiAKICAgICAvLyBTdGlsbCB3YWl0 aW5nIGZvciBpbWFnZXMvc2NyaXB0cz8KLSAgICBpZiAobnVtUmVxdWVzdHMobV9mcmFtZS0+ZG9j dW1lbnQoKSkpCisgICAgaWYgKG1fZnJhbWUtPmRvY3VtZW50KCktPmNhY2hlZFJlc291cmNlTG9h ZGVyKCktPnJlcXVlc3RDb3VudCgpKQogICAgICAgICByZXR1cm47CiAKICAgICAvLyBTdGlsbCB3 YWl0aW5nIGZvciBlbGVtZW50cyB0aGF0IGRvbid0IGdvIHRocm91Z2ggYSBGcmFtZUxvYWRlcj8K QEAgLTI0MDAsMTEgKzIzOTIsMTEgQEAgdm9pZCBGcmFtZUxvYWRlcjo6Y2hlY2tMb2FkQ29tcGxl dGUoKQogaW50IEZyYW1lTG9hZGVyOjpudW1QZW5kaW5nT3JMb2FkaW5nUmVxdWVzdHMoYm9vbCBy ZWN1cnNlKSBjb25zdAogewogICAgIGlmICghcmVjdXJzZSkKLSAgICAgICAgcmV0dXJuIG51bVJl cXVlc3RzKG1fZnJhbWUtPmRvY3VtZW50KCkpOworICAgICAgICByZXR1cm4gbV9mcmFtZS0+ZG9j dW1lbnQoKS0+Y2FjaGVkUmVzb3VyY2VMb2FkZXIoKS0+cmVxdWVzdENvdW50KCk7CiAKICAgICBp bnQgY291bnQgPSAwOwogICAgIGZvciAoRnJhbWUqIGZyYW1lID0gbV9mcmFtZTsgZnJhbWU7IGZy YW1lID0gZnJhbWUtPnRyZWUoKS0+dHJhdmVyc2VOZXh0KG1fZnJhbWUpKQotICAgICAgICBjb3Vu dCArPSBudW1SZXF1ZXN0cyhmcmFtZS0+ZG9jdW1lbnQoKSk7CisgICAgICAgIGNvdW50ICs9IGZy YW1lLT5kb2N1bWVudCgpLT5jYWNoZWRSZXNvdXJjZUxvYWRlcigpLT5yZXF1ZXN0Q291bnQoKTsK ICAgICByZXR1cm4gY291bnQ7CiB9CiAK