62978 2011-06-20 05:03:47 -0700 [EFL] ChromeClientEfl doesn't need to check whether m_view is null. 2011-06-20 18:33:50 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 ryuan.choi webkit-unassigned gyuyoung.kim kenneth leandro lucas.de.marchi rakuco tonikitoo webkit.review.bot oldest_to_newest 423601 0 ryuan.choi 2011-06-20 05:03:47 -0700 ChromeClientEfl always are created with view and it will not be removed until destroyed. So, we don't need to check whether m_view is null. 424114 1 97895 ryuan.choi 2011-06-20 17:33:08 -0700 Created attachment 97895 Patch 424124 2 97895 tonikitoo 2011-06-20 17:45:27 -0700 Comment on attachment 97895 Patch Should not you have ASSERTs instead then? 424139 3 97898 ryuan.choi 2011-06-20 18:03:27 -0700 Created attachment 97898 Patch 424144 4 ryuan.choi 2011-06-20 18:07:49 -0700 (In reply to comment #2) > (From update of attachment 97895 [details]) > Should not you have ASSERTs instead then? Thanks for your comment. m_view is only changed When called constructor of ChromeClientEfl. Does we need to add ASSERT before calling m_view every time? Almost other methods of ChromeClientEfl use m_view without checking m_view. 424158 5 webkit.review.bot 2011-06-20 18:32:26 -0700 The commit-queue encountered the following flaky tests while processing attachment 97898: http/tests/local/formdata/send-form-data.html bug 63034 (author: jianli@chromium.org) The commit-queue is continuing to process your patch. 424159 6 97898 webkit.review.bot 2011-06-20 18:33:45 -0700 Comment on attachment 97898 Patch Clearing flags on attachment: 97898 Committed r89327: <http://trac.webkit.org/changeset/89327> 424161 7 webkit.review.bot 2011-06-20 18:33:50 -0700 All reviewed patches have been landed. Closing bug. 97895 2011-06-20 17:33:08 -0700 2011-06-20 18:03:19 -0700 Patch bug-62978-20110621093222.patch text/plain 2575 ryuan.choi U3VidmVyc2lvbiBSZXZpc2lvbjogODkzMDAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZWZs L0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvZWZsL0NoYW5nZUxvZwppbmRleCBlZjkyN2I3ODQ3 NTg2NzBlODQzZjFhYTVlZmJhOGFkODJkYzc4NGFjLi5hMjBhYjkxOTIxZTU3OWIwZDYyMGIwMWZj OTQ3NjgxMDQ3NGRhNDBjIDEwMDc1NQotLS0gYS9Tb3VyY2UvV2ViS2l0L2VmbC9DaGFuZ2VMb2cK KysrIGIvU291cmNlL1dlYktpdC9lZmwvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkgQEAKKzIwMTEt MDYtMjAgIFJ5dWFuIENob2kgIDxyeXVhbi5jaG9pQHNhbXN1bmcuY29tPgorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtFRkxdIENocm9tZUNsaWVudEVm bCBkb2Vzbid0IG5lZWQgdG8gY2hlY2sgd2hldGhlciBtX3ZpZXcgaXMgbnVsbC4KKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTYyOTc4CisKKyAgICAgICAg UmVtb3ZlIHVubmVjZXNzYXJ5IGNoZWNrIHJvdXRpbmVzIG9mIG1fdmlldyBiZWNhdXNlIENocm9t ZUNsaWVudEVmbCBoYXZlCisgICAgICAgIHZhbGlkIG1fdmlldyBhbHdheXMuCisKKyAgICAgICAg KiBXZWJDb3JlU3VwcG9ydC9DaHJvbWVDbGllbnRFZmwuY3BwOgorICAgICAgICAoV2ViQ29yZTo6 Q2hyb21lQ2xpZW50RWZsOjpDaHJvbWVDbGllbnRFZmwpOiBBZGQgQVNTRVJUKG1fdmlldykKKyAg ICAgICAgKFdlYkNvcmU6OkNocm9tZUNsaWVudEVmbDo6d2luZG93UmVjdCk6CisgICAgICAgIChX ZWJDb3JlOjpDaHJvbWVDbGllbnRFZmw6OnNldFdpbmRvd1JlY3QpOgorICAgICAgICAoV2ViQ29y ZTo6Q2hyb21lQ2xpZW50RWZsOjpwYWdlUmVjdCk6CisKIDIwMTEtMDYtMjAgIFJ5b3N1a2UgTml3 YSAgPHJuaXdhQHdlYmtpdC5vcmc+CiAKICAgICAgICAgRUZMIGJ1aWxkIGZpeCBhZnRlciByODky OTMuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2VmbC9XZWJDb3JlU3VwcG9ydC9DaHJvbWVD bGllbnRFZmwuY3BwIGIvU291cmNlL1dlYktpdC9lZmwvV2ViQ29yZVN1cHBvcnQvQ2hyb21lQ2xp ZW50RWZsLmNwcAppbmRleCA2ZjRkODE0NzYwZjllYzgzNWZmZDIyNzk0OTA5ZDllOTY5MmVhNjU1 Li5iNDA1NGEzZTEzMTE5OGY0YjNlNTk2NzljZjg5MTliZWVlZWQ4ZjNlIDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViS2l0L2VmbC9XZWJDb3JlU3VwcG9ydC9DaHJvbWVDbGllbnRFZmwuY3BwCisrKyBi L1NvdXJjZS9XZWJLaXQvZWZsL1dlYkNvcmVTdXBwb3J0L0Nocm9tZUNsaWVudEVmbC5jcHAKQEAg LTc2LDYgKzc2LDcgQEAgbmFtZXNwYWNlIFdlYkNvcmUgewogQ2hyb21lQ2xpZW50RWZsOjpDaHJv bWVDbGllbnRFZmwoRXZhc19PYmplY3QqIHZpZXcpCiAgICAgOiBtX3ZpZXcodmlldykKIHsKKyAg ICBBU1NFUlQobV92aWV3KQogfQogCiBDaHJvbWVDbGllbnRFZmw6On5DaHJvbWVDbGllbnRFZmwo KQpAQCAtMTAxLDkgKzEwMiw2IEBAIEZsb2F0UmVjdCBDaHJvbWVDbGllbnRFZmw6OndpbmRvd1Jl Y3QoKQogICAgIEVjb3JlX0V2YXMqIGVlID0gMDsKICAgICBpbnQgeCwgeSwgdywgaDsKIAotICAg IGlmICghbV92aWV3KQotICAgICAgICByZXR1cm4gRmxvYXRSZWN0KCk7Ci0KICAgICBlZSA9IGVj b3JlX2V2YXNfZWNvcmVfZXZhc19nZXQoZXZhc19vYmplY3RfZXZhc19nZXQobV92aWV3KSk7CiAg ICAgZWNvcmVfZXZhc19nZW9tZXRyeV9nZXQoZWUsICZ4LCAmeSwgJncsICZoKTsKICAgICByZXR1 cm4gRmxvYXRSZWN0KHgsIHksIHcsIGgpOwpAQCAtMTExLDE1ICsxMDksMTIgQEAgRmxvYXRSZWN0 IENocm9tZUNsaWVudEVmbDo6d2luZG93UmVjdCgpCiAKIHZvaWQgQ2hyb21lQ2xpZW50RWZsOjpz ZXRXaW5kb3dSZWN0KGNvbnN0IEZsb2F0UmVjdCYgcmVjdCkKIHsKLSAgICBFY29yZV9FdmFzKiBl ZSA9IDA7Ci0gICAgSW50UmVjdCBpbnRyZWN0ID0gSW50UmVjdChyZWN0KTsKLQotICAgIGlmICgh bV92aWV3KQotICAgICAgICByZXR1cm47Ci0KICAgICBpZiAoIWV3a192aWV3X3NldHRpbmdfZW5h YmxlX2F1dG9fcmVzaXplX3dpbmRvd19nZXQobV92aWV3KSkKICAgICAgICAgcmV0dXJuOwogCisg ICAgRWNvcmVfRXZhcyogZWUgPSAwOworICAgIEludFJlY3QgaW50cmVjdCA9IEludFJlY3QocmVj dCk7CisKICAgICBlZSA9IGVjb3JlX2V2YXNfZWNvcmVfZXZhc19nZXQoZXZhc19vYmplY3RfZXZh c19nZXQobV92aWV3KSk7CiAgICAgZWNvcmVfZXZhc19tb3ZlKGVlLCBpbnRyZWN0LngoKSwgaW50 cmVjdC55KCkpOwogICAgIGVjb3JlX2V2YXNfcmVzaXplKGVlLCBpbnRyZWN0LndpZHRoKCksIGlu dHJlY3QuaGVpZ2h0KCkpOwpAQCAtMTI3LDkgKzEyMiw2IEBAIHZvaWQgQ2hyb21lQ2xpZW50RWZs OjpzZXRXaW5kb3dSZWN0KGNvbnN0IEZsb2F0UmVjdCYgcmVjdCkKIAogRmxvYXRSZWN0IENocm9t ZUNsaWVudEVmbDo6cGFnZVJlY3QoKQogewotICAgIGlmICghbV92aWV3KQotICAgICAgICByZXR1 cm4gRmxvYXRSZWN0KCk7Ci0KICAgICByZXR1cm4gZXdrX3ZpZXdfcGFnZV9yZWN0X2dldChtX3Zp ZXcpOwogfQogCg== 97898 2011-06-20 18:03:27 -0700 2011-06-20 18:33:45 -0700 Patch bug-62978-20110621100242.patch text/plain 2576 ryuan.choi U3VidmVyc2lvbiBSZXZpc2lvbjogODkzMDAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZWZs L0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvZWZsL0NoYW5nZUxvZwppbmRleCBlZjkyN2I3ODQ3 NTg2NzBlODQzZjFhYTVlZmJhOGFkODJkYzc4NGFjLi5hMjBhYjkxOTIxZTU3OWIwZDYyMGIwMWZj OTQ3NjgxMDQ3NGRhNDBjIDEwMDc1NQotLS0gYS9Tb3VyY2UvV2ViS2l0L2VmbC9DaGFuZ2VMb2cK KysrIGIvU291cmNlL1dlYktpdC9lZmwvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkgQEAKKzIwMTEt MDYtMjAgIFJ5dWFuIENob2kgIDxyeXVhbi5jaG9pQHNhbXN1bmcuY29tPgorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtFRkxdIENocm9tZUNsaWVudEVm bCBkb2Vzbid0IG5lZWQgdG8gY2hlY2sgd2hldGhlciBtX3ZpZXcgaXMgbnVsbC4KKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTYyOTc4CisKKyAgICAgICAg UmVtb3ZlIHVubmVjZXNzYXJ5IGNoZWNrIHJvdXRpbmVzIG9mIG1fdmlldyBiZWNhdXNlIENocm9t ZUNsaWVudEVmbCBoYXZlCisgICAgICAgIHZhbGlkIG1fdmlldyBhbHdheXMuCisKKyAgICAgICAg KiBXZWJDb3JlU3VwcG9ydC9DaHJvbWVDbGllbnRFZmwuY3BwOgorICAgICAgICAoV2ViQ29yZTo6 Q2hyb21lQ2xpZW50RWZsOjpDaHJvbWVDbGllbnRFZmwpOiBBZGQgQVNTRVJUKG1fdmlldykKKyAg ICAgICAgKFdlYkNvcmU6OkNocm9tZUNsaWVudEVmbDo6d2luZG93UmVjdCk6CisgICAgICAgIChX ZWJDb3JlOjpDaHJvbWVDbGllbnRFZmw6OnNldFdpbmRvd1JlY3QpOgorICAgICAgICAoV2ViQ29y ZTo6Q2hyb21lQ2xpZW50RWZsOjpwYWdlUmVjdCk6CisKIDIwMTEtMDYtMjAgIFJ5b3N1a2UgTml3 YSAgPHJuaXdhQHdlYmtpdC5vcmc+CiAKICAgICAgICAgRUZMIGJ1aWxkIGZpeCBhZnRlciByODky OTMuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2VmbC9XZWJDb3JlU3VwcG9ydC9DaHJvbWVD bGllbnRFZmwuY3BwIGIvU291cmNlL1dlYktpdC9lZmwvV2ViQ29yZVN1cHBvcnQvQ2hyb21lQ2xp ZW50RWZsLmNwcAppbmRleCA2ZjRkODE0NzYwZjllYzgzNWZmZDIyNzk0OTA5ZDllOTY5MmVhNjU1 Li4wYzczNmE1YTY2NDlhZWRkNGFjMDkyOWJjOTFiOTgzZDkzMjE1NGJiIDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViS2l0L2VmbC9XZWJDb3JlU3VwcG9ydC9DaHJvbWVDbGllbnRFZmwuY3BwCisrKyBi L1NvdXJjZS9XZWJLaXQvZWZsL1dlYkNvcmVTdXBwb3J0L0Nocm9tZUNsaWVudEVmbC5jcHAKQEAg LTc2LDYgKzc2LDcgQEAgbmFtZXNwYWNlIFdlYkNvcmUgewogQ2hyb21lQ2xpZW50RWZsOjpDaHJv bWVDbGllbnRFZmwoRXZhc19PYmplY3QqIHZpZXcpCiAgICAgOiBtX3ZpZXcodmlldykKIHsKKyAg ICBBU1NFUlQobV92aWV3KTsKIH0KIAogQ2hyb21lQ2xpZW50RWZsOjp+Q2hyb21lQ2xpZW50RWZs KCkKQEAgLTEwMSw5ICsxMDIsNiBAQCBGbG9hdFJlY3QgQ2hyb21lQ2xpZW50RWZsOjp3aW5kb3dS ZWN0KCkKICAgICBFY29yZV9FdmFzKiBlZSA9IDA7CiAgICAgaW50IHgsIHksIHcsIGg7CiAKLSAg ICBpZiAoIW1fdmlldykKLSAgICAgICAgcmV0dXJuIEZsb2F0UmVjdCgpOwotCiAgICAgZWUgPSBl Y29yZV9ldmFzX2Vjb3JlX2V2YXNfZ2V0KGV2YXNfb2JqZWN0X2V2YXNfZ2V0KG1fdmlldykpOwog ICAgIGVjb3JlX2V2YXNfZ2VvbWV0cnlfZ2V0KGVlLCAmeCwgJnksICZ3LCAmaCk7CiAgICAgcmV0 dXJuIEZsb2F0UmVjdCh4LCB5LCB3LCBoKTsKQEAgLTExMSwxNSArMTA5LDEyIEBAIEZsb2F0UmVj dCBDaHJvbWVDbGllbnRFZmw6OndpbmRvd1JlY3QoKQogCiB2b2lkIENocm9tZUNsaWVudEVmbDo6 c2V0V2luZG93UmVjdChjb25zdCBGbG9hdFJlY3QmIHJlY3QpCiB7Ci0gICAgRWNvcmVfRXZhcyog ZWUgPSAwOwotICAgIEludFJlY3QgaW50cmVjdCA9IEludFJlY3QocmVjdCk7Ci0KLSAgICBpZiAo IW1fdmlldykKLSAgICAgICAgcmV0dXJuOwotCiAgICAgaWYgKCFld2tfdmlld19zZXR0aW5nX2Vu YWJsZV9hdXRvX3Jlc2l6ZV93aW5kb3dfZ2V0KG1fdmlldykpCiAgICAgICAgIHJldHVybjsKIAor ICAgIEVjb3JlX0V2YXMqIGVlID0gMDsKKyAgICBJbnRSZWN0IGludHJlY3QgPSBJbnRSZWN0KHJl Y3QpOworCiAgICAgZWUgPSBlY29yZV9ldmFzX2Vjb3JlX2V2YXNfZ2V0KGV2YXNfb2JqZWN0X2V2 YXNfZ2V0KG1fdmlldykpOwogICAgIGVjb3JlX2V2YXNfbW92ZShlZSwgaW50cmVjdC54KCksIGlu dHJlY3QueSgpKTsKICAgICBlY29yZV9ldmFzX3Jlc2l6ZShlZSwgaW50cmVjdC53aWR0aCgpLCBp bnRyZWN0LmhlaWdodCgpKTsKQEAgLTEyNyw5ICsxMjIsNiBAQCB2b2lkIENocm9tZUNsaWVudEVm bDo6c2V0V2luZG93UmVjdChjb25zdCBGbG9hdFJlY3QmIHJlY3QpCiAKIEZsb2F0UmVjdCBDaHJv bWVDbGllbnRFZmw6OnBhZ2VSZWN0KCkKIHsKLSAgICBpZiAoIW1fdmlldykKLSAgICAgICAgcmV0 dXJuIEZsb2F0UmVjdCgpOwotCiAgICAgcmV0dXJuIGV3a192aWV3X3BhZ2VfcmVjdF9nZXQobV92 aWV3KTsKIH0KIAo=