62859 2011-06-17 06:30:43 -0700 Exclude isCALayerContext check if building Chrome to use Skia on Mac. 2011-06-17 11:14:02 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 caryclark caryclark mihaip sail webkit.review.bot oldest_to_newest 422585 0 caryclark 2011-06-17 06:30:43 -0700 Exclude isCALayerContext check if building Chrome to use Skia on Mac. 422587 1 97590 caryclark 2011-06-17 06:33:39 -0700 Created attachment 97590 Patch 422674 2 mihaip 2011-06-17 10:05:22 -0700 I'm not that familiar with the Mac Skia efforts. Would it be safer (in case there are other callsites) to change GraphicsContext.h to add a declaration of isCALayerContext when USE(SKIA) is defined to always return false? 422707 3 caryclark 2011-06-17 10:35:44 -0700 This is the only call-site. Eventually, the code will become scrollAnimator->setIsDrawingIntoLayer(false); (no compile-time condition) once all Skia patches are landed, so there's little value in adding a dummy isCALayerContext() call. 422708 4 caryclark 2011-06-17 10:36:27 -0700 (that is, this is the only call-site that is compiled when USE(SKIA) is defined on the Chromium Mac build.) 422759 5 webkit.review.bot 2011-06-17 11:12:32 -0700 The commit-queue encountered the following flaky tests while processing attachment 97590: fast/dom/NodeList/5725058-crash-scenario-1.html bug 62577 (authors: mrowe@apple.com and sam@webkit.org) The commit-queue is continuing to process your patch. 422760 6 97590 webkit.review.bot 2011-06-17 11:13:58 -0700 Comment on attachment 97590 Patch Clearing flags on attachment: 97590 Committed r89147: <http://trac.webkit.org/changeset/89147> 422761 7 webkit.review.bot 2011-06-17 11:14:02 -0700 All reviewed patches have been landed. Closing bug. 97590 2011-06-17 06:33:39 -0700 2011-06-17 11:13:58 -0700 Patch bug-62859-20110617093338.patch text/plain 1756 caryclark SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDg5MTM1KQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTggQEAKKzIwMTEtMDYtMTcgIENhcnkgQ2xh cmsgIDxjYXJ5Y2xhcmtAZ29vZ2xlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBFeGNsdWRlIGlzQ0FMYXllckNvbnRleHQgY2hlY2sgaWYgYnVp bGRpbmcgQ2hyb21lIHRvIHVzZSBTa2lhIG9uIE1hYy4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTYyODU5CisKKyAgICAgICAgTm8gbmV3IHRlc3RzLiBU aGlzIGNoYW5nZSBkb2VzIG5vdCBhZmZlY3QgZXhpc3RpbmcgZnVuY3Rpb25hbGl0eS4KKworICAg ICAgICAqIHBsYXRmb3JtL2Nocm9taXVtL1Njcm9sbGJhclRoZW1lQ2hyb21pdW1NYWMubW06Cisg ICAgICAgIChXZWJDb3JlOjpTY3JvbGxiYXJUaGVtZUNocm9taXVtTWFjOjpwYWludCk6CisgICAg ICAgIEFkZCBhIGNvbmRpdGlvbmFsIHRvIGFsd2F5cyBzZXQgZHJhd2luZyBpbnRvIGxheWVyIHRv IGZhbHNlIGlmCisgICAgICAgIFNraWEgaXMgdGhlIFdlYktpdCByZW5kZXJpbmcgZW5naW5lLiBP bmNlIFVTRShTS0lBKSBpcyBlbmFibGVkLAorICAgICAgICB0aGlzIGNvbmRpdGlvbiBjYW4gYmUg cmVtb3ZlZC4KKwogMjAxMS0wNi0xNiAgUGF2ZWwgUG9kaXZpbG92ICA8cG9kaXZpbG92QGNocm9t aXVtLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBZdXJ5IFNlbWlraGF0c2t5LgpJbmRleDog U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vY2hyb21pdW0vU2Nyb2xsYmFyVGhlbWVDaHJvbWl1bU1h Yy5tbQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9jaHJvbWl1bS9TY3Jv bGxiYXJUaGVtZUNocm9taXVtTWFjLm1tCShyZXZpc2lvbiA4OTEzNSkKKysrIFNvdXJjZS9XZWJD b3JlL3BsYXRmb3JtL2Nocm9taXVtL1Njcm9sbGJhclRoZW1lQ2hyb21pdW1NYWMubW0JKHdvcmtp bmcgY29weSkKQEAgLTQ3MSw3ICs0NzEsMTEgQEAgYm9vbCBTY3JvbGxiYXJUaGVtZUNocm9taXVt TWFjOjpwYWludChTYwogICAgICAgICB9CiAKICAgICAgICAgU2Nyb2xsQW5pbWF0b3JDaHJvbWl1 bU1hYyogc2Nyb2xsQW5pbWF0b3IgPSBzdGF0aWNfY2FzdDxTY3JvbGxBbmltYXRvckNocm9taXVt TWFjKj4oc2Nyb2xsYmFyLT5zY3JvbGxhYmxlQXJlYSgpLT5zY3JvbGxBbmltYXRvcigpKTsKKyNp ZiAhVVNFKFNLSUEpCiAgICAgICAgIHNjcm9sbEFuaW1hdG9yLT5zZXRJc0RyYXdpbmdJbnRvTGF5 ZXIoY29udGV4dC0+aXNDQUxheWVyQ29udGV4dCgpKTsKKyNlbHNlCisgICAgICAgIHNjcm9sbEFu aW1hdG9yLT5zZXRJc0RyYXdpbmdJbnRvTGF5ZXIoZmFsc2UpOworI2VuZGlmCiAKICAgICAgICAg d2tTZXRTY3JvbGxiYXJQYWludGVyS25vYlN0eWxlKHBhaW50ZXJGb3JTY3JvbGxiYXIoc2Nyb2xs YmFyKSwgdG9TY3JvbGxiYXJQYWludGVyS25vYlN0eWxlKHNjcm9sbGJhci0+c2Nyb2xsYWJsZUFy ZWEoKS0+cmVjb21tZW5kZWRTY3JvbGxiYXJPdmVybGF5U3R5bGUoKSkpOwogCg==