62795 2011-06-16 06:52:21 -0700 WebSocket: Clean up pywebsocket handlers 2011-07-04 01:36:18 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 63689 63704 63794 62786 1 yutak yutak ap tkent ukai oldest_to_newest 421930 0 yutak 2011-06-16 06:52:21 -0700 Part one of bug 62786. 421947 1 97442 yutak 2011-06-16 07:29:11 -0700 Created attachment 97442 Patch 422441 2 97442 tkent 2011-06-16 23:22:30 -0700 Comment on attachment 97442 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=97442&action=review > LayoutTests/ChangeLog:9 > + Common mistakes are: (1) not raising an exception in the end of a hander, hander -> handler? > LayoutTests/ChangeLog:11 > + This change fixes errors seen among pywebsocket handlers for layout tests. > + Common mistakes are: (1) not raising an exception in the end of a hander, > + (2) using obsolete handshake format (Hixie's protocol draft 75), (3) style > + errors such as bad indentation. In general, if we fix three erros, we had better to have three patches. This patch would be acceptable for some reviewers because it's not large. (1) and (2) seem behavior changes. Don't they affect existing layout tests? 430194 3 97442 yutak 2011-06-29 23:18:42 -0700 Comment on attachment 97442 Patch Sure, I'm going to split this patch into smaller patches. I will try to clarify your questions in ChangeLogs of these patches. 431836 4 yutak 2011-07-04 01:36:18 -0700 This is done. (in three sub-patches: bug 63689, bug 63704, and bug 63794) 97442 2011-06-16 07:29:11 -0700 2011-06-29 23:18:42 -0700 Patch bug-62795-20110616232910.patch text/plain 10421 yutak U3VidmVyc2lvbiBSZXZpc2lvbjogODg5NzIKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5n ZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCAwZGU0Nzc1MDgzZGMzYzdlOGMxZjNk OTBhZjc0YTNlZTUwYmMyMjFjLi44NTU2ZjgzNTc3ZGI0MDg5ODY3YTY0MzA4NDQ0NGRlMzY3Y2M2 MmQ2IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMv Q2hhbmdlTG9nCkBAIC0xLDMgKzEsNDAgQEAKKzIwMTEtMDYtMTYgIFl1dGEgS2l0YW11cmEgIDx5 dXRha0BjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgV2ViU29ja2V0OiBDbGVhbiB1cCBweXdlYnNvY2tldCBoYW5kbGVycworICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjI3OTUKKworICAg ICAgICBUaGlzIGNoYW5nZSBmaXhlcyBlcnJvcnMgc2VlbiBhbW9uZyBweXdlYnNvY2tldCBoYW5k bGVycyBmb3IgbGF5b3V0IHRlc3RzLgorICAgICAgICBDb21tb24gbWlzdGFrZXMgYXJlOiAoMSkg bm90IHJhaXNpbmcgYW4gZXhjZXB0aW9uIGluIHRoZSBlbmQgb2YgYSBoYW5kZXIsCisgICAgICAg ICgyKSB1c2luZyBvYnNvbGV0ZSBoYW5kc2hha2UgZm9ybWF0IChIaXhpZSdzIHByb3RvY29sIGRy YWZ0IDc1KSwgKDMpIHN0eWxlCisgICAgICAgIGVycm9ycyBzdWNoIGFzIGJhZCBpbmRlbnRhdGlv bi4KKworICAgICAgICBGb3IgKDEpOiBpZiBhbiBleGNlcHRpb24gaXMgbm90IHJhaXNlZCBpbiBh IGhhbmRsZXIsIHB5d2Vic29ja2V0IHdpbGwKKyAgICAgICAgYXV0b21hdGljYWxseSBzZW5kIGEg V2ViU29ja2V0IGhhbmRzaGFrZSAoYWZ0ZXIgd2ViX3NvY2tldF9kb19leHRyYV9oYW5kc2hha2Up CisgICAgICAgIG9yIHN0YXJ0IHRoZSBjbG9zaW5nIGhhbmRzaGFrZSAoYWZ0ZXIgd2ViX3NvY2tl dF90cmFuc2Zlcl9kYXRhKS4gQm90aCBjYXNlcworICAgICAgICBjYXVzZSB1bmludGVuZGVkIGRh dGEgdG8gYmUgc2VudCB0byB0aGUgY2xpZW50LCB3aGljaCBpcyBub3QgZGVzaXJhYmxlLgorCisg ICAgICAgICogaHR0cC90ZXN0cy93ZWJzb2NrZXQvdGVzdHMvYmFkLWhhbmRzaGFrZS1jcmFzaF93 c2gucHk6CisgICAgICAgIFVzZSB0aGUgbmV3IGhhbmRzaGFrZSBmb3JtYXQsIGFuZCByYWlzZSBh biBleGNlcHRpb24uIElmIHdlIGRvbid0IHJhaXNlCisgICAgICAgIGFuIGV4Y2VwdGlvbiwgcHl3 ZWJzb2NrZXQgc2VuZHMgYW5vdGhlciAobm90IGJyb2tlbikgaGFuZHNoYWtlIG1lc3NhZ2UKKyAg ICAgICAgd2hpY2ggd2UgcmVhbGx5IGRvbid0IHdhbnQuCisgICAgICAgICogaHR0cC90ZXN0cy93 ZWJzb2NrZXQvdGVzdHMvZnJhbWUtbGVuZ3RoLW92ZXJmbG93X3dzaC5weToKKyAgICAgICAgRG9u J3QgbGV0IHB5d2Vic29ja2V0IHN0YXJ0IHRoZSBXZWJTb2NrZXQgY2xvc2luZyBoYW5kc2hha2Ug YnkgcmFpc2luZyBhbgorICAgICAgICBleGNlcHRpb24uCisgICAgICAgICogaHR0cC90ZXN0cy93 ZWJzb2NrZXQvdGVzdHMvZnJhbWUtbGVuZ3RoLXNraXBfd3NoLnB5OgorICAgICAgICAqIGh0dHAv dGVzdHMvd2Vic29ja2V0L3Rlc3RzL2hhbmRzaGFrZS1mYWlsLWJ5LW1heGxlbmd0aF93c2gucHk6 CisgICAgICAgIFdlIGRvbid0IGhhdmUgdG8gd2FpdCBmb3IgY2xpZW50J3MgZGlzY29ubmVjdGlv bi4KKyAgICAgICAgKiBodHRwL3Rlc3RzL3dlYnNvY2tldC90ZXN0cy9oYW5kc2hha2UtZmFpbC1i eS1uby1jb25uZWN0aW9uLWhlYWRlcl93c2gucHk6CisgICAgICAgICogaHR0cC90ZXN0cy93ZWJz b2NrZXQvdGVzdHMvaGFuZHNoYWtlLWZhaWwtYnktbm8tY3Jfd3NoLnB5OgorICAgICAgICAqIGh0 dHAvdGVzdHMvd2Vic29ja2V0L3Rlc3RzL2hhbmRzaGFrZS1mYWlsLWJ5LW5vLXVwZ3JhZGUtaGVh ZGVyX3dzaC5weToKKyAgICAgICAgKiBodHRwL3Rlc3RzL3dlYnNvY2tldC90ZXN0cy9sb25nLWlu dmFsaWQtaGVhZGVyX3dzaC5weToKKyAgICAgICAgQ29tcGxldGUgaGFuZHNoYWtlIGZpZWxkcyB3 ZXJlIGFkZGVkIGluIGFkZGl0aW9uIHRvIGEgYnJva2VuIG9uZS4KKyAgICAgICAgQ2hyb21pdW0n cyBTb2NrZXRTdHJlYW1IYW5kbGUgaW1wbGVtZW50YXRpb24gbG9va3MgYXQgdGhlIGNvbnRlbnQg b2YgaGFuZHNoYWtlCisgICAgICAgIG1lc3NhZ2VzIGFuZCBkb2VzIG5vdCBzZW5kIHRoZSBoYW5k c2hha2UgcmVzcG9uc2UgdG8gV2ViS2l0IHVudGlsIGl0IHJlY2VpdmVzCisgICAgICAgIGVudGly ZSBoYW5kc2hha2UgbWVzc2FnZXMgKGkuZS4gdW50aWwgaXQgZmluZHMgIlxyXG5cclxuIiBhbmQg ZWlnaHQgbW9yZSBieXRlcykuCisgICAgICAgIFRodXMgd2UgbmVlZCB0byBzZW5kIGEgY29tcGxl dGUgaGFuZHNoYWtlIGJlZm9yZSByYWlzaW5nIGFuIGV4Y2VwdGlvbi4KKwogMjAxMS0wNi0xNSAg U3RlcGhlbiBXaGl0ZSAgPHNlbm9yYmxhbmNvQGNocm9taXVtLm9yZz4KIAogICAgICAgICBVbnJl dmlld2VkOyBtb3JlIGNocm9taXVtIHRlc3QgZXhwZWN0YXRpb25zIHVwZGF0ZXMuCmRpZmYgLS1n aXQgYS9MYXlvdXRUZXN0cy9odHRwL3Rlc3RzL3dlYnNvY2tldC90ZXN0cy9iYWQtaGFuZHNoYWtl LWNyYXNoX3dzaC5weSBiL0xheW91dFRlc3RzL2h0dHAvdGVzdHMvd2Vic29ja2V0L3Rlc3RzL2Jh ZC1oYW5kc2hha2UtY3Jhc2hfd3NoLnB5CmluZGV4IDAxYzQ4MzFiZjA3YTNlNzk5YTc1NzNjNDg3 ZjAzMzdhYTcyYmEwNGUuLmI5M2E4ZDc0ZTY0YzYxZjc2ZmIzMjcxZTk2N2JiZjhiMWY4OTlmNzYg MTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL2h0dHAvdGVzdHMvd2Vic29ja2V0L3Rlc3RzL2JhZC1o YW5kc2hha2UtY3Jhc2hfd3NoLnB5CisrKyBiL0xheW91dFRlc3RzL2h0dHAvdGVzdHMvd2Vic29j a2V0L3Rlc3RzL2JhZC1oYW5kc2hha2UtY3Jhc2hfd3NoLnB5CkBAIC0xLDExICsxLDE2IEBACiBk ZWYgd2ViX3NvY2tldF9kb19leHRyYV9oYW5kc2hha2UocmVxdWVzdCk6Ci0gIG1zZyA9ICJIVFRQ LzEuMSAxMDEgV2ViIFNvY2tldCBQcm90b2NvbCBIYW5kc2hha2VcclxuIgotICBtc2cgKz0gIlVw Z3JhZGU6IFdlYlNvY2tldFxyXG4iCi0gIG1zZyArPSAiQ29ubmVjdGlvbjogVXBncmFkZVxyXG4i Ci0gIG1zZyArPSAiXHhhNTpcclxuIgotICBtc2cgKz0gIlxyXG4iCi0gIHJlcXVlc3QuY29ubmVj dGlvbi53cml0ZShtc2cpCi0gIHByaW50IG1zZworICAgIG1zZyA9ICJIVFRQLzEuMSAxMDEgV2Vi U29ja2V0IFByb3RvY29sIEhhbmRzaGFrZVxyXG4iCisgICAgbXNnICs9ICJVcGdyYWRlOiBXZWJT b2NrZXRcclxuIgorICAgIG1zZyArPSAiQ29ubmVjdGlvbjogVXBncmFkZVxyXG4iCisgICAgbXNn ICs9ICJTZWMtV2ViU29ja2V0LUxvY2F0aW9uOiAiICsgcmVxdWVzdC53c19sb2NhdGlvbiArICJc clxuIgorICAgIG1zZyArPSAiU2VjLVdlYlNvY2tldC1PcmlnaW46ICIgKyByZXF1ZXN0LndzX29y aWdpbiArICJcclxuIgorICAgIG1zZyArPSAiXHhhNTpcclxuIgorICAgIG1zZyArPSAiXHJcbiIK KyAgICBtc2cgKz0gcmVxdWVzdC53c19jaGFsbGVuZ2VfbWQ1CisgICAgcmVxdWVzdC5jb25uZWN0 aW9uLndyaXRlKG1zZykKKyAgICBwcmludCBtc2cKKyAgICByYWlzZSBFeGNlcHRpb24oIkFib3J0 IHRoZSBjb25uZWN0aW9uIikgIyBQcmV2ZW50cyBweXdlYnNvY2tldCBmcm9tIHNlbmRpbmcgYW5v dGhlciBoYW5kc2hha2UgcmVzcG9uc2UuCisKIAogZGVmIHdlYl9zb2NrZXRfdHJhbnNmZXJfZGF0 YShyZXF1ZXN0KToKLSAgcGFzcworICAgIHBhc3MKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2h0 dHAvdGVzdHMvd2Vic29ja2V0L3Rlc3RzL2ZyYW1lLWxlbmd0aC1vdmVyZmxvd193c2gucHkgYi9M YXlvdXRUZXN0cy9odHRwL3Rlc3RzL3dlYnNvY2tldC90ZXN0cy9mcmFtZS1sZW5ndGgtb3ZlcmZs b3dfd3NoLnB5CmluZGV4IDBmNTE4YThiZDJlMDgwNDkyNjAxNGZmYjI0MTk0ZjE2MjMzNGY5YTgu LjFjN2M5MjFjYWQ5ZjVmMGE1MTliYmUxNjExYjEzYTIwZTg0MzY3YWUgMTAwNjQ0Ci0tLSBhL0xh eW91dFRlc3RzL2h0dHAvdGVzdHMvd2Vic29ja2V0L3Rlc3RzL2ZyYW1lLWxlbmd0aC1vdmVyZmxv d193c2gucHkKKysrIGIvTGF5b3V0VGVzdHMvaHR0cC90ZXN0cy93ZWJzb2NrZXQvdGVzdHMvZnJh bWUtbGVuZ3RoLW92ZXJmbG93X3dzaC5weQpAQCAtMSw2ICsxLDggQEAKIGRlZiB3ZWJfc29ja2V0 X2RvX2V4dHJhX2hhbmRzaGFrZShyZXF1ZXN0KToKLSAgcGFzcworICAgIHBhc3MKKwogCiBkZWYg d2ViX3NvY2tldF90cmFuc2Zlcl9kYXRhKHJlcXVlc3QpOgotICBtc2cgPSAxNiAqICdceGZmJwot ICByZXF1ZXN0LmNvbm5lY3Rpb24ud3JpdGUobXNnKQorICAgIG1zZyA9IDE2ICogJ1x4ZmYnCisg ICAgcmVxdWVzdC5jb25uZWN0aW9uLndyaXRlKG1zZykKKyAgICByYWlzZSBFeGNlcHRpb24oJ0Fi b3J0IHRoZSBjb25uZWN0aW9uJykgIyBQcmV2ZW50cyBweXdlYnNvY2tldCBmcm9tIHN0YXJ0aW5n IGNsb3NpbmcgaGFuZHNoYWtlLgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvaHR0cC90ZXN0cy93 ZWJzb2NrZXQvdGVzdHMvZnJhbWUtbGVuZ3RoLXNraXBfd3NoLnB5IGIvTGF5b3V0VGVzdHMvaHR0 cC90ZXN0cy93ZWJzb2NrZXQvdGVzdHMvZnJhbWUtbGVuZ3RoLXNraXBfd3NoLnB5CmluZGV4IGQx NGY1NTA3NzM1ZjYxNDRiZDU2NmJiYjZkMWJiYjA1ODI5ODgwYmIuLmZlODc0MDFkZmVhYzVmYWJj OWIxNDdlMmU3NmU4ZjUwNDcxZjIwZTUgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL2h0dHAvdGVz dHMvd2Vic29ja2V0L3Rlc3RzL2ZyYW1lLWxlbmd0aC1za2lwX3dzaC5weQorKysgYi9MYXlvdXRU ZXN0cy9odHRwL3Rlc3RzL3dlYnNvY2tldC90ZXN0cy9mcmFtZS1sZW5ndGgtc2tpcF93c2gucHkK QEAgLTEsMTEgKzEsMTIgQEAKIGRlZiB3ZWJfc29ja2V0X2RvX2V4dHJhX2hhbmRzaGFrZShyZXF1 ZXN0KToKLSAgcGFzcworICAgIHBhc3MKKwogCiBkZWYgd2ViX3NvY2tldF90cmFuc2Zlcl9kYXRh KHJlcXVlc3QpOgotICBtc2cgPSAiXDBoZWxsb1x4ZmYiCi0gIG1zZyArPSAiXHg4MFx4ODFceDAx IiAgICMgc2tpcCAxKjEyOCsxIGJ5dGVzLgotICBtc2cgKz0gIlx4MDEiCi0gIG1zZyArPSAiXDBz aG91bGQgYmUgc2tpcHBlZCIgKyAoIiAiICogMTA5KSArICJceGZmIgotICBtc2cgKz0gIlwwd29y bGRceGZmIgotICByZXF1ZXN0LmNvbm5lY3Rpb24ud3JpdGUobXNnKQotICBwcmludCBtc2cKKyAg ICBtc2cgPSAiXDBoZWxsb1x4ZmYiCisgICAgbXNnICs9ICJceDgwXHg4MVx4MDEiICAgIyBza2lw IDEqMTI4KzEgYnl0ZXMuCisgICAgbXNnICs9ICJceDAxIgorICAgIG1zZyArPSAiXDBzaG91bGQg YmUgc2tpcHBlZCIgKyAoIiAiICogMTA5KSArICJceGZmIgorICAgIG1zZyArPSAiXDB3b3JsZFx4 ZmYiCisgICAgcmVxdWVzdC5jb25uZWN0aW9uLndyaXRlKG1zZykKKyAgICBwcmludCBtc2cKZGlm ZiAtLWdpdCBhL0xheW91dFRlc3RzL2h0dHAvdGVzdHMvd2Vic29ja2V0L3Rlc3RzL2hhbmRzaGFr ZS1mYWlsLWJ5LW1heGxlbmd0aF93c2gucHkgYi9MYXlvdXRUZXN0cy9odHRwL3Rlc3RzL3dlYnNv Y2tldC90ZXN0cy9oYW5kc2hha2UtZmFpbC1ieS1tYXhsZW5ndGhfd3NoLnB5CmluZGV4IGZjN2Zm YjUzZmI4MjI5OWFhZTMzNDM4ZjExMzY1NjBlYmRiYmJlNjcuLmVkNDczNDIzODdkYTAwOTEwMDEy MGE2ZThlOTk5YTA4YzA2MjI3ODQgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL2h0dHAvdGVzdHMv d2Vic29ja2V0L3Rlc3RzL2hhbmRzaGFrZS1mYWlsLWJ5LW1heGxlbmd0aF93c2gucHkKKysrIGIv TGF5b3V0VGVzdHMvaHR0cC90ZXN0cy93ZWJzb2NrZXQvdGVzdHMvaGFuZHNoYWtlLWZhaWwtYnkt bWF4bGVuZ3RoX3dzaC5weQpAQCAtMTksMTQgKzE5LDExIEBACiAjIFRPUlQgKElOQ0xVRElORyBO RUdMSUdFTkNFIE9SIE9USEVSV0lTRSkgQVJJU0lORyBJTiBBTlkgV0FZIE9VVCBPRiBUSEUgVVNF IE9GIFRISVMKICMgU09GVFdBUkUsIEVWRU4gSUYgQURWSVNFRCBPRiBUSEUgUE9TU0lCSUxJVFkg T0YgU1VDSCBEQU1BR0UuCiAKLWltcG9ydCB0aW1lCiAKIGRlZiB3ZWJfc29ja2V0X2RvX2V4dHJh X2hhbmRzaGFrZShyZXF1ZXN0KToKICAgICAjIFRoaXMgd2lsbCBjYXVzZSB0aGUgaGFuZHNoYWtl IHRvIGZhaWwgYmVjYXVzZSBpdCBwdXNoZXMgdGhlIGxlbmd0aCBvZiB0aGUKICAgICAjIHN0YXR1 cyBsaW5lIHBhc3QgMTAyNCBjaGFyYWN0ZXJzCi0gICAgbXNnID0gIiIKLSAgICBmb3IgaSBpbiBy YW5nZSgwLCAxMDI0KToKLSAgICAgICAgbXNnICs9ICIuIgorICAgIG1zZyA9ICIuIiAqIDEwMjQK ICAgICBtc2cgKz0gJ0hUVFAvMS4xIDEwMSBXZWJTb2NrZXQgUHJvdG9jb2wgSGFuZHNoYWtlXHJc bicKICAgICBtc2cgKz0gJ1VwZ3JhZGU6IFdlYlNvY2tldFxyXG4nCiAgICAgbXNnICs9ICdDb25u ZWN0aW9uOiBVcGdyYWRlXHJcbicKQEAgLTM1LDEwICszMiw4IEBAIGRlZiB3ZWJfc29ja2V0X2Rv X2V4dHJhX2hhbmRzaGFrZShyZXF1ZXN0KToKICAgICBtc2cgKz0gJ1xyXG4nCiAgICAgbXNnICs9 IHJlcXVlc3Qud3NfY2hhbGxlbmdlX21kNQogICAgIHJlcXVlc3QuY29ubmVjdGlvbi53cml0ZSht c2cpCi0gICAgIyBjb250aW51ZSB3cml0aW5nIGRhdGEgdW50aWwgdGhlIGNsaWVudCBkaXNjb25u ZWN0cwotICAgIHdoaWxlIFRydWU6Ci0gICAgICAgIHRpbWUuc2xlZXAoMSkKLSAgICAgICAgcmVx dWVzdC5jb25uZWN0aW9uLndyaXRlKCdrZWVwYWxpdmVcbicpCisgICAgcmFpc2UgRXhjZXB0aW9u KCdBYm9ydCB0aGUgY29ubmVjdGlvbicpICMgUHJldmVudHMgcHl3ZWJzb2NrZXQgZnJvbSBzZW5k aW5nIGl0cyBvd24gaGFuZHNoYWtlIG1lc3NhZ2UuCisKIAogZGVmIHdlYl9zb2NrZXRfdHJhbnNm ZXJfZGF0YShyZXF1ZXN0KToKICAgICBwYXNzCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9odHRw L3Rlc3RzL3dlYnNvY2tldC90ZXN0cy9oYW5kc2hha2UtZmFpbC1ieS1uby1jb25uZWN0aW9uLWhl YWRlcl93c2gucHkgYi9MYXlvdXRUZXN0cy9odHRwL3Rlc3RzL3dlYnNvY2tldC90ZXN0cy9oYW5k c2hha2UtZmFpbC1ieS1uby1jb25uZWN0aW9uLWhlYWRlcl93c2gucHkKaW5kZXggNDk3ZjA5NGM3 MjRiMGNlNWUyNzIyMTE0YzA0ZGM5OTJmZTcyOWY3Mi4uN2VmYzg3YTUwZDY2ZGU4NzRjOGExZGMz ODZmMmRiNmNlZjAzYTQzNyAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvaHR0cC90ZXN0cy93ZWJz b2NrZXQvdGVzdHMvaGFuZHNoYWtlLWZhaWwtYnktbm8tY29ubmVjdGlvbi1oZWFkZXJfd3NoLnB5 CisrKyBiL0xheW91dFRlc3RzL2h0dHAvdGVzdHMvd2Vic29ja2V0L3Rlc3RzL2hhbmRzaGFrZS1m YWlsLWJ5LW5vLWNvbm5lY3Rpb24taGVhZGVyX3dzaC5weQpAQCAtOCw2ICs4LDggQEAgZGVmIHdl Yl9zb2NrZXRfZG9fZXh0cmFfaGFuZHNoYWtlKHJlcXVlc3QpOgogICAgIG1zZyArPSByZXF1ZXN0 LndzX2NoYWxsZW5nZV9tZDUKICAgICByZXF1ZXN0LmNvbm5lY3Rpb24ud3JpdGUobXNnKQogICAg IHByaW50IG1zZworICAgIHJhaXNlIEV4Y2VwdGlvbignQWJvcnQgdGhlIGNvbm5lY3Rpb24nKSAj IFByZXZlbnRzIHB5d2Vic29ja2V0IGZyb20gc2VuZGluZyBpdHMgb3duIGhhbmRzaGFrZSBtZXNz YWdlLgorCiAKIGRlZiB3ZWJfc29ja2V0X3RyYW5zZmVyX2RhdGEocmVxdWVzdCk6CiAgICAgcGFz cwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvaHR0cC90ZXN0cy93ZWJzb2NrZXQvdGVzdHMvaGFu ZHNoYWtlLWZhaWwtYnktbm8tY3Jfd3NoLnB5IGIvTGF5b3V0VGVzdHMvaHR0cC90ZXN0cy93ZWJz b2NrZXQvdGVzdHMvaGFuZHNoYWtlLWZhaWwtYnktbm8tY3Jfd3NoLnB5CmluZGV4IGM1MmY4MDk1 NzZkZWM0NDZhYTNlMDIzMjdiNzE4Y2EwNDAzMjc2NjMuLjk3ODkyNGFiNmViMThiOTU2ZmY0NTU5 ZDViOTNkYmVkZTgzYjkzMzIgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL2h0dHAvdGVzdHMvd2Vi c29ja2V0L3Rlc3RzL2hhbmRzaGFrZS1mYWlsLWJ5LW5vLWNyX3dzaC5weQorKysgYi9MYXlvdXRU ZXN0cy9odHRwL3Rlc3RzL3dlYnNvY2tldC90ZXN0cy9oYW5kc2hha2UtZmFpbC1ieS1uby1jcl93 c2gucHkKQEAgLTgsNiArOCw4IEBAIGRlZiB3ZWJfc29ja2V0X2RvX2V4dHJhX2hhbmRzaGFrZShy ZXF1ZXN0KToKICAgICBtc2cgKz0gcmVxdWVzdC53c19jaGFsbGVuZ2VfbWQ1CiAgICAgcmVxdWVz dC5jb25uZWN0aW9uLndyaXRlKG1zZykKICAgICBwcmludCBtc2cKKyAgICByYWlzZSBFeGNlcHRp b24oJ0Fib3J0IHRoZSBjb25uZWN0aW9uJykgIyBQcmV2ZW50cyBweXdlYnNvY2tldCBmcm9tIHNl bmRpbmcgaXRzIG93biBoYW5kc2hha2UgbWVzc2FnZS4KKwogCiBkZWYgd2ViX3NvY2tldF90cmFu c2Zlcl9kYXRhKHJlcXVlc3QpOgogICAgIHBhc3MKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2h0 dHAvdGVzdHMvd2Vic29ja2V0L3Rlc3RzL2hhbmRzaGFrZS1mYWlsLWJ5LW5vLXVwZ3JhZGUtaGVh ZGVyX3dzaC5weSBiL0xheW91dFRlc3RzL2h0dHAvdGVzdHMvd2Vic29ja2V0L3Rlc3RzL2hhbmRz aGFrZS1mYWlsLWJ5LW5vLXVwZ3JhZGUtaGVhZGVyX3dzaC5weQppbmRleCAyMDQwYzYzNGYzMjRk ZjdhODNmN2NiZDUzMjE1ZjVjOTM4ZThmOTE3Li4xMTRkZTc1ZTE5MzdhYzViZWU1ZTcxYTU4ZGNj ZDlkZjZiMGFmNzhjIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9odHRwL3Rlc3RzL3dlYnNvY2tl dC90ZXN0cy9oYW5kc2hha2UtZmFpbC1ieS1uby11cGdyYWRlLWhlYWRlcl93c2gucHkKKysrIGIv TGF5b3V0VGVzdHMvaHR0cC90ZXN0cy93ZWJzb2NrZXQvdGVzdHMvaGFuZHNoYWtlLWZhaWwtYnkt bm8tdXBncmFkZS1oZWFkZXJfd3NoLnB5CkBAIC04LDYgKzgsOCBAQCBkZWYgd2ViX3NvY2tldF9k b19leHRyYV9oYW5kc2hha2UocmVxdWVzdCk6CiAgICAgbXNnICs9IHJlcXVlc3Qud3NfY2hhbGxl bmdlX21kNQogICAgIHJlcXVlc3QuY29ubmVjdGlvbi53cml0ZShtc2cpCiAgICAgcHJpbnQgbXNn CisgICAgcmFpc2UgRXhjZXB0aW9uKCdBYm9ydCB0aGUgY29ubmVjdGlvbicpICMgUHJldmVudHMg cHl3ZWJzb2NrZXQgZnJvbSBzZW5kaW5nIGl0cyBvd24gaGFuZHNoYWtlIG1lc3NhZ2UuCisKIAog ZGVmIHdlYl9zb2NrZXRfdHJhbnNmZXJfZGF0YShyZXF1ZXN0KToKICAgICBwYXNzCmRpZmYgLS1n aXQgYS9MYXlvdXRUZXN0cy9odHRwL3Rlc3RzL3dlYnNvY2tldC90ZXN0cy9sb25nLWludmFsaWQt aGVhZGVyX3dzaC5weSBiL0xheW91dFRlc3RzL2h0dHAvdGVzdHMvd2Vic29ja2V0L3Rlc3RzL2xv bmctaW52YWxpZC1oZWFkZXJfd3NoLnB5CmluZGV4IGIyYTQ4ZDdkN2FhZTg1NDAwNjk4ZjU4MzYx ZjMyMjU4ZTdmODM0YzAuLjZkMzMyZjhlMjYzNTc5NDg5MGRjYjQ2OGI0YWU3YTYyMWNlNDUxYjAg MTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL2h0dHAvdGVzdHMvd2Vic29ja2V0L3Rlc3RzL2xvbmct aW52YWxpZC1oZWFkZXJfd3NoLnB5CisrKyBiL0xheW91dFRlc3RzL2h0dHAvdGVzdHMvd2Vic29j a2V0L3Rlc3RzL2xvbmctaW52YWxpZC1oZWFkZXJfd3NoLnB5CkBAIC0xLDkgKzEsMTUgQEAKIGRl ZiB3ZWJfc29ja2V0X2RvX2V4dHJhX2hhbmRzaGFrZShyZXF1ZXN0KToKLSAgbXNnID0gIkhUVFAv MS4xIDEwMSBXZWIgU29ja2V0IFByb3RvY29sIEhhbmRzaGFrZVxyXG4iCi0gIG1zZyArPSAoInAi ICogMTAyNCkgKyAiXHJcbiIKLSAgcmVxdWVzdC5jb25uZWN0aW9uLndyaXRlKG1zZykKKyAgICBt c2cgPSAiSFRUUC8xLjEgMTAxIFdlYlNvY2tldCBQcm90b2NvbCBIYW5kc2hha2VcclxuIgorICAg IG1zZyArPSAoInAiICogMTAyNCkgKyAiXHJcbiIKKyAgICBtc2cgKz0gIlVwZ3JhZGU6IFdlYlNv Y2tldFxyXG4iCisgICAgbXNnICs9ICJDb25uZWN0aW9uOiBVcGdyYWRlXHJcbiIKKyAgICBtc2cg Kz0gIlNlYy1XZWJTb2NrZXQtTG9jYXRpb246ICIgKyByZXF1ZXN0LndzX2xvY2F0aW9uICsgIlxy XG4iCisgICAgbXNnICs9ICJTZWMtV2ViU29ja2V0LU9yaWdpbjogIiArIHJlcXVlc3Qud3Nfb3Jp Z2luICsgIlxyXG4iCisgICAgbXNnICs9ICJcclxuIgorICAgIG1zZyArPSByZXF1ZXN0LndzX2No YWxsZW5nZV9tZDUKKyAgICByZXF1ZXN0LmNvbm5lY3Rpb24ud3JpdGUobXNnKQorICAgIHJhaXNl IEV4Y2VwdGlvbignQWJvcnQgdGhlIGNvbm5lY3Rpb24nKSAjIFByZXZlbnRzIHB5d2Vic29ja2V0 IGZyb20gc2VuZGluZyBpdHMgb3duIGhhbmRzaGFrZSBtZXNzYWdlLgorCiAKIGRlZiB3ZWJfc29j a2V0X3RyYW5zZmVyX2RhdGEocmVxdWVzdCk6Ci0gIG1zZyA9ICJIVFRQLzEuMSAxMDEgV2ViIFNv Y2tldCBQcm90b2NvbCBIYW5kc2hha2VcclxuIgotICBtc2cgKz0gKCJwIiAqIDEwMjQpICsgIlxy XG4iCi0gIHJlcXVlc3QuY29ubmVjdGlvbi53cml0ZShtc2cpCisgICAgcGFzcwo=