62756 2011-06-15 14:28:49 -0700 Clarify FileChooser creation code. 2011-06-15 17:55:07 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 62069 1 dglazkov dglazkov webkit.review.bot oldest_to_newest 421575 0 dglazkov 2011-06-15 14:28:49 -0700 Clarify FileChooser creation code. 421577 1 97364 dglazkov 2011-06-15 14:31:20 -0700 Created attachment 97364 Patch 421579 2 97364 abarth 2011-06-15 14:32:06 -0700 Comment on attachment 97364 Patch Even I can see that this change is correct. 421606 3 97364 webkit.review.bot 2011-06-15 15:12:04 -0700 Comment on attachment 97364 Patch Clearing flags on attachment: 97364 Committed r88977: <http://trac.webkit.org/changeset/88977> 421607 4 webkit.review.bot 2011-06-15 15:12:08 -0700 All reviewed patches have been landed. Closing bug. 421666 5 97364 ap 2011-06-15 17:45:57 -0700 Comment on attachment 97364 Patch Why not fold it into the constructor? We don't usually do anything besides new+adopt in create() functions. 421671 6 dglazkov 2011-06-15 17:55:07 -0700 (In reply to comment #5) > (From update of attachment 97364 [details]) > Why not fold it into the constructor? We don't usually do anything besides new+adopt in create() functions. loadIcon refs FileChooser and that can be a bad, bad thing. We even ASSERT about it in RefCounted. 97364 2011-06-15 14:31:20 -0700 2011-06-15 17:45:57 -0700 Patch bug-62756-20110615143118.patch text/plain 2321 dglazkov U3VidmVyc2lvbiBSZXZpc2lvbjogODg5NjgKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCA3ZmJiZjMyM2Q2NmZiNGVj YjAyYzFiNWYyYWNkZWY3ODVhODE4YmJlLi5mMTA3Mjc1ZDRkYWVlNWJhYTAyNDJhMzA2OGU2NGQ4 OWNlZmNiOGYxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0yLDYgKzIsMjEgQEAKIAogICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KIAorICAgICAgICBDbGFyaWZ5IEZpbGVDaG9vc2VyIGNyZWF0 aW9uIGNvZGUuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD02Mjc1NgorCisgICAgICAgIGluaXRpYWxpemUoKSBtZXRob2QgaXMgb25seSB1c2VkIG9uY2Ug YW5kIHRoYXQgaXMgbm90IG9idmlvdXMsIHNvIGp1c3QgZm9sZCBpdCBpbnRvIHRoZSBjcmVhdGUg bWV0aG9kLgorCisgICAgICAgIFJlZmFjdG9yaW5nLCBubyBjaGFuZ2UgaW4gYmVoYXZpb3IuCisK KyAgICAgICAgKiBwbGF0Zm9ybS9GaWxlQ2hvb3Nlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpG aWxlQ2hvb3Nlcjo6Y3JlYXRlKTogRm9sZGVkIGluaXRpYWxpemUoKSBjb2RlIHRoZXJlLgorICAg ICAgICAqIHBsYXRmb3JtL0ZpbGVDaG9vc2VyLmg6IFJlbW92ZWQgZGVjbC4KKworMjAxMS0wNi0x NSAgRGltaXRyaSBHbGF6a292ICA8ZGdsYXprb3ZAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCiAgICAgICAgIE1vdmUgRmlsZUNob29zZXI6OmJh c2VuYW1lRm9yV2lkdGggdG8gUmVuZGVyVGhlbWU6OmZpbGVMaXN0TmFtZUZvcldpZHRoLCBlbGlt aW5hdGUgZ25hcmx5IEZpbGVDaG9vc2VyRm9vIHByb2xpZmVyYXRpb24uCiAgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02Mjc0OAogCmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9GaWxlQ2hvb3Nlci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS9GaWxlQ2hvb3Nlci5jcHAKaW5kZXggN2U2ZDRhZWU4ZTAzNTMwYmI4N2VhZTQ0ODky OTk2ZGE1NmE5ZWZiZi4uODgxMzk1ZGM4NDA1MDA1MGZmZWViODU2MzgxOWYzYjM4MzE1NzZiNiAx MDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vRmlsZUNob29zZXIuY3BwCisrKyBi L1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL0ZpbGVDaG9vc2VyLmNwcApAQCAtNDQsMTYgKzQ0LDEx IEBAIGlubGluZSBGaWxlQ2hvb3Nlcjo6RmlsZUNob29zZXIoRmlsZUNob29zZXJDbGllbnQqIGNs aWVudCwgY29uc3QgVmVjdG9yPFN0cmluZz4mCiAgICAgbV9maWxlbmFtZXMgPSBpbml0aWFsRmls ZW5hbWVzOwogfQogCi12b2lkIEZpbGVDaG9vc2VyOjppbml0aWFsaXplKCkKLXsKLSAgICBsb2Fk SWNvbigpOwotICAgIG1faXNJbml0aWFsaXppbmcgPSBmYWxzZTsKLX0KLQogUGFzc1JlZlB0cjxG aWxlQ2hvb3Nlcj4gRmlsZUNob29zZXI6OmNyZWF0ZShGaWxlQ2hvb3NlckNsaWVudCogY2xpZW50 LCBjb25zdCBWZWN0b3I8U3RyaW5nPiYgaW5pdGlhbEZpbGVuYW1lcykKIHsKICAgICBSZWZQdHI8 RmlsZUNob29zZXI+IGNob29zZXIoYWRvcHRSZWYobmV3IEZpbGVDaG9vc2VyKGNsaWVudCwgaW5p dGlhbEZpbGVuYW1lcykpKTsKLSAgICBjaG9vc2VyLT5pbml0aWFsaXplKCk7CisgICAgY2hvb3Nl ci0+bG9hZEljb24oKTsKKyAgICBjaG9vc2VyLT5tX2lzSW5pdGlhbGl6aW5nID0gZmFsc2U7CiAg ICAgcmV0dXJuIGNob29zZXI7CiB9CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL0ZpbGVDaG9vc2VyLmggYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9GaWxlQ2hvb3Nlci5o CmluZGV4IGYwNGM1NTI4ZTI5NWIwODk2NzQ1MGMxOGZlYWJmYmZlZjk2NWRjYTMuLmVkM2I0MzAw YTNlZDMwYmZkYmZmYWQwMTNiMzQxOTFkOWQyNzgyMTkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJD b3JlL3BsYXRmb3JtL0ZpbGVDaG9vc2VyLmgKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v RmlsZUNob29zZXIuaApAQCAtODAsNyArODAsNiBAQCBwdWJsaWM6CiAKIHByaXZhdGU6CiAgICAg RmlsZUNob29zZXIoRmlsZUNob29zZXJDbGllbnQqLCBjb25zdCBWZWN0b3I8U3RyaW5nPiYgaW5p dGlhbEZpbGVuYW1lcyk7Ci0gICAgdm9pZCBpbml0aWFsaXplKCk7CiAgICAgdm9pZCBsb2FkSWNv bigpOwogCiAgICAgRmlsZUNob29zZXJDbGllbnQqIG1fY2xpZW50Owo=