62753 2011-06-15 13:35:01 -0700 new-run-webkit-tests: order shards by name, not number of tests 2011-06-20 18:19:55 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) PC All RESOLVED FIXED P2 Normal --- 58625 1 dpranke dpranke abarth eric ojan tony webkit.review.bot oldest_to_newest 421542 0 dpranke 2011-06-15 13:35:01 -0700 new-run-webkit-tests: order shards by name, not number of tests 421544 1 97356 dpranke 2011-06-15 13:35:40 -0700 Created attachment 97356 Patch 423854 2 dpranke 2011-06-20 12:24:17 -0700 I don't know if we even care about this, but I'll file it just to track things. 423880 3 ojan 2011-06-20 12:52:09 -0700 What's the rationale behind this? Is the theory that tests will be less flaky because we're more likely to run them in the same order as running them serially? I guess since the http tests are by far the gating factor on cycle time, this would only slow down test runs that aren't running the http tests. 423886 4 dpranke 2011-06-20 12:56:29 -0700 See the blocker bug ... I was attempting to ensure that NRWT ran the same tests in the same order as ORWT. In theory, running tests in a different order could reveal inter-test dependencies and cause failures with NRWT that don't occur with ORWT. That said, I don't actually care personally if we do make NRWT match ORWT test-for-test, I just wanted to satisfy to myself that it could and there weren't other bugs (which I did find, and I am now satisfied). I'm happy to close this as WONTFIX, or land it; it doesn't much matter to me. Given that we now shard tests by directory, rather than only top-level directory, there are usually far more shards than workers, and I don't think any ordering matters much for determining the total test run time. 423891 5 97356 ojan 2011-06-20 13:08:07 -0700 Comment on attachment 97356 Patch Seems fine to me. If it ends up reducing flakiness, it's certainly worth it. If it doesn't it's not a big deal. We can try it and look at the before/after cycle time on the chromium bots to make sure it doesn't have a significant impact. 424035 6 97356 webkit.review.bot 2011-06-20 16:05:53 -0700 Comment on attachment 97356 Patch Clearing flags on attachment: 97356 Committed r89302: <http://trac.webkit.org/changeset/89302> 424036 7 webkit.review.bot 2011-06-20 16:05:57 -0700 All reviewed patches have been landed. Closing bug. 424148 8 ojan 2011-06-20 18:19:55 -0700 Looking at http://build.chromium.org/p/chromium.webkit/stats, the doesn't seem to be any cycle time regression on any of the bots. 97356 2011-06-15 13:35:40 -0700 2011-06-20 16:05:53 -0700 Patch bug-62753-20110615133539.patch text/plain 2089 dpranke U3VidmVyc2lvbiBSZXZpc2lvbjogODg2ODUKZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBi L1Rvb2xzL0NoYW5nZUxvZwppbmRleCA3NGQzNDg0ZGUyNDVkZGI4OTMzMzkxODM2OWNiZjg1ZGFh ZGM5Y2M4Li5iMmQxNGIxZTI0N2YzNjU3NThlYjNmOGFmYWQ2MTAzYmViNThhMzA4IDEwMDY0NAot LS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIg QEAKKzIwMTEtMDYtMTUgIERpcmsgUHJhbmtlICA8ZHByYW5rZUBjaHJvbWl1bS5vcmc+CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgbmV3LXJ1bi13ZWJr aXQtdGVzdHM6IG9yZGVyIHNoYXJkcyBieSBuYW1lLCBub3QgbnVtYmVyIG9mIHRlc3RzCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02Mjc1MworCisgICAg ICAgICogU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvbGF5b3V0X3BhY2thZ2UvbWFuYWdl ci5weToKKwogMjAxMS0wNi0xNCAgRGlyayBQcmFua2UgIDxkcHJhbmtlQGNocm9taXVtLm9yZz4K IAogICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KZGlmZiAtLWdpdCBhL1Rvb2xz L1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL2xheW91dF9wYWNrYWdlL21hbmFnZXIucHkg Yi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9sYXlvdXRfcGFja2FnZS9tYW5h Z2VyLnB5CmluZGV4IDg5NzI1NzQxZTlkZjg0YTVkNzYwYzEwNjIwNDhkZmM1NzRhNTkwMTcuLjhl ZjQ1NWZjNzI1ZGFlZjI0YzVjNjMzMjI5NDc5MWVlOTRhNzc1ZTcgMTAwNjQ0Ci0tLSBhL1Rvb2xz L1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL2xheW91dF9wYWNrYWdlL21hbmFnZXIucHkK KysrIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvbGF5b3V0X3BhY2thZ2Uv bWFuYWdlci5weQpAQCAtNTY0LDE2ICs1NjQsMTMgQEAgY2xhc3MgTWFuYWdlcjoKICAgICAgICAg ICAgICAgICBlbHNlOgogICAgICAgICAgICAgICAgICAgICB0ZXN0c19ieV9kaXIuc2V0ZGVmYXVs dChkaXJlY3RvcnksIFtdKQogICAgICAgICAgICAgICAgICAgICB0ZXN0c19ieV9kaXJbZGlyZWN0 b3J5XS5hcHBlbmQodGVzdF9pbnB1dCkKLSAgICAgICAgICAgICMgU29ydCBieSB0aGUgbnVtYmVy IG9mIHRlc3RzIGluIHRoZSBkaXIgc28gdGhhdCB0aGUgb25lcyB3aXRoIHRoZQotICAgICAgICAg ICAgIyBtb3N0IHRlc3RzIGdldCBydW4gZmlyc3QgaW4gb3JkZXIgdG8gbWF4aW1pemUgcGFyYWxs ZWxpemF0aW9uLgotICAgICAgICAgICAgIyBOdW1iZXIgb2YgdGVzdHMgaXMgYSBnb29kIGVub3Vn aCwgYnV0IG5vdCBwZXJmZWN0LCBhcHByb3hpbWF0aW9uCi0gICAgICAgICAgICAjIG9mIGhvdyBs b25nIHRoYXQgc2V0IG9mIHRlc3RzIHdpbGwgdGFrZSB0byBydW4uIFdlIGNhbid0IGp1c3QgdXNl Ci0gICAgICAgICAgICAjIGEgUHJpb3JpdHlRdWV1ZSB1bnRpbCB3ZSBtb3ZlIHRvIFB5dGhvbiAy LjYuCiAgICAgICAgICAgICBmb3IgZGlyZWN0b3J5IGluIHRlc3RzX2J5X2RpcjoKICAgICAgICAg ICAgICAgICB0ZXN0X2xpc3QgPSB0ZXN0c19ieV9kaXJbZGlyZWN0b3J5XQogICAgICAgICAgICAg ICAgIHRlc3RfbGlzdF90dXBsZSA9IChkaXJlY3RvcnksIHRlc3RfbGlzdCkKICAgICAgICAgICAg ICAgICB0ZXN0X2xpc3RzLmFwcGVuZCh0ZXN0X2xpc3RfdHVwbGUpCi0gICAgICAgICAgICB0ZXN0 X2xpc3RzLnNvcnQobGFtYmRhIGEsIGI6IGNtcChsZW4oYlsxXSksIGxlbihhWzFdKSkpCisKKyAg ICAgICAgICAgICMgU29ydCB0aGUgc2hhcmRzIGJ5IGRpcmVjdG9yeSBuYW1lLgorICAgICAgICAg ICAgdGVzdF9saXN0cy5zb3J0KGxhbWJkYSBhLCBiOiBjbXAoYVswXSwgYlswXSkpCiAKICAgICAg ICAgIyBQdXQgdGhlIGh0dHAgdGVzdHMgZmlyc3QuIFRoZXJlIGFyZSBvbmx5IGEgY291cGxlIGh1 bmRyZWQgb2YgdGhlbSwKICAgICAgICAgIyBidXQgZWFjaCBodHRwIHRlc3QgdGFrZXMgYSB2ZXJ5 IGxvbmcgdGltZSB0byBydW4sIHNvIHNvcnRpbmcgYnkgdGhlCg==