62707 2011-06-15 01:43:03 -0700 [CMAKE] Remove platform/graphics/opengl/*OpenGL.cpp files in CMakeLists.txt 2011-09-12 20:01:15 -0700 1 1 1 Unclassified WebKit WebGL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 62695 62709 0 hw1008.kim webkit-unassigned gyuyoung.kim kenneth leandro lucas.de.marchi paroga rakuco ryuan.choi tonikitoo webkit.review.bot oldest_to_newest 421121 0 hw1008.kim 2011-06-15 01:43:03 -0700 Bug 62376 makes all ports use GraphicsContext3DOpenGL, Extensions3DOpenGL when enabling WebGL. However, some ports already have their own GC3D implementation. In QT and chromium, for example, GraphicsContext3D delegates to GraphicsContext3DInternal. So, I think it would be better to allow each port to decide whether or not to include files in platform/graphics/opengl. 421135 1 97261 hw1008.kim 2011-06-15 01:58:49 -0700 Created attachment 97261 Patch 421143 2 ryuan.choi 2011-06-15 02:23:32 -0700 View in context: https://bugs.webkit.org/attachment.cgi?id=97261&action=review > Source/WebCore/ChangeLog:8 > + [EFL] Make accelerated compositing build in Webkit-EFL > + https://bugs.webkit.org/show_bug.cgi?id=62361 > + > + Remove platform/graphics/opengl/*OpenGL.cpp files in CMakeLists.txt. Bug title looks wrong. Please add why you want to remove it in ChangeLog. 421145 3 97263 hw1008.kim 2011-06-15 02:38:32 -0700 Created attachment 97263 Patch 421148 4 hw1008.kim 2011-06-15 02:42:30 -0700 (In reply to comment #2) > View in context: https://bugs.webkit.org/attachment.cgi?id=97261&action=review > > Source/WebCore/ChangeLog:8 > > + [EFL] Make accelerated compositing build in Webkit-EFL > > + https://bugs.webkit.org/show_bug.cgi?id=62361 > > + > > + Remove platform/graphics/opengl/*OpenGL.cpp files in CMakeLists.txt. > Bug title looks wrong. > Please add why you want to remove it in ChangeLog. Sorry, I fixed it. 421149 5 gyuyoung.kim 2011-06-15 02:50:16 -0700 LGTM. lucas, how do you think about this ? Hyowon, If lucas agrees with your patch, It looks below files need to be added to both CMakeListEfl.txt and CMakeListWinCE.txt with ENABLE_WEBGL macro. platform/graphics/opengl/Extensions3DOpenGL.cpp platform/graphics/opengl/GraphicsContext3DOpenGL.cpp 421152 6 ryuan.choi 2011-06-15 03:07:47 -0700 (In reply to comment #5) > LGTM. lucas, how do you think about this ? > > Hyowon, > > If lucas agrees with your patch, It looks below files need to be added to both CMakeListEfl.txt and CMakeListWinCE.txt with ENABLE_WEBGL macro. > > platform/graphics/opengl/Extensions3DOpenGL.cpp > platform/graphics/opengl/GraphicsContext3DOpenGL.cpp I think that WebKit/Efl is no needed if Bug 62709 (and others if required) landed. But I agree that we should check WinCE. I add patrick in CCs. 421153 7 hw1008.kim 2011-06-15 03:09:27 -0700 (In reply to comment #6) > (In reply to comment #5) > > LGTM. lucas, how do you think about this ? > > > > Hyowon, > > > > If lucas agrees with your patch, It looks below files need to be added to both CMakeListEfl.txt and CMakeListWinCE.txt with ENABLE_WEBGL macro. > > > > platform/graphics/opengl/Extensions3DOpenGL.cpp > > platform/graphics/opengl/GraphicsContext3DOpenGL.cpp > I think that WebKit/Efl is no needed if Bug 62709 (and others if required) landed. > But I agree that we should check WinCE. > I add patrick in CCs. To do initial build for WebGL on EFL port, we have to add two files - DrawingBufferEfl.cpp & GraphicsContext3DEfl.cpp. And as gyuyoung mentioned, ENABLE_WEBGL macro should be added in CMakeListEfl.txt. IF (ENABLE_WEBGL) LIST(APPEND WebCore_SOURCES platform/graphics/efl/DrawingBufferEfl.cpp platform/graphics/efl/GraphicsContext3DEfl.cpp ) ENDIF() 421183 8 97263 paroga 2011-06-15 04:24:33 -0700 Comment on attachment 97263 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=97263&action=review (In reply to comment #6) > But I agree that we should check WinCE. WinCE has no ENABLE_WEBGL support at the moment, so you can ignore WinCE without problems. > Source/WebCore/CMakeLists.txt:-2074 > - platform/graphics/opengl/GraphicsContext3DOpenGL.cpp We usually have a empty line between different folders (graphics, graphics/gpu, graphics/opengl). But that more a "problem" of the previous patch. :-( 421225 9 lucas.de.marchi 2011-06-15 06:28:02 -0700 (In reply to comment #7) > To do initial build for WebGL on EFL port, we have to add two files - DrawingBufferEfl.cpp & GraphicsContext3DEfl.cpp. > And as gyuyoung mentioned, ENABLE_WEBGL macro should be added in CMakeListEfl.txt. > > IF (ENABLE_WEBGL) > LIST(APPEND WebCore_SOURCES > platform/graphics/efl/DrawingBufferEfl.cpp > platform/graphics/efl/GraphicsContext3DEfl.cpp > ) > ENDIF() No, you can ignore this part for now. Please, add this to CMakeListsEfl only when EFL has webgl support. 421227 10 lucas.de.marchi 2011-06-15 06:28:58 -0700 (In reply to comment #0) > Bug 62376 makes all ports use GraphicsContext3DOpenGL, Extensions3DOpenGL when enabling WebGL. > However, some ports already have their own GC3D implementation. In QT and chromium, for example, GraphicsContext3D delegates to GraphicsContext3DInternal. So, I think it would be better to allow each port to decide whether or not to include files in platform/graphics/opengl. This explanation should appear in the ChangeLog. Otherwise looks good. 421877 11 97426 hw1008.kim 2011-06-16 02:42:34 -0700 Created attachment 97426 Patch 421880 12 hw1008.kim 2011-06-16 02:50:16 -0700 (In reply to comment #11) > Created an attachment (id=97426) [details] > Patch I updated this patch to reflect Patrick's comment about empty lines & Lucas's one about the changelog. 421940 13 97426 leandro 2011-06-16 07:15:59 -0700 Comment on attachment 97426 Patch OK. 424955 14 gyuyoung.kim 2011-06-21 19:16:22 -0700 LGTM. 465847 15 97426 eric 2011-09-12 15:37:10 -0700 Comment on attachment 97426 Patch rs=me. 466053 16 97426 webkit.review.bot 2011-09-12 20:01:09 -0700 Comment on attachment 97426 Patch Clearing flags on attachment: 97426 Committed r95001: <http://trac.webkit.org/changeset/95001> 466054 17 webkit.review.bot 2011-09-12 20:01:15 -0700 All reviewed patches have been landed. Closing bug. 97261 2011-06-15 01:58:49 -0700 2011-06-15 02:38:24 -0700 Patch bug-62707-20110615175909.patch text/plain 1579 hw1008.kim U3VidmVyc2lvbiBSZXZpc2lvbjogODg5MDUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NN YWtlTGlzdHMudHh0IGIvU291cmNlL1dlYkNvcmUvQ01ha2VMaXN0cy50eHQKaW5kZXggOTY2YTdk Y2IxODZmNDIyOWFhZWFhZDk3Zjg3YTM2MDAxMzA3NzM3ZS4uZDAxOWM5YTRjMGI4NmFlMjdhNjg4 NTAyZjgxMjRiMTBiZWUxMzI4OCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ01ha2VMaXN0 cy50eHQKKysrIGIvU291cmNlL1dlYkNvcmUvQ01ha2VMaXN0cy50eHQKQEAgLTIwMDMsNiArMjAw Myw3IEBAIElGIChFTkFCTEVfV0VCR0wpCiAgICAgICAgICR7VEhJUkRQQVJUWV9ESVJ9L0FOR0xF L3NyYwogICAgICAgICAke1RISVJEUEFSVFlfRElSfS9BTkdMRS9pbmNsdWRlCiAgICAgICAgICR7 VEhJUkRQQVJUWV9ESVJ9L0FOR0xFL2luY2x1ZGUvR0xTTEFORworICAgICAgICBwbGF0Zm9ybS9n cmFwaGljcy9ncHUKICAgICApCiAgICAgTElTVChBUFBFTkQgV2ViQ29yZV9MSUJSQVJJRVMKICAg ICAgICAgJHtPUEVOR0xfZ2xfTElCUkFSWX0KQEAgLTIwNzAsOCArMjA3MSw2IEBAIElGIChFTkFC TEVfV0VCR0wpCiAgICAgICAgIHBsYXRmb3JtL2dyYXBoaWNzL0FOR0xFV2ViS2l0QnJpZGdlLmNw cAogICAgICAgICBwbGF0Zm9ybS9ncmFwaGljcy9ncHUvRHJhd2luZ0J1ZmZlci5jcHAKICAgICAg ICAgcGxhdGZvcm0vZ3JhcGhpY3MvR3JhcGhpY3NDb250ZXh0M0QuY3BwCi0gICAgICAgIHBsYXRm b3JtL2dyYXBoaWNzL29wZW5nbC9FeHRlbnNpb25zM0RPcGVuR0wuY3BwCi0gICAgICAgIHBsYXRm b3JtL2dyYXBoaWNzL29wZW5nbC9HcmFwaGljc0NvbnRleHQzRE9wZW5HTC5jcHAKICAgICApCiBF TkRJRiAoKQogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2Uv V2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMjY5OWZkMGU1ODZhNWNkOWY1MWE0YzkyYmRjM2MwM2M0 NWYyYTVhZi4uNGIxMjI4ZWU5OGYxYzRmNzZmMDQxMmY2NTY5OTFlMDMwMGJlNzVkNiAxMDA2NDQK LS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDExLTA2LTE1ICBIeW93b24gS2ltICA8aHcxMDA4Lmtp bUBzYW1zdW5nLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBbRUZMXSBNYWtlIGFjY2VsZXJhdGVkIGNvbXBvc2l0aW5nIGJ1aWxkIGluIFdlYmtp dC1FRkwKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTYy MzYxCisKKyAgICAgICAgUmVtb3ZlIHBsYXRmb3JtL2dyYXBoaWNzL29wZW5nbC8qT3BlbkdMLmNw cCBmaWxlcyBpbiBDTWFrZUxpc3RzLnR4dC4KKworICAgICAgICAqIENNYWtlTGlzdHMudHh0Ogor CiAyMDExLTA2LTE0ICBEYXZpZCBLaWx6ZXIgIDxkZGtpbHplckBhcHBsZS5jb20+CiAKICAgICAg ICAgPGh0dHA6Ly93ZWJraXQub3JnL2IvNjI2Nzc+IFBhcnQgMi8yOiBSZW1vdmUgZHVwbGljYXRl IGhlYWRlciBlbnRyaWVzIGluIFdlYkNvcmUgcHJvamVjdCBmaWxlCg== 97263 2011-06-15 02:38:32 -0700 2011-06-16 02:42:24 -0700 Patch bug-62707-20110615183853.patch text/plain 1640 hw1008.kim U3VidmVyc2lvbiBSZXZpc2lvbjogODg5MTQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NN YWtlTGlzdHMudHh0IGIvU291cmNlL1dlYkNvcmUvQ01ha2VMaXN0cy50eHQKaW5kZXggOTY2YTdk Y2IxODZmNDIyOWFhZWFhZDk3Zjg3YTM2MDAxMzA3NzM3ZS4uZDAxOWM5YTRjMGI4NmFlMjdhNjg4 NTAyZjgxMjRiMTBiZWUxMzI4OCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ01ha2VMaXN0 cy50eHQKKysrIGIvU291cmNlL1dlYkNvcmUvQ01ha2VMaXN0cy50eHQKQEAgLTIwMDMsNiArMjAw Myw3IEBAIElGIChFTkFCTEVfV0VCR0wpCiAgICAgICAgICR7VEhJUkRQQVJUWV9ESVJ9L0FOR0xF L3NyYwogICAgICAgICAke1RISVJEUEFSVFlfRElSfS9BTkdMRS9pbmNsdWRlCiAgICAgICAgICR7 VEhJUkRQQVJUWV9ESVJ9L0FOR0xFL2luY2x1ZGUvR0xTTEFORworICAgICAgICBwbGF0Zm9ybS9n cmFwaGljcy9ncHUKICAgICApCiAgICAgTElTVChBUFBFTkQgV2ViQ29yZV9MSUJSQVJJRVMKICAg ICAgICAgJHtPUEVOR0xfZ2xfTElCUkFSWX0KQEAgLTIwNzAsOCArMjA3MSw2IEBAIElGIChFTkFC TEVfV0VCR0wpCiAgICAgICAgIHBsYXRmb3JtL2dyYXBoaWNzL0FOR0xFV2ViS2l0QnJpZGdlLmNw cAogICAgICAgICBwbGF0Zm9ybS9ncmFwaGljcy9ncHUvRHJhd2luZ0J1ZmZlci5jcHAKICAgICAg ICAgcGxhdGZvcm0vZ3JhcGhpY3MvR3JhcGhpY3NDb250ZXh0M0QuY3BwCi0gICAgICAgIHBsYXRm b3JtL2dyYXBoaWNzL29wZW5nbC9FeHRlbnNpb25zM0RPcGVuR0wuY3BwCi0gICAgICAgIHBsYXRm b3JtL2dyYXBoaWNzL29wZW5nbC9HcmFwaGljc0NvbnRleHQzRE9wZW5HTC5jcHAKICAgICApCiBF TkRJRiAoKQogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2Uv V2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNjgwYzk5NDEwZDllMThjMWM1NDBiOTFkMGUyNTc2YWU3 MmIwMTI3My4uMjQ3NWIxMGNiYmJjNGU2NWFiNjY3Yjk2ZjczYjIzMDk4NWNjY2ExYiAxMDA2NDQK LS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDExLTA2LTE1ICBIeW93b24gS2ltICA8aHcxMDA4Lmtp bUBzYW1zdW5nLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBbQ01BS0VdIFJlbW92ZSBwbGF0Zm9ybS9ncmFwaGljcy9vcGVuZ2wvKk9wZW5HTC5j cHAgZmlsZXMgaW4gQ01ha2VMaXN0cy50eHQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTYyNzA3CisKKyAgICAgICAgUmVtb3ZlICpPcGVuR0wuY3BwIGZp bGVzIGluIENNYWtlTGlzdHMudHh0IHRvIGFsbG93IGVhY2ggcG9ydCB0byBkZWNpZGUKKyAgICAg ICAgd2hldGhlciBvciBub3QgdG8gdXNlIHRob3NlIGZpbGVzLgorCisgICAgICAgIE5vIGNoYW5n ZSBpbiBmdW5jdGlvbmFsaXR5IHNvIG5vIG5ldyB0ZXN0cy4KKworICAgICAgICAqIENNYWtlTGlz dHMudHh0OgorCiAyMDExLTA2LTE1ICBOaWtvbGFzIFppbW1lcm1hbm4gIDxuemltbWVybWFubkBy aW0uY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERhdmlkIEh5YXR0Lgo= 97426 2011-06-16 02:42:34 -0700 2011-09-12 20:01:09 -0700 Patch bug-62707-20110616184233.patch text/plain 2023 hw1008.kim U3VidmVyc2lvbiBSZXZpc2lvbjogODkwMjEKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NN YWtlTGlzdHMudHh0IGIvU291cmNlL1dlYkNvcmUvQ01ha2VMaXN0cy50eHQKaW5kZXggOTVlOWY3 MTgwNjJlMTc3NDU3Yjc0Y2ZhZTY2NGNmZGExODBjYjUwNC4uZjRkOTdlNzQzNjBkMTk1NDQ2MWYy M2NhYjE2NmJiYmJlYmMxMTY4MSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ01ha2VMaXN0 cy50eHQKKysrIGIvU291cmNlL1dlYkNvcmUvQ01ha2VMaXN0cy50eHQKQEAgLTIwMDMsNiArMjAw Myw3IEBAIElGIChFTkFCTEVfV0VCR0wpCiAgICAgICAgICR7VEhJUkRQQVJUWV9ESVJ9L0FOR0xF L3NyYwogICAgICAgICAke1RISVJEUEFSVFlfRElSfS9BTkdMRS9pbmNsdWRlCiAgICAgICAgICR7 VEhJUkRQQVJUWV9ESVJ9L0FOR0xFL2luY2x1ZGUvR0xTTEFORworICAgICAgICAke1dFQkNPUkVf RElSfS9wbGF0Zm9ybS9ncmFwaGljcy9ncHUKICAgICApCiAgICAgTElTVChBUFBFTkQgV2ViQ29y ZV9MSUJSQVJJRVMKICAgICAgICAgJHtPUEVOR0xfZ2xfTElCUkFSWX0KQEAgLTIwNjgsMTAgKzIw NjksOSBAQCBJRiAoRU5BQkxFX1dFQkdMKQogICAgICAgICBodG1sL2NhbnZhcy9XZWJLaXRMb3Nl Q29udGV4dC5jcHAKIAogICAgICAgICBwbGF0Zm9ybS9ncmFwaGljcy9BTkdMRVdlYktpdEJyaWRn ZS5jcHAKLSAgICAgICAgcGxhdGZvcm0vZ3JhcGhpY3MvZ3B1L0RyYXdpbmdCdWZmZXIuY3BwCiAg ICAgICAgIHBsYXRmb3JtL2dyYXBoaWNzL0dyYXBoaWNzQ29udGV4dDNELmNwcAotICAgICAgICBw bGF0Zm9ybS9ncmFwaGljcy9vcGVuZ2wvRXh0ZW5zaW9uczNET3BlbkdMLmNwcAotICAgICAgICBw bGF0Zm9ybS9ncmFwaGljcy9vcGVuZ2wvR3JhcGhpY3NDb250ZXh0M0RPcGVuR0wuY3BwCisgICAg ICAgIAorICAgICAgICBwbGF0Zm9ybS9ncmFwaGljcy9ncHUvRHJhd2luZ0J1ZmZlci5jcHAKICAg ICApCiBFTkRJRiAoKQogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cgYi9T b3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOTU1Y2IyNjMwMjc3ZDhjYmZmNDMwNWYyZDFi Y2IzZWUwMTdmODhkZC4uMDA4MjU2ZDVhNmIzOGI0YjA1YjRlNDZkZDViZjUxOWNiNmY1MGNhZSAx MDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJDb3Jl L0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDExLTA2LTE2ICBIeW93b24gS2ltICA8aHcx MDA4LmtpbUBzYW1zdW5nLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBbQ01BS0VdIFJlbW92ZSBwbGF0Zm9ybS9ncmFwaGljcy9vcGVuZ2wvKk9w ZW5HTC5jcHAgZmlsZXMgaW4gQ01ha2VMaXN0cy50eHQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTYyNzA3CisKKyAgICAgICAgTm8gY2hhbmdlIGluIGZ1 Y3Rpb25hbGl0eSBzbyBubyBuZXcgdGVzdHMuCisKKyAgICAgICAgQnVnIDYyMzc2IG1ha2VzIGFs bCBwb3J0cyB1c2UgR3JhcGhpY3NDb250ZXh0M0RPcGVuR0wgYW5kCisgICAgICAgIEV4dGVuc2lv bnMzRE9wZW5HTCB3aGVuIGVuYWJsaW5nIFdlYkdMLgorICAgICAgICBIb3dldmVyLCBzb21lIHBv cnRzIGFscmVhZHkgaGF2ZSB0aGVpciBvd24gR0MzRCBpbXBsZW1lbnRhdGlvbi4KKyAgICAgICAg SW4gUVQgYW5kIGNocm9taXVtLCBmb3IgZXhhbXBsZSwgR0MzRCBkZWxlZ2F0ZXMgdG8gR0MzRElu dGVybmFsLgorICAgICAgICBTbywgaXQgd291bGQgYmUgYmV0dGVyIHRvIGFsbG93IGVhY2ggcG9y dCB0byBkZWNpZGUgd2hldGhlciBvciBub3QKKyAgICAgICAgdG8gaW5jbHVkZSBmaWxlcyBpbiBw bGF0Zm9ybS9ncmFwaGljcy9vcGVuZ2wuIAorCisgICAgICAgICogQ01ha2VMaXN0cy50eHQ6CisK IDIwMTEtMDYtMTYgIEhheWF0byBJdG8gIDxoYXlhdG9AY2hyb21pdW0ub3JnPgogCiAgICAgICAg IFJldmlld2VkIGJ5IEhhamltZSBNb3JpdGEuCg==