62692 2011-06-14 20:08:20 -0700 [CMAKE][WK2] include cmakeconfig.h in WebKit2/config.h 2011-09-12 20:29:56 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 61838 0 ryuan.choi webkit-unassigned gyuyoung.kim kenneth leandro lucas.de.marchi rakuco tonikitoo webkit.review.bot oldest_to_newest 420975 0 ryuan.choi 2011-06-14 20:08:20 -0700 Patch will be updated. 421062 1 97241 ryuan.choi 2011-06-14 23:50:05 -0700 Created attachment 97241 Patch 421205 2 rakuco 2011-06-15 05:57:59 -0700 Looks OK to me, informal r+. 421243 3 97241 lucas.de.marchi 2011-06-15 07:08:03 -0700 Comment on attachment 97241 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=97241&action=review > Source/WebKit2/config.h:61 > -#if defined(BUILDING_QT__) || defined(BUILDING_GTK__) > +#if defined(BUILDING_QT__) || defined(BUILDING_GTK__) || defined(BUILDING_WITH_CMAKE) > > #define WTF_USE_JSC 1 > #define WTF_USE_V8 0 This one looks wrong to me. Isn't there any port that might want WTF_USE_V8? Wasn't the EFL port recently adding support to use V8 instead of JSC? 421640 4 ryuan.choi 2011-06-15 16:36:15 -0700 (In reply to comment #3) > (From update of attachment 97241 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=97241&action=review > > > Source/WebKit2/config.h:61 > > -#if defined(BUILDING_QT__) || defined(BUILDING_GTK__) > > +#if defined(BUILDING_QT__) || defined(BUILDING_GTK__) || defined(BUILDING_WITH_CMAKE) > > > > #define WTF_USE_JSC 1 > > #define WTF_USE_V8 0 > > This one looks wrong to me. Isn't there any port that might want WTF_USE_V8? Wasn't the EFL port recently adding support to use V8 instead of JSC? Right, it's not good, but I don't know that webkit2 supports v8 now. But, I'll check once more to find better way. BTW, WebKit/EFL doesn't support to use v8 yet. I am waiting Bug 61350 and need to clean up other local patches because it's too old. :( Thanks. 421774 5 97400 ryuan.choi 2011-06-15 22:27:56 -0700 Created attachment 97400 Patch 421779 6 97402 ryuan.choi 2011-06-15 22:37:00 -0700 Created attachment 97402 Patch 465845 7 97402 eric 2011-09-12 15:36:32 -0700 Comment on attachment 97402 Patch rs=me. 466072 8 97402 webkit.review.bot 2011-09-12 20:29:50 -0700 Comment on attachment 97402 Patch Clearing flags on attachment: 97402 Committed r95005: <http://trac.webkit.org/changeset/95005> 466073 9 webkit.review.bot 2011-09-12 20:29:56 -0700 All reviewed patches have been landed. Closing bug. 97241 2011-06-14 23:50:05 -0700 2011-06-15 22:27:48 -0700 Patch bug-62692-20110615154955.patch text/plain 1355 ryuan.choi U3VidmVyc2lvbiBSZXZpc2lvbjogODg5MDUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwppbmRleCA4NTA2MDhiNDNlOWQzZjA4 YmRlOGZiZmYxNTVjZDQ0MmEwODU2ZjA0Li40Mzc4NzMyZTIwMDEzNDM0MTFlNWQ1YjQ1Y2RmOGIy OTY4OWNlYzNkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTEtMDYtMTQgIFJ5dWFu IENob2kgIDxyeXVhbi5jaG9pQHNhbXN1bmcuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIFtDTUFLRV1bV0syXSBpbmNsdWRlIGNtYWtlY29uZmln LmggaW4gV2ViS2l0Mi9jb25maWcuaAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9NjI2OTIKKworICAgICAgICAqIGNvbmZpZy5oOiBhZGQgY21ha2Vjb25m aWcuaCBhbmQgZGVmaW5lIG5lY2Vzc2FyeSBtYWNyb3MgZm9yIENNYWtlIGJ1aWxkLgorCiAyMDEx LTA2LTE0ICBKb2huIFN1bGxpdmFuICA8c3VsbGl2YW5AYXBwbGUuY29tPgogCiAgICAgICAgIFJl dmlld2VkIGJ5IEFkYSBDaGFuLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvY29uZmlnLmgg Yi9Tb3VyY2UvV2ViS2l0Mi9jb25maWcuaAppbmRleCA1M2Y1NjdlZTNmYTQwNTQxMWY1NzYxYTRl YmZjMTVmYjliODUwMDM1Li4zNTFkMWI5YjFlNzA5MzA4NTZhODE1YTJmODQ2NWI2MDU0YTU3NjFk IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9jb25maWcuaAorKysgYi9Tb3VyY2UvV2ViS2l0 Mi9jb25maWcuaApAQCAtMjgsNiArMjgsMTAgQEAKICNpbmNsdWRlICJhdXRvdG9vbHNjb25maWcu aCIKICNlbmRpZiAvKiBkZWZpbmVkIChCVUlMRElOR19HVEtfXykgKi8KIAorI2lmIGRlZmluZWQg KEJVSUxESU5HX1dJVEhfQ01BS0UpCisjaW5jbHVkZSAiY21ha2Vjb25maWcuaCIKKyNlbmRpZgor CiAjaW5jbHVkZSA8d3RmL0Rpc2FsbG93Q1R5cGUuaD4KICNpbmNsdWRlIDx3dGYvUGxhdGZvcm0u aD4KIApAQCAtNTEsNyArNTUsNyBAQCBzdGF0aWMgY29uc3QgdHlwZSYgbmFtZSgpIFwKICAgICBy ZXR1cm4gbmFtZSMjVmFsdWU7IFwKIH0KIAotI2lmIGRlZmluZWQoQlVJTERJTkdfUVRfXykgfHwg ZGVmaW5lZChCVUlMRElOR19HVEtfXykKKyNpZiBkZWZpbmVkKEJVSUxESU5HX1FUX18pIHx8IGRl ZmluZWQoQlVJTERJTkdfR1RLX18pIHx8IGRlZmluZWQoQlVJTERJTkdfV0lUSF9DTUFLRSkKIAog I2RlZmluZSBXVEZfVVNFX0pTQyAxCiAjZGVmaW5lIFdURl9VU0VfVjggMAo= 97400 2011-06-15 22:27:56 -0700 2011-06-15 22:36:51 -0700 Patch bug-62692-20110616142740.patch text/plain 2144 ryuan.choi U3VidmVyc2lvbiBSZXZpc2lvbjogODg5OTEKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NN YWtlTGlzdHMudHh0IGIvU291cmNlL1dlYktpdDIvQ01ha2VMaXN0cy50eHQKaW5kZXggYmFhYjQ1 NWI5ZDE2MzE0NDMwMGQ5ZGU1MzRiNmRjNzY3NzUzZDA2ZC4uMDdlZGRhN2Q2OTIwZTU3YzRhODU2 NWVlZWU1OTBiNjIxMzY2YjhmMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ01ha2VMaXN0 cy50eHQKKysrIGIvU291cmNlL1dlYktpdDIvQ01ha2VMaXN0cy50eHQKQEAgLTQ0MSw2ICs0NDEs NyBAQCBTRVQoRm9yd2FyZGluZ05ldHdvcmtIZWFkZXJzX05BTUUgKQogSU5DTFVERV9JRl9FWElT VFMoJHtXRUJLSVQyX0RJUn0vQ01ha2VMaXN0cyR7UE9SVH0udHh0KQogCiBBRERfREVGSU5JVElP TlMoLURCVUlMRElOR19XRUJLSVQpCitBRERfREVGSU5JVElPTlMoLURXVEZfVVNFX0pTQykKIElO Q0xVREVfRElSRUNUT1JJRVMoJHtXZWJLaXQyX0lOQ0xVREVfRElSRUNUT1JJRVN9KQogQUREX0xJ QlJBUlkoJHtXZWJLaXQyX0xJQlJBUllfTkFNRX0gJHtXZWJLaXQyX0xJQlJBUllfVFlQRX0gJHtX ZWJLaXQyX1NPVVJDRVN9KQogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cg Yi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggNzcyODM3MmFiZjgwNjg1Njc5MTljMGIw NzAxNDY3NzJhMGExYjgwZC4uNjhlNTk1M2UwNzRhNmU4ZDQ0YThlNGE4NmZiMTI3YWVlN2ZjMTdh ZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJL aXQyL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE1IEBACiAyMDExLTA2LTE1ICBSeXVhbiBDaG9pICA8 cnl1YW4uY2hvaUBzYW1zdW5nLmNvbT4KIAorICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBbQ01BS0VdW1dLMl0gaW5jbHVkZSBjbWFrZWNvbmZpZy5oIGluIFdl YktpdDIvY29uZmlnLmgKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTYyNjkyCisKKyAgICAgICAgKiBDTWFrZUxpc3RzLnR4dDogZGVmaW5lIFdURl9VU0Vf SlNDPTEuCisgICAgICAgICogY29uZmlnLmg6IGFkZCBjbWFrZWNvbmZpZy5oIGFuZCBkZWZpbmUg bmVjZXNzYXJ5IG1hY3JvcyBmb3IgQ01ha2UgYnVpbGQuCisKKzIwMTEtMDYtMTUgIFJ5dWFuIENo b2kgIDxyeXVhbi5jaG9pQHNhbXN1bmcuY29tPgorCiAgICAgICAgIFJ1YmJlciBzdGFtcGVkIGJ5 IEVyaWMgU2VpZGVsLgogCiAgICAgICAgIFtDTUFLRV1bV0syXSBBZGQgYW4gb3B0aW9uIHRvIGJ1 aWxkIHdlYmtpdDIuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9jb25maWcuaCBiL1NvdXJj ZS9XZWJLaXQyL2NvbmZpZy5oCmluZGV4IDUzZjU2N2VlM2ZhNDA1NDExZjU3NjFhNGViZmMxNWZi OWI4NTAwMzUuLjYxM2FkYzA0MDNlZTZlMTM2YThlNmQ1OGU0YTI4ZjY5YTExNDMxYjUgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL2NvbmZpZy5oCisrKyBiL1NvdXJjZS9XZWJLaXQyL2NvbmZp Zy5oCkBAIC0yOCw2ICsyOCwxMCBAQAogI2luY2x1ZGUgImF1dG90b29sc2NvbmZpZy5oIgogI2Vu ZGlmIC8qIGRlZmluZWQgKEJVSUxESU5HX0dUS19fKSAqLwogCisjaWYgZGVmaW5lZCAoQlVJTERJ TkdfV0lUSF9DTUFLRSkKKyNpbmNsdWRlICJjbWFrZWNvbmZpZy5oIgorI2VuZGlmCisKICNpbmNs dWRlIDx3dGYvRGlzYWxsb3dDVHlwZS5oPgogI2luY2x1ZGUgPHd0Zi9QbGF0Zm9ybS5oPgogCkBA IC01MSw3ICs1NSwxNCBAQCBzdGF0aWMgY29uc3QgdHlwZSYgbmFtZSgpIFwKICAgICByZXR1cm4g bmFtZSMjVmFsdWU7IFwKIH0KIAotI2lmIGRlZmluZWQoQlVJTERJTkdfUVRfXykgfHwgZGVmaW5l ZChCVUlMRElOR19HVEtfXykKKyNpZiBkZWZpbmVkIChCVUlMRElOR19XSVRIX0NNQUtFKQorCisj ZGVmaW5lIEpTX0VYUE9SVERBVEEKKyNkZWZpbmUgSlNfRVhQT1JUQ0xBU1MKKyNkZWZpbmUgV1RG X0VYUE9SVF9QUklWQVRFCisjZGVmaW5lIEpTX0VYUE9SVF9QUklWQVRFCisKKyNlbGlmIGRlZmlu ZWQoQlVJTERJTkdfUVRfXykgfHwgZGVmaW5lZChCVUlMRElOR19HVEtfXykKIAogI2RlZmluZSBX VEZfVVNFX0pTQyAxCiAjZGVmaW5lIFdURl9VU0VfVjggMAo= 97402 2011-06-15 22:37:00 -0700 2011-09-12 20:29:50 -0700 Patch bug-62692-20110616143644.patch text/plain 2079 ryuan.choi U3VidmVyc2lvbiBSZXZpc2lvbjogODkwMDYKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NN YWtlTGlzdHMudHh0IGIvU291cmNlL1dlYktpdDIvQ01ha2VMaXN0cy50eHQKaW5kZXggYmFhYjQ1 NWI5ZDE2MzE0NDMwMGQ5ZGU1MzRiNmRjNzY3NzUzZDA2ZC4uYjVkNGNkMDM5ZTUzOGYzNDZjNzlk YWNiZDE2MmU1YjZmNzljYTNlOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ01ha2VMaXN0 cy50eHQKKysrIGIvU291cmNlL1dlYktpdDIvQ01ha2VMaXN0cy50eHQKQEAgLTQ0MSw2ICs0NDEs NyBAQCBTRVQoRm9yd2FyZGluZ05ldHdvcmtIZWFkZXJzX05BTUUgKQogSU5DTFVERV9JRl9FWElT VFMoJHtXRUJLSVQyX0RJUn0vQ01ha2VMaXN0cyR7UE9SVH0udHh0KQogCiBBRERfREVGSU5JVElP TlMoLURCVUlMRElOR19XRUJLSVQpCitBRERfREVGSU5JVElPTlMoLURXVEZfVVNFX0pTQz0xKQog SU5DTFVERV9ESVJFQ1RPUklFUygke1dlYktpdDJfSU5DTFVERV9ESVJFQ1RPUklFU30pCiBBRERf TElCUkFSWSgke1dlYktpdDJfTElCUkFSWV9OQU1FfSAke1dlYktpdDJfTElCUkFSWV9UWVBFfSAk e1dlYktpdDJfU09VUkNFU30pCiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxv ZyBiL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwppbmRleCBkYWUxZjUyYWNjYjYxNTFmYTQyNGMy Mzc2ZjA2ODg3YjU3YjI1NzA3Li5hYmQ1NmU0Yzg1OGY0NzY5YTVhY2U3MjA2ZmI4YjBiYjBkNTA4 YTQ1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dl YktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTEtMDYtMTUgIFJ5dWFuIENob2kg IDxyeXVhbi5jaG9pQHNhbXN1bmcuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIFtDTUFLRV1bV0syXSBpbmNsdWRlIGNtYWtlY29uZmlnLmggaW4g V2ViS2l0Mi9jb25maWcuaAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9NjI2OTIKKworICAgICAgICAqIENNYWtlTGlzdHMudHh0OiBkZWZpbmUgV1RGX1VT RV9KU0M9MS4KKyAgICAgICAgKiBjb25maWcuaDogYWRkIGNtYWtlY29uZmlnLmggYW5kIGRlZmlu ZSBuZWNlc3NhcnkgbWFjcm9zIGZvciBDTWFrZSBidWlsZC4KKwogMjAxMS0wNi0xNSAgQWRhbSBC YXJ0aCAgPGFiYXJ0aEB3ZWJraXQub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEVyaWMgU2Vp ZGVsLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvY29uZmlnLmggYi9Tb3VyY2UvV2ViS2l0 Mi9jb25maWcuaAppbmRleCA1M2Y1NjdlZTNmYTQwNTQxMWY1NzYxYTRlYmZjMTVmYjliODUwMDM1 Li42MTNhZGMwNDAzZWU2ZTEzNmE4ZTZkNThlNGEyOGY2OWExMTQzMWI1IDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViS2l0Mi9jb25maWcuaAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9jb25maWcuaApAQCAt MjgsNiArMjgsMTAgQEAKICNpbmNsdWRlICJhdXRvdG9vbHNjb25maWcuaCIKICNlbmRpZiAvKiBk ZWZpbmVkIChCVUlMRElOR19HVEtfXykgKi8KIAorI2lmIGRlZmluZWQgKEJVSUxESU5HX1dJVEhf Q01BS0UpCisjaW5jbHVkZSAiY21ha2Vjb25maWcuaCIKKyNlbmRpZgorCiAjaW5jbHVkZSA8d3Rm L0Rpc2FsbG93Q1R5cGUuaD4KICNpbmNsdWRlIDx3dGYvUGxhdGZvcm0uaD4KIApAQCAtNTEsNyAr NTUsMTQgQEAgc3RhdGljIGNvbnN0IHR5cGUmIG5hbWUoKSBcCiAgICAgcmV0dXJuIG5hbWUjI1Zh bHVlOyBcCiB9CiAKLSNpZiBkZWZpbmVkKEJVSUxESU5HX1FUX18pIHx8IGRlZmluZWQoQlVJTERJ TkdfR1RLX18pCisjaWYgZGVmaW5lZCAoQlVJTERJTkdfV0lUSF9DTUFLRSkKKworI2RlZmluZSBK U19FWFBPUlREQVRBCisjZGVmaW5lIEpTX0VYUE9SVENMQVNTCisjZGVmaW5lIFdURl9FWFBPUlRf UFJJVkFURQorI2RlZmluZSBKU19FWFBPUlRfUFJJVkFURQorCisjZWxpZiBkZWZpbmVkKEJVSUxE SU5HX1FUX18pIHx8IGRlZmluZWQoQlVJTERJTkdfR1RLX18pCiAKICNkZWZpbmUgV1RGX1VTRV9K U0MgMQogI2RlZmluZSBXVEZfVVNFX1Y4IDAK