62587 2011-06-13 12:33:29 -0700 [Texmap] [Qt] [WK2] Unsync in TextureMapperNode between parent and child lists cause crashes on WK2. 2011-07-18 10:05:06 -0700 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 47068 1 ostap73 webkit-unassigned noam webkit.review.bot oldest_to_newest 419777 0 ostap73 2011-06-13 12:33:29 -0700 In TextureMapperNode::syncCompositingStateSelf in ParentChange "if" statement m_parent gets overwritten 1st and node gets removed from new m_parent child list and never added. In ChildrenChange m_children list gets cleared, but m_parent members of child nodes are not cleared. This cause unsync in m_children <-> m_parent linkage and random crashes mostly ~TextureMapperNode(), but also in other places when already deallocated node gets referenced because it wasn't removed from child list. 419781 1 96991 ostap73 2011-06-13 12:49:07 -0700 Created attachment 96991 Fix parent/children unsync in TextureMapperNode. 438185 2 96991 noam 2011-07-16 15:02:50 -0700 Comment on attachment 96991 Fix parent/children unsync in TextureMapperNode. View in context: https://bugs.webkit.org/attachment.cgi?id=96991&action=review > Source/WebCore/ChangeLog:10 > + Unofficially reviewed by Noam Rosenthal (module author). This is now an official review, so please remove this line before committing. 438327 3 101122 ostap73 2011-07-17 21:04:20 -0700 Created attachment 101122 Updated Changelog by Noams request. 438536 4 101122 webkit.review.bot 2011-07-18 10:05:02 -0700 Comment on attachment 101122 Updated Changelog by Noams request. Clearing flags on attachment: 101122 Committed r91192: <http://trac.webkit.org/changeset/91192> 438537 5 webkit.review.bot 2011-07-18 10:05:06 -0700 All reviewed patches have been landed. Closing bug. 96991 2011-06-13 12:49:07 -0700 2011-07-17 21:04:20 -0700 Fix parent/children unsync in TextureMapperNode. TextureMapperNode_parent_child_sync_01.diff text/plain 2643 ostap73 ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA4MzJmM2E0Li5hN2MyY2NjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcg QEAKKzIwMTEtMDYtMTMgIFZpYXRjaGVzbGF2IE9zdGFwZW5rbyAgPG9zdGFwZW5rby52aWF0Y2hl c2xhdkBub2tpYS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgW1RleG1hcF0gW1F0XSBbV0syXSBVbnN5bmMgaW4gVGV4dHVyZU1hcHBlck5vZGUg YmV0d2VlbiBwYXJlbnQgYW5kIGNoaWxkIGxpc3RzIGNhdXNlIGNyYXNoZXMgb24gV0syLgorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjI1ODcKKworICAg ICAgICBGaXggdW5zeW5jIGJldHdlZW4gbV9wYXJlbnQgYW5kIG1fY2hpbGRyZW4gbGlzdCBpbiBj aGlsZCBhbmQgcGFyZW50IHRleHR1cmUgbWFwcGVyIG5vZGVzIAorICAgICAgICBpbiBzeW5jQ29t cG9zaXRpbmdTdGF0ZVNlbGYuCisgICAgICAgIFVub2ZmaWNpYWxseSByZXZpZXdlZCBieSBOb2Ft IFJvc2VudGhhbCAobW9kdWxlIGF1dGhvcikuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGlj cy90ZXhtYXAvVGV4dHVyZU1hcHBlck5vZGUuY3BwOgorICAgICAgICAoV2ViQ29yZTo6VGV4dHVy ZU1hcHBlck5vZGU6OnN5bmNDb21wb3NpdGluZ1N0YXRlU2VsZik6CisKIDIwMTEtMDYtMTMgIEFk YW0gQmFydGggIDxhYmFydGhAd2Via2l0Lm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBEYXJp biBBZGxlci4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3Rl eG1hcC9UZXh0dXJlTWFwcGVyTm9kZS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFw aGljcy90ZXhtYXAvVGV4dHVyZU1hcHBlck5vZGUuY3BwCmluZGV4IDM4ODhlMjkuLmIzNzBmNDgg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3RleG1hcC9UZXh0 dXJlTWFwcGVyTm9kZS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mv dGV4bWFwL1RleHR1cmVNYXBwZXJOb2RlLmNwcApAQCAtNTg1LDE1ICs1ODUsMjcgQEAgdm9pZCBU ZXh0dXJlTWFwcGVyTm9kZTo6c3luY0NvbXBvc2l0aW5nU3RhdGVTZWxmKEdyYXBoaWNzTGF5ZXJU ZXh0dXJlTWFwcGVyKiBncmEKICAgICAgICAgcmV0dXJuOwogCiAgICAgaWYgKG1fY3VycmVudENv bnRlbnQuY29udGVudFR5cGUgPT0gSFRNTENvbnRlbnRUeXBlICYmIChjaGFuZ2VNYXNrICYgUGFy ZW50Q2hhbmdlKSkgewotICAgICAgICBtX3BhcmVudCA9IHRvVGV4dHVyZU1hcHBlck5vZGUoZ3Jh cGhpY3NMYXllci0+cGFyZW50KCkpOwotCi0gICAgICAgIGlmICghZ3JhcGhpY3NMYXllci0+cGFy ZW50KCkgJiYgbV9wYXJlbnQpIHsKLSAgICAgICAgICAgIHNpemVfdCBpbmRleCA9IG1fcGFyZW50 LT5tX2NoaWxkcmVuLmZpbmQodGhpcyk7Ci0gICAgICAgICAgICBtX3BhcmVudC0+bV9jaGlsZHJl bi5yZW1vdmUoaW5kZXgpOworICAgICAgICBUZXh0dXJlTWFwcGVyTm9kZSogbmV3UGFyZW50ID0g dG9UZXh0dXJlTWFwcGVyTm9kZShncmFwaGljc0xheWVyLT5wYXJlbnQoKSk7CisgICAgICAgIGlm IChuZXdQYXJlbnQgIT0gbV9wYXJlbnQpIHsKKyAgICAgICAgICAgIC8vIFJlbW92ZSBub2RlIGZy b20gY3VycmVudCBmcm9tIGNoaWxkIGxpc3QgZmlyc3QuCisgICAgICAgICAgICBpZiAobV9wYXJl bnQpIHsKKyAgICAgICAgICAgICAgICBzaXplX3QgaW5kZXggPSBtX3BhcmVudC0+bV9jaGlsZHJl bi5maW5kKHRoaXMpOworICAgICAgICAgICAgICAgIG1fcGFyZW50LT5tX2NoaWxkcmVuLnJlbW92 ZShpbmRleCk7CisgICAgICAgICAgICAgICAgbV9wYXJlbnQgPSAwOworICAgICAgICAgICAgfQor ICAgICAgICAgICAgLy8gU2V0IG5ldyBub2RlIHBhcmVudCBhbmQgYWRkIG5vZGUgdG8gdGhlIHBh cmVudHMgY2hpbGQgbGlzdC4KKyAgICAgICAgICAgIGlmIChuZXdQYXJlbnQpIHsKKyAgICAgICAg ICAgICAgICBtX3BhcmVudCA9IG5ld1BhcmVudDsKKyAgICAgICAgICAgICAgICBtX3BhcmVudC0+ bV9jaGlsZHJlbi5hcHBlbmQodGhpcyk7CisgICAgICAgICAgICB9CiAgICAgICAgIH0KICAgICB9 CiAKICAgICBpZiAoY2hhbmdlTWFzayAmIENoaWxkcmVuQ2hhbmdlKSB7CisgICAgICAgIC8vIENs ZWFyIGNoaWxkcmVuIHBhcmVudCBwb2ludGVyIHRvIGF2b2lkIHVuc3luYyBhbmQgY3Jhc2ggb24g bm9kZSBkZWxldGUuCisgICAgICAgIGZvciAoc2l6ZV90IGkgPSAwOyBpIDwgbV9jaGlsZHJlbi5z aXplKCk7IGkrKykKKyAgICAgICAgICAgIG1fY2hpbGRyZW5baV0tPm1fcGFyZW50ID0gMDsKKwog ICAgICAgICBtX2NoaWxkcmVuLmNsZWFyKCk7CiAgICAgICAgIGZvciAoc2l6ZV90IGkgPSAwOyBp IDwgZ3JhcGhpY3NMYXllci0+Y2hpbGRyZW4oKS5zaXplKCk7ICsraSkgewogICAgICAgICAgICAg VGV4dHVyZU1hcHBlck5vZGUqIGNoaWxkID0gdG9UZXh0dXJlTWFwcGVyTm9kZShncmFwaGljc0xh eWVyLT5jaGlsZHJlbigpW2ldKTsK 101122 2011-07-17 21:04:20 -0700 2011-07-18 10:05:02 -0700 Updated Changelog by Noams request. ac_unsync_01.diff text/plain 2651 ostap73 ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCAzNzEwMDllLi41NjNhOGU3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYg QEAKKzIwMTEtMDctMTcgIFZpYXRjaGVzbGF2IE9zdGFwZW5rbyAgPG9zdGFwZW5rby52aWF0Y2hl c2xhdkBub2tpYS5jb20+CisKKyAgICAgICAgW1RleG1hcF0gW1F0XSBbV0syXSBVbnN5bmMgaW4g VGV4dHVyZU1hcHBlck5vZGUgYmV0d2VlbiBwYXJlbnQgYW5kIGNoaWxkIGxpc3RzIGNhdXNlIGNy YXNoZXMgb24gV0syLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9NjI1ODcKKworICAgICAgICBSZXZpZXdlZCBieSBOb2FtIFJvc2VudGhhbC4KKworICAg ICAgICBGaXggdW5zeW5jIGJldHdlZW4gbV9wYXJlbnQgYW5kIG1fY2hpbGRyZW4gbGlzdCBpbiBj aGlsZCBhbmQgcGFyZW50IHRleHR1cmUgbWFwcGVyIG5vZGVzIAorICAgICAgICBpbiBzeW5jQ29t cG9zaXRpbmdTdGF0ZVNlbGYuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy90ZXhtYXAv VGV4dHVyZU1hcHBlck5vZGUuY3BwOgorICAgICAgICAoV2ViQ29yZTo6VGV4dHVyZU1hcHBlck5v ZGU6OnN5bmNDb21wb3NpdGluZ1N0YXRlU2VsZik6CisKIDIwMTEtMDctMTYgIFNpbW9uIEZyYXNl ciAgPHNpbW9uLmZyYXNlckBhcHBsZS5jb20+CiAKICAgICAgICAgQWRkIGNvZGUgdG8gYXR0ZW1w dCB0byBhbGlnbiBjb21wb3NpdGluZyBsYXllcnMgdG8gcGl4ZWwgYm91bmRhcmllcyB3aGVuIHBh Z2Ugc2NhbGUgY2hhbmdlcwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3Jh cGhpY3MvdGV4bWFwL1RleHR1cmVNYXBwZXJOb2RlLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL2dyYXBoaWNzL3RleG1hcC9UZXh0dXJlTWFwcGVyTm9kZS5jcHAKaW5kZXggMzg4OGUyOS4u YjM3MGY0OCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvdGV4 bWFwL1RleHR1cmVNYXBwZXJOb2RlLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9n cmFwaGljcy90ZXhtYXAvVGV4dHVyZU1hcHBlck5vZGUuY3BwCkBAIC01ODUsMTUgKzU4NSwyNyBA QCB2b2lkIFRleHR1cmVNYXBwZXJOb2RlOjpzeW5jQ29tcG9zaXRpbmdTdGF0ZVNlbGYoR3JhcGhp Y3NMYXllclRleHR1cmVNYXBwZXIqIGdyYQogICAgICAgICByZXR1cm47CiAKICAgICBpZiAobV9j dXJyZW50Q29udGVudC5jb250ZW50VHlwZSA9PSBIVE1MQ29udGVudFR5cGUgJiYgKGNoYW5nZU1h c2sgJiBQYXJlbnRDaGFuZ2UpKSB7Ci0gICAgICAgIG1fcGFyZW50ID0gdG9UZXh0dXJlTWFwcGVy Tm9kZShncmFwaGljc0xheWVyLT5wYXJlbnQoKSk7Ci0KLSAgICAgICAgaWYgKCFncmFwaGljc0xh eWVyLT5wYXJlbnQoKSAmJiBtX3BhcmVudCkgewotICAgICAgICAgICAgc2l6ZV90IGluZGV4ID0g bV9wYXJlbnQtPm1fY2hpbGRyZW4uZmluZCh0aGlzKTsKLSAgICAgICAgICAgIG1fcGFyZW50LT5t X2NoaWxkcmVuLnJlbW92ZShpbmRleCk7CisgICAgICAgIFRleHR1cmVNYXBwZXJOb2RlKiBuZXdQ YXJlbnQgPSB0b1RleHR1cmVNYXBwZXJOb2RlKGdyYXBoaWNzTGF5ZXItPnBhcmVudCgpKTsKKyAg ICAgICAgaWYgKG5ld1BhcmVudCAhPSBtX3BhcmVudCkgeworICAgICAgICAgICAgLy8gUmVtb3Zl IG5vZGUgZnJvbSBjdXJyZW50IGZyb20gY2hpbGQgbGlzdCBmaXJzdC4KKyAgICAgICAgICAgIGlm IChtX3BhcmVudCkgeworICAgICAgICAgICAgICAgIHNpemVfdCBpbmRleCA9IG1fcGFyZW50LT5t X2NoaWxkcmVuLmZpbmQodGhpcyk7CisgICAgICAgICAgICAgICAgbV9wYXJlbnQtPm1fY2hpbGRy ZW4ucmVtb3ZlKGluZGV4KTsKKyAgICAgICAgICAgICAgICBtX3BhcmVudCA9IDA7CisgICAgICAg ICAgICB9CisgICAgICAgICAgICAvLyBTZXQgbmV3IG5vZGUgcGFyZW50IGFuZCBhZGQgbm9kZSB0 byB0aGUgcGFyZW50cyBjaGlsZCBsaXN0LgorICAgICAgICAgICAgaWYgKG5ld1BhcmVudCkgewor ICAgICAgICAgICAgICAgIG1fcGFyZW50ID0gbmV3UGFyZW50OworICAgICAgICAgICAgICAgIG1f cGFyZW50LT5tX2NoaWxkcmVuLmFwcGVuZCh0aGlzKTsKKyAgICAgICAgICAgIH0KICAgICAgICAg fQogICAgIH0KIAogICAgIGlmIChjaGFuZ2VNYXNrICYgQ2hpbGRyZW5DaGFuZ2UpIHsKKyAgICAg ICAgLy8gQ2xlYXIgY2hpbGRyZW4gcGFyZW50IHBvaW50ZXIgdG8gYXZvaWQgdW5zeW5jIGFuZCBj cmFzaCBvbiBub2RlIGRlbGV0ZS4KKyAgICAgICAgZm9yIChzaXplX3QgaSA9IDA7IGkgPCBtX2No aWxkcmVuLnNpemUoKTsgaSsrKQorICAgICAgICAgICAgbV9jaGlsZHJlbltpXS0+bV9wYXJlbnQg PSAwOworCiAgICAgICAgIG1fY2hpbGRyZW4uY2xlYXIoKTsKICAgICAgICAgZm9yIChzaXplX3Qg aSA9IDA7IGkgPCBncmFwaGljc0xheWVyLT5jaGlsZHJlbigpLnNpemUoKTsgKytpKSB7CiAgICAg ICAgICAgICBUZXh0dXJlTWFwcGVyTm9kZSogY2hpbGQgPSB0b1RleHR1cmVNYXBwZXJOb2RlKGdy YXBoaWNzTGF5ZXItPmNoaWxkcmVuKClbaV0pOwo=