62523 2011-06-12 19:55:29 -0700 [EFL][WK2] Add initial WebContextEfl.cpp for webkit2 efl port 2011-06-13 14:52:00 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 61838 0 enmi.lee webkit-unassigned antognolli+webkit gyuyoung.kim kenneth leandro lucas.de.marchi rakuco ryuan.choi sangseok.lim tonikitoo webkit.review.bot youngtaeck.song oldest_to_newest 419397 0 enmi.lee 2011-06-12 19:55:29 -0700 This class's functions are not implemented yet, but it is needed to prevent build error. 419398 1 96910 enmi.lee 2011-06-12 19:58:20 -0700 Created attachment 96910 Patch 419434 2 gyuyoung.kim 2011-06-12 22:32:08 -0700 LGTM. 419523 3 rakuco 2011-06-13 06:14:32 -0700 Looks OK after correcting the following nitpicks. > Source/WebKit2/UIProcess/efl/WebContextEfl.cpp:52 > + return ""; I'd rather return a String() directly here. > Source/WebKit2/UIProcess/efl/WebContextEfl.cpp:58 > + return ""; Ditto. > Source/WebKit2/UIProcess/efl/WebContextEfl.cpp:64 > + return ""; Ditto. 419887 4 96910 eric 2011-06-13 14:43:51 -0700 Comment on attachment 96910 Patch OK. 419894 5 96910 webkit.review.bot 2011-06-13 14:51:55 -0700 Comment on attachment 96910 Patch Clearing flags on attachment: 96910 Committed r88701: <http://trac.webkit.org/changeset/88701> 419895 6 webkit.review.bot 2011-06-13 14:52:00 -0700 All reviewed patches have been landed. Closing bug. 96910 2011-06-12 19:58:20 -0700 2011-06-13 14:51:55 -0700 Patch bug-62523-20110613115806.patch text/plain 3466 enmi.lee U3VidmVyc2lvbiBSZXZpc2lvbjogODg2MjQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwppbmRleCBlNzU5NTQ4YzU3YzM2NjEw N2QxOWY1OTgwN2E4NWRlNzYxOTE3OThlLi40MWEzMWZkMTcxN2QyMWI3YThhOGQ0NTBmYTljZjkx ZGRjOTJmMWJhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTggQEAKKzIwMTEtMDYtMTIgIEV1bm1p IExlZSAgPGV1bm1pMTUubGVlQHNhbXN1bmcuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIFtFRkxdW1dLMl0gQWRkIGluaXRpYWwgV2ViQ29udGV4 dEVmbC5jcHAgZm9yIHdlYmtpdDIgZWZsIHBvcnQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTYyNTIzCisKKyAgICAgICAgKiBVSVByb2Nlc3MvZWZsL1dl YkNvbnRleHRFZmwuY3BwOiBBZGRlZC4KKyAgICAgICAgKFdlYktpdDo6V2ViQ29udGV4dDo6YXBw bGljYXRpb25DYWNoZURpcmVjdG9yeSk6CisgICAgICAgIChXZWJLaXQ6OldlYkNvbnRleHQ6OnBs YXRmb3JtSW5pdGlhbGl6ZVdlYlByb2Nlc3MpOgorICAgICAgICAoV2ViS2l0OjpXZWJDb250ZXh0 OjpwbGF0Zm9ybUludmFsaWRhdGVDb250ZXh0KToKKyAgICAgICAgKFdlYktpdDo6V2ViQ29udGV4 dDo6cGxhdGZvcm1EZWZhdWx0RGF0YWJhc2VEaXJlY3RvcnkpOgorICAgICAgICAoV2ViS2l0OjpX ZWJDb250ZXh0OjpwbGF0Zm9ybURlZmF1bHRJY29uRGF0YWJhc2VQYXRoKToKKyAgICAgICAgKFdl YktpdDo6V2ViQ29udGV4dDo6cGxhdGZvcm1EZWZhdWx0TG9jYWxTdG9yYWdlRGlyZWN0b3J5KToK KwogMjAxMS0wNi0xMiAgQWRhbSBCYXJ0aCAgPGFiYXJ0aEB3ZWJraXQub3JnPgogCiAgICAgICAg IFJldmlld2VkIGJ5IEVyaWMgU2VpZGVsLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQ cm9jZXNzL2VmbC9XZWJDb250ZXh0RWZsLmNwcCBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9l ZmwvV2ViQ29udGV4dEVmbC5jcHAKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uYWM3N2VmM2YyYTE0YTMwZGFkZmZjZTkw M2UwNWRkM2U5YmUwODc5NgotLS0gL2Rldi9udWxsCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJv Y2Vzcy9lZmwvV2ViQ29udGV4dEVmbC5jcHAKQEAgLTAsMCArMSw2NyBAQAorLyoKKyAqIENvcHly aWdodCAoQykgMjAxMSBTYW1zdW5nIEVsZWN0cm9uaWNzCisgKgorICogUmVkaXN0cmlidXRpb24g YW5kIHVzZSBpbiBzb3VyY2UgYW5kIGJpbmFyeSBmb3Jtcywgd2l0aCBvciB3aXRob3V0CisgKiBt b2RpZmljYXRpb24sIGFyZSBwZXJtaXR0ZWQgcHJvdmlkZWQgdGhhdCB0aGUgZm9sbG93aW5nIGNv bmRpdGlvbnMKKyAqIGFyZSBtZXQ6CisgKiAxLiBSZWRpc3RyaWJ1dGlvbnMgb2Ygc291cmNlIGNv ZGUgbXVzdCByZXRhaW4gdGhlIGFib3ZlIGNvcHlyaWdodAorICogICAgbm90aWNlLCB0aGlzIGxp c3Qgb2YgY29uZGl0aW9ucyBhbmQgdGhlIGZvbGxvd2luZyBkaXNjbGFpbWVyLgorICogMi4gUmVk aXN0cmlidXRpb25zIGluIGJpbmFyeSBmb3JtIG11c3QgcmVwcm9kdWNlIHRoZSBhYm92ZSBjb3B5 cmlnaHQKKyAqICAgIG5vdGljZSwgdGhpcyBsaXN0IG9mIGNvbmRpdGlvbnMgYW5kIHRoZSBmb2xs b3dpbmcgZGlzY2xhaW1lciBpbiB0aGUKKyAqICAgIGRvY3VtZW50YXRpb24gYW5kL29yIG90aGVy IG1hdGVyaWFscyBwcm92aWRlZCB3aXRoIHRoZSBkaXN0cmlidXRpb24uCisgKgorICogVEhJUyBT T0ZUV0FSRSBJUyBQUk9WSURFRCBCWSBBUFBMRSBJTkMuIEFORCBJVFMgQ09OVFJJQlVUT1JTIEFT IElTJycKKyAqIEFORCBBTlkgRVhQUkVTUyBPUiBJTVBMSUVEIFdBUlJBTlRJRVMsIElOQ0xVRElO RywgQlVUIE5PVCBMSU1JVEVEIFRPLAorICogVEhFIElNUExJRUQgV0FSUkFOVElFUyBPRiBNRVJD SEFOVEFCSUxJVFkgQU5EIEZJVE5FU1MgRk9SIEEgUEFSVElDVUxBUgorICogUFVSUE9TRSBBUkUg RElTQ0xBSU1FRC4gSU4gTk8gRVZFTlQgU0hBTEwgQVBQTEUgSU5DLiBPUiBJVFMgQ09OVFJJQlVU T1JTCisgKiBCRSBMSUFCTEUgRk9SIEFOWSBESVJFQ1QsIElORElSRUNULCBJTkNJREVOVEFMLCBT UEVDSUFMLCBFWEVNUExBUlksIE9SCisgKiBDT05TRVFVRU5USUFMIERBTUFHRVMgKElOQ0xVRElO RywgQlVUIE5PVCBMSU1JVEVEIFRPLCBQUk9DVVJFTUVOVCBPRgorICogU1VCU1RJVFVURSBHT09E UyBPUiBTRVJWSUNFUzsgTE9TUyBPRiBVU0UsIERBVEEsIE9SIFBST0ZJVFM7IE9SIEJVU0lORVNT CisgKiBJTlRFUlJVUFRJT04pIEhPV0VWRVIgQ0FVU0VEIEFORCBPTiBBTlkgVEhFT1JZIE9GIExJ QUJJTElUWSwgV0hFVEhFUiBJTgorICogQ09OVFJBQ1QsIFNUUklDVCBMSUFCSUxJVFksIE9SIFRP UlQgKElOQ0xVRElORyBORUdMSUdFTkNFIE9SIE9USEVSV0lTRSkKKyAqIEFSSVNJTkcgSU4gQU5Z IFdBWSBPVVQgT0YgVEhFIFVTRSBPRiBUSElTIFNPRlRXQVJFLCBFVkVOIElGIEFEVklTRUQgT0YK KyAqIFRIRSBQT1NTSUJJTElUWSBPRiBTVUNIIERBTUFHRS4KKyAqLworCisjaW5jbHVkZSAiY29u ZmlnLmgiCisjaW5jbHVkZSAiV2ViQ29udGV4dC5oIgorCisjaW5jbHVkZSA8V2ViQ29yZS9BcHBs aWNhdGlvbkNhY2hlU3RvcmFnZS5oPgorI2luY2x1ZGUgPFdlYkNvcmUvTm90SW1wbGVtZW50ZWQu aD4KKworbmFtZXNwYWNlIFdlYktpdCB7CisKK1N0cmluZyBXZWJDb250ZXh0OjphcHBsaWNhdGlv bkNhY2hlRGlyZWN0b3J5KCkKK3sKKyAgICByZXR1cm4gV2ViQ29yZTo6Y2FjaGVTdG9yYWdlKCku Y2FjaGVEaXJlY3RvcnkoKTsKK30KKwordm9pZCBXZWJDb250ZXh0OjpwbGF0Zm9ybUluaXRpYWxp emVXZWJQcm9jZXNzKFdlYlByb2Nlc3NDcmVhdGlvblBhcmFtZXRlcnMmKQoreworICAgIG5vdElt cGxlbWVudGVkKCk7Cit9CisKK3ZvaWQgV2ViQ29udGV4dDo6cGxhdGZvcm1JbnZhbGlkYXRlQ29u dGV4dCgpCit7CisgICAgbm90SW1wbGVtZW50ZWQoKTsKK30KKworU3RyaW5nIFdlYkNvbnRleHQ6 OnBsYXRmb3JtRGVmYXVsdERhdGFiYXNlRGlyZWN0b3J5KCkgY29uc3QKK3sKKyAgICBub3RJbXBs ZW1lbnRlZCgpOworICAgIHJldHVybiAiIjsKK30KKworU3RyaW5nIFdlYkNvbnRleHQ6OnBsYXRm b3JtRGVmYXVsdEljb25EYXRhYmFzZVBhdGgoKSBjb25zdAoreworICAgIG5vdEltcGxlbWVudGVk KCk7CisgICAgcmV0dXJuICIiOworfQorCitTdHJpbmcgV2ViQ29udGV4dDo6cGxhdGZvcm1EZWZh dWx0TG9jYWxTdG9yYWdlRGlyZWN0b3J5KCkgY29uc3QKK3sKKyAgICBub3RJbXBsZW1lbnRlZCgp OworICAgIHJldHVybiAiIjsKK30KKworfSAvLyBuYW1lc3BhY2UgV2ViS2l0Cg==