62434 2011-06-09 23:55:21 -0700 [EFL] Use makeString() when getting os version 2011-06-10 01:57:05 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 gyuyoung.kim webkit-unassigned gyuyoung.kim kenneth leandro lucas.de.marchi tkent tonikitoo webkit.review.bot oldest_to_newest 418541 0 gyuyoung.kim 2011-06-09 23:55:21 -0700 In _ewk_settings_webkit_os_version_get(), to use makeString() is better than before implementation. 418543 1 96701 gyuyoung.kim 2011-06-09 23:59:50 -0700 Created attachment 96701 Proposed Patch 418572 2 96701 tkent 2011-06-10 01:19:42 -0700 Comment on attachment 96701 Proposed Patch ok 418592 3 96701 webkit.review.bot 2011-06-10 01:57:01 -0700 Comment on attachment 96701 Proposed Patch Clearing flags on attachment: 96701 Committed r88532: <http://trac.webkit.org/changeset/88532> 418593 4 webkit.review.bot 2011-06-10 01:57:05 -0700 All reviewed patches have been landed. Closing bug. 96701 2011-06-09 23:59:50 -0700 2011-06-10 01:57:00 -0700 Proposed Patch patch-os-version.patch text/plain 1223 gyuyoung.kim ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZWZsL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQv ZWZsL0NoYW5nZUxvZwppbmRleCAwNzA4Y2FmLi41ZTdmM2Q4IDEwMDc1NQotLS0gYS9Tb3VyY2Uv V2ViS2l0L2VmbC9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9lZmwvQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTYgQEAKKzIwMTEtMDYtMDkgIEd5dXlvdW5nIEtpbSAgPGd5dXlvdW5nLmtpbUBz YW1zdW5nLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBbRUZMXSBVc2UgbWFrZVN0cmluZygpIHdoZW4gZ2V0dGluZyBvcyB2ZXJzaW9uCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02MjQzNAorCisgICAg ICAgIFdoZW4gb3MgdmVyc2lvbiBzdHJpbmcgaXMgY3JlYXRlZCwgdG8gdXNlIG1ha2VTdHJpbmco KSBpcyBiZXR0ZXIgdGhhbgorICAgICAgICBTdHJpbmcgb3BlcmF0aW9uLgorCisgICAgICAgICog ZXdrL2V3a19zZXR0aW5ncy5jcHA6CisgICAgICAgIChfZXdrX3NldHRpbmdzX3dlYmtpdF9vc192 ZXJzaW9uX2dldCk6CisKIDIwMTEtMDYtMDggIEphZWh1biBMaW0gIDxsamFlaHVuLmxpbUBzYW1z dW5nLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBBbnRvbmlvIEdvbWVzLgpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYktpdC9lZmwvZXdrL2V3a19zZXR0aW5ncy5jcHAgYi9Tb3VyY2UvV2ViS2l0 L2VmbC9ld2svZXdrX3NldHRpbmdzLmNwcAppbmRleCBlY2ViNjdmLi43NjNkZDdiIDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViS2l0L2VmbC9ld2svZXdrX3NldHRpbmdzLmNwcAorKysgYi9Tb3VyY2Uv V2ViS2l0L2VmbC9ld2svZXdrX3NldHRpbmdzLmNwcApAQCAtNzcsNyArNzcsNyBAQCBzdGF0aWMg V1RGOjpTdHJpbmcgX2V3a19zZXR0aW5nc193ZWJraXRfb3NfdmVyc2lvbl9nZXQoKQogICAgIHN0 cnVjdCB1dHNuYW1lIG5hbWU7CiAKICAgICBpZiAodW5hbWUoJm5hbWUpICE9IC0xKQotICAgICAg ICB1YV9vc192ZXJzaW9uID0gV1RGOjpTdHJpbmcobmFtZS5zeXNuYW1lKSArICIgIiArIFdURjo6 U3RyaW5nKG5hbWUubWFjaGluZSk7CisgICAgICAgIHVhX29zX3ZlcnNpb24gPSBtYWtlU3RyaW5n KG5hbWUuc3lzbmFtZSwgJyAnLCBuYW1lLm1hY2hpbmUpOwogICAgIGVsc2UKICAgICAgICAgdWFf b3NfdmVyc2lvbiA9ICJVbmtub3duIjsKIAo=