62418 2011-06-09 17:40:16 -0700 Code cleanup - add wrappers for function pointer dereferences to improve readability in ApplyPropertyDefaultBase and derived classes. 2011-06-09 23:17:57 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 macpherson macpherson dglazkov eric macpherson simon.fraser webkit.review.bot oldest_to_newest 418431 0 macpherson 2011-06-09 17:40:16 -0700 Code cleanup - add wrappers for function pointer dereferences to improve readability in ApplyPropertyDefaultBase and derived classes. 418446 1 96681 macpherson 2011-06-09 18:09:32 -0700 Created attachment 96681 Patch 418504 2 96681 eric 2011-06-09 22:35:31 -0700 Comment on attachment 96681 Patch This is nicer, thank you. 418505 3 eric 2011-06-09 22:35:56 -0700 I can't remember if simon likes to see these patches or not. 418527 4 webkit.review.bot 2011-06-09 23:16:32 -0700 The commit-queue encountered the following flaky tests while processing attachment 96681: http/tests/local/formdata/send-form-data-constructed-from-form.html bug 62431 (author: jianli@chromium.org) The commit-queue is continuing to process your patch. 418529 5 96681 webkit.review.bot 2011-06-09 23:17:52 -0700 Comment on attachment 96681 Patch Clearing flags on attachment: 96681 Committed r88524: <http://trac.webkit.org/changeset/88524> 418530 6 webkit.review.bot 2011-06-09 23:17:57 -0700 All reviewed patches have been landed. Closing bug. 96681 2011-06-09 18:09:32 -0700 2011-06-09 23:17:52 -0700 Patch bug-62418-20110610110929.patch text/plain 5125 macpherson SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDg4NTA3KQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMzAgQEAKKzIwMTEtMDYtMDkgIEx1a2UgTWFj cGhlcnNvbiAgIDxtYWNwaGVyc29uQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBDb2RlIGNsZWFudXAgLSBhZGQgd3JhcHBlcnMg Zm9yIGZ1bmN0aW9uIHBvaW50ZXIgZGVyZWZlcmVuY2VzIHRvIGltcHJvdmUgcmVhZGFiaWxpdHkg aW4gQXBwbHlQcm9wZXJ0eURlZmF1bHRCYXNlIGFuZCBkZXJpdmVkIGNsYXNzZXMuCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02MjQxOAorCisgICAgICAg IE5vIG5ldyB0ZXN0cyAvIGNsZWFudXAgb25seS4KKworICAgICAgICAqIGNzcy9DU1NTdHlsZUFw cGx5UHJvcGVydHkuY3BwOgorICAgICAgICAoV2ViQ29yZTo6QXBwbHlQcm9wZXJ0eURlZmF1bHRC YXNlOjphcHBseUluaGVyaXRWYWx1ZSk6CisgICAgICAgIFVzZSBuZXcgd3JhcHBlciBmdW5jdGlv bnMuCisgICAgICAgIChXZWJDb3JlOjpBcHBseVByb3BlcnR5RGVmYXVsdEJhc2U6OmFwcGx5SW5p dGlhbFZhbHVlKToKKyAgICAgICAgVXNlIG5ldyB3cmFwcGVyIGZ1bmN0aW9ucy4KKyAgICAgICAg KFdlYkNvcmU6OkFwcGx5UHJvcGVydHlEZWZhdWx0QmFzZTo6c2V0VmFsdWUpOgorICAgICAgICBX cmFwcGVyIGZvciBjYWxsaW5nIG1fc2V0dGVyIGZ1bmN0aW9uIHBvaW50ZXIuCisgICAgICAgIChX ZWJDb3JlOjpBcHBseVByb3BlcnR5RGVmYXVsdEJhc2U6OnZhbHVlKToKKyAgICAgICAgV3JhcHBl ciBmb3IgY2FsbGluZyBtX2dldHRlciBmdW5jdGlvbiBwb2ludGVyLgorICAgICAgICAoV2ViQ29y ZTo6QXBwbHlQcm9wZXJ0eURlZmF1bHRCYXNlOjppbml0aWFsKToKKyAgICAgICAgV3JhcHBlciBm b3IgY2FsbGluZyBtX2luaXRpYWwgZnVuY3Rpb24gcG9pbnRlci4KKyAgICAgICAgKFdlYkNvcmU6 OkFwcGx5UHJvcGVydHlEZWZhdWx0OjphcHBseVZhbHVlKToKKyAgICAgICAgVXNlIG5ldyBzZXRW YWx1ZSBmdW5jdGlvbi4KKyAgICAgICAgKFdlYkNvcmU6OkFwcGx5UHJvcGVydHlMZW5ndGg6OmFw cGx5VmFsdWUpOgorICAgICAgICBVc2UgbmV3IHNldFZhbHVlIGZ1bmN0aW9uLgorICAgICAgICAo V2ViQ29yZTo6QXBwbHlQcm9wZXJ0eVdpZHRoOjphcHBseVZhbHVlKToKKyAgICAgICAgVXNlIG5l dyBzZXRWYWx1ZSBmdW5jdGlvbi4KKwogMjAxMS0wNi0wOSAgSmVyIE5vYmxlICA8amVyLm5vYmxl QGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBEYXZpZCBIeWF0dC4KSW5kZXg6IFNv dXJjZS9XZWJDb3JlL2Nzcy9DU1NTdHlsZUFwcGx5UHJvcGVydHkuY3BwCj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IFNvdXJjZS9XZWJDb3JlL2Nzcy9DU1NTdHlsZUFwcGx5UHJvcGVydHkuY3BwCShyZXZpc2lvbiA4 ODUwNSkKKysrIFNvdXJjZS9XZWJDb3JlL2Nzcy9DU1NTdHlsZUFwcGx5UHJvcGVydHkuY3BwCSh3 b3JraW5nIGNvcHkpCkBAIC05MiwxNSArOTIsMzAgQEAgcHVibGljOgogcHJpdmF0ZToKICAgICB2 aXJ0dWFsIHZvaWQgYXBwbHlJbmhlcml0VmFsdWUoQ1NTU3R5bGVTZWxlY3Rvciogc2VsZWN0b3Ip IGNvbnN0CiAgICAgewotICAgICAgICAoc2VsZWN0b3ItPnN0eWxlKCktPiptX3NldHRlcikoKHNl bGVjdG9yLT5wYXJlbnRTdHlsZSgpLT4qbV9nZXR0ZXIpKCkpOworICAgICAgICBzZXRWYWx1ZShz ZWxlY3Rvci0+c3R5bGUoKSwgdmFsdWUoc2VsZWN0b3ItPnBhcmVudFN0eWxlKCkpKTsKICAgICB9 CiAKICAgICB2aXJ0dWFsIHZvaWQgYXBwbHlJbml0aWFsVmFsdWUoQ1NTU3R5bGVTZWxlY3Rvciog c2VsZWN0b3IpIGNvbnN0CiAgICAgewotICAgICAgICAoc2VsZWN0b3ItPnN0eWxlKCktPiptX3Nl dHRlcikoKCptX2luaXRpYWwpKCkpOworICAgICAgICBzZXRWYWx1ZShzZWxlY3Rvci0+c3R5bGUo KSwgaW5pdGlhbCgpKTsKICAgICB9CiAKIHByb3RlY3RlZDoKKyAgICB2b2lkIHNldFZhbHVlKFJl bmRlclN0eWxlKiBzdHlsZSwgVCB2YWx1ZSkgY29uc3QKKyAgICB7CisgICAgICAgIChzdHlsZS0+ Km1fc2V0dGVyKSh2YWx1ZSk7CisgICAgfQorCisgICAgVCB2YWx1ZShSZW5kZXJTdHlsZSogc3R5 bGUpIGNvbnN0CisgICAgeworICAgICAgICByZXR1cm4gKHN0eWxlLT4qbV9nZXR0ZXIpKCk7Cisg ICAgfQorCisgICAgVCBpbml0aWFsKCkgY29uc3QKKyAgICB7CisgICAgICAgIHJldHVybiAoKm1f aW5pdGlhbCkoKTsKKyAgICB9CisKICAgICBHZXR0ZXJGdW5jdGlvbiBtX2dldHRlcjsKICAgICBT ZXR0ZXJGdW5jdGlvbiBtX3NldHRlcjsKICAgICBJbml0aWFsRnVuY3Rpb24gbV9pbml0aWFsOwpA QCAtMTE5LDcgKzEzNCw3IEBAIHByb3RlY3RlZDoKICAgICB2aXJ0dWFsIHZvaWQgYXBwbHlWYWx1 ZShDU1NTdHlsZVNlbGVjdG9yKiBzZWxlY3RvciwgQ1NTVmFsdWUqIHZhbHVlKSBjb25zdAogICAg IHsKICAgICAgICAgaWYgKHZhbHVlLT5pc1ByaW1pdGl2ZVZhbHVlKCkpCi0gICAgICAgICAgICAo c2VsZWN0b3ItPnN0eWxlKCktPipBcHBseVByb3BlcnR5RGVmYXVsdEJhc2U8VD46Om1fc2V0dGVy KSgqc3RhdGljX2Nhc3Q8Q1NTUHJpbWl0aXZlVmFsdWUqPih2YWx1ZSkpOworICAgICAgICAgICAg QXBwbHlQcm9wZXJ0eURlZmF1bHRCYXNlPFQ+OjpzZXRWYWx1ZShzZWxlY3Rvci0+c3R5bGUoKSwg KnN0YXRpY19jYXN0PENTU1ByaW1pdGl2ZVZhbHVlKj4odmFsdWUpKTsKICAgICB9CiB9OwogCkBA IC0yMTcsMjEgKzIzMiwyMSBAQCBwcml2YXRlOgogICAgICAgICBDU1NQcmltaXRpdmVWYWx1ZSog cHJpbWl0aXZlVmFsdWUgPSBzdGF0aWNfY2FzdDxDU1NQcmltaXRpdmVWYWx1ZSo+KHZhbHVlKTsK ICAgICAgICAgaWYgKG5vbmVFbmFibGVkICYmIHByaW1pdGl2ZVZhbHVlLT5nZXRJZGVudCgpID09 IENTU1ZhbHVlTm9uZSkKICAgICAgICAgICAgIGlmIChub25lVW5kZWZpbmVkKQotICAgICAgICAg ICAgICAgIChzZWxlY3Rvci0+c3R5bGUoKS0+Km1fc2V0dGVyKShMZW5ndGgodW5kZWZpbmVkTGVu Z3RoLCBGaXhlZCkpOworICAgICAgICAgICAgICAgIHNldFZhbHVlKHNlbGVjdG9yLT5zdHlsZSgp LCBMZW5ndGgodW5kZWZpbmVkTGVuZ3RoLCBGaXhlZCkpOwogICAgICAgICAgICAgZWxzZQotICAg ICAgICAgICAgICAgIChzZWxlY3Rvci0+c3R5bGUoKS0+Km1fc2V0dGVyKShMZW5ndGgoKSk7Cisg ICAgICAgICAgICAgICAgc2V0VmFsdWUoc2VsZWN0b3ItPnN0eWxlKCksIExlbmd0aCgpKTsKICAg ICAgICAgZWxzZSBpZiAoaW50cmluc2ljRW5hYmxlZCAmJiBwcmltaXRpdmVWYWx1ZS0+Z2V0SWRl bnQoKSA9PSBDU1NWYWx1ZUludHJpbnNpYykKLSAgICAgICAgICAgIChzZWxlY3Rvci0+c3R5bGUo KS0+Km1fc2V0dGVyKShMZW5ndGgoSW50cmluc2ljKSk7CisgICAgICAgICAgICBzZXRWYWx1ZShz ZWxlY3Rvci0+c3R5bGUoKSwgTGVuZ3RoKEludHJpbnNpYykpOwogICAgICAgICBlbHNlIGlmICht aW5JbnRyaW5zaWNFbmFibGVkICYmIHByaW1pdGl2ZVZhbHVlLT5nZXRJZGVudCgpID09IENTU1Zh bHVlTWluSW50cmluc2ljKQotICAgICAgICAgICAgKHNlbGVjdG9yLT5zdHlsZSgpLT4qbV9zZXR0 ZXIpKExlbmd0aChNaW5JbnRyaW5zaWMpKTsKKyAgICAgICAgICAgIHNldFZhbHVlKHNlbGVjdG9y LT5zdHlsZSgpLCBMZW5ndGgoTWluSW50cmluc2ljKSk7CiAgICAgICAgIGVsc2UgaWYgKGF1dG9F bmFibGVkICYmIHByaW1pdGl2ZVZhbHVlLT5nZXRJZGVudCgpID09IENTU1ZhbHVlQXV0bykKLSAg ICAgICAgICAgIChzZWxlY3Rvci0+c3R5bGUoKS0+Km1fc2V0dGVyKShMZW5ndGgoKSk7CisgICAg ICAgICAgICBzZXRWYWx1ZShzZWxlY3Rvci0+c3R5bGUoKSwgTGVuZ3RoKCkpOwogICAgICAgICBl bHNlIHsKICAgICAgICAgICAgIGludCB0eXBlID0gcHJpbWl0aXZlVmFsdWUtPnByaW1pdGl2ZVR5 cGUoKTsKICAgICAgICAgICAgIGlmIChDU1NQcmltaXRpdmVWYWx1ZTo6aXNVbml0VHlwZUxlbmd0 aCh0eXBlKSkKLSAgICAgICAgICAgICAgICAoc2VsZWN0b3ItPnN0eWxlKCktPiptX3NldHRlciko TGVuZ3RoKHByaW1pdGl2ZVZhbHVlLT5jb21wdXRlTGVuZ3RoSW50Rm9yTGVuZ3RoKHNlbGVjdG9y LT5zdHlsZSgpLCBzZWxlY3Rvci0+cm9vdEVsZW1lbnRTdHlsZSgpLCBzZWxlY3Rvci0+c3R5bGUo KS0+ZWZmZWN0aXZlWm9vbSgpKSwgRml4ZWQsIHByaW1pdGl2ZVZhbHVlLT5pc1F1aXJrVmFsdWUo KSkpOworICAgICAgICAgICAgICAgIHNldFZhbHVlKHNlbGVjdG9yLT5zdHlsZSgpLCBMZW5ndGgo cHJpbWl0aXZlVmFsdWUtPmNvbXB1dGVMZW5ndGhJbnRGb3JMZW5ndGgoc2VsZWN0b3ItPnN0eWxl KCksIHNlbGVjdG9yLT5yb290RWxlbWVudFN0eWxlKCksIHNlbGVjdG9yLT5zdHlsZSgpLT5lZmZl Y3RpdmVab29tKCkpLCBGaXhlZCwgcHJpbWl0aXZlVmFsdWUtPmlzUXVpcmtWYWx1ZSgpKSk7CiAg ICAgICAgICAgICBlbHNlIGlmICh0eXBlID09IENTU1ByaW1pdGl2ZVZhbHVlOjpDU1NfUEVSQ0VO VEFHRSkKLSAgICAgICAgICAgICAgICAoc2VsZWN0b3ItPnN0eWxlKCktPiptX3NldHRlcikoTGVu Z3RoKHByaW1pdGl2ZVZhbHVlLT5nZXREb3VibGVWYWx1ZSgpLCBQZXJjZW50KSk7CisgICAgICAg ICAgICAgICAgc2V0VmFsdWUoc2VsZWN0b3ItPnN0eWxlKCksIExlbmd0aChwcmltaXRpdmVWYWx1 ZS0+Z2V0RG91YmxlVmFsdWUoKSwgUGVyY2VudCkpOwogICAgICAgICB9CiAgICAgfQogfTsKQEAg LTM2NSw3ICszODAsNyBAQCBwcml2YXRlOgogICAgICAgICAgICAgcmV0dXJuOwogICAgICAgICB9 CiAKLSAgICAgICAgKHNlbGVjdG9yLT5zdHlsZSgpLT4qbV9zZXR0ZXIpKHdpZHRoKTsKKyAgICAg ICAgc2V0VmFsdWUoc2VsZWN0b3ItPnN0eWxlKCksIHdpZHRoKTsKICAgICB9CiB9OwogCg==