62409 2011-06-09 15:49:46 -0700 REGRESSION(r88486): Broke chromium-win compile (Requested by jamesr on #webkit). 2011-06-09 15:53:47 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 61908 1 webkit.review.bot webkit.review.bot fishd jcivelli oldest_to_newest 418360 0 webkit.review.bot 2011-06-09 15:49:46 -0700 http://trac.webkit.org/changeset/88486 broke the build: Broke chromium-win compile (Requested by jamesr on #webkit). This is an automatic bug report generated by the sheriff-bot. If this bug report was created because of a flaky test, please file a bug for the flaky test (if we don't already have one on file) and dup this bug against that bug so that we can track how often these flaky tests case pain. "Only you can prevent forest fires." -- Smokey the Bear 418361 1 96656 webkit.review.bot 2011-06-09 15:50:05 -0700 Created attachment 96656 ROLLOUT of r88486 Any committer can land this patch automatically by marking it commit-queue+. The commit-queue will build and test the patch before landing to ensure that the rollout will be successful. This process takes approximately 15 minutes. If you would like to land the rollout faster, you can use the following command: webkit-patch land-attachment ATTACHMENT_ID --ignore-builders where ATTACHMENT_ID is the ID of this attachment. 418362 2 96656 webkit.review.bot 2011-06-09 15:53:43 -0700 Comment on attachment 96656 ROLLOUT of r88486 Clearing flags on attachment: 96656 Committed r88495: <http://trac.webkit.org/changeset/88495> 418363 3 webkit.review.bot 2011-06-09 15:53:47 -0700 All reviewed patches have been landed. Closing bug. 96656 2011-06-09 15:50:05 -0700 2011-06-09 15:53:43 -0700 ROLLOUT of r88486 bug-62409-20110609224835.patch text/plain 5169 webkit.review.bot U3VidmVyc2lvbiBSZXZpc2lvbjogODg0OTAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKaW5kZXgg NzQ3YzVkYzUxZGY2YmFlNTM3ZWI0YWJjMDJkOGU2OGJkMmFhMjFkMi4uNWY0MmM0ZDE2MzMxYTcx M2U3YmVjZDc1ZGI5NDIyMjUwMWYxOWQ5MiAxMDA3NTUKLS0tIGEvU291cmNlL1dlYktpdC9jaHJv bWl1bS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKQEAg LTEsMyArMSwxOCBAQAorMjAxMS0wNi0wOSAgU2hlcmlmZiBCb3QgIDx3ZWJraXQucmV2aWV3LmJv dEBnbWFpbC5jb20+CisKKyAgICAgICAgVW5yZXZpZXdlZCwgcm9sbGluZyBvdXQgcjg4NDg2Lgor ICAgICAgICBodHRwOi8vdHJhYy53ZWJraXQub3JnL2NoYW5nZXNldC84ODQ4NgorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjI0MDkKKworICAgICAgICBC cm9rZSBjaHJvbWl1bS13aW4gY29tcGlsZSAoUmVxdWVzdGVkIGJ5IGphbWVzciBvbiAjd2Via2l0 KS4KKworICAgICAgICAqIHB1YmxpYy9XZWJEYXRhLmg6CisgICAgICAgICogcHVibGljL1dlYlBh Z2VTZXJpYWxpemVyLmg6CisgICAgICAgICogc3JjL1dlYkRhdGEuY3BwOgorICAgICAgICAqIHNy Yy9XZWJQYWdlU2VyaWFsaXplci5jcHA6CisgICAgICAgIChXZWJLaXQ6OldlYlBhZ2VTZXJpYWxp emVyOjpzZXJpYWxpemUpOgorICAgICAgICAoV2ViS2l0OjpXZWJQYWdlU2VyaWFsaXplcjo6c2Vy aWFsaXplVG9NSFRNTCk6CisKIDIwMTEtMDYtMDkgIEpheSBDaXZlbGxpICA8amNpdmVsbGlAY2hy b21pdW0ub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERhcmluIEZpc2hlci4KZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYkRhdGEuaCBiL1NvdXJjZS9XZWJL aXQvY2hyb21pdW0vcHVibGljL1dlYkRhdGEuaAppbmRleCBkZDcyOTAxZjNiODAzNGE3MGE4YThm NzQ0ZThkZThiZTJiNzhiNmU4Li41ODc0YmVkMzE2ODIzOTU3NjA4MjI5NTcyNDU3ODNjMzhjNzVl NjY4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJEYXRhLmgK KysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViRGF0YS5oCkBAIC03NiwyMiAr NzYsNiBAQCBwdWJsaWM6CiAgICAgV0VCS0lUX0FQSSB2b2lkIGFzc2lnbihjb25zdCBjaGFyKiBk YXRhLCBzaXplX3Qgc2l6ZSk7CiAKICAgICBXRUJLSVRfQVBJIHNpemVfdCBzaXplKCkgY29uc3Q7 Ci0KLSAgICAvLyBTZXRzIHxkYXRhfCB0byBwb2ludCB0byB0aGUgY29udGVudCBvZiB0aGUgV2Vi RGF0YSBhdCBpbmRleCB8cG9zaXRpb258Ci0gICAgLy8gYW5kIHJldHVybnMgdGhlIG51bWJlciBv ZiBieXRlcyBhdmFpbGFibGUgdG8gYmUgcmVhZCBpbiB8ZGF0YXwuCi0gICAgLy8gUmV0dXJuIDAg d2hlbiBubyBtb3JlIGRhdGEgaXMgbGVmdC4KLSAgICAvLyBVc2FnZToKLSAgICAvLyAgICAgIGNv bnN0IGNoYXIqIHNlZ21lbnQ7Ci0gICAgLy8gICAgICBzaXplX3QgcG9zaXRpb24gPSAwOwotICAg IC8vICAgICAgd2hpbGUgKHNpemVfdCBsZW5ndGggPSB3ZWJEYXRhLmdldFNvbWVEYXRhKHNlZ21l bnQsIHBvc2l0aW9uKSkgewotICAgIC8vICAgICAgICAgIC8vIFVzZSB0aGUgZGF0YS4gZm9yIGV4 YW1wbGU6IGRlY29kZXItPmRlY29kZShzZWdtZW50LCBsZW5ndGgpOwotICAgIC8vICAgICAgICAg IHBvc2l0aW9uICs9IGxlbmd0aDsKLSAgICAvLyAgICAgIH0KLSAgICBXRUJLSVRfQVBJIHNpemVf dCBnZXRTb21lRGF0YShjb25zdCBjaGFyKiYgZGF0YSwgc2l6ZV90IHBvc2l0aW9uKSBjb25zdDsK LQotICAgIC8vIFJldHVybnMgYWxsIHRoZSBkYXRhIGZyb20gdGhlIFNoYXJlZEJ1ZmZlci4KLSAg ICAvLyBDb25zaWRlciB1c2luZyBnZXRTb21lRGF0YSgpIGFzIGRhdGEoKSBjb3VsZCByZXF1aXJl IGZsYXR0ZW5pbmcgdGhlIGludGVybmFsIGJ1ZmZlcgotICAgIC8vIHdoaWNoIG1pZ2h0IGJlIGV4 cGVuc2l2ZS4KICAgICBXRUJLSVRfQVBJIGNvbnN0IGNoYXIqIGRhdGEoKSBjb25zdDsKIAogICAg IGJvb2wgaXNFbXB0eSgpIGNvbnN0IHsgcmV0dXJuICFzaXplKCk7IH0KZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYlBhZ2VTZXJpYWxpemVyLmggYi9Tb3VyY2Uv V2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJQYWdlU2VyaWFsaXplci5oCmluZGV4IGM5ZGM5ZGI1 Nzc1NTFjMDVhY2E1MGZlYjgyZWY3OTQ4OTU2NjI4ODEuLmUyZGIwN2JlNDE4MDU3YjBlODZkMmE1 YzgwNjg3ODdkZDBiY2ZlNzkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vcHVi bGljL1dlYlBhZ2VTZXJpYWxpemVyLmgKKysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9wdWJs aWMvV2ViUGFnZVNlcmlhbGl6ZXIuaApAQCAtMzMsNyArMzMsNiBAQAogCiAjaW5jbHVkZSAiV2Vi Q1N0cmluZy5oIgogI2luY2x1ZGUgIldlYkNvbW1vbi5oIgotI2luY2x1ZGUgIldlYkRhdGEuaCIK ICNpbmNsdWRlICJXZWJVUkwuaCIKIAogbmFtZXNwYWNlIFdlYktpdCB7CkBAIC01MCw3ICs0OSw3 IEBAIHB1YmxpYzoKICAgICBzdHJ1Y3QgUmVzb3VyY2UgewogICAgICAgICBXZWJVUkwgdXJsOwog ICAgICAgICBXZWJDU3RyaW5nIG1pbWVUeXBlOwotICAgICAgICBXZWJEYXRhIGRhdGE7CisgICAg ICAgIFdlYkNTdHJpbmcgZGF0YTsKICAgICB9OwogCiAgICAgLy8gU2VyaWFsaXplcyBhbGwgdGhl IGZyYW1lcyBmcm9tIHRoZSBXZWJWaWV3LCByZXRyaWV2ZXMgdGhlIHBhZ2UncwpAQCAtNjAsNyAr NTksNyBAQCBwdWJsaWM6CiAgICAgV0VCS0lUX0FQSSBzdGF0aWMgdm9pZCBzZXJpYWxpemUoV2Vi VmlldyosIFdlYlZlY3RvcjxSZXNvdXJjZT4qKTsKIAogICAgIC8vIFNlcmlhbGl6ZXMgdGhlIFdl YlZpZXcgY29udGVudHMgdG8gYSBNSFRNTCByZXByZXNlbnRhdGlvbi4KLSAgICBXRUJLSVRfQVBJ IHN0YXRpYyBXZWJEYXRhIHNlcmlhbGl6ZVRvTUhUTUwoV2ViVmlldyopOworICAgIFdFQktJVF9B UEkgc3RhdGljIFdlYkNTdHJpbmcgc2VyaWFsaXplVG9NSFRNTChXZWJWaWV3Kik7CiAKICAgICAv LyBJTVBPUlRBTlQ6CiAgICAgLy8gVGhlIEFQSSBiZWxvdyBpcyBhbiBvbGRlciBpbXBsZW1lbnRh dGlvbiBvZiBhIHBhZ2VzZXJpYWxpemF0aW9uIHRoYXQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJL aXQvY2hyb21pdW0vc3JjL1dlYkRhdGEuY3BwIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMv V2ViRGF0YS5jcHAKaW5kZXggN2VmMDIyOGIxNmE4ZWVkZmU0ZTg1NGU1YWJjMmQ4YmVlN2M1YzRh OS4uNmFhZmU3OTZkZDNiZWU5ZmNhYjJhNzljY2U0ZWRlZDhhMDgwZmM5NyAxMDA2NDQKLS0tIGEv U291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViRGF0YS5jcHAKKysrIGIvU291cmNlL1dlYktp dC9jaHJvbWl1bS9zcmMvV2ViRGF0YS5jcHAKQEAgLTY5LDExICs2OSw2IEBAIHNpemVfdCBXZWJE YXRhOjpzaXplKCkgY29uc3QKICAgICByZXR1cm4gY29uc3RfY2FzdDxXZWJEYXRhUHJpdmF0ZSo+ KG1fcHJpdmF0ZSktPnNpemUoKTsKIH0KIAotc2l6ZV90IFdlYkRhdGE6OmdldFNvbWVEYXRhKGNv bnN0IGNoYXIqJiBkYXRhLCBzaXplX3QgcG9zaXRpb24pIGNvbnN0Ci17Ci0gICAgcmV0dXJuIG1f cHJpdmF0ZS0+Z2V0U29tZURhdGEoZGF0YSwgcG9zaXRpb24pOwotfQotCiBjb25zdCBjaGFyKiBX ZWJEYXRhOjpkYXRhKCkgY29uc3QKIHsKICAgICBpZiAoIW1fcHJpdmF0ZSkKZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYlBhZ2VTZXJpYWxpemVyLmNwcCBiL1NvdXJj ZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYlBhZ2VTZXJpYWxpemVyLmNwcAppbmRleCBjZDBhZWM3 ZTQzOWZiMDE4ZDA1NWEzYjFhOTcyZjY1MjRjNmM3MDJlLi42ZGY4NGJiNmI5NmE4ZGQzNGMyNjg2 ZTIwNjYxMjhkN2UwZmY1YmJkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3Ny Yy9XZWJQYWdlU2VyaWFsaXplci5jcHAKKysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMv V2ViUGFnZVNlcmlhbGl6ZXIuY3BwCkBAIC0xOTMsMTUgKzE5MywxOSBAQCB2b2lkIFdlYlBhZ2VT ZXJpYWxpemVyOjpzZXJpYWxpemUoV2ViVmlldyogdmlldywgV2ViVmVjdG9yPFdlYlBhZ2VTZXJp YWxpemVyOjpSZQogICAgICAgICBSZXNvdXJjZSByZXNvdXJjZTsKICAgICAgICAgcmVzb3VyY2Uu dXJsID0gaXRlci0+dXJsOwogICAgICAgICByZXNvdXJjZS5taW1lVHlwZSA9IGl0ZXItPm1pbWVU eXBlLmFzY2lpKCk7Ci0gICAgICAgIHJlc291cmNlLmRhdGEgPSBpdGVyLT5kYXRhOworICAgICAg ICAvLyBGSVhNRTogd2UgYXJlIGNvcHlpbmcgYWxsIHRoZSByZXNvdXJjZSBkYXRhIGhlcmUuIElk ZWFseSB3ZSB3b3VsZCBoYXZlIGEgV2ViU2hhcmVkRGF0YSgpLgorICAgICAgICByZXNvdXJjZS5k YXRhID0gV2ViQ1N0cmluZyhpdGVyLT5kYXRhLT5kYXRhKCksIGl0ZXItPmRhdGEtPnNpemUoKSk7 CiAgICAgICAgIHJlc3VsdC5hcHBlbmQocmVzb3VyY2UpOwogICAgIH0KKwogICAgICpyZXNvdXJj ZXNQYXJhbSA9IHJlc3VsdDsgICAgICAgICAKIH0KIAotV2ViRGF0YSBXZWJQYWdlU2VyaWFsaXpl cjo6c2VyaWFsaXplVG9NSFRNTChXZWJWaWV3KiB2aWV3KQorV2ViQ1N0cmluZyBXZWJQYWdlU2Vy aWFsaXplcjo6c2VyaWFsaXplVG9NSFRNTChXZWJWaWV3KiB2aWV3KQogewotICAgIHJldHVybiBN SFRNTEFyY2hpdmU6OmdlbmVyYXRlTUhUTUxEYXRhKHN0YXRpY19jYXN0PFdlYlZpZXdJbXBsKj4o dmlldyktPnBhZ2UoKSk7CisgICAgUmVmUHRyPFNoYXJlZEJ1ZmZlcj4gbWh0bWwgPSBNSFRNTEFy Y2hpdmU6OmdlbmVyYXRlTUhUTUxEYXRhKHN0YXRpY19jYXN0PFdlYlZpZXdJbXBsKj4odmlldykt PnBhZ2UoKSk7CisgICAgLy8gRklYTUU6IHdlIGFyZSBjb3B5aW5nIGFsbCB0aGUgZGF0YSBoZXJl LiBJZGVhbHkgd2Ugd291bGQgaGF2ZSBhIFdlYlNoYXJlZERhdGEoKS4KKyAgICByZXR1cm4gV2Vi Q1N0cmluZyhtaHRtbC0+ZGF0YSgpLCBtaHRtbC0+c2l6ZSgpKTsKIH0KIAogYm9vbCBXZWJQYWdl U2VyaWFsaXplcjo6c2VyaWFsaXplKFdlYkZyYW1lKiBmcmFtZSwK