62194 2011-06-06 23:52:28 -0700 new-run-webkit-tests: 'images' links on results.html don't work 2011-06-10 23:04:37 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED ToolsHitList P2 Normal --- 34984 1 rniwa webkit-unassigned abarth dglazkov dpranke ojan webkit.review.bot oldest_to_newest 416378 0 rniwa 2011-06-06 23:52:28 -0700 Reproduction steps: 1. Open http://build.webkit.org/results/Chromium%20Mac%20Release%20(Tests)/r88219%20(7942)/results.html 2. Click any 'images' Expected result: Actual and expected images are shown. Actual result: No images are shown. The problem is that nrwt's diffs.html contain absolute path to local files instead of relatives paths: See http://build.webkit.org/results/Chromium%20Mac%20Release%20(Tests)/r88219%20(7942)/css2.1/t1508-c527-font-05-b-diffs.html for example. 416389 1 rniwa 2011-06-07 00:14:27 -0700 We need to modify http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py 417683 2 ojan 2011-06-08 16:39:34 -0700 We should use the same trick we use on the results.html page (http://trac.webkit.org/browser/trunk/LayoutTests/fast/harness/results.html#L366). If it's a file URL, we load the full path, if it's not, load the relative path. 418992 3 96808 rniwa 2011-06-10 15:39:34 -0700 Created attachment 96808 fixes the bug I don't know if I should be adding a test or where I should be adding a test since test_result_writer.py doesn't seem to have any tests. 419000 4 webkit.review.bot 2011-06-10 15:42:42 -0700 Attachment 96808 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Tools/ChangeLog', u'Tools/Scripts/webkitpy..." exit_code: 1 Tools/Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:247: whitespace after '{' [pep8/E201] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 419008 5 96808 ojan 2011-06-10 15:51:26 -0700 Comment on attachment 96808 fixes the bug View in context: https://bugs.webkit.org/attachment.cgi?id=96808&action=review > Tools/Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:119 > + def output_filename(self, modifier, local=False): I'd rather you just create an output_testname method. I think that results in better self-documenting code. 419021 6 dpranke 2011-06-10 16:01:20 -0700 (In reply to comment #3) > Created an attachment (id=96808) [details] > fixes the bug > > I don't know if I should be adding a test or where I should be adding a test since test_result_writer.py doesn't seem to have any tests. Hm. That's a bit odd. Feel free to start writing some in a test_result_writer_unittest.py class, but I probably wouldn't R- you for this. (In reply to comment #5) > (From update of attachment 96808 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=96808&action=review > > > Tools/Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:119 > > + def output_filename(self, modifier, local=False): > > I'd rather you just create an output_testname method. I think that results in better self-documenting code. Agreed. 419023 7 rniwa 2011-06-10 16:03:59 -0700 (In reply to comment #6) > (In reply to comment #3) > > Created an attachment (id=96808) [details] [details] > > fixes the bug > > > > I don't know if I should be adding a test or where I should be adding a test since test_result_writer.py doesn't seem to have any tests. > > Hm. That's a bit odd. Feel free to start writing some in a test_result_writer_unittest.py class, but I probably wouldn't R- you for this. Okay. I actually don't know how I can test that local path isn't included in the generated html. 419038 8 96821 rniwa 2011-06-10 16:20:59 -0700 Created attachment 96821 Added _output_testname The previous test also had a bug :( 419153 9 96821 rniwa 2011-06-10 22:08:53 -0700 Comment on attachment 96821 Added _output_testname Oops, forgot r? 419154 10 webkit.review.bot 2011-06-10 22:11:45 -0700 Attachment 96821 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Tools/ChangeLog', u'Tools/Scripts/webkitpy..." exit_code: 1 Tools/Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:248: whitespace after '{' [pep8/E201] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 419174 11 96821 rniwa 2011-06-10 23:04:32 -0700 Comment on attachment 96821 Added _output_testname Clearing flags on attachment: 96821 Committed r88598: <http://trac.webkit.org/changeset/88598> 419175 12 rniwa 2011-06-10 23:04:37 -0700 All reviewed patches have been landed. Closing bug. 96808 2011-06-10 15:39:34 -0700 2011-06-10 16:20:59 -0700 fixes the bug fix62194 text/plain 2319 rniwa SW5kZXg6IFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL2xheW91dF9wYWNrYWdl L3Rlc3RfcmVzdWx0X3dyaXRlci5weQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9TY3JpcHRzL3dlYmtp dHB5L2xheW91dF90ZXN0cy9sYXlvdXRfcGFja2FnZS90ZXN0X3Jlc3VsdF93cml0ZXIucHkJKHJl dmlzaW9uIDg4NTU0KQorKysgVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvbGF5 b3V0X3BhY2thZ2UvdGVzdF9yZXN1bHRfd3JpdGVyLnB5CSh3b3JraW5nIGNvcHkpCkBAIC0xMTYs NyArMTE2LDcgQEAKICAgICAgICAgb3V0cHV0X2ZpbGVuYW1lID0gZnMuam9pbihzZWxmLl9yb290 X291dHB1dF9kaXIsIHNlbGYuX3Rlc3RuYW1lKQogICAgICAgICBzZWxmLl9wb3J0Lm1heWJlX21h a2VfZGlyZWN0b3J5KGZzLmRpcm5hbWUob3V0cHV0X2ZpbGVuYW1lKSkKIAotICAgIGRlZiBvdXRw dXRfZmlsZW5hbWUoc2VsZiwgbW9kaWZpZXIpOgorICAgIGRlZiBvdXRwdXRfZmlsZW5hbWUoc2Vs ZiwgbW9kaWZpZXIsIGxvY2FsPUZhbHNlKToKICAgICAgICAgIiIiUmV0dXJucyBhIGZpbGVuYW1l IGluc2lkZSB0aGUgb3V0cHV0IGRpciB0aGF0IGNvbnRhaW5zIG1vZGlmaWVyLgogCiAgICAgICAg IEZvciBleGFtcGxlLCBpZiB0ZXN0IG5hbWUgaXMgImZhc3QvZG9tL2Zvby5odG1sIiBhbmQgbW9k aWZpZXIgaXMgIi1leHBlY3RlZC50eHQiLApAQCAtMTI5LDcgKzEyOSwxMCBAQAogICAgICAgICAg IFRoZSBhYnNvbHV0ZSBwYXRoIHRvIHRoZSBvdXRwdXQgZmlsZW5hbWUKICAgICAgICAgIiIiCiAg ICAgICAgIGZzID0gc2VsZi5fcG9ydC5fZmlsZXN5c3RlbQotICAgICAgICBvdXRwdXRfZmlsZW5h bWUgPSBmcy5qb2luKHNlbGYuX3Jvb3Rfb3V0cHV0X2Rpciwgc2VsZi5fdGVzdG5hbWUpCisgICAg ICAgIGlmIGxvY2FsOgorICAgICAgICAgICAgb3V0cHV0X2ZpbGVuYW1lID0gc2VsZi5fdGVzdG5h bWUKKyAgICAgICAgZWxzZToKKyAgICAgICAgICAgIG91dHB1dF9maWxlbmFtZSA9IGZzLmpvaW4o c2VsZi5fcm9vdF9vdXRwdXRfZGlyLCBzZWxmLl90ZXN0bmFtZSkKICAgICAgICAgcmV0dXJuIGZz LnNwbGl0ZXh0KG91dHB1dF9maWxlbmFtZSlbMF0gKyBtb2RpZmllcgogCiAgICAgZGVmIHdyaXRl X291dHB1dF9maWxlcyhzZWxmLCBmaWxlX3R5cGUsIG91dHB1dCwgZXhwZWN0ZWQpOgpAQCAtMjQx LDcgKzI0NCw3IEBACiAgICAgdG9nZ2xlSW1hZ2VzKCk7CiAgICAgc2V0SW50ZXJ2YWwodG9nZ2xl SW1hZ2VzLCAyMDAwKQogPC9zY3JpcHQ+Ci0iIiIgJSB7ICd0aXRsZSc6IHNlbGYuX3Rlc3RuYW1l LCAnZGlmZl9maWxlbmFtZSc6IHNlbGYub3V0cHV0X2ZpbGVuYW1lKCctZGlmZi5wbmcnKSwgJ3By ZWZpeCc6IHNlbGYub3V0cHV0X2ZpbGVuYW1lKCcnKSB9CisiIiIgJSB7ICd0aXRsZSc6IHNlbGYu X3Rlc3RuYW1lLCAnZGlmZl9maWxlbmFtZSc6IHNlbGYub3V0cHV0X2ZpbGVuYW1lKCctZGlmZi5w bmcnLCBGYWxzZSksICdwcmVmaXgnOiBzZWxmLm91dHB1dF9maWxlbmFtZSgnJywgRmFsc2UpIH0K ICAgICAgICAgc2VsZi5fcG9ydC5fZmlsZXN5c3RlbS53cml0ZV9iaW5hcnlfZmlsZShkaWZmc19o dG1sX2ZpbGVuYW1lLCBodG1sKQogCiAgICAgICAgIHJldHVybiBUcnVlCkluZGV4OiBUb29scy9D aGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvQ2hhbmdlTG9nCShyZXZpc2lvbiA4ODU3MikK KysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBACisyMDEx LTA2LTEwICBSeW9zdWtlIE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIG5ldy1ydW4td2Via2l0LXRlc3RzOiAn aW1hZ2VzJyBsaW5rcyBvbiByZXN1bHRzLmh0bWwgZG9uJ3Qgd29yaworICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjIxOTQKKworICAgICAgICBVc2UgcmVs YXRpdmUgcGF0aCB3aGVuIGdlbmVyYXRpbmcgaW1hZ2VzLWRpZmZzLmh0bWwKKworICAgICAgICAq IFNjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL2xheW91dF9wYWNrYWdlL3Rlc3RfcmVzdWx0 X3dyaXRlci5weToKKwogMjAxMS0wNi0xMCAgTWFyayBSb3dlICA8bXJvd2VAYXBwbGUuY29tPgog CiAgICAgICAgIFJldmlld2VkIGJ5IERpbWl0cmkgR2xhemtvdi4K 96821 2011-06-10 16:20:59 -0700 2011-06-10 23:04:32 -0700 Added _output_testname fix62194b text/plain 1884 rniwa SW5kZXg6IFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL2xheW91dF9wYWNrYWdl L3Rlc3RfcmVzdWx0X3dyaXRlci5weQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9TY3JpcHRzL3dlYmtp dHB5L2xheW91dF90ZXN0cy9sYXlvdXRfcGFja2FnZS90ZXN0X3Jlc3VsdF93cml0ZXIucHkJKHJl dmlzaW9uIDg4NTU0KQorKysgVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvbGF5 b3V0X3BhY2thZ2UvdGVzdF9yZXN1bHRfd3JpdGVyLnB5CSh3b3JraW5nIGNvcHkpCkBAIC0xMzIs NiArMTMyLDEwIEBACiAgICAgICAgIG91dHB1dF9maWxlbmFtZSA9IGZzLmpvaW4oc2VsZi5fcm9v dF9vdXRwdXRfZGlyLCBzZWxmLl90ZXN0bmFtZSkKICAgICAgICAgcmV0dXJuIGZzLnNwbGl0ZXh0 KG91dHB1dF9maWxlbmFtZSlbMF0gKyBtb2RpZmllcgogCisgICAgZGVmIF9vdXRwdXRfdGVzdG5h bWUoc2VsZiwgbW9kaWZpZXIpOgorICAgICAgICBmcyA9IHNlbGYuX3BvcnQuX2ZpbGVzeXN0ZW0K KyAgICAgICAgcmV0dXJuIGZzLnNwbGl0ZXh0KGZzLmJhc2VuYW1lKHNlbGYuX3Rlc3RuYW1lKSlb MF0gKyBtb2RpZmllcgorCiAgICAgZGVmIHdyaXRlX291dHB1dF9maWxlcyhzZWxmLCBmaWxlX3R5 cGUsIG91dHB1dCwgZXhwZWN0ZWQpOgogICAgICAgICAiIiJXcml0ZXMgdGhlIHRlc3Qgb3V0cHV0 LCB0aGUgZXhwZWN0ZWQgb3V0cHV0IGluIHRoZSByZXN1bHRzIGRpcmVjdG9yeS4KIApAQCAtMjQx LDcgKzI0NSw3IEBACiAgICAgdG9nZ2xlSW1hZ2VzKCk7CiAgICAgc2V0SW50ZXJ2YWwodG9nZ2xl SW1hZ2VzLCAyMDAwKQogPC9zY3JpcHQ+Ci0iIiIgJSB7ICd0aXRsZSc6IHNlbGYuX3Rlc3RuYW1l LCAnZGlmZl9maWxlbmFtZSc6IHNlbGYub3V0cHV0X2ZpbGVuYW1lKCctZGlmZi5wbmcnKSwgJ3By ZWZpeCc6IHNlbGYub3V0cHV0X2ZpbGVuYW1lKCcnKSB9CisiIiIgJSB7ICd0aXRsZSc6IHNlbGYu X3Rlc3RuYW1lLCAnZGlmZl9maWxlbmFtZSc6IHNlbGYuX291dHB1dF90ZXN0bmFtZSgnLWRpZmYu cG5nJyksICdwcmVmaXgnOiBzZWxmLl9vdXRwdXRfdGVzdG5hbWUoJycpIH0KICAgICAgICAgc2Vs Zi5fcG9ydC5fZmlsZXN5c3RlbS53cml0ZV9iaW5hcnlfZmlsZShkaWZmc19odG1sX2ZpbGVuYW1l LCBodG1sKQogCiAgICAgICAgIHJldHVybiBUcnVlCkluZGV4OiBUb29scy9DaGFuZ2VMb2cKPT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PQotLS0gVG9vbHMvQ2hhbmdlTG9nCShyZXZpc2lvbiA4ODU3MikKKysrIFRvb2xzL0No YW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDExLTA2LTEwICBSeW9z dWtlIE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIG5ldy1ydW4td2Via2l0LXRlc3RzOiAnaW1hZ2VzJyBsaW5r cyBvbiByZXN1bHRzLmh0bWwgZG9uJ3Qgd29yaworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjIxOTQKKworICAgICAgICBVc2UgcmVsYXRpdmUgcGF0aCB3 aGVuIGdlbmVyYXRpbmcgaW1hZ2VzLWRpZmZzLmh0bWwKKworICAgICAgICAqIFNjcmlwdHMvd2Vi a2l0cHkvbGF5b3V0X3Rlc3RzL2xheW91dF9wYWNrYWdlL3Rlc3RfcmVzdWx0X3dyaXRlci5weToK KyAgICAgICAgQWRkZWQgX291dHB1dF90ZXN0bmFtZS4KKwogMjAxMS0wNi0xMCAgTWFyayBSb3dl ICA8bXJvd2VAYXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERpbWl0cmkgR2xhemtv di4K