62170 2011-06-06 17:42:07 -0700 Change RenderBlock::hitTestContents to IntPoint 2011-06-07 16:24:56 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 60318 1 eae eae eric leviw simon.fraser webkit.review.bot oldest_to_newest 416175 0 eae 2011-06-06 17:42:07 -0700 Ongoing tx, ty removal. 416177 1 96164 eae 2011-06-06 17:44:46 -0700 Created attachment 96164 Patch 416179 2 eae 2011-06-06 17:52:26 -0700 I plan to rename accumulatedOffset before committing, assuming we agree on a name name before then. 416786 3 96164 eae 2011-06-07 14:25:45 -0700 Comment on attachment 96164 Patch Landing as is, will rename once we've decided on a better name. 416910 4 96164 webkit.review.bot 2011-06-07 16:24:52 -0700 Comment on attachment 96164 Patch Clearing flags on attachment: 96164 Committed r88282: <http://trac.webkit.org/changeset/88282> 416911 5 webkit.review.bot 2011-06-07 16:24:56 -0700 All reviewed patches have been landed. Closing bug. 96164 2011-06-06 17:44:46 -0700 2011-06-07 16:24:52 -0700 Patch bug-62170-20110606174445.patch text/plain 4911 eae SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDg4MjA0KQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTggQEAKKzIwMTEtMDYtMDYgIEVtaWwgQSBF a2x1bmQgIDxlYWVAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIENoYW5nZSBSZW5kZXJCbG9jazo6aGl0VGVzdENvbnRlbnRzIHRv IEludFBvaW50CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD02MjE3MAorCisgICAgICAgIENvdmVyZWQgYnkgZXhpc3RpbmcgdGVzdHMuCisKKyAgICAgICAg KiByZW5kZXJpbmcvUmVuZGVyQmxvY2suY3BwOgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyQmxv Y2s6Om5vZGVBdFBvaW50KToKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlckJsb2NrOjpoaXRUZXN0 Q29sdW1ucyk6CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJCbG9jazo6aGl0VGVzdENvbnRlbnRz KToKKyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVyQmxvY2suaDoKKwogMjAxMS0wNi0wNiAgRW1p bCBBIEVrbHVuZCAgPGVhZUBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRXJp YyBTZWlkZWwuCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyQmxvY2suY3Bw Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJCbG9jay5jcHAJ KHJldmlzaW9uIDg4MjAyKQorKysgU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckJsb2Nr LmNwcAkod29ya2luZyBjb3B5KQpAQCAtMzkyOSw3ICszOTI5LDcgQEAgYm9vbCBSZW5kZXJCbG9j azo6bm9kZUF0UG9pbnQoY29uc3QgSGl0VAogCiAgICAgICAgIC8vIEhpdCB0ZXN0IGNvbnRlbnRz IGlmIHdlIGRvbid0IGhhdmUgY29sdW1ucy4KICAgICAgICAgaWYgKCFoYXNDb2x1bW5zKCkpIHsK LSAgICAgICAgICAgIGlmIChoaXRUZXN0Q29udGVudHMocmVxdWVzdCwgcmVzdWx0LCBwb2ludElu Q29udGFpbmVyLCBzY3JvbGxlZE9mZnNldC53aWR0aCgpLCBzY3JvbGxlZE9mZnNldC5oZWlnaHQo KSwgaGl0VGVzdEFjdGlvbikpIHsKKyAgICAgICAgICAgIGlmIChoaXRUZXN0Q29udGVudHMocmVx dWVzdCwgcmVzdWx0LCBwb2ludEluQ29udGFpbmVyLCB0b1BvaW50KHNjcm9sbGVkT2Zmc2V0KSwg aGl0VGVzdEFjdGlvbikpIHsKICAgICAgICAgICAgICAgICB1cGRhdGVIaXRUZXN0UmVzdWx0KHJl c3VsdCwgcG9pbnRJbkNvbnRhaW5lciAtIGxvY2FsT2Zmc2V0KTsKICAgICAgICAgICAgICAgICBy ZXR1cm4gdHJ1ZTsKICAgICAgICAgICAgIH0KQEAgLTQwMjEsMjAgKzQwMjEsMjAgQEAgYm9vbCBS ZW5kZXJCbG9jazo6aGl0VGVzdENvbHVtbnMoY29uc3QgSAogICAgICAgICAgICAgaW50IGZpbmFs WCA9IHR4ICsgb2Zmc2V0LndpZHRoKCk7CiAgICAgICAgICAgICBpbnQgZmluYWxZID0gdHkgKyBv ZmZzZXQuaGVpZ2h0KCk7CiAgICAgICAgICAgICBpZiAocmVzdWx0LmlzUmVjdEJhc2VkVGVzdCgp ICYmICFjb2xSZWN0LmNvbnRhaW5zKHJlc3VsdC5yZWN0Rm9yUG9pbnQocG9pbnRJbkNvbnRhaW5l cikpKQotICAgICAgICAgICAgICAgIGhpdFRlc3RDb250ZW50cyhyZXF1ZXN0LCByZXN1bHQsIHBv aW50SW5Db250YWluZXIsIGZpbmFsWCwgZmluYWxZLCBoaXRUZXN0QWN0aW9uKTsKKyAgICAgICAg ICAgICAgICBoaXRUZXN0Q29udGVudHMocmVxdWVzdCwgcmVzdWx0LCBwb2ludEluQ29udGFpbmVy LCBJbnRQb2ludChmaW5hbFgsIGZpbmFsWSksIGhpdFRlc3RBY3Rpb24pOwogICAgICAgICAgICAg ZWxzZQotICAgICAgICAgICAgICAgIHJldHVybiBoaXRUZXN0Q29udGVudHMocmVxdWVzdCwgcmVz dWx0LCBwb2ludEluQ29udGFpbmVyLCBmaW5hbFgsIGZpbmFsWSwgaGl0VGVzdEFjdGlvbikgfHwg KGhpdFRlc3RBY3Rpb24gPT0gSGl0VGVzdEZsb2F0ICYmIGhpdFRlc3RGbG9hdHMocmVxdWVzdCwg cmVzdWx0LCBwb2ludEluQ29udGFpbmVyLCBmaW5hbFgsIGZpbmFsWSkpOworICAgICAgICAgICAg ICAgIHJldHVybiBoaXRUZXN0Q29udGVudHMocmVxdWVzdCwgcmVzdWx0LCBwb2ludEluQ29udGFp bmVyLCBJbnRQb2ludChmaW5hbFgsIGZpbmFsWSksIGhpdFRlc3RBY3Rpb24pIHx8IChoaXRUZXN0 QWN0aW9uID09IEhpdFRlc3RGbG9hdCAmJiBoaXRUZXN0RmxvYXRzKHJlcXVlc3QsIHJlc3VsdCwg cG9pbnRJbkNvbnRhaW5lciwgZmluYWxYLCBmaW5hbFkpKTsKICAgICAgICAgfQogICAgIH0KIAog ICAgIHJldHVybiBmYWxzZTsKIH0KIAotYm9vbCBSZW5kZXJCbG9jazo6aGl0VGVzdENvbnRlbnRz KGNvbnN0IEhpdFRlc3RSZXF1ZXN0JiByZXF1ZXN0LCBIaXRUZXN0UmVzdWx0JiByZXN1bHQsIGNv bnN0IEludFBvaW50JiBwb2ludEluQ29udGFpbmVyLCBpbnQgdHgsIGludCB0eSwgSGl0VGVzdEFj dGlvbiBoaXRUZXN0QWN0aW9uKQorYm9vbCBSZW5kZXJCbG9jazo6aGl0VGVzdENvbnRlbnRzKGNv bnN0IEhpdFRlc3RSZXF1ZXN0JiByZXF1ZXN0LCBIaXRUZXN0UmVzdWx0JiByZXN1bHQsIGNvbnN0 IEludFBvaW50JiBwb2ludEluQ29udGFpbmVyLCBjb25zdCBJbnRQb2ludCYgYWNjdW11bGF0ZWRP ZmZzZXQsIEhpdFRlc3RBY3Rpb24gaGl0VGVzdEFjdGlvbikKIHsKICAgICBpZiAoY2hpbGRyZW5J bmxpbmUoKSAmJiAhaXNUYWJsZSgpKSB7CiAgICAgICAgIC8vIFdlIGhhdmUgdG8gaGl0LXRlc3Qg b3VyIGxpbmUgYm94ZXMuCi0gICAgICAgIGlmIChtX2xpbmVCb3hlcy5oaXRUZXN0KHRoaXMsIHJl cXVlc3QsIHJlc3VsdCwgcG9pbnRJbkNvbnRhaW5lciwgSW50UG9pbnQodHgsIHR5KSwgaGl0VGVz dEFjdGlvbikpCisgICAgICAgIGlmIChtX2xpbmVCb3hlcy5oaXRUZXN0KHRoaXMsIHJlcXVlc3Qs IHJlc3VsdCwgcG9pbnRJbkNvbnRhaW5lciwgYWNjdW11bGF0ZWRPZmZzZXQsIGhpdFRlc3RBY3Rp b24pKQogICAgICAgICAgICAgcmV0dXJuIHRydWU7CiAgICAgfSBlbHNlIHsKICAgICAgICAgLy8g SGl0IHRlc3Qgb3VyIGNoaWxkcmVuLgpAQCAtNDA0Miw3ICs0MDQyLDcgQEAgYm9vbCBSZW5kZXJC bG9jazo6aGl0VGVzdENvbnRlbnRzKGNvbnN0IAogICAgICAgICBpZiAoaGl0VGVzdEFjdGlvbiA9 PSBIaXRUZXN0Q2hpbGRCbG9ja0JhY2tncm91bmRzKQogICAgICAgICAgICAgY2hpbGRIaXRUZXN0 ID0gSGl0VGVzdENoaWxkQmxvY2tCYWNrZ3JvdW5kOwogICAgICAgICBmb3IgKFJlbmRlckJveCog Y2hpbGQgPSBsYXN0Q2hpbGRCb3goKTsgY2hpbGQ7IGNoaWxkID0gY2hpbGQtPnByZXZpb3VzU2li bGluZ0JveCgpKSB7Ci0gICAgICAgICAgICBJbnRQb2ludCBjaGlsZFBvaW50ID0gZmxpcEZvcldy aXRpbmdNb2RlKGNoaWxkLCBJbnRQb2ludCh0eCwgdHkpLCBQYXJlbnRUb0NoaWxkRmxpcHBpbmdB ZGp1c3RtZW50KTsKKyAgICAgICAgICAgIEludFBvaW50IGNoaWxkUG9pbnQgPSBmbGlwRm9yV3Jp dGluZ01vZGUoY2hpbGQsIGFjY3VtdWxhdGVkT2Zmc2V0LCBQYXJlbnRUb0NoaWxkRmxpcHBpbmdB ZGp1c3RtZW50KTsKICAgICAgICAgICAgIGlmICghY2hpbGQtPmhhc1NlbGZQYWludGluZ0xheWVy KCkgJiYgIWNoaWxkLT5pc0Zsb2F0aW5nKCkgJiYgY2hpbGQtPm5vZGVBdFBvaW50KHJlcXVlc3Qs IHJlc3VsdCwgcG9pbnRJbkNvbnRhaW5lciwgY2hpbGRQb2ludC54KCksIGNoaWxkUG9pbnQueSgp LCBjaGlsZEhpdFRlc3QpKQogICAgICAgICAgICAgICAgIHJldHVybiB0cnVlOwogICAgICAgICB9 CkluZGV4OiBTb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyQmxvY2suaAo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBTb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyQmxvY2suaAkocmV2aXNpb24gODgy MDIpCisrKyBTb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyQmxvY2suaAkod29ya2luZyBj b3B5KQpAQCAtNTg5LDcgKzU4OSw3IEBAIHByaXZhdGU6CiAgICAgaW50IG5leHRGbG9hdExvZ2lj YWxCb3R0b21CZWxvdyhpbnQpIGNvbnN0OwogICAgIAogICAgIHZpcnR1YWwgYm9vbCBoaXRUZXN0 Q29sdW1ucyhjb25zdCBIaXRUZXN0UmVxdWVzdCYsIEhpdFRlc3RSZXN1bHQmLCBjb25zdCBJbnRQ b2ludCYgcG9pbnRJbkNvbnRhaW5lciwgaW50IHR4LCBpbnQgdHksIEhpdFRlc3RBY3Rpb24pOwot ICAgIHZpcnR1YWwgYm9vbCBoaXRUZXN0Q29udGVudHMoY29uc3QgSGl0VGVzdFJlcXVlc3QmLCBI aXRUZXN0UmVzdWx0JiwgY29uc3QgSW50UG9pbnQmIHBvaW50SW5Db250YWluZXIsIGludCB0eCwg aW50IHR5LCBIaXRUZXN0QWN0aW9uKTsKKyAgICB2aXJ0dWFsIGJvb2wgaGl0VGVzdENvbnRlbnRz KGNvbnN0IEhpdFRlc3RSZXF1ZXN0JiwgSGl0VGVzdFJlc3VsdCYsIGNvbnN0IEludFBvaW50JiBw b2ludEluQ29udGFpbmVyLCBjb25zdCBJbnRQb2ludCYgYWNjdW11bGF0ZWRPZmZzZXQsIEhpdFRl c3RBY3Rpb24pOwogICAgIGJvb2wgaGl0VGVzdEZsb2F0cyhjb25zdCBIaXRUZXN0UmVxdWVzdCYs IEhpdFRlc3RSZXN1bHQmLCBjb25zdCBJbnRQb2ludCYgcG9pbnRJbkNvbnRhaW5lciwgaW50IHR4 LCBpbnQgdHkpOwogCiAgICAgdmlydHVhbCBib29sIGlzUG9pbnRJbk92ZXJmbG93Q29udHJvbChI aXRUZXN0UmVzdWx0JiwgY29uc3QgSW50UG9pbnQmIHBvaW50SW5Db250YWluZXIsIGludCB0eCwg aW50IHR5KTsK