62167 2011-06-06 17:04:36 -0700 Convert RenderTextControl::hitInnerTextElement to IntPoint 2011-06-07 11:58:38 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 60318 1 eae eae eric leviw simon.fraser webkit.review.bot oldest_to_newest 416134 0 eae 2011-06-06 17:04:36 -0700 Ongoing tx, ty removal. Should be last remaining use in the hit testing code. 416148 1 96157 eae 2011-06-06 17:15:31 -0700 Created attachment 96157 Patch 416151 2 eae 2011-06-06 17:20:31 -0700 Actually, this is not the last. Found a few more :( 416694 3 96157 webkit.review.bot 2011-06-07 11:58:34 -0700 Comment on attachment 96157 Patch Clearing flags on attachment: 96157 Committed r88251: <http://trac.webkit.org/changeset/88251> 416695 4 webkit.review.bot 2011-06-07 11:58:38 -0700 All reviewed patches have been landed. Closing bug. 96157 2011-06-06 17:15:31 -0700 2011-06-07 11:58:34 -0700 Patch bug-62167-20110606171530.patch text/plain 4146 eae SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDg4MjA0KQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjAgQEAKKzIwMTEtMDYtMDYgIEVtaWwgQSBF a2x1bmQgIDxlYWVAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIENvbnZlcnQgUmVuZGVyVGV4dENvbnRyb2w6OmhpdElubmVyVGV4 dEVsZW1lbnQgdG8gSW50UG9pbnQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTYyMTY3CisKKyAgICAgICAgQ292ZXJlZCBieSBleGlzdGluZyB0ZXN0cy4K KworICAgICAgICAqIHJlbmRlcmluZy9SZW5kZXJUZXh0Q29udHJvbC5jcHA6CisgICAgICAgIChX ZWJDb3JlOjpSZW5kZXJUZXh0Q29udHJvbDo6aGl0SW5uZXJUZXh0RWxlbWVudCk6CisgICAgICAg ICogcmVuZGVyaW5nL1JlbmRlclRleHRDb250cm9sLmg6CisgICAgICAgICogcmVuZGVyaW5nL1Jl bmRlclRleHRDb250cm9sTXVsdGlMaW5lLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlclRl eHRDb250cm9sTXVsdGlMaW5lOjpub2RlQXRQb2ludCk6CisgICAgICAgICogcmVuZGVyaW5nL1Jl bmRlclRleHRDb250cm9sU2luZ2xlTGluZS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJU ZXh0Q29udHJvbFNpbmdsZUxpbmU6Om5vZGVBdFBvaW50KToKKwogMjAxMS0wNi0wNiAgRW1pbCBB IEVrbHVuZCAgPGVhZUBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRXJpYyBT ZWlkZWwuCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyVGV4dENvbnRyb2wu Y3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJUZXh0Q29u dHJvbC5jcHAJKHJldmlzaW9uIDg4MjAyKQorKysgU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1Jl bmRlclRleHRDb250cm9sLmNwcAkod29ya2luZyBjb3B5KQpAQCAtNDQ5LDEzICs0NDksMTMgQEAg dm9pZCBSZW5kZXJUZXh0Q29udHJvbDo6Y29tcHV0ZUxvZ2ljYWxIZQogICAgIFJlbmRlckJsb2Nr Ojpjb21wdXRlTG9naWNhbEhlaWdodCgpOwogfQogCi12b2lkIFJlbmRlclRleHRDb250cm9sOjpo aXRJbm5lclRleHRFbGVtZW50KEhpdFRlc3RSZXN1bHQmIHJlc3VsdCwgY29uc3QgSW50UG9pbnQm IHBvaW50SW5Db250YWluZXIsIGludCB0eCwgaW50IHR5KQordm9pZCBSZW5kZXJUZXh0Q29udHJv bDo6aGl0SW5uZXJUZXh0RWxlbWVudChIaXRUZXN0UmVzdWx0JiByZXN1bHQsIGNvbnN0IEludFBv aW50JiBwb2ludEluQ29udGFpbmVyLCBjb25zdCBJbnRQb2ludCYgYWNjdW11bGF0ZWRPZmZzZXQp CiB7CisgICAgSW50UG9pbnQgYWRqdXN0ZWRMb2NhdGlvbiA9IGFjY3VtdWxhdGVkT2Zmc2V0ICsg bG9jYXRpb24oKTsKICAgICBIVE1MRWxlbWVudCogaW5uZXJUZXh0ID0gaW5uZXJUZXh0RWxlbWVu dCgpOwogICAgIHJlc3VsdC5zZXRJbm5lck5vZGUoaW5uZXJUZXh0KTsKICAgICByZXN1bHQuc2V0 SW5uZXJOb25TaGFyZWROb2RlKGlubmVyVGV4dCk7Ci0gICAgcmVzdWx0LnNldExvY2FsUG9pbnQo cG9pbnRJbkNvbnRhaW5lciAtCi0gICAgICAgIEludFNpemUodHggKyB4KCkgKyBpbm5lclRleHQt PnJlbmRlckJveCgpLT54KCksIHR5ICsgeSgpICsgaW5uZXJUZXh0LT5yZW5kZXJCb3goKS0+eSgp KSk7CisgICAgcmVzdWx0LnNldExvY2FsUG9pbnQocG9pbnRJbkNvbnRhaW5lciAtIHRvU2l6ZShh ZGp1c3RlZExvY2F0aW9uICsgaW5uZXJUZXh0LT5yZW5kZXJCb3goKS0+bG9jYXRpb24oKSkpOwog fQogCiB2b2lkIFJlbmRlclRleHRDb250cm9sOjpmb3J3YXJkRXZlbnQoRXZlbnQqIGV2ZW50KQpJ bmRleDogU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclRleHRDb250cm9sLmgKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclRleHRDb250cm9sLmgJKHJl dmlzaW9uIDg4MjAyKQorKysgU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclRleHRDb250 cm9sLmgJKHdvcmtpbmcgY29weSkKQEAgLTYzLDcgKzYzLDcgQEAgcHJvdGVjdGVkOgogCiAgICAg dmlydHVhbCB2b2lkIHN0eWxlRGlkQ2hhbmdlKFN0eWxlRGlmZmVyZW5jZSwgY29uc3QgUmVuZGVy U3R5bGUqIG9sZFN0eWxlKTsKIAotICAgIHZvaWQgaGl0SW5uZXJUZXh0RWxlbWVudChIaXRUZXN0 UmVzdWx0JiwgY29uc3QgSW50UG9pbnQmIHBvaW50SW5Db250YWluZXIsIGludCB0eCwgaW50IHR5 KTsKKyAgICB2b2lkIGhpdElubmVyVGV4dEVsZW1lbnQoSGl0VGVzdFJlc3VsdCYsIGNvbnN0IElu dFBvaW50JiBwb2ludEluQ29udGFpbmVyLCBjb25zdCBJbnRQb2ludCYgYWNjdW11bGF0ZWRPZmZz ZXQpOwogICAgIHZvaWQgZm9yd2FyZEV2ZW50KEV2ZW50Kik7CiAKICAgICBpbnQgdGV4dEJsb2Nr V2lkdGgoKSBjb25zdDsKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJUZXh0 Q29udHJvbE11bHRpTGluZS5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvcmVuZGVy aW5nL1JlbmRlclRleHRDb250cm9sTXVsdGlMaW5lLmNwcAkocmV2aXNpb24gODgyMDIpCisrKyBT b3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyVGV4dENvbnRyb2xNdWx0aUxpbmUuY3BwCSh3 b3JraW5nIGNvcHkpCkBAIC03MCw3ICs3MCw3IEBAIGJvb2wgUmVuZGVyVGV4dENvbnRyb2xNdWx0 aUxpbmU6Om5vZGVBdFAKICAgICAgICAgcmV0dXJuIGZhbHNlOwogCiAgICAgaWYgKHJlc3VsdC5p bm5lck5vZGUoKSA9PSBub2RlKCkgfHwgcmVzdWx0LmlubmVyTm9kZSgpID09IGlubmVyVGV4dEVs ZW1lbnQoKSkKLSAgICAgICAgaGl0SW5uZXJUZXh0RWxlbWVudChyZXN1bHQsIHBvaW50SW5Db250 YWluZXIsIHR4LCB0eSk7CisgICAgICAgIGhpdElubmVyVGV4dEVsZW1lbnQocmVzdWx0LCBwb2lu dEluQ29udGFpbmVyLCBJbnRQb2ludCh0eCwgdHkpKTsKIAogICAgIHJldHVybiB0cnVlOwogfQpJ bmRleDogU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclRleHRDb250cm9sU2luZ2xlTGlu ZS5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclRleHRD b250cm9sU2luZ2xlTGluZS5jcHAJKHJldmlzaW9uIDg4MjAyKQorKysgU291cmNlL1dlYkNvcmUv cmVuZGVyaW5nL1JlbmRlclRleHRDb250cm9sU2luZ2xlTGluZS5jcHAJKHdvcmtpbmcgY29weSkK QEAgLTM0Miw3ICszNDIsNyBAQCBib29sIFJlbmRlclRleHRDb250cm9sU2luZ2xlTGluZTo6bm9k ZUF0CiAgICAgLy8gYW5kIGlmIHdlIGhpdCBvdXIgbm9kZSAoZS5nLiB3ZSdyZSBvdmVyIHRoZSBi b3JkZXIgb3IgcGFkZGluZyksIGFsc28gc2F5IHRoYXQgd2UgaGl0IHRoZQogICAgIC8vIGlubmVy IHRleHQgZWxlbWVudCBzbyB0aGF0IGl0IGdhaW5zIGZvY3VzLgogICAgIGlmIChyZXN1bHQuaW5u ZXJOb2RlKCktPmlzRGVzY2VuZGFudE9mKGlubmVyVGV4dEVsZW1lbnQoKSkgfHwgcmVzdWx0Lmlu bmVyTm9kZSgpID09IG5vZGUoKSkKLSAgICAgICAgaGl0SW5uZXJUZXh0RWxlbWVudChyZXN1bHQs IHBvaW50SW5Db250YWluZXIsIHR4LCB0eSk7CisgICAgICAgIGhpdElubmVyVGV4dEVsZW1lbnQo cmVzdWx0LCBwb2ludEluQ29udGFpbmVyLCBJbnRQb2ludCh0eCwgdHkpKTsKIAogICAgIC8vIElm IHdlIGZvdW5kIGEgc3BpbiBidXR0b24sIHdlJ3JlIGRvbmUuCiAgICAgSFRNTEVsZW1lbnQqIGlu bmVyU3BpbkJ1dHRvbiA9IGlubmVyU3BpbkJ1dHRvbkVsZW1lbnQoKTsK