62140 2011-06-06 13:09:44 -0700 Update RenderBlock::paint to use IntPoint internally 2011-06-06 18:47:05 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 62132 62133 60318 1 eae eae ap commit-queue eric leviw simon.fraser webkit.review.bot oldest_to_newest 415962 0 eae 2011-06-06 13:09:44 -0700 NOTE: This bug is not about changing the signature of the paint method. 415974 1 96117 eae 2011-06-06 13:34:20 -0700 Created attachment 96117 Patch 415987 2 96117 eric 2011-06-06 14:03:34 -0700 Comment on attachment 96117 Patch OK. 416104 3 96148 eae 2011-06-06 16:29:23 -0700 Created attachment 96148 Patch for landing 416180 4 96148 webkit.review.bot 2011-06-06 17:53:28 -0700 Comment on attachment 96148 Patch for landing Clearing flags on attachment: 96148 Committed r88205: <http://trac.webkit.org/changeset/88205> 416182 5 webkit.review.bot 2011-06-06 17:53:33 -0700 All reviewed patches have been landed. Closing bug. 416208 6 commit-queue 2011-06-06 18:47:05 -0700 The commit-queue encountered the following flaky tests while processing attachment 96148: http/tests/appcache/foreign-iframe-main.html bug 54872 (author: ap@webkit.org) The commit-queue is continuing to process your patch. 96117 2011-06-06 13:34:20 -0700 2011-06-06 16:29:20 -0700 Patch bug-62140-20110606133419.patch text/plain 2572 eae SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDg4MTg1KQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTEtMDYtMDYgIEVtaWwgQSBF a2x1bmQgIDxlYWVAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIFVwZGF0ZSBSZW5kZXJCbG9jazo6cGFpbnQgdG8gdXNlIEludFBv aW50IGludGVybmFsbHkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTYyMTQwCisKKyAgICAgICAgQ292ZXJlZCBieSBleGlzdGluZyB0ZXN0cy4KKworICAg ICAgICAqIHJlbmRlcmluZy9SZW5kZXJCbG9jay5jcHA6CisgICAgICAgIChXZWJDb3JlOjpSZW5k ZXJCbG9jazo6cGFpbnQpOgorCiAyMDExLTA2LTA2ICBFbWlsIEEgRWtsdW5kICA8ZWFlQGNocm9t aXVtLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBFcmljIFNlaWRlbC4KSW5kZXg6IFNvdXJj ZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJCbG9jay5jcHAKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNl L1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckJsb2NrLmNwcAkocmV2aXNpb24gODc5MzIpCisrKyBT b3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyQmxvY2suY3BwCSh3b3JraW5nIGNvcHkpCkBA IC0yMjQyLDggKzIyNDIsNyBAQCB2b2lkIFJlbmRlckJsb2NrOjpyZXBhaW50T3ZlcmhhbmdpbmdG bG9hCiAgCiB2b2lkIFJlbmRlckJsb2NrOjpwYWludChQYWludEluZm8mIHBhaW50SW5mbywgaW50 IHR4LCBpbnQgdHkpCiB7Ci0gICAgdHggKz0geCgpOwotICAgIHR5ICs9IHkoKTsKKyAgICBJbnRQ b2ludCBhZGp1c3RlZE9mZnNldCA9IGxvY2F0aW9uKCkgKyBJbnRTaXplKHR4LCB0eSk7CiAgICAg CiAgICAgUGFpbnRQaGFzZSBwaGFzZSA9IHBhaW50SW5mby5waGFzZTsKIApAQCAtMjI1NCwyMSAr MjI1MywyMSBAQCB2b2lkIFJlbmRlckJsb2NrOjpwYWludChQYWludEluZm8mIHBhaW50CiAgICAg ICAgIEludFJlY3Qgb3ZlcmZsb3dCb3ggPSB2aXN1YWxPdmVyZmxvd1JlY3QoKTsKICAgICAgICAg ZmxpcEZvcldyaXRpbmdNb2RlKG92ZXJmbG93Qm94KTsKICAgICAgICAgb3ZlcmZsb3dCb3guaW5m bGF0ZShtYXhpbWFsT3V0bGluZVNpemUocGFpbnRJbmZvLnBoYXNlKSk7Ci0gICAgICAgIG92ZXJm bG93Qm94Lm1vdmUodHgsIHR5KTsKKyAgICAgICAgb3ZlcmZsb3dCb3gubW92ZShhZGp1c3RlZE9m ZnNldCk7CiAgICAgICAgIGlmICghb3ZlcmZsb3dCb3guaW50ZXJzZWN0cyhwYWludEluZm8ucmVj dCkpCiAgICAgICAgICAgICByZXR1cm47CiAgICAgfQogCi0gICAgYm9vbCBwdXNoZWRDbGlwID0g cHVzaENvbnRlbnRzQ2xpcChwYWludEluZm8sIHR4LCB0eSk7Ci0gICAgcGFpbnRPYmplY3QocGFp bnRJbmZvLCB0eCwgdHkpOworICAgIGJvb2wgcHVzaGVkQ2xpcCA9IHB1c2hDb250ZW50c0NsaXAo cGFpbnRJbmZvLCBhZGp1c3RlZE9mZnNldCk7CisgICAgcGFpbnRPYmplY3QocGFpbnRJbmZvLCBh ZGp1c3RlZE9mZnNldC54KCksIGFkanVzdGVkT2Zmc2V0LnkoKSk7CiAgICAgaWYgKHB1c2hlZENs aXApCi0gICAgICAgIHBvcENvbnRlbnRzQ2xpcChwYWludEluZm8sIHBoYXNlLCB0eCwgdHkpOwor ICAgICAgICBwb3BDb250ZW50c0NsaXAocGFpbnRJbmZvLCBwaGFzZSwgYWRqdXN0ZWRPZmZzZXQp OwogCiAgICAgLy8gT3VyIHNjcm9sbGJhciB3aWRnZXRzIHBhaW50IGV4YWN0bHkgd2hlbiB3ZSB0 ZWxsIHRoZW0gdG8sIHNvIHRoYXQgdGhleSB3b3JrIHByb3Blcmx5IHdpdGgKICAgICAvLyB6LWlu ZGV4LiAgV2UgcGFpbnQgYWZ0ZXIgd2UgcGFpbnRlZCB0aGUgYmFja2dyb3VuZC9ib3JkZXIsIHNv IHRoYXQgdGhlIHNjcm9sbGJhcnMgd2lsbAogICAgIC8vIHNpdCBhYm92ZSB0aGUgYmFja2dyb3Vu ZC9ib3JkZXIuCiAgICAgaWYgKGhhc092ZXJmbG93Q2xpcCgpICYmIHN0eWxlKCktPnZpc2liaWxp dHkoKSA9PSBWSVNJQkxFICYmIChwaGFzZSA9PSBQYWludFBoYXNlQmxvY2tCYWNrZ3JvdW5kIHx8 IHBoYXNlID09IFBhaW50UGhhc2VDaGlsZEJsb2NrQmFja2dyb3VuZCkgJiYgcGFpbnRJbmZvLnNo b3VsZFBhaW50V2l0aGluUm9vdCh0aGlzKSkKLSAgICAgICAgbGF5ZXIoKS0+cGFpbnRPdmVyZmxv d0NvbnRyb2xzKHBhaW50SW5mby5jb250ZXh0LCBJbnRQb2ludCh0eCwgdHkpLCBwYWludEluZm8u cmVjdCk7CisgICAgICAgIGxheWVyKCktPnBhaW50T3ZlcmZsb3dDb250cm9scyhwYWludEluZm8u Y29udGV4dCwgYWRqdXN0ZWRPZmZzZXQsIHBhaW50SW5mby5yZWN0KTsKIH0KIAogdm9pZCBSZW5k ZXJCbG9jazo6cGFpbnRDb2x1bW5SdWxlcyhQYWludEluZm8mIHBhaW50SW5mbywgaW50IHR4LCBp bnQgdHkpCg== 96148 2011-06-06 16:29:23 -0700 2011-06-06 17:53:28 -0700 Patch for landing bug-62140-20110606162922.patch text/plain 2599 eae SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDg4MTk5KQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTEtMDYtMDYgIEVtaWwgQSBF a2x1bmQgIDxlYWVAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IEVyaWMgU2Vp ZGVsLgorCisgICAgICAgIFVwZGF0ZSBSZW5kZXJCbG9jazo6cGFpbnQgdG8gdXNlIEludFBvaW50 IGludGVybmFsbHkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTYyMTQwCisKKyAgICAgICAgQ292ZXJlZCBieSBleGlzdGluZyB0ZXN0cy4KKworICAgICAg ICAqIHJlbmRlcmluZy9SZW5kZXJCbG9jay5jcHA6CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJC bG9jazo6cGFpbnQpOgorCiAyMDExLTA2LTA2ICBKYW1lcyBTaW1vbnNlbiAgPHNpbW9uamFtQGNo cm9taXVtLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBKYW1lcyBSb2JpbnNvbi4KSW5kZXg6 IFNvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJCbG9jay5jcHAKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g U291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckJsb2NrLmNwcAkocmV2aXNpb24gODgxOTkp CisrKyBTb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyQmxvY2suY3BwCSh3b3JraW5nIGNv cHkpCkBAIC0yMjQwLDggKzIyNDAsNyBAQCB2b2lkIFJlbmRlckJsb2NrOjpyZXBhaW50T3Zlcmhh bmdpbmdGbG9hCiAgCiB2b2lkIFJlbmRlckJsb2NrOjpwYWludChQYWludEluZm8mIHBhaW50SW5m bywgaW50IHR4LCBpbnQgdHkpCiB7Ci0gICAgdHggKz0geCgpOwotICAgIHR5ICs9IHkoKTsKKyAg ICBJbnRQb2ludCBhZGp1c3RlZE9mZnNldCA9IGxvY2F0aW9uKCkgKyBJbnRTaXplKHR4LCB0eSk7 CiAgICAgCiAgICAgUGFpbnRQaGFzZSBwaGFzZSA9IHBhaW50SW5mby5waGFzZTsKIApAQCAtMjI1 MiwyMSArMjI1MSwyMSBAQCB2b2lkIFJlbmRlckJsb2NrOjpwYWludChQYWludEluZm8mIHBhaW50 CiAgICAgICAgIEludFJlY3Qgb3ZlcmZsb3dCb3ggPSB2aXN1YWxPdmVyZmxvd1JlY3QoKTsKICAg ICAgICAgZmxpcEZvcldyaXRpbmdNb2RlKG92ZXJmbG93Qm94KTsKICAgICAgICAgb3ZlcmZsb3dC b3guaW5mbGF0ZShtYXhpbWFsT3V0bGluZVNpemUocGFpbnRJbmZvLnBoYXNlKSk7Ci0gICAgICAg IG92ZXJmbG93Qm94Lm1vdmUodHgsIHR5KTsKKyAgICAgICAgb3ZlcmZsb3dCb3gubW92ZUJ5KGFk anVzdGVkT2Zmc2V0KTsKICAgICAgICAgaWYgKCFvdmVyZmxvd0JveC5pbnRlcnNlY3RzKHBhaW50 SW5mby5yZWN0KSkKICAgICAgICAgICAgIHJldHVybjsKICAgICB9CiAKLSAgICBib29sIHB1c2hl ZENsaXAgPSBwdXNoQ29udGVudHNDbGlwKHBhaW50SW5mbywgSW50UG9pbnQodHgsIHR5KSk7Ci0g ICAgcGFpbnRPYmplY3QocGFpbnRJbmZvLCBJbnRQb2ludCh0eCwgdHkpKTsKKyAgICBib29sIHB1 c2hlZENsaXAgPSBwdXNoQ29udGVudHNDbGlwKHBhaW50SW5mbywgYWRqdXN0ZWRPZmZzZXQpOwor ICAgIHBhaW50T2JqZWN0KHBhaW50SW5mbywgYWRqdXN0ZWRPZmZzZXQpOwogICAgIGlmIChwdXNo ZWRDbGlwKQotICAgICAgICBwb3BDb250ZW50c0NsaXAocGFpbnRJbmZvLCBwaGFzZSwgSW50UG9p bnQodHgsIHR5KSk7CisgICAgICAgIHBvcENvbnRlbnRzQ2xpcChwYWludEluZm8sIHBoYXNlLCBh ZGp1c3RlZE9mZnNldCk7CiAKICAgICAvLyBPdXIgc2Nyb2xsYmFyIHdpZGdldHMgcGFpbnQgZXhh Y3RseSB3aGVuIHdlIHRlbGwgdGhlbSB0bywgc28gdGhhdCB0aGV5IHdvcmsgcHJvcGVybHkgd2l0 aAogICAgIC8vIHotaW5kZXguICBXZSBwYWludCBhZnRlciB3ZSBwYWludGVkIHRoZSBiYWNrZ3Jv dW5kL2JvcmRlciwgc28gdGhhdCB0aGUgc2Nyb2xsYmFycyB3aWxsCiAgICAgLy8gc2l0IGFib3Zl IHRoZSBiYWNrZ3JvdW5kL2JvcmRlci4KICAgICBpZiAoaGFzT3ZlcmZsb3dDbGlwKCkgJiYgc3R5 bGUoKS0+dmlzaWJpbGl0eSgpID09IFZJU0lCTEUgJiYgKHBoYXNlID09IFBhaW50UGhhc2VCbG9j a0JhY2tncm91bmQgfHwgcGhhc2UgPT0gUGFpbnRQaGFzZUNoaWxkQmxvY2tCYWNrZ3JvdW5kKSAm JiBwYWludEluZm8uc2hvdWxkUGFpbnRXaXRoaW5Sb290KHRoaXMpKQotICAgICAgICBsYXllcigp LT5wYWludE92ZXJmbG93Q29udHJvbHMocGFpbnRJbmZvLmNvbnRleHQsIEludFBvaW50KHR4LCB0 eSksIHBhaW50SW5mby5yZWN0KTsKKyAgICAgICAgbGF5ZXIoKS0+cGFpbnRPdmVyZmxvd0NvbnRy b2xzKHBhaW50SW5mby5jb250ZXh0LCBhZGp1c3RlZE9mZnNldCwgcGFpbnRJbmZvLnJlY3QpOwog fQogCiB2b2lkIFJlbmRlckJsb2NrOjpwYWludENvbHVtblJ1bGVzKFBhaW50SW5mbyYgcGFpbnRJ bmZvLCBjb25zdCBJbnRQb2ludCYgcGFpbnRPZmZzZXQpCg==