62133 2011-06-06 10:59:17 -0700 Convert RenderBox::pushContentsClip to IntPoint 2011-06-06 16:05:00 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 60318 62140 1 eae eae ap commit-queue eric leviw simon.fraser webkit.review.bot oldest_to_newest 415899 0 eae 2011-06-06 10:59:17 -0700 Ongoing tx, ty removal. 415955 1 96110 eae 2011-06-06 12:48:16 -0700 Created attachment 96110 Patch 416043 2 commit-queue 2011-06-06 15:08:01 -0700 The commit-queue encountered the following flaky tests while processing attachment 96110: media/video-currentTime-set.html bug 62154 (authors: annacc@chromium.org, jamesr@chromium.org, pnormand@igalia.com, and vrk@chromium.org) http/tests/websocket/tests/frame-length-longer-than-buffer.html bug 61837 (author: abarth@webkit.org) The commit-queue is continuing to process your patch. 416045 3 96110 commit-queue 2011-06-06 15:09:02 -0700 Comment on attachment 96110 Patch Rejecting attachment 96110 from commit-queue. Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=cr-jail-8', 'land-a..." exit_code: 2 Last 500 characters of output: ource/WebCore/rendering/RenderListBox.cpp r88193 = c097f47edbacae18f2bf84fccb808dbe2304b2ff (refs/remotes/trunk) A LayoutTests/platform/chromium-win/fast/inline/inline-wrap-with-parent-padding-expected.png A LayoutTests/platform/chromium-win/fast/inline/inline-wrap-with-parent-padding-expected.txt M LayoutTests/ChangeLog r88194 = 58e12fd9578b5b8483300ca23171b25471a16c04 (refs/remotes/trunk) First, rewinding head to replay your work on top of it... Fast-forwarded master to refs/remotes/trunk. Full output: http://queues.webkit.org/results/8788008 416055 4 96110 webkit.review.bot 2011-06-06 15:14:20 -0700 Comment on attachment 96110 Patch Rejecting attachment 96110 from commit-queue. Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=ec2-cq-01', '--port..." exit_code: 2 Last 500 characters of output: nderBox.cpp patching file Source/WebCore/rendering/RenderBox.h Hunk #1 FAILED at 349. 1 out of 1 hunk FAILED -- saving rejects to file Source/WebCore/rendering/RenderBox.h.rej patching file Source/WebCore/rendering/RenderTable.cpp Hunk #1 succeeded at 467 with fuzz 1. patching file Source/WebCore/rendering/RenderTableSection.cpp Hunk #1 succeeded at 903 with fuzz 1. Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--reviewer', u'Eric Seidel', u'--force']" exit_code: 1 Full output: http://queues.webkit.org/results/8770493 416090 5 eae 2011-06-06 16:04:49 -0700 Landed as revision 88198. 96110 2011-06-06 12:48:16 -0700 2011-06-06 16:05:00 -0700 Patch bug-62133-20110606124815.patch text/plain 5081 eae SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDg4MTc3KQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjIgQEAKKzIwMTEtMDYtMDYgIEVtaWwgQSBF a2x1bmQgIDxlYWVAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIENvbnZlcnQgUmVuZGVyQm94OjpwdXNoQ29udGVudHNDbGlwIHRv IEludFBvaW50CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD02MjEzMworCisgICAgICAgIENvdmVyZWQgYnkgZXhpc3RpbmcgdGVzdHMuCisKKyAgICAgICAg KiByZW5kZXJpbmcvUmVuZGVyQmxvY2suY3BwOgorICAgICAgICAoV2ViQ29yZTo6Q292ZXJlZCBi eSBleGlzdGluZyB0ZXN0cy5SZW5kZXJCbG9jazo6cGFpbnQpOgorICAgICAgICAqIHJlbmRlcmlu Zy9SZW5kZXJCb3guY3BwOgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyQm94OjpwdXNoQ29udGVu dHNDbGlwKToKKyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVyQm94Lmg6CisgICAgICAgICogcmVu ZGVyaW5nL1JlbmRlclRhYmxlLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlclRhYmxlOjpw YWludCk6CisgICAgICAgICogcmVuZGVyaW5nL1JlbmRlclRhYmxlU2VjdGlvbi5jcHA6CisgICAg ICAgIChXZWJDb3JlOjpSZW5kZXJUYWJsZVNlY3Rpb246OnBhaW50KToKKwogMjAxMS0wNi0wNiAg TGV2aSBXZWludHJhdWIgIDxsZXZpd0BjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQg YnkgRXJpYyBTZWlkZWwuCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyQmxv Y2suY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJCbG9j ay5jcHAJKHJldmlzaW9uIDg4MTcxKQorKysgU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRl ckJsb2NrLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMjI1Nyw3ICsyMjU3LDcgQEAgdm9pZCBSZW5k ZXJCbG9jazo6cGFpbnQoUGFpbnRJbmZvJiBwYWludAogICAgICAgICAgICAgcmV0dXJuOwogICAg IH0KIAotICAgIGJvb2wgcHVzaGVkQ2xpcCA9IHB1c2hDb250ZW50c0NsaXAocGFpbnRJbmZvLCB0 eCwgdHkpOworICAgIGJvb2wgcHVzaGVkQ2xpcCA9IHB1c2hDb250ZW50c0NsaXAocGFpbnRJbmZv LCBJbnRQb2ludCh0eCwgdHkpKTsKICAgICBwYWludE9iamVjdChwYWludEluZm8sIEludFBvaW50 KHR4LCB0eSkpOwogICAgIGlmIChwdXNoZWRDbGlwKQogICAgICAgICBwb3BDb250ZW50c0NsaXAo cGFpbnRJbmZvLCBwaGFzZSwgdHgsIHR5KTsKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3JlbmRlcmlu Zy9SZW5kZXJCb3guY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9S ZW5kZXJCb3guY3BwCShyZXZpc2lvbiA4ODE3MSkKKysrIFNvdXJjZS9XZWJDb3JlL3JlbmRlcmlu Zy9SZW5kZXJCb3guY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xMDk2LDcgKzEwOTYsNyBAQCB2b2lk IFJlbmRlckJveDo6cGFpbnRDdXN0b21IaWdobGlnaHQoY29uCiAKICNlbmRpZgogCi1ib29sIFJl bmRlckJveDo6cHVzaENvbnRlbnRzQ2xpcChQYWludEluZm8mIHBhaW50SW5mbywgaW50IHR4LCBp bnQgdHkpCitib29sIFJlbmRlckJveDo6cHVzaENvbnRlbnRzQ2xpcChQYWludEluZm8mIHBhaW50 SW5mbywgY29uc3QgSW50UG9pbnQmIGFjY3VtdWxhdGVkT2Zmc2V0KQogewogICAgIGlmIChwYWlu dEluZm8ucGhhc2UgPT0gUGFpbnRQaGFzZUJsb2NrQmFja2dyb3VuZCB8fCBwYWludEluZm8ucGhh c2UgPT0gUGFpbnRQaGFzZVNlbGZPdXRsaW5lIHx8IHBhaW50SW5mby5waGFzZSA9PSBQYWludFBo YXNlTWFzaykKICAgICAgICAgcmV0dXJuIGZhbHNlOwpAQCAtMTExMSwxMyArMTExMSwxMyBAQCBi b29sIFJlbmRlckJveDo6cHVzaENvbnRlbnRzQ2xpcChQYWludEluCiAgICAgICAgIHBhaW50SW5m by5waGFzZSA9IFBhaW50UGhhc2VDaGlsZE91dGxpbmVzOwogICAgIGVsc2UgaWYgKHBhaW50SW5m by5waGFzZSA9PSBQYWludFBoYXNlQ2hpbGRCbG9ja0JhY2tncm91bmQpIHsKICAgICAgICAgcGFp bnRJbmZvLnBoYXNlID0gUGFpbnRQaGFzZUJsb2NrQmFja2dyb3VuZDsKLSAgICAgICAgcGFpbnRP YmplY3QocGFpbnRJbmZvLCBJbnRQb2ludCh0eCwgdHkpKTsKKyAgICAgICAgcGFpbnRPYmplY3Qo cGFpbnRJbmZvLCBhY2N1bXVsYXRlZE9mZnNldCk7CiAgICAgICAgIHBhaW50SW5mby5waGFzZSA9 IFBhaW50UGhhc2VDaGlsZEJsb2NrQmFja2dyb3VuZHM7CiAgICAgfQotICAgIEludFJlY3QgY2xp cFJlY3QoaXNDb250cm9sQ2xpcCA/IGNvbnRyb2xDbGlwUmVjdChJbnRQb2ludCh0eCwgdHkpKSA6 IG92ZXJmbG93Q2xpcFJlY3QoSW50UG9pbnQodHgsIHR5KSkpOworICAgIEludFJlY3QgY2xpcFJl Y3QoaXNDb250cm9sQ2xpcCA/IGNvbnRyb2xDbGlwUmVjdChhY2N1bXVsYXRlZE9mZnNldCkgOiBv dmVyZmxvd0NsaXBSZWN0KGFjY3VtdWxhdGVkT2Zmc2V0KSk7CiAgICAgcGFpbnRJbmZvLmNvbnRl eHQtPnNhdmUoKTsKICAgICBpZiAoc3R5bGUoKS0+aGFzQm9yZGVyUmFkaXVzKCkpCi0gICAgICAg IHBhaW50SW5mby5jb250ZXh0LT5hZGRSb3VuZGVkUmVjdENsaXAoc3R5bGUoKS0+Z2V0Um91bmRl ZEJvcmRlckZvcihJbnRSZWN0KHR4LCB0eSwgd2lkdGgoKSwgaGVpZ2h0KCkpKSk7CisgICAgICAg IHBhaW50SW5mby5jb250ZXh0LT5hZGRSb3VuZGVkUmVjdENsaXAoc3R5bGUoKS0+Z2V0Um91bmRl ZEJvcmRlckZvcihJbnRSZWN0KGFjY3VtdWxhdGVkT2Zmc2V0LCBzaXplKCkpKSk7CiAgICAgcGFp bnRJbmZvLmNvbnRleHQtPmNsaXAoY2xpcFJlY3QpOwogICAgIHJldHVybiB0cnVlOwogfQpJbmRl eDogU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckJveC5oCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNv dXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJCb3guaAkocmV2aXNpb24gODgxNzEpCisrKyBT b3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyQm94LmgJKHdvcmtpbmcgY29weSkKQEAgLTM0 OSw3ICszNDksNyBAQCBwdWJsaWM6CiAgICAgSW50UmVjdCBjbGlwUmVjdChpbnQgdHgsIGludCB0 eSk7CiAgICAgdmlydHVhbCBib29sIGhhc0NvbnRyb2xDbGlwKCkgY29uc3QgeyByZXR1cm4gZmFs c2U7IH0KICAgICB2aXJ0dWFsIEludFJlY3QgY29udHJvbENsaXBSZWN0KGNvbnN0IEludFBvaW50 JikgY29uc3QgeyByZXR1cm4gSW50UmVjdCgpOyB9Ci0gICAgYm9vbCBwdXNoQ29udGVudHNDbGlw KFBhaW50SW5mbyYsIGludCB0eCwgaW50IHR5KTsKKyAgICBib29sIHB1c2hDb250ZW50c0NsaXAo UGFpbnRJbmZvJiwgY29uc3QgSW50UG9pbnQmIGFjY3VtdWxhdGVkT2Zmc2V0KTsKICAgICB2b2lk IHBvcENvbnRlbnRzQ2xpcChQYWludEluZm8mLCBQYWludFBoYXNlIG9yaWdpbmFsUGhhc2UsIGlu dCB0eCwgaW50IHR5KTsKIAogICAgIHZpcnR1YWwgdm9pZCBwYWludE9iamVjdChQYWludEluZm8m LCBjb25zdCBJbnRQb2ludCYpIHsgQVNTRVJUX05PVF9SRUFDSEVEKCk7IH0KSW5kZXg6IFNvdXJj ZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJUYWJsZS5jcHAKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNl L1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclRhYmxlLmNwcAkocmV2aXNpb24gODgxNzEpCisrKyBT b3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyVGFibGUuY3BwCSh3b3JraW5nIGNvcHkpCkBA IC00NjcsNyArNDY3LDcgQEAgdm9pZCBSZW5kZXJUYWJsZTo6cGFpbnQoUGFpbnRJbmZvJiBwYWlu dAogICAgICAgICAgICAgcmV0dXJuOwogICAgIH0KIAotICAgIGJvb2wgcHVzaGVkQ2xpcCA9IHB1 c2hDb250ZW50c0NsaXAocGFpbnRJbmZvLCB0eCwgdHkpOyAgICAKKyAgICBib29sIHB1c2hlZENs aXAgPSBwdXNoQ29udGVudHNDbGlwKHBhaW50SW5mbywgSW50UG9pbnQodHgsIHR5KSk7CiAgICAg cGFpbnRPYmplY3QocGFpbnRJbmZvLCBJbnRQb2ludCh0eCwgdHkpKTsKICAgICBpZiAocHVzaGVk Q2xpcCkKICAgICAgICAgcG9wQ29udGVudHNDbGlwKHBhaW50SW5mbywgcGFpbnRQaGFzZSwgdHgs IHR5KTsKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJUYWJsZVNlY3Rpb24u Y3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJUYWJsZVNl Y3Rpb24uY3BwCShyZXZpc2lvbiA4ODE3MSkKKysrIFNvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9S ZW5kZXJUYWJsZVNlY3Rpb24uY3BwCSh3b3JraW5nIGNvcHkpCkBAIC05MDMsNyArOTAzLDcgQEAg dm9pZCBSZW5kZXJUYWJsZVNlY3Rpb246OnBhaW50KFBhaW50SW5mbwogICAgIHR5ICs9IHkoKTsK IAogICAgIFBhaW50UGhhc2UgcGhhc2UgPSBwYWludEluZm8ucGhhc2U7Ci0gICAgYm9vbCBwdXNo ZWRDbGlwID0gcHVzaENvbnRlbnRzQ2xpcChwYWludEluZm8sIHR4LCB0eSk7CisgICAgYm9vbCBw dXNoZWRDbGlwID0gcHVzaENvbnRlbnRzQ2xpcChwYWludEluZm8sIEludFBvaW50KHR4LCB0eSkp OwogICAgIHBhaW50T2JqZWN0KHBhaW50SW5mbywgSW50UG9pbnQodHgsIHR5KSk7CiAgICAgaWYg KHB1c2hlZENsaXApCiAgICAgICAgIHBvcENvbnRlbnRzQ2xpcChwYWludEluZm8sIHBoYXNlLCB0 eCwgdHkpOwo=