62059 2011-06-03 15:14:13 -0700 Switch paintSelection to use IntPoint 2011-06-06 13:42:50 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 60318 1 leviw leviw darin eae eric simon.fraser oldest_to_newest 415234 0 leviw 2011-06-03 15:14:13 -0700 Ongoing tx/ty removal. 415235 1 95974 leviw 2011-06-03 15:16:19 -0700 Created attachment 95974 Patch 415241 2 95974 eric 2011-06-03 15:37:04 -0700 Comment on attachment 95974 Patch LGTM. 415981 3 leviw 2011-06-06 13:42:18 -0700 Committed r88186: <http://trac.webkit.org/changeset/88186> 415982 4 95974 leviw 2011-06-06 13:42:50 -0700 Comment on attachment 95974 Patch Clearing flags. 95974 2011-06-03 15:16:19 -0700 2011-06-06 13:42:50 -0700 Patch bug-62059-20110603151618.patch text/plain 6806 leviw SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDg4MDY4KQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjQgQEAKKzIwMTEtMDYtMDMgIExldmkgV2Vp bnRyYXViICA8bGV2aXdAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIFN3aXRjaCBwYWludFNlbGVjdGlvbiB0byB1c2UgSW50UG9p bnQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTYyMDU5 CisKKyAgICAgICAgU3dpdGNoaW5nIHBhaW50U2VsZWN0aW9uIHRvIHVzZSBhbiBJbnRQb2ludCB0 byByZXByZXNlbnQgdGhlIHBhaW50IG9mZnNldAorICAgICAgICBpbnN0ZWFkIG9mIGEgcGFpciBv ZiBpbnRzLgorCisgICAgICAgIE5vIG5ldyB0ZXN0cyBzaW5jZSB0aGlzIGlzIHNpbXBsZSByZWZh Y3RvcmluZy4KKworICAgICAgICAqIHJlbmRlcmluZy9FbGxpcHNpc0JveC5jcHA6CisgICAgICAg IChXZWJDb3JlOjpFbGxpcHNpc0JveDo6cGFpbnQpOgorICAgICAgICAoV2ViQ29yZTo6RWxsaXBz aXNCb3g6OnBhaW50U2VsZWN0aW9uKToKKyAgICAgICAgKiByZW5kZXJpbmcvRWxsaXBzaXNCb3gu aDoKKyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVyQmxvY2suY3BwOgorICAgICAgICAoV2ViQ29y ZTo6UmVuZGVyQmxvY2s6OnBhaW50T2JqZWN0KToKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlckJs b2NrOjpwYWludFNlbGVjdGlvbik6CisgICAgICAgICogcmVuZGVyaW5nL1JlbmRlckJsb2NrLmg6 CisKIDIwMTEtMDUtMzEgIE1hcnRpbiBSb2JpbnNvbiAgPG1yb2JpbnNvbkBpZ2FsaWEuY29tPgog CiAgICAgICAgIFJldmlld2VkIGJ5IFJ5b3N1a2UgTml3YS4KSW5kZXg6IFNvdXJjZS9XZWJDb3Jl L3JlbmRlcmluZy9FbGxpcHNpc0JveC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUv cmVuZGVyaW5nL0VsbGlwc2lzQm94LmNwcAkocmV2aXNpb24gODgwNTIpCisrKyBTb3VyY2UvV2Vi Q29yZS9yZW5kZXJpbmcvRWxsaXBzaXNCb3guY3BwCSh3b3JraW5nIGNvcHkpCkBAIC00Niw3ICs0 Niw3IEBAIHZvaWQgRWxsaXBzaXNCb3g6OnBhaW50KFBhaW50SW5mbyYgcGFpbnQKIAogICAgIGNv bnN0IEZvbnQmIGZvbnQgPSBzdHlsZS0+Zm9udCgpOwogICAgIGlmIChzZWxlY3Rpb25TdGF0ZSgp ICE9IFJlbmRlck9iamVjdDo6U2VsZWN0aW9uTm9uZSkgewotICAgICAgICBwYWludFNlbGVjdGlv bihjb250ZXh0LCBwYWludE9mZnNldC54KCksIHBhaW50T2Zmc2V0LnkoKSwgc3R5bGUsIGZvbnQp OworICAgICAgICBwYWludFNlbGVjdGlvbihjb250ZXh0LCBwYWludE9mZnNldCwgc3R5bGUsIGZv bnQpOwogCiAgICAgICAgIC8vIFNlbGVjdCB0aGUgY29ycmVjdCBjb2xvciBmb3IgcGFpbnRpbmcg dGhlIHRleHQuCiAgICAgICAgIENvbG9yIGZvcmVncm91bmQgPSBwYWludEluZm8uZm9yY2VCbGFj a1RleHQgPyBDb2xvcjo6YmxhY2sgOiByZW5kZXJlcigpLT5zZWxlY3Rpb25Gb3JlZ3JvdW5kQ29s b3IoKTsKQEAgLTgxLDcgKzgxLDcgQEAgSW50UmVjdCBFbGxpcHNpc0JveDo6c2VsZWN0aW9uUmVj dChpbnQgdAogICAgIHJldHVybiBlbmNsb3NpbmdJbnRSZWN0KGZvbnQuc2VsZWN0aW9uUmVjdEZv clRleHQoUmVuZGVyQmxvY2s6OmNvbnN0cnVjdFRleHRSdW4ocmVuZGVyZXIoKSwgZm9udCwgbV9z dHIsIHN0eWxlLCBUZXh0UnVuOjpBbGxvd1RyYWlsaW5nRXhwYW5zaW9uKSwgSW50UG9pbnQoeCgp ICsgdHgsIHkoKSArIHR5ICsgcm9vdCgpLT5zZWxlY3Rpb25Ub3AoKSksIHJvb3QoKS0+c2VsZWN0 aW9uSGVpZ2h0KCkpKTsKIH0KIAotdm9pZCBFbGxpcHNpc0JveDo6cGFpbnRTZWxlY3Rpb24oR3Jh cGhpY3NDb250ZXh0KiBjb250ZXh0LCBpbnQgdHgsIGludCB0eSwgUmVuZGVyU3R5bGUqIHN0eWxl LCBjb25zdCBGb250JiBmb250KQordm9pZCBFbGxpcHNpc0JveDo6cGFpbnRTZWxlY3Rpb24oR3Jh cGhpY3NDb250ZXh0KiBjb250ZXh0LCBjb25zdCBJbnRQb2ludCYgcGFpbnRPZmZzZXQsIFJlbmRl clN0eWxlKiBzdHlsZSwgY29uc3QgRm9udCYgZm9udCkKIHsKICAgICBDb2xvciB0ZXh0Q29sb3Ig PSBzdHlsZS0+dmlzaXRlZERlcGVuZGVudENvbG9yKENTU1Byb3BlcnR5Q29sb3IpOwogICAgIENv bG9yIGMgPSBtX3JlbmRlcmVyLT5zZWxlY3Rpb25CYWNrZ3JvdW5kQ29sb3IoKTsKQEAgLTk2LDkg Kzk2LDkgQEAgdm9pZCBFbGxpcHNpc0JveDo6cGFpbnRTZWxlY3Rpb24oR3JhcGhpYwogICAgIEdy YXBoaWNzQ29udGV4dFN0YXRlU2F2ZXIgc3RhdGVTYXZlcigqY29udGV4dCk7CiAgICAgaW50IHRv cCA9IHJvb3QoKS0+c2VsZWN0aW9uVG9wKCk7CiAgICAgaW50IGggPSByb290KCktPnNlbGVjdGlv bkhlaWdodCgpOwotICAgIGNvbnRleHQtPmNsaXAoSW50UmVjdCh4KCkgKyB0eCwgdG9wICsgdHks IG1fbG9naWNhbFdpZHRoLCBoKSk7CisgICAgY29udGV4dC0+Y2xpcChJbnRSZWN0KHgoKSArIHBh aW50T2Zmc2V0LngoKSwgdG9wICsgcGFpbnRPZmZzZXQueSgpLCBtX2xvZ2ljYWxXaWR0aCwgaCkp OwogICAgIC8vIEZJWE1FOiBXaHkgaXMgdGhpcyBhbHdheXMgTFRSPyBGaXggYnkgcGFzc2luZyBj b3JyZWN0IHRleHQgcnVuIGZsYWdzIGJlbG93LgotICAgIGNvbnRleHQtPmRyYXdIaWdobGlnaHRG b3JUZXh0KGZvbnQsIFJlbmRlckJsb2NrOjpjb25zdHJ1Y3RUZXh0UnVuKHJlbmRlcmVyKCksIGZv bnQsIG1fc3RyLCBzdHlsZSwgVGV4dFJ1bjo6QWxsb3dUcmFpbGluZ0V4cGFuc2lvbiksIEludFBv aW50KHgoKSArIHR4LCB5KCkgKyB0eSArIHRvcCksIGgsIGMsIHN0eWxlLT5jb2xvclNwYWNlKCkp OworICAgIGNvbnRleHQtPmRyYXdIaWdobGlnaHRGb3JUZXh0KGZvbnQsIFJlbmRlckJsb2NrOjpj b25zdHJ1Y3RUZXh0UnVuKHJlbmRlcmVyKCksIGZvbnQsIG1fc3RyLCBzdHlsZSwgVGV4dFJ1bjo6 QWxsb3dUcmFpbGluZ0V4cGFuc2lvbiksIEludFBvaW50KHgoKSArIHBhaW50T2Zmc2V0LngoKSwg eSgpICsgcGFpbnRPZmZzZXQueSgpICsgdG9wKSwgaCwgYywgc3R5bGUtPmNvbG9yU3BhY2UoKSk7 CiB9CiAKIGJvb2wgRWxsaXBzaXNCb3g6Om5vZGVBdFBvaW50KGNvbnN0IEhpdFRlc3RSZXF1ZXN0 JiByZXF1ZXN0LCBIaXRUZXN0UmVzdWx0JiByZXN1bHQsIGNvbnN0IEludFBvaW50JiBwb2ludElu Q29udGFpbmVyLCBpbnQgdHgsIGludCB0eSwgaW50IGxpbmVUb3AsIGludCBsaW5lQm90dG9tKQpJ bmRleDogU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL0VsbGlwc2lzQm94LmgKPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot LS0gU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL0VsbGlwc2lzQm94LmgJKHJldmlzaW9uIDg4MDUy KQorKysgU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL0VsbGlwc2lzQm94LmgJKHdvcmtpbmcgY29w eSkKQEAgLTQ3LDcgKzQ3LDcgQEAgcHVibGljOgogcHJpdmF0ZToKICAgICB2aXJ0dWFsIGludCBo ZWlnaHQoKSBjb25zdCB7IHJldHVybiBtX2hlaWdodDsgfQogICAgIHZpcnR1YWwgUmVuZGVyT2Jq ZWN0OjpTZWxlY3Rpb25TdGF0ZSBzZWxlY3Rpb25TdGF0ZSgpIHsgcmV0dXJuIG1fc2VsZWN0aW9u U3RhdGU7IH0KLSAgICB2b2lkIHBhaW50U2VsZWN0aW9uKEdyYXBoaWNzQ29udGV4dCosIGludCB0 eCwgaW50IHR5LCBSZW5kZXJTdHlsZSosIGNvbnN0IEZvbnQmKTsKKyAgICB2b2lkIHBhaW50U2Vs ZWN0aW9uKEdyYXBoaWNzQ29udGV4dCosIGNvbnN0IEludFBvaW50JiwgUmVuZGVyU3R5bGUqLCBj b25zdCBGb250Jik7CiAKICAgICBpbnQgbV9oZWlnaHQ7CiAgICAgQXRvbWljU3RyaW5nIG1fc3Ry OwpJbmRleDogU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckJsb2NrLmNwcAo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyQmxvY2suY3BwCShyZXZpc2lv biA4ODA1MikKKysrIFNvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJCbG9jay5jcHAJKHdv cmtpbmcgY29weSkKQEAgLTI1MDAsNyArMjUwMCw3IEBAIHZvaWQgUmVuZGVyQmxvY2s6OnBhaW50 T2JqZWN0KFBhaW50SW5mbyYKICAgICAvLyBGSVhNRTogTWFrZSB0aGlzIHdvcmsgd2l0aCBtdWx0 aSBjb2x1bW4gbGF5b3V0cy4gIEZvciBub3cgZG9uJ3QgZmlsbCBnYXBzLgogICAgIGJvb2wgaXNQ cmludGluZyA9IGRvY3VtZW50KCktPnByaW50aW5nKCk7CiAgICAgaWYgKCFpc1ByaW50aW5nICYm ICFoYXNDb2x1bW5zKCkpCi0gICAgICAgIHBhaW50U2VsZWN0aW9uKHBhaW50SW5mbywgc2Nyb2xs ZWRYLCBzY3JvbGxlZFkpOyAvLyBGaWxsIGluIGdhcHMgaW4gc2VsZWN0aW9uIG9uIGxpbmVzIGFu ZCBiZXR3ZWVuIGJsb2Nrcy4KKyAgICAgICAgcGFpbnRTZWxlY3Rpb24ocGFpbnRJbmZvLCBJbnRQ b2ludChzY3JvbGxlZFgsIHNjcm9sbGVkWSkpOyAvLyBGaWxsIGluIGdhcHMgaW4gc2VsZWN0aW9u IG9uIGxpbmVzIGFuZCBiZXR3ZWVuIGJsb2Nrcy4KIAogICAgIC8vIDQuIHBhaW50IGZsb2F0cy4K ICAgICBpZiAocGFpbnRQaGFzZSA9PSBQYWludFBoYXNlRmxvYXQgfHwgcGFpbnRQaGFzZSA9PSBQ YWludFBoYXNlU2VsZWN0aW9uIHx8IHBhaW50UGhhc2UgPT0gUGFpbnRQaGFzZVRleHRDbGlwKSB7 CkBAIC0yNzQ1LDcgKzI3NDUsNyBAQCBHYXBSZWN0cyBSZW5kZXJCbG9jazo6c2VsZWN0aW9uR2Fw UmVjdHNGCiAgICAgcmV0dXJuIHNlbGVjdGlvbkdhcHModGhpcywgb2Zmc2V0RnJvbVJlcGFpbnRD b250YWluZXIsIEludFNpemUoKSwgbGFzdFRvcCwgbGFzdExlZnQsIGxhc3RSaWdodCk7CiB9CiAK LXZvaWQgUmVuZGVyQmxvY2s6OnBhaW50U2VsZWN0aW9uKFBhaW50SW5mbyYgcGFpbnRJbmZvLCBp bnQgdHgsIGludCB0eSkKK3ZvaWQgUmVuZGVyQmxvY2s6OnBhaW50U2VsZWN0aW9uKFBhaW50SW5m byYgcGFpbnRJbmZvLCBjb25zdCBJbnRQb2ludCYgcGFpbnRPZmZzZXQpCiB7CiAgICAgaWYgKHNo b3VsZFBhaW50U2VsZWN0aW9uR2FwcygpICYmIHBhaW50SW5mby5waGFzZSA9PSBQYWludFBoYXNl Rm9yZWdyb3VuZCkgewogICAgICAgICBpbnQgbGFzdFRvcCA9IDA7CkBAIC0yNzUzLDEwICsyNzUz LDEwIEBAIHZvaWQgUmVuZGVyQmxvY2s6OnBhaW50U2VsZWN0aW9uKFBhaW50SW4KICAgICAgICAg aW50IGxhc3RSaWdodCA9IGxvZ2ljYWxSaWdodFNlbGVjdGlvbk9mZnNldCh0aGlzLCBsYXN0VG9w KTsKICAgICAgICAgR3JhcGhpY3NDb250ZXh0U3RhdGVTYXZlciBzdGF0ZVNhdmVyKCpwYWludElu Zm8uY29udGV4dCk7CiAKLSAgICAgICAgSW50UmVjdCBnYXBSZWN0c0JvdW5kcyA9IHNlbGVjdGlv bkdhcHModGhpcywgSW50UG9pbnQodHgsIHR5KSwgSW50U2l6ZSgpLCBsYXN0VG9wLCBsYXN0TGVm dCwgbGFzdFJpZ2h0LCAmcGFpbnRJbmZvKTsKKyAgICAgICAgSW50UmVjdCBnYXBSZWN0c0JvdW5k cyA9IHNlbGVjdGlvbkdhcHModGhpcywgcGFpbnRPZmZzZXQsIEludFNpemUoKSwgbGFzdFRvcCwg bGFzdExlZnQsIGxhc3RSaWdodCwgJnBhaW50SW5mbyk7CiAgICAgICAgIGlmICghZ2FwUmVjdHNC b3VuZHMuaXNFbXB0eSgpKSB7CiAgICAgICAgICAgICBpZiAoUmVuZGVyTGF5ZXIqIGxheWVyID0g ZW5jbG9zaW5nTGF5ZXIoKSkgewotICAgICAgICAgICAgICAgIGdhcFJlY3RzQm91bmRzLm1vdmUo SW50U2l6ZSgtdHgsIC10eSkpOworICAgICAgICAgICAgICAgIGdhcFJlY3RzQm91bmRzLm1vdmVC eSgtcGFpbnRPZmZzZXQpOwogICAgICAgICAgICAgICAgIGlmICghaGFzTGF5ZXIoKSkgewogICAg ICAgICAgICAgICAgICAgICBJbnRSZWN0IGxvY2FsQm91bmRzKGdhcFJlY3RzQm91bmRzKTsKICAg ICAgICAgICAgICAgICAgICAgZmxpcEZvcldyaXRpbmdNb2RlKGxvY2FsQm91bmRzKTsKSW5kZXg6 IFNvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJCbG9jay5oCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNv dXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJCbG9jay5oCShyZXZpc2lvbiA4ODA1MikKKysr IFNvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJCbG9jay5oCSh3b3JraW5nIGNvcHkpCkBA IC01NjUsNyArNTY1LDcgQEAgcHJpdmF0ZToKICAgICB2b2lkIHBhaW50Q29sdW1uUnVsZXMoUGFp bnRJbmZvJiwgaW50IHR4LCBpbnQgdHkpOwogICAgIHZvaWQgcGFpbnRDaGlsZHJlbihQYWludElu Zm8mLCBpbnQgdHgsIGludCB0eSk7CiAgICAgdm9pZCBwYWludEVsbGlwc2lzQm94ZXMoUGFpbnRJ bmZvJiwgaW50IHR4LCBpbnQgdHkpOwotICAgIHZvaWQgcGFpbnRTZWxlY3Rpb24oUGFpbnRJbmZv JiwgaW50IHR4LCBpbnQgdHkpOworICAgIHZvaWQgcGFpbnRTZWxlY3Rpb24oUGFpbnRJbmZvJiwg Y29uc3QgSW50UG9pbnQmKTsKICAgICB2b2lkIHBhaW50Q2FyZXQoUGFpbnRJbmZvJiwgY29uc3Qg SW50UG9pbnQmLCBDYXJldFR5cGUpOwogCiAgICAgRmxvYXRpbmdPYmplY3QqIGluc2VydEZsb2F0 aW5nT2JqZWN0KFJlbmRlckJveCopOwo=