62031 2011-06-03 11:26:17 -0700 Switch paintBackgroundsBehindCell to use IntPoint 2011-06-03 13:59:46 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 60318 62033 1 leviw leviw darin eae eric simon.fraser oldest_to_newest 415023 0 leviw 2011-06-03 11:26:17 -0700 Ongoing tx/ty removal. 415047 1 95936 leviw 2011-06-03 11:48:56 -0700 Created attachment 95936 Patch 415156 2 95936 leviw 2011-06-03 13:59:43 -0700 Comment on attachment 95936 Patch Clearing flags on attachment: 95936 Committed r88051: <http://trac.webkit.org/changeset/88051> 415157 3 leviw 2011-06-03 13:59:46 -0700 All reviewed patches have been landed. Closing bug. 95936 2011-06-03 11:48:56 -0700 2011-06-03 13:59:43 -0700 Patch bug-62031-20110603114855.patch text/plain 6843 leviw SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDg4MDMzKQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjQgQEAKKzIwMTEtMDYtMDMgIExldmkgV2Vp bnRyYXViICA8bGV2aXdAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIFN3aXRjaCBwYWludEJhY2tncm91bmRzQmVoaW5kQ2VsbCB0 byB1c2UgSW50UG9pbnQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTYyMDMxCisKKyAgICAgICAgU3dpdGNoaW5nIHBhaW50QmFja2dyb3VuZHNCZWhpbmRD ZWxsIHRvIHRha2UgYW4gSW50UG9pbnQgcmVwcmVzZW50aW5nCisgICAgICAgIHRoZSBwYWludCBv ZmZzZXQgaW5zdGVhZCBvZiBhIHBhaXIgb2YgaW50cy4KKworICAgICAgICBObyBuZXcgdGVzdHMg YXMgdGhpcyBpcyBzaW1wbGUgcmVmYWN0b3JpbmcuCisKKyAgICAgICAgKiByZW5kZXJpbmcvUmVu ZGVyVGFibGVDZWxsLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlclRhYmxlQ2VsbDo6cGFp bnRCYWNrZ3JvdW5kc0JlaGluZENlbGwpOgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyVGFibGVD ZWxsOjpwYWludEJveERlY29yYXRpb25zKToKKyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVyVGFi bGVDZWxsLmg6CisgICAgICAgICogcmVuZGVyaW5nL1JlbmRlclRhYmxlUm93LmNwcDoKKyAgICAg ICAgKFdlYkNvcmU6OlJlbmRlclRhYmxlUm93OjpwYWludCk6CisgICAgICAgICogcmVuZGVyaW5n L1JlbmRlclRhYmxlU2VjdGlvbi5jcHA6CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJUYWJsZVNl Y3Rpb246OnBhaW50Q2VsbCk6CisKIDIwMTEtMDYtMDMgIExldmkgV2VpbnRyYXViICA8bGV2aXdA Y2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEVyaWMgU2VpZGVsLgpJbmRleDog U291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclRhYmxlQ2VsbC5jcHAKPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot LS0gU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclRhYmxlQ2VsbC5jcHAJKHJldmlzaW9u IDg4MDMzKQorKysgU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclRhYmxlQ2VsbC5jcHAJ KHdvcmtpbmcgY29weSkKQEAgLTk2MSw3ICs5NjEsNyBAQCB2b2lkIFJlbmRlclRhYmxlQ2VsbDo6 cGFpbnRDb2xsYXBzZWRCb3JkCiAgICAgfQogfQogCi12b2lkIFJlbmRlclRhYmxlQ2VsbDo6cGFp bnRCYWNrZ3JvdW5kc0JlaGluZENlbGwoUGFpbnRJbmZvJiBwYWludEluZm8sIGludCB0eCwgaW50 IHR5LCBSZW5kZXJPYmplY3QqIGJhY2tncm91bmRPYmplY3QpCit2b2lkIFJlbmRlclRhYmxlQ2Vs bDo6cGFpbnRCYWNrZ3JvdW5kc0JlaGluZENlbGwoUGFpbnRJbmZvJiBwYWludEluZm8sIGNvbnN0 IEludFBvaW50JiBwYWludE9mZnNldCwgUmVuZGVyT2JqZWN0KiBiYWNrZ3JvdW5kT2JqZWN0KQog ewogICAgIGlmICghcGFpbnRJbmZvLnNob3VsZFBhaW50V2l0aGluUm9vdCh0aGlzKSkKICAgICAg ICAgcmV0dXJuOwpAQCAtOTc2LDEzICs5NzYsOSBAQCB2b2lkIFJlbmRlclRhYmxlQ2VsbDo6cGFp bnRCYWNrZ3JvdW5kc0JlCiAgICAgaWYgKCF0YWJsZUVsdC0+Y29sbGFwc2VCb3JkZXJzKCkgJiYg c3R5bGUoKS0+ZW1wdHlDZWxscygpID09IEhJREUgJiYgIWZpcnN0Q2hpbGQoKSkKICAgICAgICAg cmV0dXJuOwogCi0gICAgaWYgKGJhY2tncm91bmRPYmplY3QgIT0gdGhpcykgewotICAgICAgICB0 eCArPSB4KCk7Ci0gICAgICAgIHR5ICs9IHkoKTsKLSAgICB9Ci0KLSAgICBpbnQgdyA9IHdpZHRo KCk7Ci0gICAgaW50IGggPSBoZWlnaHQoKTsKKyAgICBJbnRQb2ludCBhZGp1c3RlZFBhaW50T2Zm c2V0ID0gcGFpbnRPZmZzZXQ7CisgICAgaWYgKGJhY2tncm91bmRPYmplY3QgIT0gdGhpcykKKyAg ICAgICAgYWRqdXN0ZWRQYWludE9mZnNldC5tb3ZlKGxvY2F0aW9uKCkpOwogCiAgICAgQ29sb3Ig YyA9IGJhY2tncm91bmRPYmplY3QtPnN0eWxlKCktPnZpc2l0ZWREZXBlbmRlbnRDb2xvcihDU1NQ cm9wZXJ0eUJhY2tncm91bmRDb2xvcik7CiAgICAgY29uc3QgRmlsbExheWVyKiBiZ0xheWVyID0g YmFja2dyb3VuZE9iamVjdC0+c3R5bGUoKS0+YmFja2dyb3VuZExheWVycygpOwpAQCAtOTkzLDEx ICs5ODksMTEgQEAgdm9pZCBSZW5kZXJUYWJsZUNlbGw6OnBhaW50QmFja2dyb3VuZHNCZQogICAg ICAgICBib29sIHNob3VsZENsaXAgPSBiYWNrZ3JvdW5kT2JqZWN0LT5oYXNMYXllcigpICYmIChi YWNrZ3JvdW5kT2JqZWN0ID09IHRoaXMgfHwgYmFja2dyb3VuZE9iamVjdCA9PSBwYXJlbnQoKSkg JiYgdGFibGVFbHQtPmNvbGxhcHNlQm9yZGVycygpOwogICAgICAgICBHcmFwaGljc0NvbnRleHRT dGF0ZVNhdmVyIHN0YXRlU2F2ZXIoKnBhaW50SW5mby5jb250ZXh0LCBzaG91bGRDbGlwKTsKICAg ICAgICAgaWYgKHNob3VsZENsaXApIHsKLSAgICAgICAgICAgIEludFJlY3QgY2xpcFJlY3QodHgg KyBib3JkZXJMZWZ0KCksIHR5ICsgYm9yZGVyVG9wKCksCi0gICAgICAgICAgICAgICAgdyAtIGJv cmRlckxlZnQoKSAtIGJvcmRlclJpZ2h0KCksIGggLSBib3JkZXJUb3AoKSAtIGJvcmRlckJvdHRv bSgpKTsKKyAgICAgICAgICAgIEludFJlY3QgY2xpcFJlY3QoYWRqdXN0ZWRQYWludE9mZnNldC54 KCkgKyBib3JkZXJMZWZ0KCksIGFkanVzdGVkUGFpbnRPZmZzZXQueSgpICsgYm9yZGVyVG9wKCks CisgICAgICAgICAgICAgICAgd2lkdGgoKSAtIGJvcmRlckxlZnQoKSAtIGJvcmRlclJpZ2h0KCks IGhlaWdodCgpIC0gYm9yZGVyVG9wKCkgLSBib3JkZXJCb3R0b20oKSk7CiAgICAgICAgICAgICBw YWludEluZm8uY29udGV4dC0+Y2xpcChjbGlwUmVjdCk7CiAgICAgICAgIH0KLSAgICAgICAgcGFp bnRGaWxsTGF5ZXJzKHBhaW50SW5mbywgYywgYmdMYXllciwgSW50UmVjdCh0eCwgdHksIHcsIGgp LCBCYWNrZ3JvdW5kQmxlZWROb25lLCBDb21wb3NpdGVTb3VyY2VPdmVyLCBiYWNrZ3JvdW5kT2Jq ZWN0KTsKKyAgICAgICAgcGFpbnRGaWxsTGF5ZXJzKHBhaW50SW5mbywgYywgYmdMYXllciwgSW50 UmVjdChhZGp1c3RlZFBhaW50T2Zmc2V0LCBzaXplKCkpLCBCYWNrZ3JvdW5kQmxlZWROb25lLCBD b21wb3NpdGVTb3VyY2VPdmVyLCBiYWNrZ3JvdW5kT2JqZWN0KTsKICAgICB9CiB9CiAKQEAgLTEw MTQsNyArMTAxMCw3IEBAIHZvaWQgUmVuZGVyVGFibGVDZWxsOjpwYWludEJveERlY29yYXRpb24K ICAgICBwYWludEJveFNoYWRvdyhwYWludEluZm8uY29udGV4dCwgcGFpbnRSZWN0LCBzdHlsZSgp LCBOb3JtYWwpOwogICAgIAogICAgIC8vIFBhaW50IG91ciBjZWxsIGJhY2tncm91bmQuCi0gICAg cGFpbnRCYWNrZ3JvdW5kc0JlaGluZENlbGwocGFpbnRJbmZvLCBwYWludE9mZnNldC54KCksIHBh aW50T2Zmc2V0LnkoKSwgdGhpcyk7CisgICAgcGFpbnRCYWNrZ3JvdW5kc0JlaGluZENlbGwocGFp bnRJbmZvLCBwYWludE9mZnNldCwgdGhpcyk7CiAKICAgICBwYWludEJveFNoYWRvdyhwYWludElu Zm8uY29udGV4dCwgcGFpbnRSZWN0LCBzdHlsZSgpLCBJbnNldCk7CiAKSW5kZXg6IFNvdXJjZS9X ZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJUYWJsZUNlbGwuaAo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2Uv V2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyVGFibGVDZWxsLmgJKHJldmlzaW9uIDg4MDMzKQorKysg U291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclRhYmxlQ2VsbC5oCSh3b3JraW5nIGNvcHkp CkBAIC05Niw3ICs5Niw3IEBAIHB1YmxpYzoKIAogICAgIHZpcnR1YWwgdm9pZCBwYWludChQYWlu dEluZm8mLCBpbnQgdHgsIGludCB0eSk7CiAKLSAgICB2b2lkIHBhaW50QmFja2dyb3VuZHNCZWhp bmRDZWxsKFBhaW50SW5mbyYsIGludCB0eCwgaW50IHR5LCBSZW5kZXJPYmplY3QqIGJhY2tncm91 bmRPYmplY3QpOworICAgIHZvaWQgcGFpbnRCYWNrZ3JvdW5kc0JlaGluZENlbGwoUGFpbnRJbmZv JiwgY29uc3QgSW50UG9pbnQmLCBSZW5kZXJPYmplY3QqIGJhY2tncm91bmRPYmplY3QpOwogCiAg ICAgaW50IGNlbGxCYXNlbGluZVBvc2l0aW9uKCkgY29uc3Q7CiAKSW5kZXg6IFNvdXJjZS9XZWJD b3JlL3JlbmRlcmluZy9SZW5kZXJUYWJsZVJvdy5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dl YkNvcmUvcmVuZGVyaW5nL1JlbmRlclRhYmxlUm93LmNwcAkocmV2aXNpb24gODgwMzMpCisrKyBT b3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyVGFibGVSb3cuY3BwCSh3b3JraW5nIGNvcHkp CkBAIC0yMTgsNyArMjE4LDcgQEAgdm9pZCBSZW5kZXJUYWJsZVJvdzo6cGFpbnQoUGFpbnRJbmZv JiBwYQogICAgICAgICAgICAgLy8gUGFpbnQgdGhlIHJvdyBiYWNrZ3JvdW5kIGJlaGluZCB0aGUg Y2VsbC4KICAgICAgICAgICAgIGlmIChwYWludEluZm8ucGhhc2UgPT0gUGFpbnRQaGFzZUJsb2Nr QmFja2dyb3VuZCB8fCBwYWludEluZm8ucGhhc2UgPT0gUGFpbnRQaGFzZUNoaWxkQmxvY2tCYWNr Z3JvdW5kKSB7CiAgICAgICAgICAgICAgICAgUmVuZGVyVGFibGVDZWxsKiBjZWxsID0gdG9SZW5k ZXJUYWJsZUNlbGwoY2hpbGQpOwotICAgICAgICAgICAgICAgIGNlbGwtPnBhaW50QmFja2dyb3Vu ZHNCZWhpbmRDZWxsKHBhaW50SW5mbywgdHgsIHR5LCB0aGlzKTsKKyAgICAgICAgICAgICAgICBj ZWxsLT5wYWludEJhY2tncm91bmRzQmVoaW5kQ2VsbChwYWludEluZm8sIEludFBvaW50KHR4LCB0 eSksIHRoaXMpOwogICAgICAgICAgICAgfQogICAgICAgICAgICAgaWYgKCF0b1JlbmRlckJveChj aGlsZCktPmhhc1NlbGZQYWludGluZ0xheWVyKCkpCiAgICAgICAgICAgICAgICAgY2hpbGQtPnBh aW50KHBhaW50SW5mbywgdHgsIHR5KTsKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9S ZW5kZXJUYWJsZVNlY3Rpb24uY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3JlbmRl cmluZy9SZW5kZXJUYWJsZVNlY3Rpb24uY3BwCShyZXZpc2lvbiA4ODAzMykKKysrIFNvdXJjZS9X ZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJUYWJsZVNlY3Rpb24uY3BwCSh3b3JraW5nIGNvcHkpCkBA IC05MzMsMTYgKzkzMywxNiBAQCB2b2lkIFJlbmRlclRhYmxlU2VjdGlvbjo6cGFpbnRDZWxsKFJl bmRlCiAgICAgICAgIC8vIHRoZSBzdGFjaywgc2luY2Ugd2UgaGF2ZSBhbHJlYWR5IG9wZW5lZCBh IHRyYW5zcGFyZW5jeSBsYXllciAocG90ZW50aWFsbHkpIGZvciB0aGUgdGFibGUgcm93IGdyb3Vw LgogICAgICAgICAvLyBOb3RlIHRoYXQgd2UgZGVsaWJlcmF0ZWx5IGlnbm9yZSB3aGV0aGVyIG9y IG5vdCB0aGUgY2VsbCBoYXMgYSBsYXllciwgc2luY2UgdGhlc2UgYmFja2dyb3VuZHMgcGFpbnQg ImJlaGluZCIgdGhlCiAgICAgICAgIC8vIGNlbGwuCi0gICAgICAgIGNlbGwtPnBhaW50QmFja2dy b3VuZHNCZWhpbmRDZWxsKHBhaW50SW5mbywgY2VsbFBvaW50LngoKSwgY2VsbFBvaW50LnkoKSwg Y29sR3JvdXApOwotICAgICAgICBjZWxsLT5wYWludEJhY2tncm91bmRzQmVoaW5kQ2VsbChwYWlu dEluZm8sIGNlbGxQb2ludC54KCksIGNlbGxQb2ludC55KCksIGNvbCk7CisgICAgICAgIGNlbGwt PnBhaW50QmFja2dyb3VuZHNCZWhpbmRDZWxsKHBhaW50SW5mbywgY2VsbFBvaW50LCBjb2xHcm91 cCk7CisgICAgICAgIGNlbGwtPnBhaW50QmFja2dyb3VuZHNCZWhpbmRDZWxsKHBhaW50SW5mbywg Y2VsbFBvaW50LCBjb2wpOwogCiAgICAgICAgIC8vIFBhaW50IHRoZSByb3cgZ3JvdXAgbmV4dC4K LSAgICAgICAgY2VsbC0+cGFpbnRCYWNrZ3JvdW5kc0JlaGluZENlbGwocGFpbnRJbmZvLCBjZWxs UG9pbnQueCgpLCBjZWxsUG9pbnQueSgpLCB0aGlzKTsKKyAgICAgICAgY2VsbC0+cGFpbnRCYWNr Z3JvdW5kc0JlaGluZENlbGwocGFpbnRJbmZvLCBjZWxsUG9pbnQsIHRoaXMpOwogCiAgICAgICAg IC8vIFBhaW50IHRoZSByb3cgbmV4dCwgYnV0IG9ubHkgaWYgaXQgZG9lc24ndCBoYXZlIGEgbGF5 ZXIuICBJZiBhIHJvdyBoYXMgYSBsYXllciwgaXQgd2lsbCBiZSByZXNwb25zaWJsZSBmb3IKICAg ICAgICAgLy8gcGFpbnRpbmcgdGhlIHJvdyBiYWNrZ3JvdW5kIGZvciB0aGUgY2VsbC4KICAgICAg ICAgaWYgKCFyb3ctPmhhc1NlbGZQYWludGluZ0xheWVyKCkpCi0gICAgICAgICAgICBjZWxsLT5w YWludEJhY2tncm91bmRzQmVoaW5kQ2VsbChwYWludEluZm8sIGNlbGxQb2ludC54KCksIGNlbGxQ b2ludC55KCksIHJvdyk7CisgICAgICAgICAgICBjZWxsLT5wYWludEJhY2tncm91bmRzQmVoaW5k Q2VsbChwYWludEluZm8sIGNlbGxQb2ludCwgcm93KTsKICAgICB9CiAgICAgaWYgKCghY2VsbC0+ aGFzU2VsZlBhaW50aW5nTGF5ZXIoKSAmJiAhcm93LT5oYXNTZWxmUGFpbnRpbmdMYXllcigpKSB8 fCBwYWludEluZm8ucGhhc2UgPT0gUGFpbnRQaGFzZUNvbGxhcHNlZFRhYmxlQm9yZGVycykKICAg ICAgICAgY2VsbC0+cGFpbnQocGFpbnRJbmZvLCBjZWxsUG9pbnQueCgpLCBjZWxsUG9pbnQueSgp KTsK