62014 2011-06-03 07:35:02 -0700 Undefined reference to v8::HeapProfiler::DefineWrapperClass() due to ScriptProfiler::initialize() 2011-06-06 02:08:28 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 steveblock webkit-unassigned mnaganov pfeldman steveblock oldest_to_newest 414877 0 steveblock 2011-06-03 07:35:02 -0700 http://trac.webkit.org/changeset/81265 added ScriptProfiler::initialize(), which calls v8::HeapProfiler::DefineWrapperClass(). On Android, this gives a linker error because we build v8 without ENABLE_LOGGING_AND_PROFILING defined. Should there be enable guard around either the call site (in V8DOMWindowShell::initContextIfNeeded()) or implementation of ScriptProfiler::initialize() ? 414889 1 mnaganov 2011-06-03 07:44:26 -0700 I'm sorry! Will fix today. 415107 2 mnaganov 2011-06-03 12:49:55 -0700 Fixed in V8: http://code.google.com/p/v8/source/detail?r=8170 I have defined stub implementations when profiling is disabled (consistent with the rest of the API implementation). BTW, we are planning to do something with this option, as Crankshaft can't work w/o profiler parts. See http://code.google.com/p/v8/issues/detail?id=1271 415748 3 steveblock 2011-06-06 02:08:28 -0700 Thanks Mikhail