61906 2011-06-01 23:07:53 -0700 layout test for misalignment caused by float->int rounding error 2011-06-17 15:18:27 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 22759 60318 1 dgrogan dgrogan eae eric leviw logingx webkit.review.bot oldest_to_newest 413926 0 dgrogan 2011-06-01 23:07:53 -0700 layout test for misalignment caused by float->int rounding error 413931 1 95726 dgrogan 2011-06-01 23:16:30 -0700 Created attachment 95726 Patch 413934 2 dgrogan 2011-06-01 23:21:32 -0700 Eric, can you take a look at this? 414090 3 95726 eric 2011-06-02 07:04:48 -0700 Comment on attachment 95726 Patch Looks OK. Does FF and IE pass this test (aka do we know it's a valid test?) 414244 4 dgrogan 2011-06-02 10:33:43 -0700 FF passes. It returns a float for the top and bottom that is ~31.55. I don't know about IE. Levi or Emil, do either of you guys have a windows machine? Or know where I can rdesktop into one? 414282 5 leviw 2011-06-02 11:12:55 -0700 (In reply to comment #4) > FF passes. It returns a float for the top and bottom that is ~31.55. > > I don't know about IE. Levi or Emil, do either of you guys have a windows machine? Or know where I can rdesktop into one? It'd be handy if you uploaded the layout test itself for easy testin' :) 414333 6 dgrogan 2011-06-02 12:11:00 -0700 There is no gap between the divs (the gap being the root cause of the problem on ebuyer.com) on either FF or IE. Oddly, the top div on IE extends into the bottom div. Webkit: top.bottom = 29 bottom.top = 31 FF: top.bottom =~ 31.35 bottom.top =~ 31.37 IE 8/9: top.bottom = 32 bottom.top = 31 421758 7 97396 dgrogan 2011-06-15 21:37:28 -0700 Created attachment 97396 Just the layout test 421762 8 dgrogan 2011-06-15 21:44:59 -0700 (In reply to comment #7) > Created an attachment (id=97396) [details] > Just the layout test Alternatively, to have the resources resolved properly: http://goto.google.com/vnibh Apologies to non-googlers. 422868 9 dgrogan 2011-06-17 14:01:06 -0700 Eric and Levi, Are you guys ok with me submitting this? 422893 10 95726 eric 2011-06-17 14:37:40 -0700 Comment on attachment 95726 Patch I like tests! :) 422907 11 95726 webkit.review.bot 2011-06-17 15:18:22 -0700 Comment on attachment 95726 Patch Clearing flags on attachment: 95726 Committed r89176: <http://trac.webkit.org/changeset/89176> 422909 12 webkit.review.bot 2011-06-17 15:18:27 -0700 All reviewed patches have been landed. Closing bug. 95726 2011-06-01 23:16:30 -0700 2011-06-17 15:18:22 -0700 Patch bug-61906-20110601231629.patch text/plain 3124 dgrogan U3VidmVyc2lvbiBSZXZpc2lvbjogODc4NzYKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5n ZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCAxNDY4OTU4OTBkMDZjZWJiOTNmMjdk OWVkY2E2NzEzMGUxMGJlMjYyLi4zNTNlMzBiMmU1MTdmODFkMTRkMzczYjRlZDA0MjM0MTExM2Jh ODk2IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMv Q2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkgQEAKKzIwMTEtMDYtMDEgIERhdmlkIEdyb2dhbiAgPGRn cm9nYW5AY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIGxheW91dCB0ZXN0IGZvciBtaXNhbGlnbm1lbnQgY2F1c2VkIGJ5IGZsb2F0 LT5pbnQgcm91bmRpbmcgZXJyb3IKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTYxOTA2CisKKyAgICAgICAgSnVzdCB0aGUgbGF5b3V0IHRlc3QgZGVtb25z dHJhdGluZyB0aGUgcHJvYmxlbS4gIEl0IHdpbGwgYmUgYSB3aGlsZQorICAgICAgICB1bnRpbCBJ IGhhdmUgY3ljbGVzIHRvIHBsYXkgYXJvdW5kIHdpdGggdGhlIGZpeCBzdGFydGVkIGluCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMjc1OS4gIEFuZCBp dCdkIGJlIG5pY2UgdG8KKyAgICAgICAga25vdyBpZiB0aGlzIHdlcmUgZml4ZWQgZm9yIGZyZWUg dmlhIHRoZSBvbmdvaW5nIHN5c3RlbWljIGludC0+ZmxvYXQKKyAgICAgICAgcmVmYWN0b3Jpbmcu CisKKyAgICAgICAgKiBjc3MxL3VuaXRzL3JvdW5kaW5nLWV4cGVjdGVkLnR4dDogQWRkZWQuCisg ICAgICAgICogY3NzMS91bml0cy9yb3VuZGluZy5odG1sOiBBZGRlZC4KKwogMjAxMS0wNi0wMSAg QWRhbSBCYXJ0aCAgPGFiYXJ0aEB3ZWJraXQub3JnPgogCiAgICAgICAgIFRoZXJlIHNlZW1zIHRv IGJlIHNvbWV0aGluZyBvZGQgYWJvdXQgcmVnaXN0ZXJQcm90b2NvbEhhbmRsZXIgb24gTWFjLgpk aWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvY3NzMS91bml0cy9yb3VuZGluZy1leHBlY3RlZC50eHQg Yi9MYXlvdXRUZXN0cy9jc3MxL3VuaXRzL3JvdW5kaW5nLWV4cGVjdGVkLnR4dApuZXcgZmlsZSBt b2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw Li41YzE1YWVkNDQ0YzRkMmI2NmIzNTQ2YzdiYzc5ZDFhN2Y1YWExYjBlCi0tLSAvZGV2L251bGwK KysrIGIvTGF5b3V0VGVzdHMvY3NzMS91bml0cy9yb3VuZGluZy1leHBlY3RlZC50eHQKQEAgLTAs MCArMSwxMiBAQAorbm8gZ2FwIGJlbG93CitubyBnYXAgYWJvdmUKK1RoaXMgdGVzdCBjaGVja3Mg dGhhdCBmbG9hdGluZyBwb2ludCByb3VuZGluZyBkb2Vzbid0IGNhdXNlIG1pc2FsaWdubWVudC4g VGhlcmUgc2hvdWxkIGJlIG5vIGdhcCBiZXR3ZWVuIHRoZSBkaXZzLgorCitPbiBzdWNjZXNzLCB5 b3Ugd2lsbCBzZWUgYSBzZXJpZXMgb2YgIlBBU1MiIG1lc3NhZ2VzLCBmb2xsb3dlZCBieSAiVEVT VCBDT01QTEVURSIuCisKK0ZBSUwgZGl2dG9wLmJvdHRvbSBzaG91bGQgYmUgMzEuIFdhcyAyOS4K K1BBU1MgZGl2Ym90dG9tLnRvcCBpcyAzMQorUEFTUyBzdWNjZXNzZnVsbHlQYXJzZWQgaXMgdHJ1 ZQorCitURVNUIENPTVBMRVRFCisKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2NzczEvdW5pdHMv cm91bmRpbmcuaHRtbCBiL0xheW91dFRlc3RzL2NzczEvdW5pdHMvcm91bmRpbmcuaHRtbApuZXcg ZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwLi5iZWU2YmQ1M2JkMGExMDA2ZTg5MTdiOGY4MjU3ZmQwMTcyZDA3Zjg4Ci0tLSAvZGV2 L251bGwKKysrIGIvTGF5b3V0VGVzdHMvY3NzMS91bml0cy9yb3VuZGluZy5odG1sCkBAIC0wLDAg KzEsNDkgQEAKKzxodG1sPgorPGhlYWQ+Cis8bGluayByZWw9InN0eWxlc2hlZXQiIGhyZWY9Ii4u Ly4uL2Zhc3QvanMvcmVzb3VyY2VzL2pzLXRlc3Qtc3R5bGUuY3NzIi8+Cis8c3R5bGUgdHlwZT0i dGV4dC9jc3MiPgorICAgIGJvZHksIGRpdiB7CisgICAgICAgIG1hcmdpbjogMDsKKyAgICAgICAg cGFkZGluZzogMDsKKyAgICAgICAgYm9yZGVyOiAwOworICAgIH0KKyAgICAjdG9wLCAjYm90dG9t IHsKKyAgICAgICAgbGluZS1oZWlnaHQ6IDEuNTsKKyAgICAgICAgZm9udC1zaXplOiA3MCU7Cisg ICAgICAgIGJhY2tncm91bmQ6Z3JlZW47CisgICAgICAgIGNvbG9yOndoaXRlOworICAgICAgICB3 aWR0aDoxMDAlOworICAgIH0KKyAgICAjdG9wIHsKKyAgICAgICAgcGFkZGluZzouNmVtIDAgLjdl bTsKKyAgICB9CisgICAgI2JvdHRvbSB7CisgICAgICBwb3NpdGlvbjphYnNvbHV0ZTsKKyAgICAg IHRvcDoyLjhlbTsKKyAgICB9Cis8L3N0eWxlPgorPC9oZWFkPgorPGJvZHk+CisKKzxkaXYgaWQ9 InRvcCI+bm8gZ2FwIGJlbG93PC9kaXY+Cis8ZGl2IGlkPSJib3R0b20iPm5vIGdhcCBhYm92ZTwv ZGl2PgorCis8ZGl2IGlkPSJkZXNjcmlwdGlvbiI+PC9kaXY+Cis8ZGl2IGlkPSJjb25zb2xlIj48 L2Rpdj4KKzxzY3JpcHQgc3JjPSIuLi8uLi9mYXN0L2pzL3Jlc291cmNlcy9qcy10ZXN0LXByZS5q cyI+PC9zY3JpcHQ+Cis8c2NyaXB0PgorCitkZXNjcmlwdGlvbigiVGhpcyB0ZXN0IGNoZWNrcyB0 aGF0IGZsb2F0aW5nIHBvaW50IHJvdW5kaW5nIGRvZXNuJ3QgY2F1c2UgbWlzYWxpZ25tZW50LiAg VGhlcmUgc2hvdWxkIGJlIG5vIGdhcCBiZXR3ZWVuIHRoZSBkaXZzLiIpOworCit2YXIgZGl2dG9w ID0gZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoInRvcCIpLmdldEJvdW5kaW5nQ2xpZW50UmVjdCgp OwordmFyIGRpdmJvdHRvbSA9IGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCJib3R0b20iKS5nZXRC b3VuZGluZ0NsaWVudFJlY3QoKTsKK3Nob3VsZEJlKCdkaXZ0b3AuYm90dG9tJywgJzMxJyk7Citz aG91bGRCZSgnZGl2Ym90dG9tLnRvcCcsICczMScpOworCitzdWNjZXNzZnVsbHlQYXJzZWQgPSB0 cnVlOworPC9zY3JpcHQ+CisKKzxzY3JpcHQgc3JjPSIuLi8uLi9mYXN0L2pzL3Jlc291cmNlcy9q cy10ZXN0LXBvc3QuanMiPjwvc2NyaXB0PgorCis8L2JvZHk+Cis8L2h0bWw+Cg== 97396 2011-06-15 21:37:28 -0700 2011-06-15 21:37:28 -0700 Just the layout test rounding.html text/html 1128 dgrogan PGh0bWw+CjxoZWFkPgo8bGluayByZWw9InN0eWxlc2hlZXQiIGhyZWY9Ii4uLy4uL2Zhc3QvanMv cmVzb3VyY2VzL2pzLXRlc3Qtc3R5bGUuY3NzIi8+CjxzdHlsZSB0eXBlPSJ0ZXh0L2NzcyI+CiAg ICBib2R5LCBkaXYgewogICAgICAgIG1hcmdpbjogMDsKICAgICAgICBwYWRkaW5nOiAwOwogICAg ICAgIGJvcmRlcjogMDsKICAgIH0KICAgICN0b3AsICNib3R0b20gewogICAgICAgIGxpbmUtaGVp Z2h0OiAxLjU7CiAgICAgICAgZm9udC1zaXplOiA3MCU7CiAgICAgICAgYmFja2dyb3VuZDpncmVl bjsKICAgICAgICBjb2xvcjp3aGl0ZTsKICAgICAgICB3aWR0aDoxMDAlOwogICAgfQogICAgI3Rv cCB7CiAgICAgICAgcGFkZGluZzouNmVtIDAgLjdlbTsKICAgIH0KICAgICNib3R0b20gewogICAg ICBwb3NpdGlvbjphYnNvbHV0ZTsKICAgICAgdG9wOjIuOGVtOwogICAgfQo8L3N0eWxlPgo8L2hl YWQ+Cjxib2R5PgoKPGRpdiBpZD0idG9wIj5ubyBnYXAgYmVsb3c8L2Rpdj4KPGRpdiBpZD0iYm90 dG9tIj5ubyBnYXAgYWJvdmU8L2Rpdj4KCjxkaXYgaWQ9ImRlc2NyaXB0aW9uIj48L2Rpdj4KPGRp diBpZD0iY29uc29sZSI+PC9kaXY+CjxzY3JpcHQgc3JjPSIuLi8uLi9mYXN0L2pzL3Jlc291cmNl cy9qcy10ZXN0LXByZS5qcyI+PC9zY3JpcHQ+CjxzY3JpcHQ+CgpkZXNjcmlwdGlvbigiVGhpcyB0 ZXN0IGNoZWNrcyB0aGF0IGZsb2F0aW5nIHBvaW50IHJvdW5kaW5nIGRvZXNuJ3QgY2F1c2UgbWlz YWxpZ25tZW50LiAgVGhlcmUgc2hvdWxkIGJlIG5vIGdhcCBiZXR3ZWVuIHRoZSBkaXZzLiIpOwoK dmFyIGRpdnRvcCA9IGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCJ0b3AiKS5nZXRCb3VuZGluZ0Ns aWVudFJlY3QoKTsKdmFyIGRpdmJvdHRvbSA9IGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCJib3R0 b20iKS5nZXRCb3VuZGluZ0NsaWVudFJlY3QoKTsKc2hvdWxkQmUoJ2RpdnRvcC5ib3R0b20nLCAn MzEnKTsKc2hvdWxkQmUoJ2RpdmJvdHRvbS50b3AnLCAnMzEnKTsKCnN1Y2Nlc3NmdWxseVBhcnNl ZCA9IHRydWU7Cjwvc2NyaXB0PgoKPHNjcmlwdCBzcmM9Ii4uLy4uL2Zhc3QvanMvcmVzb3VyY2Vz L2pzLXRlc3QtcG9zdC5qcyI+PC9zY3JpcHQ+Cgo8L2JvZHk+CjwvaHRtbD4K