61863 2011-06-01 08:17:51 -0700 EventSource loader should not buffer data 2011-08-12 13:59:11 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) All All RESOLVED FIXED P2 Critical --- 65926 1 goberman webkit-unassigned adam.bergkvist ap beidson darin jberlin psolanki webkit.review.bot oldest_to_newest 413383 0 goberman 2011-06-01 08:17:51 -0700 I filed a bug about memory leak in the EventSource streaming on Chromium 5 months ago. Since I see no progress on it, I am filing it here. Hopefully with better luck. Thanks. Steps to duplicate are below: http://code.google.com/p/chromium/issues/detail?id=68160 413395 1 ap 2011-06-01 08:35:17 -0700 Could you please post actual steps to reproduce? Making everyone who looks at this bug click through to some other site for actual description is not very efficient. 413400 2 95609 goberman 2011-06-01 08:41:30 -0700 Created attachment 95609 files to reproduce leak 413401 3 goberman 2011-06-01 08:42:26 -0700 This is yet another problem with EventSource. My browser based application connects to the Java server to receive financial data. The volume of data may be high with users receiving hundreds thousands updates from the server throughout the day. I currently use XHR to push data from the server to the client, however it requires periodic disconnect and I would like to replace it with something that does not create a memory leak/ does not require disconnects (unfortunately multipart/x-mixed-replace is not supported in Chrome). I was surprised to find out that EventSource has a memory leak. I wrote a simple Java Server/ JavaScript client program to demonstrate the issue. What steps will reproduce the problem? 1. Run the server in Tomcat (use the latest Tomcat 7). You will need to add Java file test.WebFrameworkServletEventSource. Add StreamingEventSourceTest.html as a web resource. 2. Open http://localhost/Test/web/StreamingEventSourceTest.html in Chrome and press "test". It should connect to the server and generate about 300 messages per second. 3. Now open task manager and watch memory for Chrome. It steadily grows at about 100K per second. It will allocate hundreds of thousands megabytes of memory if left to run for hours. What is the expected result? Did not expect memory to grow at all. What happens instead? Nasty memory leak. 416618 4 96258 adam.bergkvist 2011-06-07 10:36:47 -0700 Created attachment 96258 Proposed patch 416625 5 webkit.review.bot 2011-06-07 10:42:26 -0700 Attachment 96258 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebCore/ChangeLog:5: Line contains tab character. [whitespace/tab] [5] Total errors found: 1 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style. 416635 6 96262 adam.bergkvist 2011-06-07 10:50:48 -0700 Created attachment 96262 Updated patch Removed a tab from the ChangeLog. I would like to change the bug title to "EventSource loader should not buffer data" since this is a buffering issue rather than a memory leak, but I don't have the necessary permissions. 417159 7 goberman 2011-06-08 02:32:06 -0700 Adam, thanks for fixing it! If only EventSource allowed cross domain access, it would have been the best streaming mechanism. 448015 8 adam.bergkvist 2011-08-08 08:35:03 -0700 Alexey, could you please take a look at this patch? The fix is just one line but the patch has been in the review queue since early June. 448199 9 ap 2011-08-08 13:02:02 -0700 I think that this patch will break platforms that use CFNETWORK_DATA_ARRAY_CALLBACK. Specifically, ResourceLoader::didReceiveDataArray() bails out if m_shouldBufferData is false. This is probably a bug in didReceiveDataArray(), but it needs to be fixed prior to landing this. I don't quite understand what the "should buffer data" option is about, and why it would cause huge leaks in the first place. CC'ing some folks who have more recent experience with this code. 448281 10 psolanki 2011-08-08 14:43:05 -0700 I don't recall why I added the early bailout for m_shouldBufferData in ResourceLoader::didReceiveDataArray(). Most likely I did that because of what ResourceLoader::addData() does. ResourceLoader::didReceiveData() calls addData() and since that had the check, I kept the same check in didReceiveDataArray(). I don't know how EventSource works, but if the patch is correct when CFNETWORK_DATA_ARRAY_CALLBACK is not enabled, then it should be correct when we do enable that flag. 448291 11 ap 2011-08-08 15:06:19 -0700 So I think what we should do is: 1. Fix ResourceLoader::didReceiveDataArray() to not bail out (in a separate patch). 2. Land this EventSource patch as is. 3. Consider renaming shouldBufferData, since it's arguably not about buffering. I certainly don't think about storing the full response body in ResourceLoader when I see "shouldBufferData". Buffers usually have a fixed size. 448292 12 96262 ap 2011-08-08 15:07:07 -0700 Comment on attachment 96262 Updated patch r+/cq-, this depends on another fix we need to make. 448642 13 psolanki 2011-08-09 10:09:12 -0700 (In reply to comment #11) > So I think what we should do is: > 1. Fix ResourceLoader::didReceiveDataArray() to not bail out (in a separate patch). Filed bug 65926 to track this. 450627 14 96262 ap 2011-08-12 13:40:41 -0700 Comment on attachment 96262 Updated patch Blocking bug fixed, fine to land now. 450647 15 96262 webkit.review.bot 2011-08-12 13:59:05 -0700 Comment on attachment 96262 Updated patch Clearing flags on attachment: 96262 Committed r92991: <http://trac.webkit.org/changeset/92991> 450648 16 webkit.review.bot 2011-08-12 13:59:11 -0700 All reviewed patches have been landed. Closing bug. 95609 2011-06-01 08:41:30 -0700 2011-06-01 08:41:30 -0700 files to reproduce leak bug.zip application/zip 1913 goberman UEsDBAoAAAAAAOlUwT4AAAAAAAAAAAAAAAAEAAAAYnVnL1BLAwQUAAAACADDVME+nnyx/kcCAACy BQAAIQAAAGJ1Zy9TdHJlYW1pbmdFdmVudFNvdXJjZVRlc3QuaHRtbJVUXW/aMBR9n7T/4OUlQRsx tLxQQicVkDapZajNNE3THoxzgWzGjuwbPjTtv89OUgINrVY/JPb9OOfYvtfRu/GXUfx9NiGf4rtb Mvt6c/t5RLw2pd8uR5SO43Hp6IWdLok1kybFVEkmKJ1MPeKtELMrSrfbbbi9DJVe0viedvv9Pr2f jNorXItep9t2hu7FRY8KpQyECSbe9ds3kXMXf2CJ/RM7IkxRwDWCwYgWcxdAq4horpL9Y2QqsxwJ 7jMYevMcUUmPbJjI7TKePMQeUZKLlP8eeg4taA2IBsy1JAsmDAw8Qi1ShWW4TrMSzIXvkP5iG1Za PUdYDouvSaLWEwFrkDg4dazBGLYEM9OK2ykkZEg6T2JgY/MeNLfm2rHIJXenSkqh5I9z1aMmJEO7 4LmbhkvAympu9jFbTtkaAt8dkN/60fn5SFCjwDxfBj5XUgJHv9UIQL0/MNfjoNhyS9iSSbFUueaW rbp9oTgTK2WQxmA/IyVRKyFAW5ZTwL+nS86Qr0gA9ZabgmHHIXOncw7MGZpSQyVVBpIM65MNCt9L PEWGT96XKKErhQbh4AVG0Frp11EWKc9zNlm4sO0TvEpWVZT/KYzSUlqtx4rzjyQmDNk5/jMX3Kzv at+VpIOA4/5QMexOypxrYAjOOlUJHHIHZ1LH6aaZWfVI4Cfp5mkFFSkhy+zNJ6NVKpKgoHdRz3Vg mEoDGm9goTQELv/DsXfFTAHktBrbyR+Pnfzgsf1JrojMhWg1zy6i5btTvE4RLZ48N6ley39QSwME FAAAAAgAylTBPnUERjz5AAAA4QEAAAsAAABidWcvd2ViLnhtbJ1QyWrDMBC9G/wPqs+Vhia3YgSt 7UKgS8AppaegyKJxKktCGjv07+s4TmN87PHN22Ymvcnfss3nuiBHtaPCORJHhKzfH59XGUkoQNka 8lJLb8NPQNWEW7IykgHkm5x8qB15cE7XUmBtDVmwJUDxmgwZyR7R3QMcRCdYaA2TtoEKKxiLtovt kvU44XEUR+k47cHJnAblO62Qn8AVUiMaxTNr0FutlU9hSszFUosQOKqArN/0yfeSo/Xf5ZkuOmWw tK2Xaoi5Wi452oqKWkMDCo+t43cpzEaD8s892502/T21+frXDa3X1AlE5Q2HqXhCjO2zuvM74fLP X1BLAwQUAAAACADNVME+Yp4i70UCAAAoBQAAJwAAAGJ1Zy9XZWJGcmFtZXdvcmtTZXJ2bGV0RXZl bnRTb3VyY2UuamF2YZVTTW+bQBA9Eyn/YbRSJSxvKDi249jKoYnaxqdWdaQcQg4bGBsaYOnuYjuK /N87C3ZCHadqJdj5ejPzmFlKET2KBYJBbSbHR8dHaV5KZeCnWAovld702+d1hKVJZTF5E/yu0sLc qtSg2s9dexrVMkPjzRr5WuYdXGJM6V3TsU34V9wP/FWh/g+4LmWhsSZcVg9ZGkGUCa3hFh++KJHj SqrHHeklFmYmKxUh4NpgEWto1YJnW8TZVlnKNIZYfkXjvqUHqpEcDnChYKN0wCRKrjTsD41DaxG2 rePMnrTB3JOV8Uq7h6xw2SUu0gLmUoFGrQk6BgbdXW9vgWbW+F2jKuxYxzR2OwRhFvjCgwLbvbqd zsR2s+9LVKO5RhFTlJVKLHLBOLBCnkQiSpCToo1UyCjznawaeBLJwiiZHUzmuVif0MW88K1GPpGR zg6TuaJCtKibpxJdZmhRH9EujrIUiryV1LqwQIODi0Nf/AonMOQ0MOKhZ1SQ8H4dXCVphtAMsdmG 87IHl8XCiDFQ2/3Ac8jykI1H/f6Ih0yR6pNEkgFJTfIuZJefrryQcf+eXHPruvP5kJ+en5/y3j2/ GwzICoLRoLH6NtYLRo1FxnAYnDVGj/d5MCAt6NmUM98n//3mAK+wCIu2e55VOnG3jvpoT6HbbQXS Obh/jOgDDOCC5rSbi2PU0051bhJaSOzpDLF0e/62g7OBRkbCRAm404LWoKrSYPx65+2gt+habP7K IfB9v03j8O9iwfW9b2d3Jrv69WFfen4DUEsBAhQACgAAAAAA6VTBPgAAAAAAAAAAAAAAAAQAAAAA AAAAAAAQAAAAAAAAAGJ1Zy9QSwECFAAUAAAACADDVME+nnyx/kcCAACyBQAAIQAAAAAAAAAAACAA AAAiAAAAYnVnL1N0cmVhbWluZ0V2ZW50U291cmNlVGVzdC5odG1sUEsBAhQAFAAAAAgAylTBPnUE Rjz5AAAA4QEAAAsAAAAAAAAAAAAgAAAAqAIAAGJ1Zy93ZWIueG1sUEsBAhQAFAAAAAgAzVTBPmKe Iu9FAgAAKAUAACcAAAAAAAAAAAAgAAAAygMAAGJ1Zy9XZWJGcmFtZXdvcmtTZXJ2bGV0RXZlbnRT b3VyY2UuamF2YVBLBQYAAAAABAAEAA8BAABUBgAAAAA= 96258 2011-06-07 10:36:47 -0700 2011-06-07 10:50:48 -0700 Proposed patch es_buffering_off.patch text/plain 3770 adam.bergkvist ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA3NDlmODRjLi4yMGRhODU3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkg QEAKKzIwMTEtMDYtMDcgIEFkYW0gQmVyZ2t2aXN0ICA8YWRhbS5iZXJna3Zpc3RAZXJpY3Nzb24u Y29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisJRXZlbnRTb3Vy Y2UgbG9hZGVyIHNob3VsZCBub3QgYnVmZmVyIGRhdGEKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTYxODYzCisKKyAgICAgICAgRGlzYWJsZWQgYnVmZmVy aW5nIGluIHRoZSBFdmVudFNvdXJjZSBsb2FkZXIuCisKKyAgICAgICAgQWRkZWQgYSBtYW51YWwg dGVzdC4KKworICAgICAgICAqIG1hbnVhbC10ZXN0cy9ldmVudHNvdXJjZS9ldmVudHNvdXJjZS1s b2FkZXItYnVmZmVyaW5nLmh0bWw6IEFkZGVkLgorICAgICAgICAqIG1hbnVhbC10ZXN0cy9ldmVu dHNvdXJjZS9ldmVudHNvdXJjZS1sb2FkZXItYnVmZmVyaW5nLnBocDogQWRkZWQuCisgICAgICAg ICogcGFnZS9FdmVudFNvdXJjZS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpFdmVudFNvdXJjZTo6 Y29ubmVjdCk6CisKIDIwMTEtMDUtMzAgIFJ5YW4gU2xlZXZpICA8cnNsZWV2aUBjaHJvbWl1bS5v cmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgTWFydGluIFJvYmluc29uLgpkaWZmIC0tZ2l0IGEv U291cmNlL1dlYkNvcmUvbWFudWFsLXRlc3RzL2V2ZW50c291cmNlL2V2ZW50c291cmNlLWxvYWRl ci1idWZmZXJpbmcuaHRtbCBiL1NvdXJjZS9XZWJDb3JlL21hbnVhbC10ZXN0cy9ldmVudHNvdXJj ZS9ldmVudHNvdXJjZS1sb2FkZXItYnVmZmVyaW5nLmh0bWwKbmV3IGZpbGUgbW9kZSAxMDA2NDQK aW5kZXggMDAwMDAwMC4uODk2Yjc5MAotLS0gL2Rldi9udWxsCisrKyBiL1NvdXJjZS9XZWJDb3Jl L21hbnVhbC10ZXN0cy9ldmVudHNvdXJjZS9ldmVudHNvdXJjZS1sb2FkZXItYnVmZmVyaW5nLmh0 bWwKQEAgLTAsMCArMSw1NCBAQAorPCFkb2N0eXBlIGh0bWw+Cis8aHRtbD4KKzxoZWFkPgorPHRp dGxlPkV2ZW50U291cmNlIExvYWRlciBCdWZmZXJpbmc8L3RpdGxlPgorPHNjcmlwdD4KK3dpbmRv dy5vbmxvYWQgPSBmdW5jdGlvbiAoKSB7CisgICAgc2V0VGltZW91dCh0ZXN0X2VzLCA1MDApOwor fTsKKworZnVuY3Rpb24gdGVzdF9lcygpIHsKKyAgICB2YXIgbGVuID0gMDsKKyAgICB2YXIgY291 bnQgPSAwOworICAgIHZhciBzdGVwID0gMTAwMDsKKyAgICB2YXIgZXMgPSBuZXcgRXZlbnRTb3Vy Y2UoImV2ZW50c291cmNlLWxvYWRlci1idWZmZXJpbmcucGhwIik7CisgICAgZXMub25vcGVuID0g ZnVuY3Rpb24gKCkgeworICAgICAgICBsb2coImdvdCAnb3BlbicgZXZlbnQiKTsKKyAgICAgICAg bG9nKCJ3YWl0aW5nIGZvciB0aGUgZmlyc3QgIiArIHN0ZXAgKyAiICdtZXNzYWdlJyBldmVudHMi KTsKKyAgICB9OworICAgIGVzLm9ubWVzc2FnZSA9IGZ1bmN0aW9uIChldnQpIHsKKyAgICAgICAg bGVuICs9IGV2dC5kYXRhLmxlbmd0aDsKKyAgICAgICAgaWYgKCsrY291bnQgJSBzdGVwKQorICAg ICAgICAgICAgcmV0dXJuOworICAgICAgICBsb2coImdvdCAiICsgY291bnQgKyAiICdtZXNzYWdl JyBldmVudHMgKCIgKyBsZW4gKyAiIGNoYXJhY3RlcnMpIiwgMSk7CisgICAgICAgIGlmIChsZW4g Pj0gMWU5KQorICAgICAgICAgICAgZW5kKCk7CisgICAgfTsKKyAgICBlcy5vbmVycm9yID0gZnVu Y3Rpb24gKCkgeworICAgICAgICBsb2coImdvdCAnZXJyb3InIGV2ZW50Iik7CisgICAgICAgIGVu ZCgpOworICAgIH07CisgICAgZnVuY3Rpb24gZW5kKCkgeworICAgICAgICBpZiAoZXMucmVhZHlT dGF0ZSAhPSBlcy5DTE9TRUQpCisgICAgICAgICAgICBlcy5jbG9zZSgpOworICAgICAgICBsb2co IkVOREVEIik7CisgICAgfTsKK30KKworZnVuY3Rpb24gbG9nKG1lc3NhZ2UsIHVwZGF0ZUxhc3Qp IHsKKyAgICBpZiAoIWxvZy5saXN0KQorICAgICAgICBsb2cubGlzdCA9IGRvY3VtZW50LmdldEVs ZW1lbnRCeUlkKCJsb2ciKTsKKyAgICB2YXIgdGV4dCA9IGRvY3VtZW50LmNyZWF0ZVRleHROb2Rl KG1lc3NhZ2UpOworICAgIGlmICh1cGRhdGVMYXN0KQorICAgICAgICBsb2cubGlzdC5sYXN0Q2hp bGQucmVwbGFjZUNoaWxkKHRleHQsIGxvZy5saXN0Lmxhc3RDaGlsZC5maXJzdENoaWxkKTsKKyAg ICBlbHNlCisgICAgICAgIGxvZy5saXN0LmFwcGVuZENoaWxkKGRvY3VtZW50LmNyZWF0ZUVsZW1l bnQoImxpIikpLmFwcGVuZENoaWxkKHRleHQpOworfQorPC9zY3JpcHQ+Cis8L2hlYWQ+Cis8Ym9k eT4KKzxwPk1hbnVhbCB0ZXN0IHRvIHZlcmlmeSB0aGF0IHRoZSBFdmVudFNvdXJjZSBsb2FkZXIg ZG9lcyBub3QgYnVmZmVyIGRhdGEgKG1heSByZXN1bHQgaW4gbWVtb3J5IGdyb3d0aCB3aXRoIGxv bmcgbGl2ZWQgY29ubmVjdGlvbnMpLiBNb25pdG9yIG1lbW9yeSB1c2FnZTsgaXQgc2hvdWxkIGJl IHN0YWJsZS4gVGhpcyBmaWxlIGhhcyB0byBiZSBzZXJ2ZWQgZnJvbSB0aGUgc2FtZSB3ZWIgc2Vy dmVyIGFzIHRoZSBwaHAgc2NyaXB0IHdpdGggdGhlIHNhbWUgbmFtZS48L3A+Cis8dWwgaWQ9Imxv ZyIgc3R5bGU9Imxpc3Qtc3R5bGUtdHlwZTogbm9uZSI+PC91bD4KKzwvYm9keT4KKzwvaHRtbD4K KwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvbWFudWFsLXRlc3RzL2V2ZW50c291cmNlL2V2 ZW50c291cmNlLWxvYWRlci1idWZmZXJpbmcucGhwIGIvU291cmNlL1dlYkNvcmUvbWFudWFsLXRl c3RzL2V2ZW50c291cmNlL2V2ZW50c291cmNlLWxvYWRlci1idWZmZXJpbmcucGhwCm5ldyBmaWxl IG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAuLmZlMmM4NmYKLS0tIC9kZXYvbnVsbAorKysgYi9T b3VyY2UvV2ViQ29yZS9tYW51YWwtdGVzdHMvZXZlbnRzb3VyY2UvZXZlbnRzb3VyY2UtbG9hZGVy LWJ1ZmZlcmluZy5waHAKQEAgLTAsMCArMSwxMyBAQAorPD9waHAKK2hlYWRlcigiQ29udGVudC1U eXBlOiB0ZXh0L2V2ZW50LXN0cmVhbSIpOworCiskZGF0YSA9ICIiOworZm9yICgkaSA9IDA7ICRp IDwgMTAwMDsgJGkrKykKKyAgICAkZGF0YSAuPSAieCI7CisKK2ZvciAoJGkgPSAwOyAkaSA8IDMw MDAwOyAkaSsrKSB7CisgICAgZWNobyAiZGF0YTogJGRhdGFcblxuIjsKKyAgICBmbHVzaCgpOwor ICAgIHVzbGVlcCgxMDAwKTsKK30KKz8+CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wYWdl L0V2ZW50U291cmNlLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BhZ2UvRXZlbnRTb3VyY2UuY3BwCmlu ZGV4IDAyMGQ0NjQuLjk2NzlkMDkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BhZ2UvRXZl bnRTb3VyY2UuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BhZ2UvRXZlbnRTb3VyY2UuY3BwCkBA IC0xMTYsNiArMTE2LDcgQEAgdm9pZCBFdmVudFNvdXJjZTo6Y29ubmVjdCgpCiAgICAgb3B0aW9u cy5zZW5kTG9hZENhbGxiYWNrcyA9IHRydWU7CiAgICAgb3B0aW9ucy5zbmlmZkNvbnRlbnQgPSBm YWxzZTsKICAgICBvcHRpb25zLmFsbG93Q3JlZGVudGlhbHMgPSB0cnVlOworICAgIG9wdGlvbnMu c2hvdWxkQnVmZmVyRGF0YSA9IGZhbHNlOwogCiAgICAgbV9sb2FkZXIgPSBUaHJlYWRhYmxlTG9h ZGVyOjpjcmVhdGUoc2NyaXB0RXhlY3V0aW9uQ29udGV4dCgpLCB0aGlzLCByZXF1ZXN0LCBvcHRp b25zKTsKIAo= 96262 2011-06-07 10:50:48 -0700 2011-08-12 13:59:05 -0700 Updated patch es_buffering_off_2.patch text/plain 3777 adam.bergkvist ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA3NDlmODRjLi42ZGY1M2ZlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkg QEAKKzIwMTEtMDYtMDcgIEFkYW0gQmVyZ2t2aXN0ICA8YWRhbS5iZXJna3Zpc3RAZXJpY3Nzb24u Y29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEV2 ZW50U291cmNlIGxvYWRlciBzaG91bGQgbm90IGJ1ZmZlciBkYXRhCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02MTg2MworCisgICAgICAgIERpc2FibGVk IGJ1ZmZlcmluZyBpbiB0aGUgRXZlbnRTb3VyY2UgbG9hZGVyLgorCisgICAgICAgIEFkZGVkIGEg bWFudWFsIHRlc3QuCisKKyAgICAgICAgKiBtYW51YWwtdGVzdHMvZXZlbnRzb3VyY2UvZXZlbnRz b3VyY2UtbG9hZGVyLWJ1ZmZlcmluZy5odG1sOiBBZGRlZC4KKyAgICAgICAgKiBtYW51YWwtdGVz dHMvZXZlbnRzb3VyY2UvZXZlbnRzb3VyY2UtbG9hZGVyLWJ1ZmZlcmluZy5waHA6IEFkZGVkLgor ICAgICAgICAqIHBhZ2UvRXZlbnRTb3VyY2UuY3BwOgorICAgICAgICAoV2ViQ29yZTo6RXZlbnRT b3VyY2U6OmNvbm5lY3QpOgorCiAyMDExLTA1LTMwICBSeWFuIFNsZWV2aSAgPHJzbGVldmlAY2hy b21pdW0ub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IE1hcnRpbiBSb2JpbnNvbi4KZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJDb3JlL21hbnVhbC10ZXN0cy9ldmVudHNvdXJjZS9ldmVudHNvdXJj ZS1sb2FkZXItYnVmZmVyaW5nLmh0bWwgYi9Tb3VyY2UvV2ViQ29yZS9tYW51YWwtdGVzdHMvZXZl bnRzb3VyY2UvZXZlbnRzb3VyY2UtbG9hZGVyLWJ1ZmZlcmluZy5odG1sCm5ldyBmaWxlIG1vZGUg MTAwNjQ0CmluZGV4IDAwMDAwMDAuLjg5NmI3OTAKLS0tIC9kZXYvbnVsbAorKysgYi9Tb3VyY2Uv V2ViQ29yZS9tYW51YWwtdGVzdHMvZXZlbnRzb3VyY2UvZXZlbnRzb3VyY2UtbG9hZGVyLWJ1ZmZl cmluZy5odG1sCkBAIC0wLDAgKzEsNTQgQEAKKzwhZG9jdHlwZSBodG1sPgorPGh0bWw+Cis8aGVh ZD4KKzx0aXRsZT5FdmVudFNvdXJjZSBMb2FkZXIgQnVmZmVyaW5nPC90aXRsZT4KKzxzY3JpcHQ+ Cit3aW5kb3cub25sb2FkID0gZnVuY3Rpb24gKCkgeworICAgIHNldFRpbWVvdXQodGVzdF9lcywg NTAwKTsKK307CisKK2Z1bmN0aW9uIHRlc3RfZXMoKSB7CisgICAgdmFyIGxlbiA9IDA7CisgICAg dmFyIGNvdW50ID0gMDsKKyAgICB2YXIgc3RlcCA9IDEwMDA7CisgICAgdmFyIGVzID0gbmV3IEV2 ZW50U291cmNlKCJldmVudHNvdXJjZS1sb2FkZXItYnVmZmVyaW5nLnBocCIpOworICAgIGVzLm9u b3BlbiA9IGZ1bmN0aW9uICgpIHsKKyAgICAgICAgbG9nKCJnb3QgJ29wZW4nIGV2ZW50Iik7Cisg ICAgICAgIGxvZygid2FpdGluZyBmb3IgdGhlIGZpcnN0ICIgKyBzdGVwICsgIiAnbWVzc2FnZScg ZXZlbnRzIik7CisgICAgfTsKKyAgICBlcy5vbm1lc3NhZ2UgPSBmdW5jdGlvbiAoZXZ0KSB7Cisg ICAgICAgIGxlbiArPSBldnQuZGF0YS5sZW5ndGg7CisgICAgICAgIGlmICgrK2NvdW50ICUgc3Rl cCkKKyAgICAgICAgICAgIHJldHVybjsKKyAgICAgICAgbG9nKCJnb3QgIiArIGNvdW50ICsgIiAn bWVzc2FnZScgZXZlbnRzICgiICsgbGVuICsgIiBjaGFyYWN0ZXJzKSIsIDEpOworICAgICAgICBp ZiAobGVuID49IDFlOSkKKyAgICAgICAgICAgIGVuZCgpOworICAgIH07CisgICAgZXMub25lcnJv ciA9IGZ1bmN0aW9uICgpIHsKKyAgICAgICAgbG9nKCJnb3QgJ2Vycm9yJyBldmVudCIpOworICAg ICAgICBlbmQoKTsKKyAgICB9OworICAgIGZ1bmN0aW9uIGVuZCgpIHsKKyAgICAgICAgaWYgKGVz LnJlYWR5U3RhdGUgIT0gZXMuQ0xPU0VEKQorICAgICAgICAgICAgZXMuY2xvc2UoKTsKKyAgICAg ICAgbG9nKCJFTkRFRCIpOworICAgIH07Cit9CisKK2Z1bmN0aW9uIGxvZyhtZXNzYWdlLCB1cGRh dGVMYXN0KSB7CisgICAgaWYgKCFsb2cubGlzdCkKKyAgICAgICAgbG9nLmxpc3QgPSBkb2N1bWVu dC5nZXRFbGVtZW50QnlJZCgibG9nIik7CisgICAgdmFyIHRleHQgPSBkb2N1bWVudC5jcmVhdGVU ZXh0Tm9kZShtZXNzYWdlKTsKKyAgICBpZiAodXBkYXRlTGFzdCkKKyAgICAgICAgbG9nLmxpc3Qu bGFzdENoaWxkLnJlcGxhY2VDaGlsZCh0ZXh0LCBsb2cubGlzdC5sYXN0Q2hpbGQuZmlyc3RDaGls ZCk7CisgICAgZWxzZQorICAgICAgICBsb2cubGlzdC5hcHBlbmRDaGlsZChkb2N1bWVudC5jcmVh dGVFbGVtZW50KCJsaSIpKS5hcHBlbmRDaGlsZCh0ZXh0KTsKK30KKzwvc2NyaXB0PgorPC9oZWFk PgorPGJvZHk+Cis8cD5NYW51YWwgdGVzdCB0byB2ZXJpZnkgdGhhdCB0aGUgRXZlbnRTb3VyY2Ug bG9hZGVyIGRvZXMgbm90IGJ1ZmZlciBkYXRhIChtYXkgcmVzdWx0IGluIG1lbW9yeSBncm93dGgg d2l0aCBsb25nIGxpdmVkIGNvbm5lY3Rpb25zKS4gTW9uaXRvciBtZW1vcnkgdXNhZ2U7IGl0IHNo b3VsZCBiZSBzdGFibGUuIFRoaXMgZmlsZSBoYXMgdG8gYmUgc2VydmVkIGZyb20gdGhlIHNhbWUg d2ViIHNlcnZlciBhcyB0aGUgcGhwIHNjcmlwdCB3aXRoIHRoZSBzYW1lIG5hbWUuPC9wPgorPHVs IGlkPSJsb2ciIHN0eWxlPSJsaXN0LXN0eWxlLXR5cGU6IG5vbmUiPjwvdWw+Cis8L2JvZHk+Cis8 L2h0bWw+CisKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL21hbnVhbC10ZXN0cy9ldmVudHNv dXJjZS9ldmVudHNvdXJjZS1sb2FkZXItYnVmZmVyaW5nLnBocCBiL1NvdXJjZS9XZWJDb3JlL21h bnVhbC10ZXN0cy9ldmVudHNvdXJjZS9ldmVudHNvdXJjZS1sb2FkZXItYnVmZmVyaW5nLnBocApu ZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwLi5mZTJjODZmCi0tLSAvZGV2L251bGwK KysrIGIvU291cmNlL1dlYkNvcmUvbWFudWFsLXRlc3RzL2V2ZW50c291cmNlL2V2ZW50c291cmNl LWxvYWRlci1idWZmZXJpbmcucGhwCkBAIC0wLDAgKzEsMTMgQEAKKzw/cGhwCitoZWFkZXIoIkNv bnRlbnQtVHlwZTogdGV4dC9ldmVudC1zdHJlYW0iKTsKKworJGRhdGEgPSAiIjsKK2ZvciAoJGkg PSAwOyAkaSA8IDEwMDA7ICRpKyspCisgICAgJGRhdGEgLj0gIngiOworCitmb3IgKCRpID0gMDsg JGkgPCAzMDAwMDsgJGkrKykgeworICAgIGVjaG8gImRhdGE6ICRkYXRhXG5cbiI7CisgICAgZmx1 c2goKTsKKyAgICB1c2xlZXAoMTAwMCk7Cit9Cis/PgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNv cmUvcGFnZS9FdmVudFNvdXJjZS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL0V2ZW50U291cmNl LmNwcAppbmRleCAwMjBkNDY0Li45Njc5ZDA5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9w YWdlL0V2ZW50U291cmNlLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL0V2ZW50U291cmNl LmNwcApAQCAtMTE2LDYgKzExNiw3IEBAIHZvaWQgRXZlbnRTb3VyY2U6OmNvbm5lY3QoKQogICAg IG9wdGlvbnMuc2VuZExvYWRDYWxsYmFja3MgPSB0cnVlOwogICAgIG9wdGlvbnMuc25pZmZDb250 ZW50ID0gZmFsc2U7CiAgICAgb3B0aW9ucy5hbGxvd0NyZWRlbnRpYWxzID0gdHJ1ZTsKKyAgICBv cHRpb25zLnNob3VsZEJ1ZmZlckRhdGEgPSBmYWxzZTsKIAogICAgIG1fbG9hZGVyID0gVGhyZWFk YWJsZUxvYWRlcjo6Y3JlYXRlKHNjcmlwdEV4ZWN1dGlvbkNvbnRleHQoKSwgdGhpcywgcmVxdWVz dCwgb3B0aW9ucyk7CiAK