61835 2011-05-31 20:46:09 -0700 Web Inspector: [JSC] JSLock ASSERTs Seen Under eventListenerHandlerBody 2011-06-01 06:02:02 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 joepeck webkit-unassigned apavlov bweinstein commit-queue joepeck keishi loislo pfeldman pmuellr rik timothy yurys oldest_to_newest 413112 0 joepeck 2011-05-31 20:46:09 -0700 A few of the ASSERTs. I only saw this with the Interpreter and not the JIT. But it might as well be fixed. ASSERTION FAILED: JSLock::lockCount() > 0 Source/JavaScriptCore/runtime/JSCell.h(399) : void* JSC::Heap::allocate(size_t) 1 JSC::Heap::allocate(unsigned long) 2 JSC::JSCell::operator new(unsigned long, JSC::JSGlobalData*) 3 JSC::jsNontrivialString(JSC::JSGlobalData*, JSC::UString const&) 4 JSC::jsNontrivialString(JSC::ExecState*, JSC::UString const&) 5 JSC::JSValue JSC::jsMakeNontrivialString<char const*, JSC::UString, char const*, JSC::UString, char const*, JSC::UString>(JSC::ExecState*, char const*, JSC::UString, char const*, JSC::UString, char const*, JSC::UString) 6 _ZN3JSCL25functionProtoFuncToStringEPNS_9ExecStateE 7 JSC::Interpreter::executeCall(JSC::ExecState*, JSC::JSObject*, JSC::CallType, JSC::CallData const&, JSC::JSValue, JSC::ArgList const&) 8 JSC::call(JSC::ExecState*, JSC::JSValue, JSC::CallType, JSC::CallData const&, JSC::JSValue, JSC::ArgList const&) 9 _ZN3JSCL24callDefaultValueFunctionEPNS_9ExecStateEPKNS_8JSObjectERKNS_10IdentifierE 10 JSC::JSObject::defaultValue(JSC::ExecState*, JSC::PreferredPrimitiveType) const 11 JSC::JSObject::toPrimitive(JSC::ExecState*, JSC::PreferredPrimitiveType) const 12 JSC::JSObject::toString(JSC::ExecState*) const 13 WebCore::eventListenerHandlerBody(WebCore::Document*, WebCore::EventListener*) 14 WebCore::InspectorDOMAgent::buildObjectForEventListener(WebCore::RegisteredEventListener const&, WTF::AtomicString const&, WebCore::Node*) 15 WebCore::InspectorDOMAgent::getEventListenersForNode(WTF::String*, int, WTF::RefPtr<WebCore::InspectorArray>*) ASSERTION FAILED: JSLock::lockCount() > 0 JSCell.h(399) : void* JSC::Heap::allocate(size_t) 1 JSC::Heap::allocate(unsigned long) 2 JSC::JSCell::operator new(unsigned long, JSC::JSGlobalData*) 3 JSC::jsNontrivialString(JSC::JSGlobalData*, JSC::UString const&) 4 JSC::jsNontrivialString(JSC::ExecState*, JSC::UString const&) 5 WebCore::JSLazyEventListener::initializeJSFunction(WebCore::ScriptExecutionContext*) const 6 WebCore::JSEventListener::jsFunction(WebCore::ScriptExecutionContext*) const 7 WebCore::eventListenerHandlerBody(WebCore::Document*, WebCore::EventListener*) 8 WebCore::InspectorDOMAgent::buildObjectForEventListener(WebCore::RegisteredEventListener const&, WTF::AtomicString const&, WebCore::Node*) 9 WebCore::InspectorDOMAgent::getEventListenersForNode(WTF::String*, int, WTF::RefPtr<WebCore::InspectorArray>*) Patch to follow. 413113 1 95539 joepeck 2011-05-31 20:48:00 -0700 Created attachment 95539 [PATCH] Add JSLock Silence Assertions 413280 2 95539 commit-queue 2011-06-01 04:18:11 -0700 Comment on attachment 95539 [PATCH] Add JSLock Silence Assertions Clearing flags on attachment: 95539 Committed r87793: <http://trac.webkit.org/changeset/87793> 413281 3 commit-queue 2011-06-01 04:18:15 -0700 All reviewed patches have been landed. Closing bug. 413320 4 commit-queue 2011-06-01 06:02:02 -0700 The commit-queue encountered the following flaky tests while processing attachment 95539: inspector/debugger/debugger-scripts.html bug 59921 (authors: pfeldman@chromium.org and podivilov@chromium.org) http/tests/misc/favicon-loads-with-icon-loading-override.html bug 58412 (author: alice.liu@apple.com) The commit-queue is continuing to process your patch. 95539 2011-05-31 20:48:00 -0700 2011-06-01 04:18:11 -0700 [PATCH] Add JSLock Silence Assertions jslock-asserts.patch text/plain 1384 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCAyODIwYWE4Li42ODZjNGExIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0yLDYgKzIsMTgg QEAKIAogICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KIAorICAgICAgICBXZWIg SW5zcGVjdG9yOiBbSlNDXSBKU0xvY2sgQVNTRVJUcyBTZWVuIFVuZGVyIGV2ZW50TGlzdGVuZXJI YW5kbGVyQm9keQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9NjE4MzUKKworICAgICAgICBBZGQgYSBKU0xvY2sgY2FsbCBiZWZvcmUgcG9zc2libGUgYWxs b2NhdGlvbnMgaW4ganNGdW5jdGlvbiBhbmQgdG9TdHJpbmcuCisKKyAgICAgICAgKiBiaW5kaW5n cy9qcy9TY3JpcHRFdmVudExpc3RlbmVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OmV2ZW50TGlz dGVuZXJIYW5kbGVyQm9keSk6CisKKzIwMTEtMDUtMzEgIEpvc2VwaCBQZWNvcmFybyAgPGpvZXBl Y2tAd2Via2l0Lm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwog ICAgICAgICBXZWIgSW5zcGVjdG9yOiBDUkFTSCBpZiBFeHBhbmRpbmcgRXZlbnQgTGlzdGVuZXIg b24gZG9jdW1lbnQKICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTYxODM0CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL2pzL1Njcmlw dEV2ZW50TGlzdGVuZXIuY3BwIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvanMvU2NyaXB0RXZl bnRMaXN0ZW5lci5jcHAKaW5kZXggM2EwM2Y1OS4uMDZjZWRhYiAxMDA2NDQKLS0tIGEvU291cmNl L1dlYkNvcmUvYmluZGluZ3MvanMvU2NyaXB0RXZlbnRMaXN0ZW5lci5jcHAKKysrIGIvU291cmNl L1dlYkNvcmUvYmluZGluZ3MvanMvU2NyaXB0RXZlbnRMaXN0ZW5lci5jcHAKQEAgLTk5LDYgKzk5 LDcgQEAgU3RyaW5nIGV2ZW50TGlzdGVuZXJIYW5kbGVyQm9keShEb2N1bWVudCogZG9jdW1lbnQs IEV2ZW50TGlzdGVuZXIqIGV2ZW50TGlzdGVuZXIKICAgICBjb25zdCBKU0V2ZW50TGlzdGVuZXIq IGpzTGlzdGVuZXIgPSBKU0V2ZW50TGlzdGVuZXI6OmNhc3QoZXZlbnRMaXN0ZW5lcik7CiAgICAg aWYgKCFqc0xpc3RlbmVyKQogICAgICAgICByZXR1cm4gIiI7CisgICAgSlNMb2NrIGxvY2soU2ls ZW5jZUFzc2VydGlvbnNPbmx5KTsKICAgICBKU0M6OkpTT2JqZWN0KiBqc0Z1bmN0aW9uID0ganNM aXN0ZW5lci0+anNGdW5jdGlvbihkb2N1bWVudCk7CiAgICAgaWYgKCFqc0Z1bmN0aW9uKQogICAg ICAgICByZXR1cm4gIiI7Cg==