<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>61780</bug_id>
          
          <creation_ts>2011-05-31 05:13:04 -0700</creation_ts>
          <short_desc>[Qt] Fix run-qtwebkit-tests on Windows</short_desc>
          <delta_ts>2014-02-03 03:17:52 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Tools / Tests</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>All</rep_platform>
          <op_sys>Windows XP</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>INVALID</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>Qt, QtTriaged</keywords>
          <priority>P1</priority>
          <bug_severity>Critical</bug_severity>
          <target_milestone>---</target_milestone>
          
          <blocked>55056</blocked>
          <everconfirmed>1</everconfirmed>
          <reporter name="Csaba Osztrogonác">ossy</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>ademar</cc>
    
    <cc>jedrzej.nowacki</cc>
    
    <cc>ossy</cc>
    
    <cc>sergio.ahumada</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>412557</commentid>
    <comment_count>0</comment_count>
    <who name="Csaba Osztrogonác">ossy</who>
    <bug_when>2011-05-31 05:13:04 -0700</bug_when>
    <thetext>bug 1:
-------
Traceback (most recent call last):
  File &quot;&lt;string&gt;&quot;, line 1, in &lt;module&gt;
  File &quot;c:\Python26\lib\multiprocessing\forking.py&quot;, line 341, in main
    prepare(preparation_data)
  File &quot;c:\Python26\lib\multiprocessing\forking.py&quot;, line 450, in prepare
    file, path_name, etc = imp.find_module(main_name, dirs)
ImportError: No module named run-qtwebkit-tests

--&gt; multiprocessing doesn&apos;t work on Windows for some reason.
If we pass -j1 to the script, it works more or less, but
it would be better if we can disable multiprocessing on Windows.



bug 2:
-------
find_tests_paths function are buggy, because it selects all 
files, but it should find only files end with &quot;exe&quot; extension.

quick workaround works for me on Windows:
-filtered_path = filter(lambda w: w.startswith(&apos;tst_&apos;) and os.access(os.path.join(root, w), os.X_OK), files)
+filtered_path = filter(lambda w: w.startswith(&apos;tst_&apos;) and w.endswith(&apos;exe&apos;) and os.access(os.path.join(root, w), os.X_OK), files)

It would be great if we have a proper fix for it.



bug 3:
-------
I got this error after all tests run:

Traceback (most recent call last):
  File &quot;./Tools/Scripts/run-qtwebkit-tests&quot;, line 389, in &lt;module&gt;
    main.run()
  File &quot;./Tools/Scripts/run-qtwebkit-tests&quot;, line 219, in run
    transformed_results = self.transform(results)
  File &quot;./Tools/Scripts/run-qtwebkit-tests&quot;, line 248, in transform
    stdout = self.convert_to_stdout(results)
  File &quot;./Tools/Scripts/run-qtwebkit-tests&quot;, line 271, in convert_to_stdout
    txt = &quot;\n\n&quot;.join(map(lambda w: w.output(), results))
TypeError: sequence item 3: expected string, NoneType found</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>425233</commentid>
    <comment_count>1</comment_count>
    <who name="Ademar Reis">ademar</who>
    <bug_when>2011-06-22 07:54:54 -0700</bug_when>
    <thetext>Even though we never had layout tests running on windows before, we&apos;ll need this in place to support qtwebkit-2.2 minor updates later (to avoid regressions on windows).

But we&apos;re having trouble allocating people to work on this, so this bug won&apos;t block the release (marking it as &quot;nice-to-have&quot;), at least for now. :(

BTW, see also Bug 61778</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>975226</commentid>
    <comment_count>2</comment_count>
    <who name="Jocelyn Turcotte">jturcotte</who>
    <bug_when>2014-02-03 03:17:52 -0800</bug_when>
    <thetext>=== Bulk closing of Qt bugs ===

If you believe that this bug report is still relevant for a non-Qt port of webkit.org, please re-open it and remove [Qt] from the summary.

If you believe that this is still an important QtWebKit bug, please fill a new report at https://bugreports.qt-project.org and add a link to this issue. See http://qt-project.org/wiki/ReportingBugsInQt for additional guidelines.</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>